From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A819C43334 for ; Tue, 5 Jul 2022 08:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 861A76B0071; Tue, 5 Jul 2022 04:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EB1F6B0073; Tue, 5 Jul 2022 04:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68AB66B0074; Tue, 5 Jul 2022 04:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 572D46B0071 for ; Tue, 5 Jul 2022 04:06:13 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 288341210DA for ; Tue, 5 Jul 2022 08:06:13 +0000 (UTC) X-FDA: 79652313426.01.F26BCC9 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by imf25.hostedemail.com (Postfix) with ESMTP id 9890AA0020 for ; Tue, 5 Jul 2022 08:06:12 +0000 (UTC) Received: from mail-yw1-f174.google.com ([209.85.128.174]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MqapC-1nmRtK3Q5g-00mYE8 for ; Tue, 05 Jul 2022 10:06:11 +0200 Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-31c9b70c382so38409147b3.6 for ; Tue, 05 Jul 2022 01:06:10 -0700 (PDT) X-Gm-Message-State: AJIora8I28+/xOoO8O3mC9McnZWt173NqE69f9IWe2Y4bNL/0P/LmwUQ mSD4kbYwq3H4GWBVJKy0cwIkyPewhYaS6SDfbms= X-Google-Smtp-Source: AGRyM1siFTQxWWzBOhd/CS5tY6dinBjb/3v8JI3nSeDseCJdiuCqCTqoFZco5yyHdSdSX4iHxr4392vEVjGUym3EjqY= X-Received: by 2002:a81:1e4d:0:b0:31c:86f1:95b1 with SMTP id e74-20020a811e4d000000b0031c86f195b1mr14599301ywe.42.1657008369140; Tue, 05 Jul 2022 01:06:09 -0700 (PDT) MIME-Version: 1.0 References: <20220704112526.2492342-1-chenhuacai@loongson.cn> <20220704112526.2492342-5-chenhuacai@loongson.cn> In-Reply-To: From: Arnd Bergmann Date: Tue, 5 Jul 2022 10:05:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 4/4] LoongArch: Enable ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP To: Muchun Song Cc: Huacai Chen , Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , loongarch@lists.linux.dev, linux-arch , Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux-MM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List , Linux ARM , Feiyang Chen Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:wB/zAE6uAsCb/9t46mrQrDbPc38Dbj1OI8H5Pg2ImCeUiVBFKWH xy75awOuK7wQok5rT6g12b1abwfUeJS//BGIXmdggXpu8LV/U7N2zOXSwwK36Ho+YUsrESa TpuJDKVQ3gQibhEltWNzSFzfmtXWqprWcFM2+nJenKa28ZFouRLjqajPKiwNCXVzXC7f77N Yy2MhD8lPUjnfW8QxhcHQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:IpWbwUwIYeQ=:tEYeNPzWy5Kn5HJmYEBiyt k0IjA1EKbt0LJo9s8rXMjtzzk6IQtBaEEPDDlAdT8qfZ02bwUGqejHOJ3sFIuxu8qEX6aKyaV e7CUXyWmq7IMBsQPgAG7RM/IX+km+vzI5l2LMOtMQ8cQAtG7z3E2PbhRhTv9DpXgfb/5rNNn9 qZn/cWLfdoQcOc2XINdo7VErGvfeZrv9Lzs30VbV6tQZqOe7KcwSoiwh5Z7auf3K4hNRmZPH8 et6c0wufwwZly+tbyzuNl7P0u/fUKXx97v0difE6AlpDvk0+/IU/c/IrtFBNXjq3JEdCzIma1 DoZBCt9THorpOGPbwHyhhf6Bwm59RD5IVqDZHexFd5DC3pxV5gaAdhaO41ruvwKmQwWgmEppS rkf974bfzcp/0XDWooNYGdKPtli9H9TtqSs9N22uwyhVcrZlx1pX3K2A0VIP3f92upma8AouA oHyMLsWWfpoSZH47+CBtmiQkU/L75S9SK6klB6ZXLdcILsY87ymQWFeJRuGCI60+A3PLFY3NI soOrU0nO9ZBJwMMpwfO4aSR4QpcSmr4nXO3woGZ5QbL4cd9g6pDKCsquvHpU2WcjlQ3iokN+t 1pZtzOwPvuVvvo7YbFwnuUdbQfpI8aAavyzXETeb7rZjTt1nur7Bmp3//dMdnGXL8vd2M3HPA 6PcJjXOE9zJrHRqAfG0in7FJvvQMWQ30gu32HIvbDqGLnFk4FLxI4VX8Gm3m0XFTTHXQhqsiT eJ9IuilzsRmXFpQFaERvtCOhZJgy4z6pvjJTG6daXyKLOM3y7zefgkHVjUcPn6+X5dADMMaUF 2JYc7PGBx50J3St8O5rIiuqAhZCiFVpdHXPeX8CEkyKI8dhuwPy2TsrkQ1M9eYZowC4nrkuWT N3qoFW8LP3grVBFgPp4g== ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.10) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657008372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xN29vTS2IlfqYowcyOzNiAdc3/7UdPOdZOZHyl6ac98=; b=2i04+3vO7LmNjIGomg2KD0kplDHGbCgZIImWRJHU+sRbCwJZwxWEsXi3OxodHLrXJ5Ze2H d1pUPWA6fgZkhG7tgpqDC//lXHsZi/USHOrPGMbSzhcbX5nTHYClIWoff9XtlgubXlqpWP DUqeiRwzJggEjDMkhuRSFuFhTt6ak+I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657008372; a=rsa-sha256; cv=none; b=K+OzcMywq53MUNvpMoNMFl56nLRDVTAG2VkFtbCrBDPWFEMcS8RNLNKaMBHU+HAiuJGDIi v0jocAdMdnPx5lPn9N3ehtXUzG4/xOX2+uEmpjgL4q+f42ByaSqZQUNqb6s6HcBdTOvRos 4e2ygpjR35tiSyMpAsp1GQD4Ed4+AEE= X-Stat-Signature: prnimk7ozdi96cjfp6c7jzyjw193pknp X-Rspamd-Queue-Id: 9890AA0020 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.10) smtp.mailfrom=arnd@arndb.de X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1657008372-313613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 5, 2022 at 9:51 AM Muchun Song wrote: > > On Tue, Jul 5, 2022 at 2:22 PM Huacai Chen wrote: > > > > Hi, Arnd, > > > > On Mon, Jul 4, 2022 at 8:18 PM Arnd Bergmann wrote: > > > > > > On Mon, Jul 4, 2022 at 1:25 PM Huacai Chen wrote: > > > > To avoid the following build error on LoongArch we should include linux/ > > > > static_key.h in page-flags.h. > > > > > > > > In file included from ./include/linux/mmzone.h:22, > > > > from ./include/linux/gfp.h:6, > > > > from ./include/linux/mm.h:7, > > > > from arch/loongarch/kernel/asm-offsets.c:9: > > > > ./include/linux/page-flags.h:208:1: warning: data definition has no > > > > type or storage class > > > > 208 | DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > ./include/linux/page-flags.h:208:1: error: type defaults to 'int' in > > > > declaration of 'DECLARE_STATIC_KEY_MAYBE' [-Werror=implicit-int] > > > > ./include/linux/page-flags.h:209:26: warning: parameter names (without > > > > types) in function declaration > > > > > > I wonder if page_fixed_fake_head() should be moved out of line to avoid > > > this, it's already nontrivial here, and that would avoid the static key > > > in a central header. > > I have some consideration here. I think both inline function and > > static key are instruments to make things faster, in other words, > > page_fixed_fake_head() is a performance critical function. If so, it > > is not suitable to move it out of line. > > +1 > > The static key is an optimization when HVO is disabled. How about splitting up linux/page_flags.h so the static_key header is only included in those places that use one of the inline functions that depend on it? Arnd