From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D127FC43603 for ; Wed, 11 Dec 2019 19:31:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DFC120836 for ; Wed, 11 Dec 2019 19:31:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DFC120836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 318BA6B33A0; Wed, 11 Dec 2019 14:31:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C8DD6B33A1; Wed, 11 Dec 2019 14:31:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DED46B33A2; Wed, 11 Dec 2019 14:31:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 063846B33A0 for ; Wed, 11 Dec 2019 14:31:49 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id C848C181AEF10 for ; Wed, 11 Dec 2019 19:31:48 +0000 (UTC) X-FDA: 76253855496.19.judge58_670f771462e04 X-HE-Tag: judge58_670f771462e04 X-Filterd-Recvd-Size: 5250 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 19:31:48 +0000 (UTC) Received: from mail-qv1-f50.google.com ([209.85.219.50]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MNbtF-1iLYnR1uZ9-00P5Lf for ; Wed, 11 Dec 2019 20:31:46 +0100 Received: by mail-qv1-f50.google.com with SMTP id b18so6261214qvy.3 for ; Wed, 11 Dec 2019 11:31:45 -0800 (PST) X-Gm-Message-State: APjAAAW7LYuWBLddOSNsYN/a+sEDBdd9Ku8ygBDekMwZheicq7Qno/uk 6IxF5TdIkSkaf5CjP2sJXdwDQjJBWXXmUS0jfKU= X-Google-Smtp-Source: APXvYqxf4Xp3FM5HTNk2/2drmImAUw5dWnmacIZ0J+E8kqRJYuJMCsxwFdxNI6gooeiVMm0eDFBLHuuFTWJB+qkX2Ec= X-Received: by 2002:a0c:893d:: with SMTP id 58mr4762571qvp.4.1576092704997; Wed, 11 Dec 2019 11:31:44 -0800 (PST) MIME-Version: 1.0 References: <20191211184027.20130-1-catalin.marinas@arm.com> <20191211184027.20130-13-catalin.marinas@arm.com> In-Reply-To: <20191211184027.20130-13-catalin.marinas@arm.com> From: Arnd Bergmann Date: Wed, 11 Dec 2019 20:31:28 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 12/22] arm64: mte: Add specific SIGSEGV codes To: Catalin Marinas Cc: Linux ARM , Will Deacon , Marc Zyngier , Vincenzo Frascino , Szabolcs Nagy , Richard Earnshaw , Kevin Brodsky , Andrey Konovalov , Linux-MM , linux-arch , "Eric W. Biederman" , Al Viro Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:tglDcVsglEccZCAnBoCdgFKRgpCmDYN3KJ+7kDNYrc5q6Ccj95+ WEkOendEKsI4FxV2B+PsJABFi8DMhU46j1mfQLLuggYxfdfzUC5WakN17Cy/N2GVsw25IbZ JPG73nm/clMrBOEYo+maORYORsUV6uAGDA1gJpeUM20oFY0JIRWNkQr7KabfHUNSZsfTGNY B/5qlx+Uso6zw4MPOquvg== X-UI-Out-Filterresults: notjunk:1;V03:K0:+GQs6BN0MTE=:y2FcrzWjvina0I4HqA4/Xj VkyPoYUgpoV0pUVZhlkMzFVc2u4kG0sIFpPTFsDSSM04evlXA7rKECm1m9jCEi7QKdH5jZzGI P3CibKgO4VJDDTdIwu9GzmgwpAouvVu8gSYzQI1I+81NMFSnlb5uCPsx4Xb8zKcGOdo1xmBoB 9WTVekPF4EAQzbOAQ4t1wywBf3gyWcEWqRJ8Q2KqZKsqEeHLapNH0pEg2CmFgKkBDKOkikzP/ hBgvatmXvU2UPKnPAocwPe4dXFyd6cCM81ZL/x31m1o3JMjAx4meqcXXtA3jvtD+Obqv/yZp+ DLjNXeheQoqQynf8HX0lIBzHA0Tw+iX+7ccCzpP0JuKEHxQhA1NBjXzJhFgnZJ7IzhX1+WJRl Ea6XmMXxp9QzjIiCaF7ImpDdm5q0x3eEjP10BRRJYvkuUT/ryq9VxEZQN91xUl3DmQNaWkJNo jzMHRSDQ7pr7fXbd0FNVRV/YmozxpYpvFmGrGPjFDch2Oeq3cgNWUEQktvcqGnx+5gFK6Tk5c sV/XutXwDNbdk/pa3A7JgAeyqpb7FLM91O4L3yxkkcmlpluliXJQg2MZsaQo+x/ckONaYiulc Cdh+BAmoywf3nGnxraRXNFN6j4yo10ZKlUPItR4RUKGUONPUZDHcxvizvwe8amp/5ioJ1ra+7 ERJmqqAVCs1Jtn7PkxYt9S/jyYf1rqqmcwO6bPDnc+VQEm5Kt97qPq4YVGEXP0Ed7vsJKDA0X Lqiba9D0zBy1DSyo2OJd+TkxLEfmQ/ZxXB8wDZErn0u9u/IhUq6eoKj9I9/dlUCP7RH4Lm9XO CFAqE4e+DQXKhrXgugzfgBnxFNk0hNxSiNQi3CiwyG50TEpPYO5t3UDgAkDPnWqI2Q0c1lY8R nx2iuXjZPgQeu4i5CaYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 11, 2019 at 7:40 PM Catalin Marinas wrote: > > From: Vincenzo Frascino > > Add MTE-specific SIGSEGV codes to siginfo.h. > > Note that the for MTE we are reusing the same SPARC ADI codes because > the two functionalities are similar and they cannot coexist on the same > system. > > Cc: Arnd Bergmann > Signed-off-by: Vincenzo Frascino > [catalin.marinas@arm.com: renamed precise/imprecise to sync/async] > Signed-off-by: Catalin Marinas > --- > include/uapi/asm-generic/siginfo.h | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/asm-generic/siginfo.h b/include/uapi/asm-generic/siginfo.h > index cb3d6c267181..a5184a5438c6 100644 > --- a/include/uapi/asm-generic/siginfo.h > +++ b/include/uapi/asm-generic/siginfo.h > @@ -227,8 +227,13 @@ typedef struct siginfo { > # define SEGV_PKUERR 4 /* failed protection key checks */ > #endif > #define SEGV_ACCADI 5 /* ADI not enabled for mapped object */ > -#define SEGV_ADIDERR 6 /* Disrupting MCD error */ > -#define SEGV_ADIPERR 7 /* Precise MCD exception */ > +#ifdef __aarch64__ > +# define SEGV_MTEAERR 6 /* Asynchronous MTE error */ > +# define SEGV_MTESERR 7 /* Synchronous MTE exception */ > +#else > +# define SEGV_ADIDERR 6 /* Disrupting MCD error */ > +# define SEGV_ADIPERR 7 /* Precise MCD exception */ > +#endif SEGV_ADIPERR/SEGV_ADIDERR were added together with SEGV_ACCADI, it seems a bit odd to make only two of them conditional but not the others. I think we are generally working towards having the same constants across architectures even for features that only exist on one of them. Adding Al and Eric to Cc, maybe they have another suggestion on what constants should be used. Arnd