From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666A4C00140 for ; Mon, 8 Aug 2022 06:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00B6C8E0002; Mon, 8 Aug 2022 02:58:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED6F98E0001; Mon, 8 Aug 2022 02:58:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D76598E0002; Mon, 8 Aug 2022 02:58:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C499C8E0001 for ; Mon, 8 Aug 2022 02:58:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 80F25C0ABF for ; Mon, 8 Aug 2022 06:58:13 +0000 (UTC) X-FDA: 79775521266.23.5610F9B Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by imf13.hostedemail.com (Postfix) with ESMTP id C989120061 for ; Mon, 8 Aug 2022 06:58:12 +0000 (UTC) Received: from mail-ej1-f44.google.com ([209.85.218.44]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N0qmr-1nR2JS1BNV-00wnlR for ; Mon, 08 Aug 2022 08:58:11 +0200 Received: by mail-ej1-f44.google.com with SMTP id tl27so14906258ejc.1 for ; Sun, 07 Aug 2022 23:58:10 -0700 (PDT) X-Gm-Message-State: ACgBeo1EuqADixlKKUmR4XvSBIo1LlAJIppDyuAbZpJ7BE4LMPoJv0Er NSWX6sE6LVfYQjA170fkyZ9yqHPpuO00pbKuDhk= X-Google-Smtp-Source: AA6agR7+MNBPFkwjMYrs9F5cklCO3PmGk+NVWugFBet3Tm9GK726GURnSLhj9K8pZOtw7GOLS3S01sY9ymEq4UpWwag= X-Received: by 2002:a17:907:7395:b0:730:b636:2c89 with SMTP id er21-20020a170907739500b00730b6362c89mr12935429ejc.547.1659941890680; Sun, 07 Aug 2022 23:58:10 -0700 (PDT) MIME-Version: 1.0 References: <20220807220934.5689-1-rdunlap@infradead.org> In-Reply-To: <20220807220934.5689-1-rdunlap@infradead.org> From: Arnd Bergmann Date: Mon, 8 Aug 2022 08:57:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64 To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Josh Triplett , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-api@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:SEYjhoQCoTfY6UtSFYn5GAzJ3fo53SiB3OMOw42K/rdY3dqNNnW OcPIeeJCgc8WmYdLTy8Z4/kLr+P9XCIvZ34ilIja9dejmwqfFmjJ0t7QMsDAuw54weXliTg IsgVw6S2Zm5VZkO6KuhDSpcTCpsF9MtUAw1gu3wM8lEltsUdS3FFfa9tyq9Kfo6HtSDNmbe XibAalZIbVEzu6g+PaNew== X-UI-Out-Filterresults: notjunk:1;V03:K0:/Nd9MqQ9ZqA=:MejBLrjiEPAYeWGpj1E07U XM5/m9EwnIIO5e9h/b71Z0zTbyPbJQLCs782EAyUqAxB6nIwf8qsy4RB4l98j7r9UP/cxhoK8 fByoLpVmZaUcs7PgxPrhoYlrZlPhOdHDhiSnusmITUcxDAUP98zS9nXHwiBzwf41cFGor/6TO sq3hUYiXIW6dJLP449KuFJ+0OxkG9cX67ZGd4+fBB/9kaTGKY6r0lypz4jfg3Lb17akVfO4cV V5J3dua162BM7rORUaHjXx/evgo18rAhYckSwNgZ4rKm/sQLzCUbxg2NtrCJK5TQ6gLlZrk4W 4SRqbfrsrdC4B00VG7au2QkZVw9pW243HFHguFCFE56AgVogSV1jExCKJSmqLf9s6daJm45ST VYlTnCHjDykpo50jrhYm3RIlPz2jrdHZMa5wYiU3PvV949T4TWOTuTf/VQmhhXDKXyJx9AvBM 18085TgGztP3uoctQ+QSTqA4mkKCwf8c+jKPLnJ6m3LYy1aBaKJ4a9qTSDsHDGSOZc9j1azuf 80mSRNBQHb7meuDxiyC/ywzbdyu4UIuaYE3gf+6ksn0pVFnuesPmT01vWaryShHZqbFioylUE r/VQxsHtWCJcPF9yqIyzs4vRn/QqPv6ndLOUri4WaYwyjRIoHsD5JBxw46oBpKYVTbPVrOzfA L2yh0jYV0pgYkj8AlPvpgTDPTTJt27hB0awG5xWdoXjXHo/D1cLKktWnTLZrVqdrLjDSVA+Bw cY+e8zXDe50dBG1X+55d8Z4zsY2FKh2IfM6j1K0upwpWVJ4QDGnNzyG9ZECtMImIBLAN9UTv/ 0sTU1P1Xs5bWsoMrtCKOcY4iATV7gtWnw2W2ls9paACZZ/W1p/MN1WOAI3QywFFDFnK5ourQI wDtWRpZJHMCe7j1ZaMPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659941893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WOci5dLljSgCQlQZJJvuJ/5mJIB5sv7PyDcvcykWQU=; b=fduoGcyjEzJtFfnZUhouCSsg8OLuZScURW+R4vsyi/iJEItGNSXr+w5zhzS9z3MgYSieck hJ4pp8NHTnZe48EKk52aDzYaozax+o0dDDfP3tlwJWAsEdA+5ftICU060EBCSfVizRHaXr vV3hPjMwrmnpZ96meGC4LVwNy9kJoAQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.187) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659941893; a=rsa-sha256; cv=none; b=FdKQAWLcyVvzjgADnF3adUTXm7gaHi28OJdbR4kH5Etnx5kTz3Z8lamwtFq4TLM74e2aR+ Rupew6XR7j/KrJUTwdd+vRF7d9/TTpY3XpId+JAnvC2nsqIZzIQiMK9+nW74uLCYk2JGOU Di7/3gbYqiKiWTl6l/DKadlUaYjrOu0= X-Rspamd-Queue-Id: C989120061 X-Rspamd-Server: rspam03 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.187) smtp.mailfrom=arnd@arndb.de X-Stat-Signature: q1xbrohmdb5tbt989f8y8b6wp8ixzjtn X-HE-Tag: 1659941892-699939 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 8, 2022 at 12:09 AM Randy Dunlap wrote: > > When CONFIG_ADVISE_SYSCALLS is not set/enabled and CONFIG_COMPAT is > set/enabled, the riscv compat_syscall_table references > 'compat_sys_fadvise64_64', which is not defined: > > riscv64-linux-ld: arch/riscv/kernel/compat_syscall_table.o:(.rodata+0x6f8): > undefined reference to `compat_sys_fadvise64_64' > > Add 'fadvise64_64' to kernel/sys_ni.c as a conditional COMPAT function > so that when CONFIG_ADVISE_SYSCALLS is not set, there is a fallback > function available. > > Fixes: d3ac21cacc24 ("mm: Support compiling out madvise and fadvise") > Signed-off-by: Randy Dunlap > Suggested-by: Arnd Bergmann Reviewed-by: Arnd Bergmann