From: Arnd Bergmann <arnd@arndb.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will.deacon@arm.com>, Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm-generic: fix compilation failure in cmpxchg_double()
Date: Thu, 23 Mar 2017 14:31:04 +0100 [thread overview]
Message-ID: <CAK8P3a0v1_hb_BLmnbz-hcgvCi=-B8mKvhhkX-FpXJM5z+TQgA@mail.gmail.com> (raw)
In-Reply-To: <CACT4Y+aL-X8VbFC0kfHG8tKVSanhkY9a_hNrEcAHGUyQk1WtSA@mail.gmail.com>
On Thu, Mar 23, 2017 at 9:49 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Wed, Mar 22, 2017 at 10:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wed, Mar 22, 2017 at 12:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Wed, Mar 22, 2017 at 12:10 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
>>>> Arnd reported that the new code leads to compilation failures
>>>> with some versions of gcc. I've filed gcc issue 72873,
>>>> but we need a kernel fix as well.
>>>>
>>>> Remove instrumentation from cmpxchg_double() for now.
>>>
>>> Thanks, I also checked that fixes the build error for me.
>>
>> I got a new variant of the bug in
>> arch/x86/include/asm/cmpxchg_32.h:set_64bit() now.
>>
>> In file included from /git/arm-soc/arch/x86/include/asm/cmpxchg.h:142:0,
>> from /git/arm-soc/arch/x86/include/asm/atomic.h:7,
>> from /git/arm-soc/arch/x86/include/asm/msr.h:66,
>> from /git/arm-soc/arch/x86/include/asm/processor.h:20,
>> from /git/arm-soc/arch/x86/include/asm/cpufeature.h:4,
>> from /git/arm-soc/arch/x86/include/asm/thread_info.h:52,
>> from /git/arm-soc/include/linux/thread_info.h:25,
>> from /git/arm-soc/arch/x86/include/asm/preempt.h:6,
>> from /git/arm-soc/include/linux/preempt.h:80,
>> from /git/arm-soc/include/linux/spinlock.h:50,
>> from /git/arm-soc/include/linux/mmzone.h:7,
>> from /git/arm-soc/include/linux/gfp.h:5,
>> from /git/arm-soc/include/linux/mm.h:9,
>> from /git/arm-soc/mm/khugepaged.c:3:
>> /git/arm-soc/mm/khugepaged.c: In function 'khugepaged':
>> /git/arm-soc/arch/x86/include/asm/cmpxchg_32.h:29:2: error: 'asm'
>> operand has impossible constraints
>> asm volatile("\n1:\t"
>>
>> Defconfig is at http://pastebin.com/raw/Pthhv5iU
>
>
> I can't reproduce it with gcc 4.8.4, 7.0.0, 7.0.1.
>
> Are you sure it's related to my recent change? I did not touch set_64bit.
You are right, this is different, it just appeared on the same day with
almost exactly the same symptom as the other one, so I mistakenly
assumed it was the same root cause.
Reverting your patches doesn't fix it, and I only see it with the
latest gcc-7.0.1 snapshot, not with one from a few weeks ago.
I'll open a gcc bug for it.
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-03-23 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 11:10 Dmitry Vyukov
2017-03-22 11:27 ` Arnd Bergmann
2017-03-22 21:27 ` Arnd Bergmann
2017-03-23 8:49 ` Dmitry Vyukov
2017-03-23 13:31 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0v1_hb_BLmnbz-hcgvCi=-B8mKvhhkX-FpXJM5z+TQgA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox