From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93DDC4338F for ; Mon, 16 Aug 2021 12:11:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DB2A63247 for ; Mon, 16 Aug 2021 12:11:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5DB2A63247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A26B16B0071; Mon, 16 Aug 2021 08:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D7868D0001; Mon, 16 Aug 2021 08:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EC296B0073; Mon, 16 Aug 2021 08:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 744026B0071 for ; Mon, 16 Aug 2021 08:11:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0F2EC182111CD for ; Mon, 16 Aug 2021 12:11:38 +0000 (UTC) X-FDA: 78480829476.06.A8EB8EC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id A6B1110008B5 for ; Mon, 16 Aug 2021 12:11:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C970C63247 for ; Mon, 16 Aug 2021 12:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629115896; bh=9dTCrEHRJR7CF2ccLKdgftzbK5W1e+uUOV66/fFk01I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FMtMK2akfy9A6GHQmu3GzPl4CuywiJZId7/oP8C92LbcKKzn9e2gbM/rd1Q0G1/Dn xRhk7Ha8VhOFU/qhTA+k5KlcoFkkS16WB5V3+s2hgJ+RHFgN3BKht7EwpcKdb5nxSB qY/je1H8uHxT5gdKtX+PPlyGRCr+L86afzZwos8QuwXaNlCRjFd08vMgfseVVzqUTK 5OPEERphFfzC9y8vmjNVi1RIVs8r4/HDkEnlTeHQ/NHwkaSARxI6m7xPaXDoA2F15D LBRbELN2+3b7QV1oahqHHEDIcjji+/o1KiNUvi4jBPooFQtoiSWqq9qjWxnryKJqao bRRNHeLsq6htA== Received: by mail-wr1-f52.google.com with SMTP id r6so23302864wrt.4 for ; Mon, 16 Aug 2021 05:11:36 -0700 (PDT) X-Gm-Message-State: AOAM533/rMf8H79sRPP3aWQRuNQrCcRU7RKs5V1iQgYz0uMfUkr0aCnX 0NQFdNLAYX4eCjptjx2r52OBH/3haVHkNau1L4c= X-Google-Smtp-Source: ABdhPJzX5oMhQ9zKvhiOsZpgAdY3atsASS7gJRNU/XPtc7GxeFqEXRar9Ddb8WirX3eYzLHItJ2Xjyra8CESGLC2prw= X-Received: by 2002:a05:6000:46:: with SMTP id k6mr18774557wrx.105.1629115895437; Mon, 16 Aug 2021 05:11:35 -0700 (PDT) MIME-Version: 1.0 References: <202108151230.lcHk2Pkk-lkp@intel.com> <20210816102209.GY6592@e120937-lin> In-Reply-To: <20210816102209.GY6592@e120937-lin> From: Arnd Bergmann Date: Mon, 16 Aug 2021 14:11:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 5053/7963] virtio.c:undefined reference to `virtio_check_driver_offered_feature' To: Cristian Marussi Cc: kernel test robot , Igor Skalkin , kbuild-all@lists.01.org, Linux Memory Management List , Sudeep Holla , Peter Hilber Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A6B1110008B5 X-Stat-Signature: o4o5ednpjncd5drgq9fn49juz655u8ry Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FMtMK2ak; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of arnd@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=arnd@kernel.org X-HE-Tag: 1629115897-470308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 12:22 PM Cristian Marussi wrote: > On Sun, Aug 15, 2021 at 12:54:38PM +0800, kernel test robot wrote: > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > index 7f4d2435503b..daa349615e91 100644 > --- a/drivers/firmware/arm_scmi/Kconfig > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -4,6 +4,7 @@ menu "ARM System Control and Management Interface Protocol" > config ARM_SCMI_PROTOCOL > tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > depends on ARM || ARM64 || COMPILE_TEST > + select VIRTIO if ARM_SCMI_TRANSPORT_VIRTIO > help > ARM System Control and Management Interface (SCMI) protocol is a > set of operating system-independent software interfaces that are > @@ -68,7 +69,6 @@ config ARM_SCMI_TRANSPORT_SMC > > config ARM_SCMI_TRANSPORT_VIRTIO > bool "SCMI transport based on VirtIO" > - depends on VIRTIO > select ARM_SCMI_HAVE_TRANSPORT > select ARM_SCMI_HAVE_MSG > help Generally speaking it's bad to have both 'select' and 'depends on' for drivers using the same subsystem. This can lead to both circular dependencies, and to general confusion when users are surprised by this. My recommendation is to stick with 'depends on' in general, as that is usually what you want. In this case, there are two things you could do that work better to solve this problem: a) add 'depends on VIRTIO || !VIRTIO' under ARM_SCMI_PROTOCOL, to prevent it from being built-in when virtio is a loadable module b) change the dependency in ARM_SCMI_TRANSPORT_VIRTIO to list the correct thing, as in 'depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL'. I don't have a strong preference between those two, as neither of them is perfect: either you and up not seeing the virtio transport option, or you force ARM_SCMI_PROTOCOL to be non-built-in when virtio is a module even when the virtio transport is disabled. Arnd