From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD2DEC4332F for ; Wed, 13 Oct 2021 11:34:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14453610C9 for ; Wed, 13 Oct 2021 11:34:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14453610C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7F8426B006C; Wed, 13 Oct 2021 07:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A8146B0071; Wed, 13 Oct 2021 07:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69748900002; Wed, 13 Oct 2021 07:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 571626B006C for ; Wed, 13 Oct 2021 07:34:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F1CBF181EE432 for ; Wed, 13 Oct 2021 11:34:52 +0000 (UTC) X-FDA: 78691207224.01.568498A Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 6F7BE10000A5 for ; Wed, 13 Oct 2021 11:34:52 +0000 (UTC) Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MBDva-1mSPbQ3vDy-00Ckfh for ; Wed, 13 Oct 2021 13:34:50 +0200 Received: by mail-wr1-f47.google.com with SMTP id o20so7310651wro.3 for ; Wed, 13 Oct 2021 04:34:50 -0700 (PDT) X-Gm-Message-State: AOAM533BKuRWcpbGb74gm/PCFjZlB8+hvzSpqMWJg4znbm4DHbbKZa8k ikF6wialwDrwA24rk8knA+BJE+8JYY8PYS3VmoY= X-Google-Smtp-Source: ABdhPJz/tQxa5v4qhwFE3sQu9avl5eu7/EDdEmltQMqmVp+Zjg8+ZW0kGehN4p6hG6cHdJWighfCnt4BmNvUupzN+ls= X-Received: by 2002:adf:ab46:: with SMTP id r6mr38988320wrc.71.1634124890085; Wed, 13 Oct 2021 04:34:50 -0700 (PDT) MIME-Version: 1.0 References: <202110130002.A7C0A86@keescook> In-Reply-To: From: Arnd Bergmann Date: Wed, 13 Oct 2021 13:34:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 06/10] asm-generic: Refactor dereference_[kernel]_function_descriptor() To: Christophe Leroy Cc: Kees Cook , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Arnd Bergmann , Greg Kroah-Hartman , Linux Kernel Mailing List , linuxppc-dev , linux-ia64@vger.kernel.org, Parisc List , linux-arch , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:A9P3pd9iDkB15hPcVWrWF9CcgRtdZedAy/1tDzdfZNRVCErCJdz 7bNwwdMy93QXN8z8alUt4wLp1JOyKn/3Nrdb97c2BLn6Nc4xXRqgZNAujzIlFlfu01ZLUWS yxYF3yDc5rUUohMNKu7uZjTuXKs+PMdkCrMS5OWqJki2TnDf4lUi/i6s2jRX9QX8wT7EcJq fT4KBDm4QRaTCiSg5ydug== X-UI-Out-Filterresults: notjunk:1;V03:K0:2M2DmfPW+tg=:Ql0hKe84VpdWLHoRj7V9m1 elWuWQpB2iWo0qXkTGuFaqPZL1fXwPyJE7A5ySAkVm64gb1pHzeryvC/3Bgtd4/Xas/Q3eqav fIhZcELJ7jFJrIPHaVcBIKTgYhL9SNZXge9TNTyd/OgfPwP5k1vF8pkA4v0phs4M0GMK2HaX6 eCTCK27MOzyua/MHBdjTPk3T58PtC+ZApPyQ0Pt9aXiNJvar8h7/CcjtNfRC2a8SM7wAd7zlb Q++4Qh3mSae0uLwSDmQV5Su+Ghy24j7TZpoZqKQscM8xHCoANcpoFVQhluHCb20TiGvA1D4I7 jJ5KMFtLXe6xktU5xjnn9zwnNjJ+znjPGwo/q+2NZLRM2hpMuxe83bYA3QwUaEZj2pRUMEXww EwAjnAf4awRat4FwZxO0QmWQMPNvexfli8r9CbxgIIy3UAPJv8oUKyoKB7t2pBJB0x4dPJwiK B0/n4rVEd40zLSoAFhNL7DRgO6Tud0N+AIa6kILnDGsgflCH1Zz4ib28Slg+VWDE35bCPdyql bqVpDAMTC6LF9At6a4GpPQ0Jmwud4XQeLgE44VLwLSwGW1Hazt5jWxur4K1deBWyC0PXyVffg bt0BA/dbqMZFR+Yxs0gOmase3gbqV8wbpkokyps6unfCMo6adPHPd/hDbsO9KwbDKYRkpoAcZ 24nnyNS5Y4NxtJaKnVLEamtwDEzkzeWewONvvU8JZCt9m0sEXWfE5gKFQX+WQPPXGeiSfvj1I mf11oNNFmUBQUoVD8QBOrh4WYb39JXwtLvYnYjxutIDRnpTdunmeqDfMLxCvWT6rthiq2lVka ci4McFEOALX8ADn6hYL2RyW7BRR6pZUZVQq1kEyb9YRIXj94Ivs3yqJRIsIz/DNO/Xloq2G82 KHgx+HugHh9rRJM6TiZQ== X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6F7BE10000A5 X-Stat-Signature: s3hg1z3spzf5j48x6keujwtqs7b93ajk Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.130) smtp.mailfrom=arnd@arndb.de X-HE-Tag: 1634124892-607770 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 1:20 PM Christophe Leroy wrote: > Le 13/10/2021 =C3=A0 09:02, Kees Cook a =C3=A9crit : > > On Mon, Oct 11, 2021 at 05:25:33PM +0200, Christophe Leroy wrote: > >> dereference_function_descriptor() and > >> dereference_kernel_function_descriptor() are identical on the > >> three architectures implementing them. > >> > >> Make it common. > >> > >> Signed-off-by: Christophe Leroy > >> --- > >> arch/ia64/include/asm/sections.h | 19 ------------------- > >> arch/parisc/include/asm/sections.h | 9 --------- > >> arch/parisc/kernel/process.c | 21 --------------------- > >> arch/powerpc/include/asm/sections.h | 23 ----------------------- > >> include/asm-generic/sections.h | 18 ++++++++++++++++++ > >> 5 files changed, 18 insertions(+), 72 deletions(-) > > > > A diffstat to love. :) > > > > Reviewed-by: Kees Cook Reviewed-by: Arnd Bergmann > Unless somebody minds, I will make them out of line as > suggested by Helge in he's comment to patch 4. > > Allthough there is no spectacular size reduction, the functions > are not worth being inlined as they are not used in critical pathes. Sounds good to me. Arnd