From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D15BC433EF for ; Tue, 12 Oct 2021 08:02:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E218060E0B for ; Tue, 12 Oct 2021 08:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E218060E0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 70071900002; Tue, 12 Oct 2021 04:02:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 687566B0071; Tue, 12 Oct 2021 04:02:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55B35900002; Tue, 12 Oct 2021 04:02:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 4231A6B006C for ; Tue, 12 Oct 2021 04:02:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DC8852C5A4 for ; Tue, 12 Oct 2021 08:02:22 +0000 (UTC) X-FDA: 78687042924.27.2FDC674 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by imf21.hostedemail.com (Postfix) with ESMTP id 58E4ED04056C for ; Tue, 12 Oct 2021 08:02:22 +0000 (UTC) Received: from mail-wr1-f43.google.com ([209.85.221.43]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M7bJ5-1mfST32xHZ-0083rG for ; Tue, 12 Oct 2021 10:02:20 +0200 Received: by mail-wr1-f43.google.com with SMTP id g25so17657421wrb.2 for ; Tue, 12 Oct 2021 01:02:20 -0700 (PDT) X-Gm-Message-State: AOAM532ToO/U70kx52eSMv8tbyBBIEXneV07KKmeDG2SUZbI7ODjKhmn y6ig5tTBLJe42hDJVqiLSr8Aq/gtsL3iDrAbpIA= X-Google-Smtp-Source: ABdhPJwnvZ0Y6Hum+PqySTSqvTb9cKPN3NBY9WwyA3F69Xi/jCmvpemQKNAXUmqZQmtOtxFaHVKwRHP1wYX1RAaUqTk= X-Received: by 2002:adf:ab46:: with SMTP id r6mr29708426wrc.71.1634025739862; Tue, 12 Oct 2021 01:02:19 -0700 (PDT) MIME-Version: 1.0 References: <8ff3ec195d695033b652e9971fba2dc5528f7151.1633964380.git.christophe.leroy@csgroup.eu> <878ryy7m6v.fsf@mpe.ellerman.id.au> In-Reply-To: <878ryy7m6v.fsf@mpe.ellerman.id.au> From: Arnd Bergmann Date: Tue, 12 Oct 2021 10:02:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 01/10] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h To: Michael Ellerman Cc: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Kees Cook , Greg Kroah-Hartman , Linux Kernel Mailing List , linuxppc-dev , linux-ia64@vger.kernel.org, Parisc List , linux-arch , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:lhnrdCQ+BONVbfBazBUe27q8+5Gql2ery5AmRClNk+hjUIr7BS7 VUnwPc9RC9Y7l0N/+DcSTib5si6wLwh+8JBx2O7JhG2OSWzgKFro4+jyyk3Y2KN3jNqa92E 6FiZbPYubLE7InSv7D6/kQHkuQMrphImSN3Hd0MGmnT6deVH3KR9NYe4TZbxt+ooCus9X7L yXGmYlRdpGBE5tIzmYf8g== X-UI-Out-Filterresults: notjunk:1;V03:K0:WX9QzlTujDQ=:rS0IUkXDVsM2Q7nbKPYSVY 5gwn7uPpwII6hDRC/h9c89WvlrAjKmEpDGHcwk+FOW+KL3wslaGMSwTjW+idaWqhcPuY23aKv bWnuS6684gXgPxLkKRgAZ8rzntSv9uLrVl5spa3k5IEeeZgScEWPDVR19bs0oasFPjSHjF9q9 fYjoJZme8qv04iHnql9Chkq3DRWARVj3Wc+lTp32ld8t9SHgDFs404YtDUpI6eCam0uQloUes DTdTB7J9oyFqQsVVJpawqlGUxpaSEF0V2unZENpYfN2tBmj+JeTvYY9YBw9hGtTAOnRLaQnYq QRapziFT6qM8yuv3l0FtDQYFU0Z4dryZ/AfXFynCxM1fFxvHj2JmhHeBMTy+XVVIkfsP2kjgS ZeJNJrdWe17lb+auLpUmof70DCi6NitKpsxScGa8GsP/zOtfaU1teuBOF5eFhYiHE5xNczZNX yhSnqbg199htQ7MdPI4VEZSusDIOh17MFoWRwQNy3RgT5yWRMVFnqiDvr1xVLq9aeEHLKfLmL RfcEx0S9h7w/gkyIokpfibPOR9NIlpYxptF7YCgiJmQiDloJNeqkWkZYPAA5iicb4fAXHMFJG GreCXMLlG7TEYlml7ThlV8Ru+QCYh6FwcrImZPNrbACG57tmkhUS6oYVnVFlt30TT3nRT79gH xOUPpvOWlNqosYMThdaNye8JUoudsx4f1ThoszhbNJsx/vbwlltCNedWiXKPnGhPiFxvH2FvP DW1tCGU5AsjGXCkQ/KtnmOuWMRPF3dxtbXpBcMRTrIBTnxu7VxRSSITi03MTm83bpCuo5dQSd tq5EX3qaJ8z9/M/YVp3ZSsFVLYCRGGMr8tgVqJ+T2swZCxV8Kl0hyDRPPaEUPi06jNh8s0BqK HwD4jigOFnWYIaBfCnkw== X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 58E4ED04056C X-Stat-Signature: p9oryks8qj3tenq7nh47fd8h3hhqedbi Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 217.72.192.74) smtp.mailfrom=arnd@arndb.de X-HE-Tag: 1634025742-352381 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 9:10 AM Michael Ellerman wrote: > Christophe Leroy writes: > > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h > > But it was by mistake added outside of __KERNEL__ section, > > therefore commit c3617f72036c ("UAPI: (Scripted) Disintegrate > > arch/powerpc/include/asm") moved it to uapi/asm/elf.h > > ... it's been visible to userspace since the first commit moved it, ~13 > years ago in 2008, v2.6.27. > > > Move it back into asm/elf.h, this brings it back in line with > > IA64 and PARISC architectures. > > Removing it from the uapi header risks breaking userspace, I doubt > anything uses it, but who knows. > > Given how long it's been there I think it's a bit risky to remove it :/ I would not be too worried about it. While we should absolutely never break existing binaries, changing the visibility of internal structures in header files only breaks compiling applications that do rely on these entries, and they really should not be using this in the first place. Arnd