From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866F6C30653 for ; Wed, 3 Jul 2024 14:50:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ADD36B0083; Wed, 3 Jul 2024 10:50:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15E166B0096; Wed, 3 Jul 2024 10:50:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F40116B0099; Wed, 3 Jul 2024 10:50:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D67576B0083 for ; Wed, 3 Jul 2024 10:50:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 837CE140C0E for ; Wed, 3 Jul 2024 14:50:21 +0000 (UTC) X-FDA: 82298727042.21.64C3EE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 81A0918001D for ; Wed, 3 Jul 2024 14:50:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jcFbI+Z6; spf=pass (imf06.hostedemail.com: domain of masahiroy@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=masahiroy@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720018208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t3u2Mkl6JibVXDVxlOXfni0/+ZZ4OyLYUZjP4kDskAQ=; b=aLQ8oTRIfx4LdaBeCS40FXN8svjJdsF5fD5MN0zUqzCwreKvoZWA0yTnkTqChVu9hajXMq qx2brYniAHWlJQkAnotcUPaDlxbal8Ec+zR4W/GrgPI4f+p5o5afdzsYX9mw7zyzRQzjQD FM6x9QCyJTGD9FJ5PwK06ihb0/Y//JE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jcFbI+Z6; spf=pass (imf06.hostedemail.com: domain of masahiroy@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=masahiroy@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720018208; a=rsa-sha256; cv=none; b=MHzv2hBr8Z6Ey/z/aVtXbWLrig97H3MzAqIGlkawqgoD1qQu30WVx+RAA2/xD2sHoGQrji q9dyNwVzzgmq8IQ5lr8HZYswF/FXdDBDduKJRYyBRMu8Y2weUKvHNeUMT93Qo8vxQ1ELDl 1zilk5Ka7ADxl1ktwxQpqAc1SoHrxJ0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 881276229B for ; Wed, 3 Jul 2024 14:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AFB1C3277B for ; Wed, 3 Jul 2024 14:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720018218; bh=DiZJ0dILrXy2O013iz+bCGWZocmbBOMiap6sH6MRS2s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jcFbI+Z6lRD3WEZSda4ofZtQCQaCdDIk96edMJ+s6TxX/U4DfAJtrLLzHna3j79OG tPpjAXpi3Nd+aO3IJKBFW7Q4u+QH2J8UjKAP/kTgwS7rFTEilIjoqsdTzuKkr42LZN 2JpI0ojfYh1w52bIW1na6U5VAEZ46Uv1yFcGNqLw+Qmv0WUE1/teG4Cn9C/IX2qYID /FWRd+Njfy+VNi+TsKvmkcf/evGUmFJ/rFFPWNEWYXQsFiX+qdWIxO/s7h/wse3o+6 RNlbfv7klYn46Lz6nWgKk8zozcKxXIWNzTTYuI7MZ88aSXTpA/AhOs18U3bnB3zade tYPpEAcm+S+jw== Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2eabd22d3f4so54997221fa.1 for ; Wed, 03 Jul 2024 07:50:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU0qrzQApEpbCkM4kppGbVrKl9d+4KDi04Us+ID8xLvBZqyjy9JUHrW+jK0QxUSY/dGWt5VmO6fPKJ14wfEdjRuCJg= X-Gm-Message-State: AOJu0Yw86Sf7hvwmxqvZYYLXF2WVmDltIrmZgVHTKGfKndJSMxBpWz+o 4N1lJDJklUs7Gq2Eb+OXLn9nD7vo3Nv85R2wammvIFKTZHaWGQtqRLtNooEL4HgTrnxrjXOfkF9 WM/K5vv7iBIzvz7pcDOnluvXoX0c= X-Google-Smtp-Source: AGHT+IEIWx0ohubc/gEMbIlq7uaD+5IUVCdvsx24gzXDTf+BCAo6XWw/fWojD8I4j0YT/KHy8zlrPKTeoiWu61pmhgs= X-Received: by 2002:a2e:bcc5:0:b0:2ee:7b7d:66ed with SMTP id 38308e7fff4ca-2ee7b7d68cdmr29931121fa.10.1720018216931; Wed, 03 Jul 2024 07:50:16 -0700 (PDT) MIME-Version: 1.0 References: <20240702234008.19101-1-richard.weiyang@gmail.com> <20240702234008.19101-2-richard.weiyang@gmail.com> <20240702185230.9ff500bf6a89db888207f8f1@linux-foundation.org> In-Reply-To: <20240702185230.9ff500bf6a89db888207f8f1@linux-foundation.org> From: Masahiro Yamada Date: Wed, 3 Jul 2024 23:49:40 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set To: Andrew Morton Cc: Wei Yang , nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 81A0918001D X-Stat-Signature: ffnx3a9ce7dmn3qprg4i9tje34j8o5ii X-HE-Tag: 1720018219-149413 X-HE-Meta: U2FsdGVkX18zcInpJ7OZ/zLGu668r5n94xH7KU7HieNGqaf2hUaQLzFxcqLMvOwjeNApEH9RtK4ohp+VCQDSb7qql4l1nMFtZ1mrqmrwSXkH8vWBtLqgroIzYK4UxQOTAgBqFP426KIH8UOdXx10ZPQ8a1KWinvUnbDO2/fVhuIosanUFkpxQbHWA4rcYeh1fKwUmuTZ3+XkXe5KHOGYdzY+RlbSGv0yYW9gCZcar51i+ys/4Zcw+pthETeMYmyrgOcePjuuMk+CqSWnv9REAX1QyDONOoxYH2cVJWv4P8HmR8iTf1y1boIAvmGLaU5hOellpt1KDqBahzZeRWGKy9XQ9G2n6ISLdVJtOjoyUv2aN7lisJwC+SQy6wC7YLknlW7daM2tC/TYBU9/E9VHVlTZc0MC5cdIlVmRWnE19hIhVugESr+y27Asv0f5hbSZ4NFmx6t1foJB/3o3yQOoFwCNXZRoMi4tWXV59yI1k7GIqRd07UtwITR4piAGXkStWTVNjA7HPaWa4xDINonKufZej1EU7c208L5Q5L8S4Qwd82pb9u84kfQXxzGnv4AgYVo7HUCID62cRH/Ndc41RVzI/9kyUUcm8avelyax41BN4LRFoI+IRR8h0GEk3bCMHcVjziZLpyeLeq0W99XrIeXTGGQzwhtgAebEV3rbvp6GDDHjAkqQUO72DXoGhb6GBH8U7vA5iz7NJkrC+D4BFzWCNBEIHHrtNh7GbymMdLmKK/TlKA88PHM+zgcf39FxdHrGu1XdI9k59bJnwhuScVtCg9Wx2ovGvzZ0dnspa/ajPHa5T6j2Kxr5TW8GeC//hPItZlPBJmQgo/OEyCDbMefZlccRkW4r0VNLScCnf7sOhv4oJ1E8f27w+fTyt4tOWWRX76kBA/bfowwQRHs0o1keO5Er9zc48hxHAwKfLCPTjgT2fG09IaiaRVUHMu75ljn48U2TvExBVutTbCT DGWeVGH8 /c0ycf5ZlaFXZ959Kl7hYhVP+mKQhWOtSjYvNDPk+tkjyTIGOqEYr1Gclak6jUsFSX0NwQ6cuEm6kNfNSn6QOxZmCIqY/Ruze5F/Qj2/5zxq3XLLmuLxJ7WRPq8H6GDeDMqmzK3j7EtPWnsal1p1Nqf9ZZ4NVxu71Rh5IzIJfwrb6nQBpB4EAkO6AhpnXsT17NP6nwu5Lr7ntEk6ZVUhTOVfrY107mhV1ND83QLOldHrNrw4HR2Rg8uezZnDD1ga4bW4QmleNlDR1LvvhgZfn9fa4SVKW6EfTHh7pYTxH8kkkzRiemMeCvpSIx4HREpd1dp7FjwkLRd3keCSY72fCpebc57KesdRvN8he6tkpBV8uElFvmbhdsNRww8zPToHZkBup4VkttWZeEMCQi4ni5czVP9kXPo8PL+4Jf9P4xS/DhGDuhYffJxS2h1c3r25F/HP+SX2aEHs+7HAjeDAeTKj8mV05VfWpqeRT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 3, 2024 at 10:52=E2=80=AFAM Andrew Morton wrote: > > On Tue, 2 Jul 2024 23:40:07 +0000 Wei Yang w= rote: > > > .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is > > set, since we define MEM_KEEP()/MEM_DISCARD() according to > > CONFIG_MEMORY_HOTPLUG. > > Please describe how this changes modpost behaviour. > > Something like: "we're currently not checking for references into > meminit and meminitdata when CONFIG_HOTPLUG=3Dy, which may cause us to > fail to notice incorrect references.". But I don't think that's > correct. So what *is* wrong with the current code? > Sigh. If you do not understand, you should not apply it. I am surprised that there exists a person who attempted to apply this. --=20 Best Regards Masahiro Yamada