From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4A9C43331 for ; Tue, 12 Nov 2019 07:54:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E627421872 for ; Tue, 12 Nov 2019 07:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="OrtZ1ZiT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E627421872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 802836B0003; Tue, 12 Nov 2019 02:54:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3416B0005; Tue, 12 Nov 2019 02:54:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C9BD6B0006; Tue, 12 Nov 2019 02:54:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 57F286B0003 for ; Tue, 12 Nov 2019 02:54:31 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 0209A180AD811 for ; Tue, 12 Nov 2019 07:54:31 +0000 (UTC) X-FDA: 76146863142.19.hat56_27383890a0d1c X-HE-Tag: hat56_27383890a0d1c X-Filterd-Recvd-Size: 3309 Received: from conssluserg-02.nifty.com (conssluserg-02.nifty.com [210.131.2.81]) by imf44.hostedemail.com (Postfix) with SMTP for ; Tue, 12 Nov 2019 07:54:29 +0000 (UTC) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (authenticated) by conssluserg-02.nifty.com with ESMTP id xAC7sPeh011601 for ; Tue, 12 Nov 2019 16:54:26 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com xAC7sPeh011601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1573545266; bh=iDlxySlUV7nX35FxWeaHPxszgWMmXPkxQCXH4II5Xks=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OrtZ1ZiTSUHAM8xy/JWHwVZ3pfUKQ1YdN2cp5V5uIAxHs3MYm2PzitqVLM2quNM1d YfaSGbnZitYk/k44cwV4QUJMhh807fFsufGR439BlR4TpTjNXvnwfzqnc7SsDaGwss 1kAmV9P8d1O6SkbpQnzST1EZn6oaLocyL2mEWfYci0t4lbOpLbIZpNYIuN+r7vpy2p iCg9sHdDbWfPnor4IgzDyogBvyKYiuLlMbgIU+1YuvnrBidyHX/G/r43NO6vLX1jg2 qSfNlOKzhb9pTR3bGuVB2rcVqC939AsP2Wb9nvmg3sAllgHmNzQRgnm691i62MrHSQ swlIsfvGzJI9A== X-Nifty-SrcIP: [209.85.217.41] Received: by mail-vs1-f41.google.com with SMTP id c25so10196410vsp.0 for ; Mon, 11 Nov 2019 23:54:26 -0800 (PST) X-Gm-Message-State: APjAAAUAA90j1KCi3qTc1WDmjyWgTZ4d+6hAZUBLvnlyZ1jBGJnUkA70 fsXFrCgkevAaFGjKuG73g3MGBlyH3K8KSGyRu+M= X-Google-Smtp-Source: APXvYqwS2w0GOOpBycu4itKhNzVpeZeulJ8dLt/RDqVQnSDtqVcybYmRkOT9L1gMkoicnYz6g0a5eywUq/jz6i4s7Co= X-Received: by 2002:a05:6102:3204:: with SMTP id r4mr21763759vsf.181.1573545265218; Mon, 11 Nov 2019 23:54:25 -0800 (PST) MIME-Version: 1.0 References: <20191108124133.31751-1-yamada.masahiro@socionext.com> In-Reply-To: <20191108124133.31751-1-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Tue, 12 Nov 2019 16:53:49 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: fixmap: convert __set_fixmap_offset() to an inline function To: Linux Kernel Mailing List , Andrew Morton , linux-mm@kvack.org Cc: Arnd Bergmann , linux-arch Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On Fri, Nov 8, 2019 at 9:42 PM Masahiro Yamada wrote: > > I just stopped by the ugly variable name, ________addr. > (8 underscores!) > > If this is just a matter of casting to (unsigned long), this variable > is unneeded since you can do like this: > > ({ \ > __set_fixmap(idx, phys, flags); \ > (unsigned long)(fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1))); \ > }) > > However, I'd rather like to change it to an inline function since it > is more readable, and the parameter types are clearer. > > Signed-off-by: Masahiro Yamada Unfortunately, this patch broke building ppc, mips, etc. (Not all arch implement __set_fixmap) Could you drop it from your tree? Thanks. -- Best Regards Masahiro Yamada