From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5536AC2BD09 for ; Wed, 3 Jul 2024 14:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2E3E6B0093; Wed, 3 Jul 2024 10:45:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB6346B0095; Wed, 3 Jul 2024 10:45:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C55D86B0096; Wed, 3 Jul 2024 10:45:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A70B86B0093 for ; Wed, 3 Jul 2024 10:45:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 284AA80C07 for ; Wed, 3 Jul 2024 14:45:22 +0000 (UTC) X-FDA: 82298714484.25.5640F96 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 17D1E140006 for ; Wed, 3 Jul 2024 14:45:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LvyumqQb; spf=pass (imf09.hostedemail.com: domain of masahiroy@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=masahiroy@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720017895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JTZNA3LD3mKSkDaOL4vS5/+sqURS2eaaBBop1P793q0=; b=mzs0USXIE7Z985/plqCbZFDVfnWPBWeTJH43OjaUXK3Avelcoo0o64cKQJqFwxECnZukrP wz5jVhrhhGOWg/ngUD6e8D8EiDkpOD1SM8JFLJgStP2Wm5pzbuB3wkASaX9ezMFXT/ClC3 KE74wbz6nCZVWaCPqUdpNfEul9D2ifE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720017895; a=rsa-sha256; cv=none; b=DUfBl/2wxy+11sMqU693lA9/iABW/i691X/tGWUvSRjNxOKlf/0eZtc9a0/ii4hYNKNoMU I/K2KfWED55TC4KoP2m/oQg+9G185Apbzh8Rg24ujEEBXzQPMnoilwwa6uwCNEryAES5pQ iv0EoXnCSgmr3ShtyoQf9bxC+U1ljmk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LvyumqQb; spf=pass (imf09.hostedemail.com: domain of masahiroy@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=masahiroy@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0461A6229B for ; Wed, 3 Jul 2024 14:45:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA093C4AF0E for ; Wed, 3 Jul 2024 14:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720017917; bh=8MLZSPdKQEwtId+N1rboQzxPCHIumfHyHcWlOBEgzCo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LvyumqQbwIV9k7EByMcycTpXk3y7TBu/z8QYnr5GWBbSH3D8XKVL51kRwPgqhn+qk VfQxRHzUfB5VKegqUc2YAxLog5tPZHSb8t3ujgLjzPXfG92HLF5pXJEKL54wiGEs/H dTS/8X00+Qq4YfdbkDaGthiPkteghxts0BmL6rPmJNd3lZ6oqEumpXKv/qbcSrK92K pwQPbiUByO6ySwBLFhe0NmoQE3i/nRxsIDbfl1NmfkoxXMafGiP7NFmM++pFZ112Jh q7QdLyXFw3RbRZU4sVy3o/RQ9IMIVJmUSGvIz4/+XLKpM0vjUzFypwVN8QnY8NXlVe 0lnSQu1AABgxQ== Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ec4eefbaf1so58971981fa.1 for ; Wed, 03 Jul 2024 07:45:17 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW4SH96v4Bp8wDI9xjZXHfB7QtWRCsy25RNSsNnzAAyXH2/mIcyHck1ggIQ+czqtlH9/iaila2hXTPKExmHx+hPSnk= X-Gm-Message-State: AOJu0Yz+0uVUeJPvNcSMs6RQw5iW+DJ5owDyi7g2iHYqJTdk8soc4xIr Cbf1vI+v97Bx1UAbrQEvIs/iwHAgzHg72SnBJOACRkgoLDAgQ12NN2V+mRlnXOkXJk2Z/KSz4pF 1Oho1HPkVtjE7etu5O7U3mNXIiTk= X-Google-Smtp-Source: AGHT+IG5Sd4bSXWYjGcKQ9KzumasGYwJzCiLLKVPtWZ2LPlWrEZuQpGY/ZV/RDCcxD81zIMMA77mCw772cPZ+k0DB8E= X-Received: by 2002:a2e:a813:0:b0:2ee:6b86:b0ab with SMTP id 38308e7fff4ca-2ee6b86b2b9mr73206421fa.20.1720017916267; Wed, 03 Jul 2024 07:45:16 -0700 (PDT) MIME-Version: 1.0 References: <20240702234008.19101-1-richard.weiyang@gmail.com> <20240702234008.19101-2-richard.weiyang@gmail.com> In-Reply-To: <20240702234008.19101-2-richard.weiyang@gmail.com> From: Masahiro Yamada Date: Wed, 3 Jul 2024 23:44:38 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set To: Wei Yang Cc: akpm@linux-foundation.org, nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sqh5z55ypgukd5gbyreccs14drrfhqbe X-Rspamd-Queue-Id: 17D1E140006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720017918-120256 X-HE-Meta: U2FsdGVkX19awOSbO9yOQUlFT506w0EwtnqRAyQSixixoakDfYaLBSYSH6/4pbCKXPy1wPuaT495LuiSHD+0UfX4pHNX0zHpiAnH7UIPdPTpi4YHXSveh6QuTN4jSnGVRDFEOt0ZSaIijjzU6oWDYVrXMR1q6w5OEevLDXfBDki5c0GVmhWQrcpytT/WN+aZYgDnF7/iNqBp7wuAFkmo1aE/wLhqlgKFKnkdLuIHxZPppmvPydnCJ+ZCpbxHMr92TCoSBXfjfQtWDiElPedCD38Cbr8L+zX3nb4mXWNn9NKbnKG3NE1e3REh47xqFyod+09qERndhH7IKpWc7Ml9UcoqeP6ahvORsQ1pk5wQNBTrxb0hAHFFdKsaK8P+lc+9W9dSXLMmOKM0igpXM1YO4z7+aNRhfHhnrNpbrEWBMOEnLz5d1ei8OhcAubh85JMDwUGhJ6TUu7ENlsitIj3YwbA7vRz82z6yeePABN2YaOv6xSOriSJlSEC6dVVt/PczspFjenLVA8nf+0T3bhpiBP7gZqdusWUMXLha/o30iCVZUi2l2htG/1XEdSg5y73R4WDdrDBbXi7JNhI6Irnz5LB4XboMUzOw/iu3mvUTCXLR/KGCEwIGI4Iy3tqISr6n/UPhzoFJ2X9DxMdtxwbdP1/PzGyS9Y/ERSCUFHYea23qTXyCNJcorWNjUbTstRN1VjW/JAou18ii0yGjKGx9I0azxH8qEaTlAVF1EmWky5mnE5NF+M88C4tp7tU6DdShJXq/LzF3UK2xlO3XdkfFa3VHhZyurDQkqwE92alxbTvYdW5YMmjQw+p+5z0kkD3uva5EnADpeKf217n6jb9utcBJ+4vlpSZBGfb+bxkvJAajocxbc3WMqfPd83ZqhncK2g400dYEX+VV15sthnJnWnC5rzBGQuwxl8teuEht2x5LCoPUNJVzjcRrLdY9gsBGUSCN6euSi3e/PZpQBcI 5NtSHDex fXXgferlZTg8kHQDDq/Qct4pwXQKCfC3+VNT+2U5/gsIGCcdBUhDKHWif+3BRQSVv94iFQiVpm6bacRQtwx872xpJomTRCY6KHRgOevcfZsZ2ZRYPsmqbFrEVnq7LWHsQ/TZU2d3vYVPMIMacXjLueOvdN05v9MCke56+MlO4pd3Us1HP1aBgXVwKVSjRjhDQ4T5KKjnzPyT+zRNybKFhVB/L4oTFhe5dhrpit8Y2dqn+E6CilTROUftukICjboiMIHA0pJ0COrZ1nQJs8TWdK5AMpHxFF6rr/xeoCkkjloAIJjWCz1LqASQXcJqSs3wJYmudkJCX/6rrJX5PSMHUI8uURWjV7Xs3ieoG1PPQGpOUPn9bShnyKpduKOSr6DVGZYxaxXP4mdYX5ywHmDbtNl2BKQ7Nyr6qqQbsmLFPt7PLguSy4rFVWKTK5xBR8O2oNbfV78c6jpsfLq/uyvgnnKfHgO6NrjG2h1ESYjCD2fpsiP18uzUgaH1OQF9RMtDm92yqJk6MsZirorBiT1x5mxGBEH71LZ2z1AKznxgTiH6vn/yTYpdpnFE5bCm7f0JggjsxAZSsqeokRKwP0Ke9IpsHAxarVk/4BXGP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 3, 2024 at 8:40=E2=80=AFAM Wei Yang = wrote: > > .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is > set, since we define MEM_KEEP()/MEM_DISCARD() according to > CONFIG_MEMORY_HOTPLUG. > > Signed-off-by: Wei Yang > CC: Mike Rapoport (IBM) > --- > scripts/mod/modpost.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) NACK. The section mismatch is performed _unconditionally_. In the old days, we did this depending on relevant CONFIG options. It was more than 15 years ago that we stopped doing that. See this: commit eb8f689046b857874e964463619f09df06d59fad Author: Sam Ravnborg Date: Sun Jan 20 20:07:28 2008 +0100 Use separate sections for __dev/__cpu/__mem code/data So, if you wanted to check this only when CONFIG_MEMORY_HOTPLUG=3Dn, you would need to add #ifdef CONFIG_MEMORY_HOTPLUG to include/linux/init.h That is what we did in the Linux 2.6.* era, which had much worse section mismatch coverage. --=20 Best Regards Masahiro Yamada