From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DB8C48BF6 for ; Tue, 27 Feb 2024 02:15:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72FBE4401DD; Mon, 26 Feb 2024 21:15:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DFFA44017F; Mon, 26 Feb 2024 21:15:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55A964401DD; Mon, 26 Feb 2024 21:15:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3840544017F for ; Mon, 26 Feb 2024 21:15:58 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1306840A75 for ; Tue, 27 Feb 2024 02:15:58 +0000 (UTC) X-FDA: 81835968396.26.45EDD8E Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 44F0E180007 for ; Tue, 27 Feb 2024 02:15:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NM3nhg0z; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709000156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XADzUalCyqzenFShHhcCXOpXUVDuaN8mLhuPYViKtP0=; b=Pvx0nvhZAS+0A5wrvl57bO0qj6jerHBLurjCoSWk7VwF/kFGiaBX0XI3GPL8C1d7itfRf/ HKpoYrB9dvO3XjW8LfMa3FmWt0HP/VrTB0gV9hhPpbWm7Vx2UfKKSVMhzRsnOPDc0SDM8J R1xzJRytSQ3FY/xCoXuMGHF84MZU77k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709000156; a=rsa-sha256; cv=none; b=TpojRz70h0N1vrF0iWR84mLltQnrNUrijFtDZYc9jwzf/vjlpKQRtNx5LrNu56xvgmdKR2 9fQIgv6yGvoRG4egy+5lLUIidr2VpFu1sQ3BajOgAlEdfWqccoQn3W48aLPkEzhv1uyQjf brbomgaYh+kZBwPr0h5vS8jaA09Aeao= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NM3nhg0z; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-608e0b87594so22342247b3.1 for ; Mon, 26 Feb 2024 18:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709000155; x=1709604955; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XADzUalCyqzenFShHhcCXOpXUVDuaN8mLhuPYViKtP0=; b=NM3nhg0zuHbh3cULP+Mo4T4TujAx6x82tdTymnTUIjOWOTey7Iz55yMoAt8m8YyiZ9 o+Uz7gz4i/U2U8mKHh/lL4R3vTmibUhoCr7QaF8/3ETFBPXdMj5dvoCSX2nWtwzNNlms KJuLwqs3Wvn+zt5u20jt8xKn5V79Qo2cFcxpWh6Sutp7TRRk2jj3Lc81OABM4S/3BLxQ EONTwX4+RnZGGh0NQJ5ZOoXiqXhkKU6MqeBIFPrSvn6vp15s0DZK1cbOtsSVxiROPfop I4PgacJDhxLY/woTxREE0+e6ez/IZt4k0QKPnrXWwCahL/oK4qUNSh/I/775TGV1K92B Fd9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709000155; x=1709604955; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XADzUalCyqzenFShHhcCXOpXUVDuaN8mLhuPYViKtP0=; b=ZNM6m3RQpEYTv+Xw2PqeGOkdOk/o5xNeX0JX2eJLN2wteW4ckavLNuGbrtjR2mUyYf MQwEd/2jCMW+vt56+/n5I3vzXmT4iBjBNHGAWPVMRqJ44Xij57prEk8sOTcIieQGrDju 8BwSH1guND41iPagGgH5NRkqAhg5mi0W4FDK/y4seD+x7vI8fvTHS4Cupy0hcMtDwM0l 7DN3qW49xVfZ9ZdGRXAb30+EtLajLcNmyS96xvpw+i1KMfJaMpthmeDKB9TW0It7/342 pGe4f5dUc1ZDYIM/7EPfmMUYGXMToNPNSanjWKWxegausWhkI+Z9+uJxAG3eheUJUIP8 s0OQ== X-Forwarded-Encrypted: i=1; AJvYcCWFFLkJ/73ON1bT+SSfOEolFAb9v0rna6G+QF8g0Zm5pVB/9eCtxfM/msGjO6d3BZ1t2kyhgViWLp5wlpKGEow9qYU= X-Gm-Message-State: AOJu0Yy8s6AxjV9IUVXCFK49C+GaQL3EIRpFW89yy2LZIQezEQAfFXXL oYE9KKo0kdmiPOimdX39CE5tf5NmYx71qHthiT6mTUZ++16if3gg46bNYd50xMVjGBlZ11oYMUW sc0hyWc1U3T3RZs/c6t/L3YJEA28= X-Google-Smtp-Source: AGHT+IE/9QetanPpeHio2vCkD+cyXLQAeOf1Fm5gRVXkkaRDNSvLErLYqbtjNHI5HxouLeyPUMT/ibwSUta6rDaPvE4= X-Received: by 2002:a0d:dd89:0:b0:608:8a2b:b96d with SMTP id g131-20020a0ddd89000000b006088a2bb96dmr869584ywe.10.1709000155300; Mon, 26 Feb 2024 18:15:55 -0800 (PST) MIME-Version: 1.0 References: <20240227012127.174048-1-21cnbao@gmail.com> In-Reply-To: From: Lance Yang Date: Tue, 27 Feb 2024 10:15:44 +0800 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, david@redhat.com, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 44F0E180007 X-Rspam-User: X-Stat-Signature: 13s8urqbxwrs3e3x6oi9mu1xt6oc9o4s X-Rspamd-Server: rspam03 X-HE-Tag: 1709000156-975861 X-HE-Meta: U2FsdGVkX1+95Wp8x16FkuSrwYqbk/puum34336FgXuXHhdfeMsr9V+tjJx5CMXK5A4iQscfVnjkEIVL8ejuVqTs9t9iim/IU6Vte6lj+6D3eS21KyzcD9CqQUrzDWQUnpY0NxXvLN34hBv8WuCFkBhspKOJ3G3kxSA/4Ni7u1WKt/n+zWgkDfFaJQdZRj7lipo49KrJjQQeuJM2Y7ZlZPUWmXknd0rhiVOPdwiq8VEYOxFBnXhQDA5adegJvvadzXWThM6odCcCQS3pydVai89OwmebIPv6WgGllgSb4/VLDtQsgLqNirRujBfBO2LWCzDIRhFxNrwWMWZnHVZNEjpPtY+Q1JuEKK6Bgl6zN4DbrxZHU0NZewpmagNID7aKdyFOrzP2FJwk6PubVpORfI8ANKxE7uQ/r2kYRX8R5xHFjFJ9IlPE2EYYxoWubgD+4T5J9hdE8C2XpkyAxUvAhsnsob+mWLsV5NIoo8uzZ95+vWRo1zSucp8UyRjt1BA4n8b9lKQY1/u8f1OqFAFa2ysPMJvbEfY+FScoCcyuOMsbjAh0ULqcCn62OQtl3JTRaba7tt9l9YsFrHY7unvT5N/CseccDf5jmGYhVyznKr7NV6JzBV7m9oKqyDj5yJk2U7n7jfHMOoHOD+qQ0Cvcnk7hzsGS5tdyz79BnKnJjA2AqhTFwpagH8f6yted0LPZ8unIRMeqEmk5BXWsUn6Ltuo000R7ZRYjlcsF9UxShuV7LQxzYdk/KyQaXUooYrW7etkhP2W7nxnCWTj3//pP9iV7l6hrO2ZoUeNqPFm/RWGw8vP2vUhHAlD1qmy7r/mm7vGUcaWS0IfESIzgGnFBqi3IuSz/wRrD8xT8D7PZ8Ez+uJkq/NcoxBhkFzs+X5atQ62pMeJoTQeZC5feHMASqXNMFRWWhhh7hOJzT5hhqzaI+VIeDmXlHdEIfGzGpchjiXSvgedE47kk0L1VCIK /P3TrPKX XLsw+BE18knfO3aC5LiJHZ2WE/gjvw+oVutLo7C0uYzgt8QL/DvYayWcJRwKwaFH5m6ReWdn3e0V+SmHOzyOd2XXQz/qtGAiarqDNtH5K1vi3YLs+mHq7sNUncw4ZFELXAaZh/rqLGr5MM7tIgr/oWf5AUJ5oeuImIKT5G/2TMGMeC7+3cWFesOzMZ+9sRS6L2eCcG6597Ss9UuDiXN2jWNWgORMuJy/tI9g09I1ufM7pVyM2/k0CwKBallmzj2ugGW00TG8mfc4fZbCfy0Ql+twyIe/UXUdFgF9QOpqpLKJpCywds3FTG+KGKyu28N3I3804x7M/jQPwXUxxhMpYXQHQYDFKktULY8APBRya/vqM4JuLEjXJV8L1LDQZ6ZuaT9lhCnzjNzILdfBdsLn+abwDXEor4WLqCRAQ6MMiCMUEV4FU3O0ZVW4ZzGhLhhv4sF+NEN6+oNMXqHhQDdzGhgnzIF8gAzV/RradyS2pDLf4imi3y7ptd/i0kVSM9R4HOtx57wqKP3N2DUZhPG00MJOpMFOhDzq2P1CwaSVC2pnwxLWGoDXClltB1pyShXbcAm4J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks, Barry! On Tue, Feb 27, 2024 at 10:12=E2=80=AFAM Barry Song <21cnbao@gmail.com> wro= te: > > On Tue, Feb 27, 2024 at 2:48=E2=80=AFPM Lance Yang = wrote: > > > > On Tue, Feb 27, 2024 at 9:21=E2=80=AFAM Barry Song <21cnbao@gmail.com> = wrote: > > > > > > > Thanks for your suggestion. I'll use folio_pte_batch() in v2. > > > > > > Hi Lance, > > > Obviously, we both need this. While making large folio swap-in > > > v2, I am exporting folio_pte_batch() as below, > > > > Thanks, Barry. > > > > Could you separate the export of folio_pte_batch() from the large folio > > swap-in v2? Prioritizing the push for this specific change would aid in > > the development of the v2 based on it. > > I agree we should make this one pulled in by Andrew early to avoid potent= ial > dependencies and conflicts in two jobs. > > > > > Best, > > Lance > > > > > > > > From: Barry Song > > > Date: Tue, 27 Feb 2024 14:05:43 +1300 > > > Subject: [PATCH] mm: export folio_pte_batch as a couple of modules ne= ed it > > > > > > MADV_FREE, MADV_PAGEOUT and some other modules might need folio_pte_b= atch > > > to check if a range of PTEs are completely mapped to a large folio wi= th > > > contiguous physcial offset. > > > > > > Cc: Lance Yang > > > Cc: Ryan Roberts > > > Cc: David Hildenbrand > > > Signed-off-by: Barry Song > > > --- > > > mm/internal.h | 13 +++++++++++++ > > > mm/memory.c | 2 +- > > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > > > diff --git a/mm/internal.h b/mm/internal.h > > > index 36c11ea41f47..7e11aea3eda9 100644 > > > --- a/mm/internal.h > > > +++ b/mm/internal.h > > > @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio= *folio) > > > return (void *)(mapping & ~PAGE_MAPPING_FLAGS); > > > } > > > > > > +/* Flags for folio_pte_batch(). */ > > > +typedef int __bitwise fpb_t; > > > + > > > +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ > > > +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) > > > + > > > +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirt= y bit. */ > > > +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) > > > + > > > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > > > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags= , > > > + bool *any_writable); > > > + > > > void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, > > > int nr_throttled); > > > static inline void acct_reclaim_writeback(struct folio *folio) > > > diff --git a/mm/memory.c b/mm/memory.c > > > index 6378f6bc22c5..dd9bd67f037a 100644 > > > --- a/mm/memory.c > > > +++ b/mm/memory.c > > > @@ -989,7 +989,7 @@ static inline pte_t __pte_batch_clear_ignored(pte= _t pte, fpb_t flags) > > > * If "any_writable" is set, it will indicate if any other PTE besid= es the > > > * first (given) PTE is writable. > > > */ > > > -static inline int folio_pte_batch(struct folio *folio, unsigned long= addr, > > > +int folio_pte_batch(struct folio *folio, unsigned long addr, > > > pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags= , > > > bool *any_writable) > > > { > > > -- > > > 2.34.1 > > > > > > > Best, > > > > Lance > > > > Thanks > Barry > > >