From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B1CC4345F for ; Thu, 18 Apr 2024 00:10:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D876A6B0083; Wed, 17 Apr 2024 20:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D36116B0085; Wed, 17 Apr 2024 20:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7796B0087; Wed, 17 Apr 2024 20:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 965B36B0083 for ; Wed, 17 Apr 2024 20:10:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 05BB741056 for ; Thu, 18 Apr 2024 00:10:04 +0000 (UTC) X-FDA: 82020719928.22.75AF98E Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 1B7F9180016 for ; Thu, 18 Apr 2024 00:10:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZPIkCyOs; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713399002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bWNnfVzIIfJeshD3FIeRNRSQAI7PxLGbs+JyRQWqQZE=; b=JNCB+iB3JNeHAsSpPKr+e3B/we+vKSpPTBxUFYb668IcKpsitu+SmDQrJUtqV2kiMOrieT ps+nnsfzH17lVxNP40WWJZ7SkHnKsigl2HcnSEzpRm7tHekjixA56HSxENDdFrwxXaozxR shYG3WlyjbsjtUv2u0aHhK41sTcr+wY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713399002; a=rsa-sha256; cv=none; b=N7ePQhCh5EHUVE4tuiOvQIfTQXj5uTsQMzMOb+x2pXa65SCGIijbCtL4Ylt2oEAvEcU8t9 0qKFfn6wmYpb+wU1pTmAOW5qVj28xAVFwUBBC/LtE/CsbZX4cJOT6yQ9MmNAbrLOKIb9+f ziw5LIh4NrpPZOLtLj2LrQKuivRrv5k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZPIkCyOs; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-57020ad438fso627603a12.0 for ; Wed, 17 Apr 2024 17:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713399000; x=1714003800; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bWNnfVzIIfJeshD3FIeRNRSQAI7PxLGbs+JyRQWqQZE=; b=ZPIkCyOsmgmRCEBqDYg8SbNSqNaylNG6wUpAI4/tOGazEAxmCBJ3RncVeAe4n/lnIH Q32G7aBpUlTTEEjw8eRdKRfyixJ2+tzyP1qlgqnzrkVM7eD+TgdmxHd4HU7r+aBbVwno 46qPFQA1eVns5ohF8lf9FYTRy+66rufb/BTErTaFH6PdFNNqoWmZqmxyAHRlfa+Qc1mq I7hN5Nh7BJaBxx+15+MPbmQk+7LvP7gYycCKU4mIx0nE6BAcN05MhX2/ygiSYOKVyPge N48PMwEYMbpxkNWc682rc0bEJEYK12xbRTMDtv9+7HtHNWkZeGRb5Ckpkn9DFhLOeaQO U6yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713399000; x=1714003800; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bWNnfVzIIfJeshD3FIeRNRSQAI7PxLGbs+JyRQWqQZE=; b=Hr3V1T6K3LWgWReNDbnUxs4iIWHTH0np6uMdpvjPrQRC6nqdn7eioZq1O/+/RKqfrY ktjWWBnk7n3JXHBg2X1HPC3/Q4WKzGpNfU7KPCzjTTzntKX1C1R+Ats3VtiVhlj1XOj6 kOsLCvfYMQayajL152V/s/6LLNpRLnazwmw8fnabfnYyAccrcx+BbNS24Kofuacaf2Oe UuNC/+FoXVcEDDndoT7NrVWrjt/u4LIzk1wUkouy+kY1iHo/0/I34Cys+6ylkkHqI99v fKR+WKLRFUQNaMDfv3bdnsmbiJ1BR8MKL/0d9d7ylopcWQ69yAoUVSE5+HMbgCzhvQSD qhJw== X-Forwarded-Encrypted: i=1; AJvYcCVGwBnl8H0CUlvnarjidQuXJkZ78kCuM0Nc50eHxXR7Heff0I2UgC7Cen8/0VI8BTj8ApmIBQGatomKhEf+k1+Ws+o= X-Gm-Message-State: AOJu0YxtP7N2Kv9/XZNhJaPYW5BwddEwVQpnf8Q5q8/vWftpF9MfSzCc CXUcbQDn0VdT9wdpuoDXJRB5fo0tin8DlSgmRERO9PGvFHy+/Qo+OgukLV/gjNB9skRM2rDARkS 7J9CINhiXn4BsNa+zJ60ZBZVikZ4= X-Google-Smtp-Source: AGHT+IFxvgg4TrqYmmtEv3dEcoyPdMa0XHro7sMEdAno+N/fY4YFecJxK/aGYpZbM3pLOqFHQRWMDWh+B1xEX3DZMrw= X-Received: by 2002:a50:9343:0:b0:570:392:aa1a with SMTP id n3-20020a509343000000b005700392aa1amr458921eda.7.1713398999904; Wed, 17 Apr 2024 17:09:59 -0700 (PDT) MIME-Version: 1.0 References: <20240417141436.77963-1-ioworker0@gmail.com> <20240417141436.77963-4-ioworker0@gmail.com> <10c33581-b016-453f-ab7d-84832393466e@arm.com> In-Reply-To: <10c33581-b016-453f-ab7d-84832393466e@arm.com> From: Lance Yang Date: Thu, 18 Apr 2024 08:09:48 +0800 Message-ID: Subject: Re: [PATCH v8 3/3] mm/madvise: optimize lazyfreeing with mTHP in madvise_free To: Ryan Roberts Cc: akpm@linux-foundation.org, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1B7F9180016 X-Stat-Signature: qejwaqyrjojsioz5rwsr5dno9tqbwyyr X-HE-Tag: 1713399001-867377 X-HE-Meta: U2FsdGVkX18tMFtDWfwPuchJwkEx8ABiH6X5+B/zTdhibRVlYW9sZ6np6RAQ3ntrwd02d1uVrhkWMuQ0v7YmxbBYmkVIS9IztQB6hJpAl+Z9zj+UNP44WddR033rEdHZgMQbR/saLQuqkxQd6jSL6nsGwIDvgxRsaPJxmddHH1P47CBQjG+KAxEzya1jBTEGl5RNMyiL5HTpMZRN0VmNSHdT/4HqV754dYBNWxPVVoP5ZzRi13JWuL+0KvHvDOrgApLCaUTkrrWKhkz7AkunRi9dcvCBYa8+2jkxH1IFiurjUZu54NaEUUh5WFNkaS6V80HF9APoCphYPrhHaiGUVopBL58Qoh9m+nbDKrvYYcZ8S5QpiS5uPUkjKByz8CGMNLQcECDX8VnJUmdiozmT1cWelskNkmqyfG3TbCUho1KxAtwc0qfyffNx2Rehtm3EjTaoI+4U8pf8lm9VuOVWvxSYRS+2ssGPi7x+2BfYrMYVIkewkiCqxWE7Jp8z9WFsunvI5jLwR51bARjUi2rj6z9nFiKazluax13HrJni9AtI5RxF7GWTvVCe7AS7IT+Pet8NJohTnqG7kQxOYXlnj5/W38ccFIVrq/RbImxNr56ZQ6F+hvGxXu9lFq1HjtrUQKhyxWTtN8xbyLjd69lbtAoTD56gs0Yp080urZZcQ6ekddXLpPNkBrSEQTz93K409AYmn7fq1x5j9BwUejMao4ehcHmczlyRps/YP9RlgPtorVMcgbhC50Azuwx0G1NJ9HDD5O85AhdC4qIRvKgY9FkSvNpSosf7kgg701jzU5mGYpXbUzMJKXapWxSlyokMnO64TYnso3tqp4NwWFDQjV2/kO4WbRgJiNg7mKH7von9i/Rovrd+ta1ScTnmSUUmf5LiPMTBsg+nC9LpdtW7+z2015IQSRJqP4mR/aG12vUTbCMklRBhvhUvWNk1iLtXEuiY+INU3zbCK5c+R0/ GgcWQMTI Y78UbRA/UahS4DUGpumY1lh+rublHE/KJ/GCJ1nZ8S7/MxMlSM+wssmJsiwhwujPNKo+lXEbtXoiWMRcReJEece5PU2EHqtna+XlHjq41tBP3klB0IdMOm0ymkIkWaB1OVUHHfcPrwKyDyXQeJC3zUEcrNx4vDPsVfP9LHcr68k3dD+m4W3et7SL6DX6I7fceBEu2tLuAGHQXVG9iFPmGv5/O8ifqEpu/zDOD8FIKmTfQ+VXwbjjuQmr91wWs7vUEQL/GL5shPw1TQApzHNtXZd2Hyap4Ki/C+ovbjgV+ukteZnAkBxTPokcSeZqFjWU3fVA45fFWRAKN1JZuMTancjCbeUxdnTFfp80vO5Wm2csr7tlriuz5yO9QzSrCAcojhECRLeXa7dBG1uj9Naow/jo3GKItScxNfm1d+pF7/qKhWbq0gdPH59PQ1OghHDQV1C4pLsWWYOSC1CjkbYQ97Y9C7jq+jg7gH1D3ftJhlZhEmV2YoZ39B9QFMPld5GKYJDPED1bFu+4NqCcJDa4NOeOp9MQ1haRYj+T1iGM4SM+SWEdLYdEw5QwYSGXOP8h8Z0y+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 12:25=E2=80=AFAM Ryan Roberts wrote: > > On 17/04/2024 15:14, Lance Yang wrote: > > This patch optimizes lazyfreeing with PTE-mapped mTHP[1] > > (Inspired by David Hildenbrand[2]). We aim to avoid unnecessary folio > > splitting if the large folio is fully mapped within the target range. > > > > If a large folio is locked or shared, or if we fail to split it, we jus= t > > leave it in place and advance to the next PTE in the range. But note th= at > > the behavior is changed; previously, any failure of this sort would cau= se > > the entire operation to give up. As large folios become more common, > > sticking to the old way could result in wasted opportunities. > > > > On an Intel I5 CPU, lazyfreeing a 1GiB VMA backed by PTE-mapped folios = of > > the same size results in the following runtimes for madvise(MADV_FREE) = in > > seconds (shorter is better): > > > > Folio Size | Old | New | Change > > ------------------------------------------ > > 4KiB | 0.590251 | 0.590259 | 0% > > 16KiB | 2.990447 | 0.185655 | -94% > > 32KiB | 2.547831 | 0.104870 | -95% > > 64KiB | 2.457796 | 0.052812 | -97% > > 128KiB | 2.281034 | 0.032777 | -99% > > 256KiB | 2.230387 | 0.017496 | -99% > > 512KiB | 2.189106 | 0.010781 | -99% > > 1024KiB | 2.183949 | 0.007753 | -99% > > 2048KiB | 0.002799 | 0.002804 | 0% > > > > [1] https://lkml.kernel.org/r/20231207161211.2374093-5-ryan.roberts@arm= .com > > [2] https://lore.kernel.org/linux-mm/20240214204435.167852-1-david@redh= at.com > > > > Signed-off-by: Lance Yang > > LGTM! > > Reviewed-by: Ryan Roberts Hey Ryan, Thanks a lot for taking time to review! Lance > > > --- > > mm/internal.h | 12 ++++- > > mm/madvise.c | 141 ++++++++++++++++++++++++++++---------------------- > > mm/memory.c | 4 +- > > 3 files changed, 91 insertions(+), 66 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index c6483f73ec13..daa59cef85d7 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -134,6 +134,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t= pte, fpb_t flags) > > * first one is writable. > > * @any_young: Optional pointer to indicate whether any entry except t= he > > * first one is young. > > + * @any_dirty: Optional pointer to indicate whether any entry except t= he > > + * first one is dirty. > > * > > * Detect a PTE batch: consecutive (present) PTEs that map consecutive > > * pages of the same large folio. > > @@ -149,18 +151,20 @@ static inline pte_t __pte_batch_clear_ignored(pte= _t pte, fpb_t flags) > > */ > > static inline int folio_pte_batch(struct folio *folio, unsigned long a= ddr, > > pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > > - bool *any_writable, bool *any_young) > > + bool *any_writable, bool *any_young, bool *any_dirty) > > { > > unsigned long folio_end_pfn =3D folio_pfn(folio) + folio_nr_pages= (folio); > > const pte_t *end_ptep =3D start_ptep + max_nr; > > pte_t expected_pte, *ptep; > > - bool writable, young; > > + bool writable, young, dirty; > > int nr; > > > > if (any_writable) > > *any_writable =3D false; > > if (any_young) > > *any_young =3D false; > > + if (any_dirty) > > + *any_dirty =3D false; > > > > VM_WARN_ON_FOLIO(!pte_present(pte), folio); > > VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); > > @@ -176,6 +180,8 @@ static inline int folio_pte_batch(struct folio *fol= io, unsigned long addr, > > writable =3D !!pte_write(pte); > > if (any_young) > > young =3D !!pte_young(pte); > > + if (any_dirty) > > + dirty =3D !!pte_dirty(pte); > > pte =3D __pte_batch_clear_ignored(pte, flags); > > > > if (!pte_same(pte, expected_pte)) > > @@ -193,6 +199,8 @@ static inline int folio_pte_batch(struct folio *fol= io, unsigned long addr, > > *any_writable |=3D writable; > > if (any_young) > > *any_young |=3D young; > > + if (any_dirty) > > + *any_dirty |=3D dirty; > > > > nr =3D pte_batch_hint(ptep, pte); > > expected_pte =3D pte_advance_pfn(expected_pte, nr); > > diff --git a/mm/madvise.c b/mm/madvise.c > > index f5e3699e7b54..d6f1889d6308 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -321,6 +321,39 @@ static inline bool can_do_file_pageout(struct vm_a= rea_struct *vma) > > file_permission(vma->vm_file, MAY_WRITE) =3D=3D 0; > > } > > > > +static inline int madvise_folio_pte_batch(unsigned long addr, unsigned= long end, > > + struct folio *folio, pte_t *pte= p, > > + pte_t pte, bool *any_young, > > + bool *any_dirty) > > +{ > > + int max_nr =3D (end - addr) / PAGE_SIZE; > > + const fpb_t fpb_flags =3D FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRT= Y; > > + > > + return folio_pte_batch(folio, addr, ptep, pte, max_nr, fpb_flags,= NULL, > > + any_young, any_dirty); > > +} > > + > > +static inline bool madvise_pte_split_folio(struct mm_struct *mm, pmd_t= *pmd, > > + unsigned long addr, > > + struct folio *folio, pte_t **p= te, > > + spinlock_t **ptl) > > +{ > > + int err; > > + > > + if (!folio_trylock(folio)) > > + return false; > > + > > + folio_get(folio); > > + pte_unmap_unlock(*pte, *ptl); > > + err =3D split_folio(folio); > > + folio_unlock(folio); > > + folio_put(folio); > > + > > + *pte =3D pte_offset_map_lock(mm, pmd, addr, ptl); > > + > > + return err =3D=3D 0; > > +} > > + > > static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > > unsigned long addr, unsigned long end, > > struct mm_walk *walk) > > @@ -456,41 +489,30 @@ static int madvise_cold_or_pageout_pte_range(pmd_= t *pmd, > > * next pte in the range. > > */ > > if (folio_test_large(folio)) { > > - const fpb_t fpb_flags =3D FPB_IGNORE_DIRTY | > > - FPB_IGNORE_SOFT_DIRTY; > > - int max_nr =3D (end - addr) / PAGE_SIZE; > > bool any_young; > > > > - nr =3D folio_pte_batch(folio, addr, pte, ptent, m= ax_nr, > > - fpb_flags, NULL, &any_young)= ; > > - if (any_young) > > - ptent =3D pte_mkyoung(ptent); > > + nr =3D madvise_folio_pte_batch(addr, end, folio, = pte, > > + ptent, &any_young, N= ULL); > > > > if (nr < folio_nr_pages(folio)) { > > - int err; > > - > > if (folio_likely_mapped_shared(folio)) > > continue; > > if (pageout_anon_only_filter && !folio_te= st_anon(folio)) > > continue; > > - if (!folio_trylock(folio)) > > - continue; > > - folio_get(folio); > > + > > arch_leave_lazy_mmu_mode(); > > - pte_unmap_unlock(start_pte, ptl); > > - start_pte =3D NULL; > > - err =3D split_folio(folio); > > - folio_unlock(folio); > > - folio_put(folio); > > - start_pte =3D pte =3D > > - pte_offset_map_lock(mm, pmd, addr= , &ptl); > > + if (madvise_pte_split_folio(mm, pmd, addr= , > > + folio, &start= _pte, &ptl)) > > + nr =3D 0; > > if (!start_pte) > > break; > > + pte =3D start_pte; > > arch_enter_lazy_mmu_mode(); > > - if (!err) > > - nr =3D 0; > > continue; > > } > > + > > + if (any_young) > > + ptent =3D pte_mkyoung(ptent); > > } > > > > /* > > @@ -688,44 +710,48 @@ static int madvise_free_pte_range(pmd_t *pmd, uns= igned long addr, > > continue; > > > > /* > > - * If pmd isn't transhuge but the folio is large and > > - * is owned by only this process, split it and > > - * deactivate all pages. > > + * If we encounter a large folio, only split it if it is = not > > + * fully mapped within the range we are operating on. Oth= erwise > > + * leave it as is so that it can be marked as lazyfree. I= f we > > + * fail to split a folio, leave it in place and advance t= o the > > + * next pte in the range. > > */ > > if (folio_test_large(folio)) { > > - int err; > > + bool any_young, any_dirty; > > > > - if (folio_likely_mapped_shared(folio)) > > - break; > > - if (!folio_trylock(folio)) > > - break; > > - folio_get(folio); > > - arch_leave_lazy_mmu_mode(); > > - pte_unmap_unlock(start_pte, ptl); > > - start_pte =3D NULL; > > - err =3D split_folio(folio); > > - folio_unlock(folio); > > - folio_put(folio); > > - if (err) > > - break; > > - start_pte =3D pte =3D > > - pte_offset_map_lock(mm, pmd, addr, &ptl); > > - if (!start_pte) > > - break; > > - arch_enter_lazy_mmu_mode(); > > - pte--; > > - addr -=3D PAGE_SIZE; > > - continue; > > + nr =3D madvise_folio_pte_batch(addr, end, folio, = pte, > > + ptent, &any_young, &= any_dirty); > > + > > + if (nr < folio_nr_pages(folio)) { > > + if (folio_likely_mapped_shared(folio)) > > + continue; > > + > > + arch_leave_lazy_mmu_mode(); > > + if (madvise_pte_split_folio(mm, pmd, addr= , > > + folio, &start= _pte, &ptl)) > > + nr =3D 0; > > + if (!start_pte) > > + break; > > + pte =3D start_pte; > > + arch_enter_lazy_mmu_mode(); > > + continue; > > + } > > + > > + if (any_young) > > + ptent =3D pte_mkyoung(ptent); > > + if (any_dirty) > > + ptent =3D pte_mkdirty(ptent); > > } > > > > if (folio_test_swapcache(folio) || folio_test_dirty(folio= )) { > > if (!folio_trylock(folio)) > > continue; > > /* > > - * If folio is shared with others, we mustn't cle= ar > > - * the folio's dirty flag. > > + * If we have a large folio at this point, we kno= w it is > > + * fully mapped so if its mapcount is the same as= its > > + * number of pages, it must be exclusive. > > */ > > - if (folio_mapcount(folio) !=3D 1) { > > + if (folio_mapcount(folio) !=3D folio_nr_pages(fol= io)) { > > folio_unlock(folio); > > continue; > > } > > @@ -741,19 +767,10 @@ static int madvise_free_pte_range(pmd_t *pmd, uns= igned long addr, > > } > > > > if (pte_young(ptent) || pte_dirty(ptent)) { > > - /* > > - * Some of architecture(ex, PPC) don't update TLB > > - * with set_pte_at and tlb_remove_tlb_entry so fo= r > > - * the portability, remap the pte with old|clean > > - * after pte clearing. > > - */ > > - ptent =3D ptep_get_and_clear_full(mm, addr, pte, > > - tlb->fullmm); > > - > > - ptent =3D pte_mkold(ptent); > > - ptent =3D pte_mkclean(ptent); > > - set_pte_at(mm, addr, pte, ptent); > > - tlb_remove_tlb_entry(tlb, pte, addr); > > + clear_young_dirty_ptes(vma, addr, pte, nr, > > + CYDP_CLEAR_YOUNG | > > + CYDP_CLEAR_DIRTY); > > + tlb_remove_tlb_entries(tlb, pte, nr, addr); > > } > > folio_mark_lazyfree(folio); > > } > > diff --git a/mm/memory.c b/mm/memory.c > > index 33d87b64d15d..9e07d1b9020c 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -989,7 +989,7 @@ copy_present_ptes(struct vm_area_struct *dst_vma, s= truct vm_area_struct *src_vma > > flags |=3D FPB_IGNORE_SOFT_DIRTY; > > > > nr =3D folio_pte_batch(folio, addr, src_pte, pte, max_nr,= flags, > > - &any_writable, NULL); > > + &any_writable, NULL, NULL); > > folio_ref_add(folio, nr); > > if (folio_test_anon(folio)) { > > if (unlikely(folio_try_dup_anon_rmap_ptes(folio, = page, > > @@ -1558,7 +1558,7 @@ static inline int zap_present_ptes(struct mmu_gat= her *tlb, > > */ > > if (unlikely(folio_test_large(folio) && max_nr !=3D 1)) { > > nr =3D folio_pte_batch(folio, addr, pte, ptent, max_nr, f= pb_flags, > > - NULL, NULL); > > + NULL, NULL, NULL); > > > > zap_present_folio_ptes(tlb, vma, folio, page, pte, ptent,= nr, > > addr, details, rss, force_flush, >