From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0E5C2BBCA for ; Wed, 26 Jun 2024 01:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CEDF6B0098; Tue, 25 Jun 2024 21:26:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 557D66B0099; Tue, 25 Jun 2024 21:26:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F9546B009A; Tue, 25 Jun 2024 21:26:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 218146B0098 for ; Tue, 25 Jun 2024 21:26:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC6F41408CC for ; Wed, 26 Jun 2024 01:26:51 +0000 (UTC) X-FDA: 82271300622.11.5EC292C Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf15.hostedemail.com (Postfix) with ESMTP id E7B9BA0004 for ; Wed, 26 Jun 2024 01:26:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WGIYY0a5; spf=pass (imf15.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719365202; a=rsa-sha256; cv=none; b=4qOuryc9LkXsmh1eeuhk/Zo1HOo+55X3AmWJ6bagr/WssvCGCtcqAjkR35rD1ET0cQQPmM kX93v0UDk3g2Z4OMCbi8u2yHoNJGx5nlxJao3Dsj4B8TTnAMvlqLRKCghqbTec29ur8QO4 wfKKoMIDPvw+tC9xab0XRESde3HyStY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WGIYY0a5; spf=pass (imf15.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719365202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tANEY+M56yiD7hSog1hj0C9LymtYDipW0j1BMyxicPw=; b=Bmi0XSJBe8VyK8jNgZDOAonvZUl5z1SfVA94s4dHlHRnpWZE7tnhEqR9C6BooVoLeRriOg 9PgyGCK9vc/oFMw883ZLhloNBJMPm9wWVevQ6p1FXEKOH0nqNOrugLjYj6D0oZMXPIXx+5 jIPIUoQTnVyrXkXsH34Uifwq69aw6Z4= Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ebe40673e8so67622731fa.3 for ; Tue, 25 Jun 2024 18:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719365208; x=1719970008; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tANEY+M56yiD7hSog1hj0C9LymtYDipW0j1BMyxicPw=; b=WGIYY0a5mXQrzVESmPDwYkQ3d/aXaka+b2BxXSBB8hKJDKjIZeRu/RacEiesbY9VlU Vp3FYuMPemlsBBYElicIN08evyu0d/5sZTVKXwlocYVLLYrJ4Mtz6j6dByEQHSgNOjBm FMZJXtYYHFg2ePBSoh12fDrqTwK/5zpl0u5tBNte3HLeC3kJsTeyaqRT7v5EJeOyQOuH IFqLjamY3V8xWN8z5o6vX8iXlP2W8MyOJnDMlL1Ycdb98W1440+5R1VikvnSLt7nV89o Hpd+2AH2C0SMnn+Ar7k3nCW5Keu+tpXSPG80of+4WmPZhjgmT6Enj/hmLXK4ymDxJr77 Kosw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719365208; x=1719970008; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tANEY+M56yiD7hSog1hj0C9LymtYDipW0j1BMyxicPw=; b=EmQptLBZ1e1ai0QNBuK556P+JtMNqDAPJJsPs07xDL3ph8RFcSGedLvHwXp8ZQjGc1 yXTbNbi5AHDUlRulc81kIuhWDQ9sSxKCQCgJxmr5sPToDPLeVKQAq8L2FTKzkUFxM4nr 2mrDuQG+SWTQR3/4bQ6OxU3Fs1zHxvkCA4f3pb9IFdH2fIvCK1D05gEYKZ8Fm59Bqner KyN+vNK1DXo3G59QSKRloISKLrUEoWWs+ZKnHLcw9OERCnWvcqQZs1x08U1tb6/xFt1h GlD3N4DRg74XjYkNe97fj9ujRCqrB7iLKyL4TUGOd95v8UK/4SH+f/qLkvfXN6aImJQS 8zBQ== X-Forwarded-Encrypted: i=1; AJvYcCXppPvju6yQjrQ7ZGqeOYF0u4GZeUz2IIlaB0U3Z0j+AiAI9XvPr1xBgl1KafGPd53jSTWtsuoX5waXMsNYBoZWYG0= X-Gm-Message-State: AOJu0YyXfgW/tks/vzAHNPJQrQ8qerR1pgkodgc9WdZ0vTeLerqfyyNS 584Sqn5UpmuCpwEPvcHSbH1DEdtjK4sqfBk7jFWEf5VXWgL6qfeqakj3RmM2KoLjh7XvpMXywCn up73O9OM62I7xMhVN4SpvxtzvsFg= X-Google-Smtp-Source: AGHT+IEETQh2pfp7G4EtPUAG4zfYaOcqG4MrmB8HSsZzqNVtmys/DMhBHIIqOctT8mteNfPrcq1X0+Bn/gHiO0U9f90= X-Received: by 2002:a19:e046:0:b0:52c:e171:ba2 with SMTP id 2adb3069b0e04-52ce1835617mr4892289e87.17.1719365208080; Tue, 25 Jun 2024 18:26:48 -0700 (PDT) MIME-Version: 1.0 References: <202406260514.SLhNM9kQ-lkp@intel.com> <20240625145252.d78d18a109cb6bf84eefb5f7@linux-foundation.org> In-Reply-To: <20240625145252.d78d18a109cb6bf84eefb5f7@linux-foundation.org> From: Lance Yang Date: Wed, 26 Jun 2024 09:26:36 +0800 Message-ID: Subject: Re: [linux-next:master 7701/8232] mm/huge_memory.c:2735:31: warning: variable 'page' is uninitialized when used here To: Andrew Morton Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3oizcm6tk5rtg3f3wohwjfucjrzr9r8w X-Rspamd-Queue-Id: E7B9BA0004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719365209-134135 X-HE-Meta: U2FsdGVkX198pGhCsYXv3FFs2oDKQR0/CL+8LIriGftkLqm901SZZS7Xz00HlnvTFc5xvLVAmf5T0pnoxhAEFBLVHPKsoMtnoHtREpPxZXM+PcVbZpOK1LDQssnoiEjpxizJdAr7GTRSdXwfAF9OEh/v01w+rird5AR44wtNLbJd8crUPkZQXGd6IrivZY//9HGuJRudS7HCQAGTcsei5OWrU1FRN+mDn8osPnUKWA6ZmTsSGU34e61iAwR3eVsrc19vAk7nGf5XjPDqXLv9LSHdnjXiH/l72o96aSPZeaKZGw7k1oTpnWgdMtuR6alWQOM/7vxqgG4n+N5V+F/8FKRzX0E7++EqLheXLz09mVmPpq+b5/HjLSpjAXmqopzwuTOLCW0LSupXjH7mApk3R5GAktTp8dmB9oI6EkcWrfbDY24AY7EetAf0XxI3d8k0462+9ib2HQ7o8Dt1ZyTeJAnA9VCub6FY1Ty1PgdowvL53nMCt7yfpjmS/pXyi2Z04WyQOMUgfTuI9zs0EbEa0AJx2NiRamMDsbfukmOH10iowc+Onk4SYrIr0HR3fMJrbUu6JDDN0JhIS2cY3B42bM6wn38tYTJZe4Qot7BWpA3dGYEPH3KeTINpyFwGxcvjJ5YuDyXQHIdDvr5CySuzHNkg0Sjk9/rz3FXhLRNNN1ayZ6KExJ2uCrjPY3v6PybM0xlezNOs7ca7LA5y9kZLZtEH+bJGQVjbvJWvMtA8Xp/PLWEN6Gz+NqvCxti+xKq3CU8dTfcACg3yhr3k4cSulpTu3Ha/iz//gQjsuAt9Qv+hLuxCdsP2NDEwVRnQrWWKxQBaZ6K3zKB3wpyOp2jMd2WvdGnI2FRSDUkq+DUXk+hke317oArUR+I3Ky0C9Gk7RtMIavQGFUpL5NA0zqpszsmNRuneTMvPLbqxZ6Gm91wn+fITwcTtzoDbNwY1yplKPN16ZkCbJDfFSPs1e7n PkvPwbmD 9NNMc8LgE4G/3KWkCTcn6P+Ajxj2lZSP0L3MXCbewt5quRMFEVTsxjkhxy7iubkp7QSUiEcw1jx0cFLLYpbNoHlGwjUjSErhbELn0/WwLlvLmODUDk+zK/W1bi8Mr8eEnjgS9ms3aHOvlmdAIQ6+rfKQJt+piGkP0M32sP0yLOFstbv3mEBgpKzPUwVINW0byC/8hBXxwO9jjENtNwqp1v2QnTanSonekm2tcYGmqneuFvjZldSNdf+hMmzg6GxjMmOtkgbt1lDlRVnQCJkDWG93mMMJo3ZtIYV8FdeJxdWVmxYrXFCzu8tvJpjOKbft0cURZ8q9HWOt6NTeQEPDOPWB3+BWwycpuLJCXQqssDbjTt+wJjmIdv+N9Mc0+VkxQ3zjlOEW8QB+8sk4hnDQIMRFX1vJ+p9pwTBR1S5RsIxCclM7IiKPaPs/3xByCj0tXcBuoX7K2MaQ3SEMFY3n+9KH94hm+jOgYV8l2gXanpvFhAXsfz9jdidVZY7mfrgdTlIAYObTwfsREMr4j6vBAh4gcpdYvILCtodIae/YIXn8/sE+oWxby72RccapZFdeHiqX53RmNHvwfjemkEOj1sSzJqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 26, 2024 at 5:52=E2=80=AFAM Andrew Morton wrote: > > On Wed, 26 Jun 2024 05:39:54 +0800 kernel test robot wrot= e: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed > > commit: 4627108658d68fad359600dbe667b88b501cee71 [7701/8232] mm/vmscan:= avoid split lazyfree THP during shrink_folio_list() > > config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/2= 0240626/202406260514.SLhNM9kQ-lkp@intel.com/config) > > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 61= 7a15a9eac96088ae5e9134248d8236e34b91b1) > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20240626/202406260514.SLhNM9kQ-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202406260514.SLhNM9kQ-l= kp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> mm/huge_memory.c:2735:31: warning: variable 'page' is uninitialized = when used here [-Wuninitialized] > > 2735 | folio_remove_rmap_pmd(folio, page, vma); > > | ^~~~ > > mm/huge_memory.c:2699:19: note: initialize the variable 'page' to si= lence this warning > > 2699 | struct page *page; > > | ^ > > | =3D NULL > > 1 warning generated. > > > > > > um yes. > https://lore.kernel.org/all/20240622100057.3352-1-ioworker0@gmail.com/T/#= u > removed the initialization. My bad. I could have done better :( > > I'll do this, because I'm about to push a tree out: > > --- a/mm/huge_memory.c~hack > +++ a/mm/huge_memory.c > @@ -2697,7 +2697,6 @@ static bool __discard_anon_folio_pmd_loc > struct mm_struct *mm =3D vma->vm_mm; > int ref_count, map_count; > pmd_t orig_pmd =3D *pmdp; > - struct page *page; > > if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) > return false; > @@ -2733,7 +2732,7 @@ static bool __discard_anon_folio_pmd_loc > return false; > } > > - folio_remove_rmap_pmd(folio, page, vma); > + folio_remove_rmap_pmd(folio, pmd_page(orig_pmd), vma); Thanks a lot for jumping in! Lance > zap_deposited_table(mm, pmdp); > add_mm_counter(mm, MM_ANONPAGES, -HPAGE_PMD_NR); > if (vma->vm_flags & VM_LOCKED) > _ >