From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBE6C30653 for ; Sun, 30 Jun 2024 10:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 710FF6B0085; Sun, 30 Jun 2024 06:44:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C12F6B0088; Sun, 30 Jun 2024 06:44:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5611C6B0089; Sun, 30 Jun 2024 06:44:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37EEE6B0085 for ; Sun, 30 Jun 2024 06:44:30 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BA748A3869 for ; Sun, 30 Jun 2024 10:44:29 +0000 (UTC) X-FDA: 82287221058.11.A37A11C Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf21.hostedemail.com (Postfix) with ESMTP id DCBF61C0012 for ; Sun, 30 Jun 2024 10:44:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X6YgCenY; spf=pass (imf21.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719744257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nxZ3tJj5i7QOrkJh0VIa529AtPkb/VxWhsoREUbh1oY=; b=Q+qKFSNMfEy7EllQOjqQD/fCI5rpbOh34o5EBQllOFEXYKr7EVfd0cPJ0VGA225pM3BMeN cOhyp6lJVvmarj+7P8uqP1eVJqDZsTkG1VKDXHrYiJW+NI7Lrew5HhzzSIcqeCMjjvx8o6 mBCY2o8t6CCPjb435EHRP/qpKeDhw9Y= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X6YgCenY; spf=pass (imf21.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719744257; a=rsa-sha256; cv=none; b=6w3tPtIUG5TuHIe9/XQ1d4x/KdRLDcdcKEfSmtGlufeL+ddwiNkaGAM6DL+d3+wWTDZwux xwCIluKMcsc1KJOUs2myscMbd2NB7YmtHEWhb2Mf7GE4cLNjsFQonwdFmsqpQXW3J7Vtvt xooqhJnX8HrBFI0WD2uZV/L1W8nD4CA= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-57d1782679fso2551595a12.0 for ; Sun, 30 Jun 2024 03:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719744266; x=1720349066; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nxZ3tJj5i7QOrkJh0VIa529AtPkb/VxWhsoREUbh1oY=; b=X6YgCenYo5pJJag42B9jRmI6vN8+FM+LzXWDSVE7nJqtySub/2e/Nolekw1mw24yRd F9W4SsP8aGivQ6p5MPpUa8fvuQkLX78Vu8VmSSChFXXlIDWCusZ35Uhnji4eZ3ylb/Oc QvmFzNs+r7du3I231tExl1oqogG1rgYD8beJmOfiCLIKFFDuj78Mc8kXFOFOQrbpugzU 1rSD3EyHUGI9Wfq3hrpTot8WnYp9qjJKC5qNu5kIuCwfiXqnuMxLkHi9Wbtub3q+TnFU /020LFM6XGRPIYXIz1W66uh5EA0LVJJf8QGCNHmTvvHiS6SgCZNBm6F9DOAcDiz4Ib2z Yd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719744266; x=1720349066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxZ3tJj5i7QOrkJh0VIa529AtPkb/VxWhsoREUbh1oY=; b=TjgQ3FB2ZwkwWrYqAr3tSnZMJNRFD7RTARJOL5kkg6rmYh6pC7miqWELDPimsn2lAr mDVEWK21g5ntyzJGPvfc7Q5JsRitNJ+xOg+yCxDEkzotpUr+N+4Qr/rteYJw02Wl6Fk0 hSJ3LpEVpqs4uVa8KSXI5WcHMW4ra1mQTaRJedPrslhCbIYBmw75lmgNYmu+zTZiWY+L avhTvePSuEnfrDZPwnIiI04dPBDZJc5r0uBX+3KFQxMdWmXU0ELoXmHEobxc+g56zVMN nwnXzwtt6drVvyN9XrAN+HIZonEixHh3NNli2z8swG1oYijjPB01Buf4vRdge/+VBTim Ri1w== X-Forwarded-Encrypted: i=1; AJvYcCWeJpQWo1hY1CsE/ncdO27g8miIMCLH2CyH1gC/Zq8b98GL173P3p5I7pZwEz4cXMLAofQsNloGwj9CDc1sKPvdQZ0= X-Gm-Message-State: AOJu0YylRTK5TaT2M83CGrDJ9j27XOWfyUJgK+668NNqMuktlL+ijujW FNJCiWYQEZAlNHndZ6PVHzYG2nfDHt6+O4JyqomHIj4IIGKgarPHPdV+yncddLxLi+fUETOot0a fYpGK/LRn7j4KTq2DJfsV8Ngp2Bw= X-Google-Smtp-Source: AGHT+IEwNnRMTNLVFa2Vct7GYPnmOxdeoHNqOi6hW20KZkNAdRp96NVMLfzP0R695C5mK/j/t4BulFbOfccJlSwZwUY= X-Received: by 2002:a05:6402:5111:b0:57c:da58:51e7 with SMTP id 4fb4d7f45d1cf-5879eaff6cemr2096516a12.1.1719744266033; Sun, 30 Jun 2024 03:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20240628205958.2845610-1-jiaqiyan@google.com> <20240628205958.2845610-2-jiaqiyan@google.com> In-Reply-To: <20240628205958.2845610-2-jiaqiyan@google.com> From: Lance Yang Date: Sun, 30 Jun 2024 18:44:12 +0800 Message-ID: Subject: Re: [PATCH v7 1/4] mm/memory-failure: refactor log format in soft offline code To: Jiaqi Yan Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com, muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, rdunlap@infradead.org, corbet@lwn.net, osalvador@suse.de, rientjes@google.com, duenwen@google.com, fvdl@google.com, ak@linux.intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DCBF61C0012 X-Stat-Signature: 84ahb7ika9re8pqx31knu77uk5tejtdd X-Rspam-User: X-HE-Tag: 1719744267-247793 X-HE-Meta: U2FsdGVkX1+9aleXtQo9hpCKTH7IpBFSEbQOPiGP3Z8rtRI6V4Ip3IoTAOvC9l/cQ1NgfFjRKMzgFLActFRcG4HSadOgInPTHBoqQjYDKlxmcrDO8i2TzqMJFR9mqPBFgNT2S1jh8NoRWozpYlJIhxSNhwaNEwHPI/PbRNqRVdGRKyobQ4mWKc3Icp2mA5VzSllQnbpJLXubHuRUsdgSKdOenFtiQtNdkZC6TE5rkhlkIZ27Wc3hfFNOnmc0+LODMmtmbaAJtccZyibMFW3VoWpiYJIGDbWZVV+6Es7WaAVtxVbDel4fD9xak3WCsk2AtjBPI5F9o0DP6VEFDMZjVf7kgmb7sX9D2jDtoUeb9srFVutBWo1BkB7Zx7d0uAs/KH3TBfwhKp6+BpUJgRtAIoFTjUyE1qesJtRmxzh5CZPoDHGH5lVUPtqlMzsUWwBR1IdzKe/UMIRQD0Meg0oWxeIMKDYM44KEbMfcjp7j1KGd+YGs7HYpZvnZm1Pbgqhx/sbjLSza8K3DTGDEeDYE+aQchxtYIwpLpqL0dOwJf/80c8edQfeStmuZkwPQ38Doqg+XLokBi1l7MWKss6d3z9iDIyxJ7FrfNPob6vGDQ1x5SHszFAFaGYRgjt2YCfXo5NSx7HAkSd2E1eDfghKZZ3ob2iNYoHvf7TnQQExPhOfynv6j7hnJhT45ZLLIo9skkKDApIkbJDBg+ChyDE6B/SbQhSxZw/F/fyxR1KBN5ne+hiyzmSL8Pi+XryKMXkQd/YhP2Gvw71xWE7O8HtsdqmIE/ZgzWwrD5J1eiD9gIn0LC0cuzeIETN0hzAu9GxwXxVAexyiQZ0ZooeJ7LwtpIxwVUlg06Bcy/y08qmQmtiur8zgiYiCNhHXsrVFtYh1bJcSZWbPQ1iYkzMQsFRc84BNordW0w04NuERk5+qH4AyY3gGcdQKpcBUrj+xgOunw2pBJa9DN4MAWp8QCy+u kzziTVzy xr0PiVsUQBFNHxJD7pMY3ODsE+Q4lfO7FTq14e7DJVg0Dd+Taug2XKLy/8in1fcvoJiaNPHrMSR01aXCk8FzQPatwitiwb3YXdtfhbC8erDrFIRpysxF9RC3BCAzyhBDmrEYFTBKHyxZiHH4Ibj8Rnj2aY1zazA7xPfgDCjbYS24Cmv51YTVZrBvzrV0JMOVlfrOsoYuDqvkfWUZKgzibnx0Efm+a/5gcb3uzByGfGHoo9QVxBEIqYPgOk1GKjW2LWxvmBRYi9Yu6GLsEQai+uJRs7dQMsJg4VG3Bme6nn6/3poIogISHUc/V8CQ3kOWOuLzs3kUIt7vjytR+q37qlJbIZCFc7b32aYEBP/HYX23eOfB32CEcsA8P+2pYV5UB1t1NiGsq+yeEYCtLEqX0Wh5I1sn3EMHI6yItju3dfhToAG/xA432qZ1zDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 5:00=E2=80=AFAM Jiaqi Yan wro= te: > > Logs from soft_offline_page and soft_offline_in_use_page have > different formats than majority of the memory failure code: > > "Memory failure: 0x${pfn}: ${lower_case_message}" > > Convert them to the following format: > > "Soft offline: 0x${pfn}: ${lower_case_message}" > > No functional change in this commit. > > Acked-by: Miaohe Lin > Signed-off-by: Jiaqi Yan LGTM. Feel free to add: Reviewed-by: Lance Yang Thanks, Lance > --- > mm/memory-failure.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 2cf7acc286de..685ab9a77966 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2640,6 +2640,9 @@ int unpoison_memory(unsigned long pfn) > } > EXPORT_SYMBOL(unpoison_memory); > > +#undef pr_fmt > +#define pr_fmt(fmt) "Soft offline: " fmt > + > static bool mf_isolate_folio(struct folio *folio, struct list_head *page= list) > { > bool isolated =3D false; > @@ -2695,7 +2698,7 @@ static int soft_offline_in_use_page(struct page *pa= ge) > > if (!huge && folio_test_large(folio)) { > if (try_to_split_thp_page(page, true)) { > - pr_info("soft offline: %#lx: thp split failed\n",= pfn); > + pr_info("%#lx: thp split failed\n", pfn); > return -EBUSY; > } > folio =3D page_folio(page); > @@ -2707,7 +2710,7 @@ static int soft_offline_in_use_page(struct page *pa= ge) > if (PageHWPoison(page)) { > folio_unlock(folio); > folio_put(folio); > - pr_info("soft offline: %#lx page already poisoned\n", pfn= ); > + pr_info("%#lx: page already poisoned\n", pfn); > return 0; > } > > @@ -2720,7 +2723,7 @@ static int soft_offline_in_use_page(struct page *pa= ge) > folio_unlock(folio); > > if (ret) { > - pr_info("soft_offline: %#lx: invalidated\n", pfn); > + pr_info("%#lx: invalidated\n", pfn); > page_handle_poison(page, false, true); > return 0; > } > @@ -2737,13 +2740,13 @@ static int soft_offline_in_use_page(struct page *= page) > if (!list_empty(&pagelist)) > putback_movable_pages(&pagelist); > > - pr_info("soft offline: %#lx: %s migration failed = %ld, type %pGp\n", > + pr_info("%#lx: %s migration failed %ld, type %pGp= \n", > pfn, msg_page[huge], ret, &page->flags); > if (ret > 0) > ret =3D -EBUSY; > } > } else { > - pr_info("soft offline: %#lx: %s isolation failed, page co= unt %d, type %pGp\n", > + pr_info("%#lx: %s isolation failed, page count %d, type %= pGp\n", > pfn, msg_page[huge], page_count(page), &page->fla= gs); > ret =3D -EBUSY; > } > @@ -2795,7 +2798,7 @@ int soft_offline_page(unsigned long pfn, int flags) > mutex_lock(&mf_mutex); > > if (PageHWPoison(page)) { > - pr_info("%s: %#lx page already poisoned\n", __func__, pfn= ); > + pr_info("%#lx: page already poisoned\n", pfn); > put_ref_page(pfn, flags); > mutex_unlock(&mf_mutex); > return 0; > -- > 2.45.2.803.g4e1b14247a-goog >