From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800D1C10F1A for ; Tue, 7 May 2024 06:50:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3EB56B0083; Tue, 7 May 2024 02:50:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEE0F6B0087; Tue, 7 May 2024 02:50:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB5076B0088; Tue, 7 May 2024 02:50:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BDF696B0083 for ; Tue, 7 May 2024 02:50:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E8E980D08 for ; Tue, 7 May 2024 06:50:48 +0000 (UTC) X-FDA: 82090676976.06.93ADEAD Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf08.hostedemail.com (Postfix) with ESMTP id 9B0BD16000C for ; Tue, 7 May 2024 06:50:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OnpyIpdu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715064646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vtf9JTxvmEium7Z5IYrhPwaVkYIMsaQSn2TAuNeOINo=; b=wxOJGMWMuI72drJJVeRazQW0LN9pj+7hW7xkaBB+DLSchxb46ZqGNnEZeN5qkBHyHcpQM0 A5YNRDLPuWnVR+ZCr4K5zN2cnV2aLr8uIaNFWTuSQdDBGBeRPAr6wyaNPFTy8z4WY0Osct kCytU/e7+yNVofxWd0n7uSefI/vsJcg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715064646; a=rsa-sha256; cv=none; b=u7fT99WlTsoSj7DFYCmZDqnMYXHWxJHJOZBG7cKMUI4abYN0lHj02pv7NqsR4WiHvsVbS6 To0bOdYXas76dIb4PdMugq5k68DyP6f3RF9LyKa420itiNkLdzoY/+eORMt0cyY/VtxbIF P5obPjdPZmo9D2vbI6+f/uJgesbw0VY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OnpyIpdu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a599af16934so664482966b.1 for ; Mon, 06 May 2024 23:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715064645; x=1715669445; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vtf9JTxvmEium7Z5IYrhPwaVkYIMsaQSn2TAuNeOINo=; b=OnpyIpduVtvsygDE1N5PG4YKAbdcMWkpbsrFhvdoDfFrO+RAFX0PKIfHMGVKl5O6n7 3j/7fl4GyxrkJ+Wj5xVre8TyF7VOybJ2FIFf3JXn05n4Pk5xHyGncBaz23NOdLX9KqyJ F+wSykb9Hwzy25YK5jAlP/iHXqXuUUNPZD3GG8qS5z2qRE1LAvUGotQKKxiWijnFVibC 5j+TkRLQcaFc85wYKxrF7mpj8xmKd85DwHi7xxsavhO5Q7aCSCP4QGWaJFIrU5Zfvf2r gZ5Maob4sCoBJFoOlpE/VmuT2DdsftNkMeBJcQAuuXP09vssa2TcnJR+fY58GGv71pQs I44w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715064645; x=1715669445; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vtf9JTxvmEium7Z5IYrhPwaVkYIMsaQSn2TAuNeOINo=; b=KFxbzxCcLxtIx/9yuhoBKOuH1abVyIM44oMDBwAVs4sCWtnzIrLH5T5BZA4D0Y51yT vkUtIW7d436Z3KJpI8zFLhrYVt8S4sX8FzorYM7jSUX12x4ifYP/FgLzFLHdrx98tuOY IK8SNBJC3XWMhzPV6xQGOlwR1K7dwpDMpxbgM73syq613QDqFimzg+YwBpy85nq5glEK 0TVxC1PHItSmFW76hMT/o83Zj6/tWvctDw2/Q8HFJRnAUBxuu9MySK1nKzWo+xU4cw0+ ro6+gyu/0sKTb5oj1hglQFm3MDdNZpdyrLQEqhuyKE601Fas49+tpa+cFmPTc3xOupcm AKVA== X-Forwarded-Encrypted: i=1; AJvYcCU+gp/xKKrpOoZHHtpLBjlF+0KRrrCmyT9BWhdXoycHEWBHU/lXEPjvXtl40nFAbVjgMjD1dRO9M+RlAplRht5pQUk= X-Gm-Message-State: AOJu0YzPbWEWTzxlwDunOhFy1xTaZGw7gGoW6TGUUg83iewQSEvJN9OW +FKrTZ5zUzahcVWeQClYxWO9LZURzkLheTFHmgd2I8/p36p4z1BXXM0QP9AVsOP/VOaiJXwQnCT 73Lcxo0Kur+zlAxTC3BM7+czOuGl16u48/vY= X-Google-Smtp-Source: AGHT+IFdfdm61Vn8oi+xzryCzRzJSFLKb1UrL2QHh03A24gevJJW27V1tPShZQ9It2eEb4A0AnspboCZwuS1463YKFs= X-Received: by 2002:a50:a404:0:b0:570:1de9:4cd7 with SMTP id u4-20020a50a404000000b005701de94cd7mr8065600edb.15.1715064645064; Mon, 06 May 2024 23:50:45 -0700 (PDT) MIME-Version: 1.0 References: <20240506105447.1171-1-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Tue, 7 May 2024 14:50:33 +0800 Message-ID: Subject: Re: [PATCH 0/8] add mTHP support for anonymous shmem To: Baolin Wang Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9B0BD16000C X-Stat-Signature: b7kzp6wd689qz58s33yed51buztjj5ma X-Rspam-User: X-HE-Tag: 1715064646-271543 X-HE-Meta: U2FsdGVkX1/Y9ZtC8SaulnJZKulT4cli7GSRhYQrKKxkEII7Ru0CcXgfS06vCGc6l8v03e+M4UU8N7ZUmozuZi3G3xSdd9acLhBKhvKRO+sGSyJeUt5hMyPq7SeMeY7zcehHvYsE36LtdIxgQaErF6zINH94gUJHxEVlcQNlnzfsGsLDtK+QpHpLYsjabWxkpitIIFz7gr07qh9hn3CqvNmj4idSPY02QebW4Sb6ZJVH8rnU1rAoDErXYNOpw6K6GS4lMDkpyMVoWRQH5bisANfDW9N2Fp1aXY4CGX3G01uvw3ARrw+WtPHiiye0eF66VEaXrt9MpQgPLYHlaRbWuHE8RzUGkPXHBzewNBlDaFzbFkHR4r7xwI9Ne15Y3cCozVAYr6zo9TBcB3xvLXhVUp/DcmCuvhWlfa/GsmWgOE/qQNHLNIW1hccCHrZhZLRzkaNKS2PwIIlwbV4EZ4xLw7RWGksibkmBFkG+OyXIxwVF2rPQUprth7gxw5d/4hv4n5Q6z/YLY5uWj2qUvvBUuZzQeMmYBrbPd+eGNtAYyTbUWwft1cyBDya5zUE9dahVoZE+WUsh2rYUmFMv1+Rgd0W3BcJSYTO81nYV+zrYwvhTvPUdmaqZNCFfL7YMQhGZ+vQBeqBthLLRJjhufKVbKZI+reyKsSQgtcfNPth2vdLU1wz85eQR1YiV+4FXREwPishC8UHTUK/xxf35K/sg8/ImboPY0nq8fMNLfWZVx5ppQPwaLGJi3ofwRusbTjqJn3R3tjNLtI3ZUbjs0S6MN5HcZaRYMMMkZO9aBr4GHDwZ6hA+gtxL8RMD7gBnH340HAGYMtf3Cja5qGPFr8SeDHzAXL0MiVxo09arXMgZQBMAutj5O/vFJ5zFvxv3VPeOKAjtyrON84S99toS4SjGXknBtHaBoQivWt1lR01KfRmlTETEkgsJBxKhYseooNGzJjh1y/PUkSKF9+dNS/v 69fbNWpq /p/Lsly/ELXwUFBB5z3r4VMEY4pVjXbsVdjihmrllebAk1/9XsgPA+RxKaxop2Fuk2cTAXFxNeU4Fjl7Cxt2RUpHzAfM94MziB2/IJI07+pVTpUqVbs9fVzvNEYW/nwiUCGiIRAvImi85jvqHlhNUMoGzpKbBfDeSClnmNMhL9igI0zRYzSN+UMzR8+cCARfkkCfMESobJVSNzVIJEHkxGSMpUEUOoixwipKTo5I+uVbPN225Sn3lpUFnyNWc27/06QvhUap7u8ZlXKH6lW+QmN5zDFyxaTS03YCmkjn6SZM6n59Ddd8ez1FxY2tyHNr4q3e5Wzww7EO7/p8igrurED9N78rEVvbHyd7VmrNHMABPKJz1P8MGUBfbuCIr2HZrOVm9zs8RipevPVk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 7, 2024 at 9:47=E2=80=AFAM Baolin Wang wrote: > > Hi Lance, > > On 2024/5/6 18:54, Lance Yang wrote: > > Hey Baolin, > > > > I found a compilation issue that failed one[1] of my configurations > > after applying this series. The error message is as follows: > > > > mm/shmem.c: In function =E2=80=98shmem_get_unmapped_area=E2=80=99: > > ././include/linux/compiler_types.h:460:45: error: call to =E2=80=98__co= mpiletime_assert_481=E2=80=99 declared with attribute error: BUILD_BUG fail= ed > > _compiletime_assert(condition, msg, __compiletime_assert_, __C= OUNTER__) > > ^ > > ././include/linux/compiler_types.h:441:25: note: in definition of macro= =E2=80=98__compiletime_assert=E2=80=99 > > prefix ## suffix(); = \ > > ^~~~~~ > > ././include/linux/compiler_types.h:460:9: note: in expansion of macro = =E2=80=98_compiletime_assert=E2=80=99 > > _compiletime_assert(condition, msg, __compiletime_assert_, __C= OUNTER__) > > ^~~~~~~~~~~~~~~~~~~ > > ./include/linux/build_bug.h:39:37: note: in expansion of macro =E2=80= =98compiletime_assert=E2=80=99 > > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > > ^~~~~~~~~~~~~~~~~~ > > ./include/linux/build_bug.h:59:21: note: in expansion of macro =E2=80= =98BUILD_BUG_ON_MSG=E2=80=99 > > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > > ^~~~~~~~~~~~~~~~ > > ./include/linux/huge_mm.h:97:28: note: in expansion of macro =E2=80=98B= UILD_BUG=E2=80=99 > > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > > ^~~~~~~~~ > > ./include/linux/huge_mm.h:104:35: note: in expansion of macro =E2=80=98= HPAGE_PMD_SHIFT=E2=80=99 > > #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) > > ^~~~~~~~~~~~~~~ > > mm/shmem.c:2419:36: note: in expansion of macro =E2=80=98HPAGE_PMD_SIZE= =E2=80=99 > > unsigned long hpage_size =3D HPAGE_PMD_SIZE; > > ^~~~~~~~~~~~~~~ > > > > It seems like we need to handle the case where CONFIG_PGTABLE_HAS_HUGE_= LEAVES > > is undefined. > > > > [1] export ARCH=3Darm64 && make allnoconfig && make olddefconfig && mak= e -j$(nproc) > > Thanks for reporting. I can move the use of HPAGE_PMD_SIZE to after the > check for CONFIG_TRANSPARENT_HUGEPAGE, which can avoid the building error= : I confirmed that the issue I reported before has disappeared after applying this change. For the fix, Tested-by: Lance Yang Thanks, Lance > > diff --git a/mm/shmem.c b/mm/shmem.c > index 1af2f0aa384d..d603e36e0f4f 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2416,7 +2416,7 @@ unsigned long shmem_get_unmapped_area(struct file > *file, > unsigned long inflated_len; > unsigned long inflated_addr; > unsigned long inflated_offset; > - unsigned long hpage_size =3D HPAGE_PMD_SIZE; > + unsigned long hpage_size; > > if (len > TASK_SIZE) > return -ENOMEM; > @@ -2446,6 +2446,7 @@ unsigned long shmem_get_unmapped_area(struct file > *file, > if (uaddr =3D=3D addr) > return addr; > > + hpage_size =3D HPAGE_PMD_SIZE; > if (shmem_huge !=3D SHMEM_HUGE_FORCE) { > struct super_block *sb; > unsigned long __maybe_unused hpage_orders;