From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713C9C25B78 for ; Tue, 14 May 2024 07:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7BBE6B0159; Tue, 14 May 2024 03:46:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFDA76B015D; Tue, 14 May 2024 03:46:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC37F6B0155; Tue, 14 May 2024 03:46:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F04C6B0152 for ; Tue, 14 May 2024 03:46:59 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2AB491A0D7D for ; Tue, 14 May 2024 07:46:59 +0000 (UTC) X-FDA: 82116220158.25.6D282EA Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 548B51A0016 for ; Tue, 14 May 2024 07:46:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i7RsrSTx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715672817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QDDRioPzmPP6+LE9lNoP/oGDK/+i7IaW61Opfh8Z7TM=; b=Sp0VKlVlvbS+6ViWQftnJMUIkc298C3lSl0uqgEl+lA3o9brdhkcLjotCOffNp8bDy1GUf mJhkbB4NijkO6MfATtjccipWhFXkTBYOuu/blXmRMtn+QyP36ER8Pm8XZag+LwfN4a9klE GFjPMzg5zids391/X5kI8xvGtIJ9O/g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i7RsrSTx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715672817; a=rsa-sha256; cv=none; b=1CCkCNzinwP2jD7xXI5fcYci9EjLHmBVKRUz/xpm//vXn/Lq7LzpcAvzW+DXjCfSPfzeZH QGq8gTxjCzW2cfYLU2GsDcbQTHd3ibwULICor4iQinZ7PHzrmdnZ442ZPjkunC8V095zx1 RA4mEdt/csBVo7WZcxYzXUGXdn1M9F0= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a59ad344f7dso1068394666b.0 for ; Tue, 14 May 2024 00:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715672816; x=1716277616; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QDDRioPzmPP6+LE9lNoP/oGDK/+i7IaW61Opfh8Z7TM=; b=i7RsrSTxdV9CFT0sAhJXJa+luXklf3vklcuRX11vHRg0AlREY23gXU+ucoY8MWJpw1 aiI6M5MzVGqTRh7iMf63eq1NAdEcMcpazU7xj951faMXibyGdG+ckM3NKV4brjN3DywK xUNmNioIs8fgZe5d18B0uqygsBIJHR4JYyvTy9Bj/nM2N702G5BLbx9Xeq7Rx5pwhViH pyUegqdxh7EerOpTMwdL17ce1hqnR/ev/c7chJysmscHZwHUsn6AYGSrlw5TCORaT1UI XptFCyKxZtDXX6fiq54CiiYbCKUhxsegiohfGpzv5FY28+qKAbdpD1UhxwlpMce+4+Yw Pe7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715672816; x=1716277616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QDDRioPzmPP6+LE9lNoP/oGDK/+i7IaW61Opfh8Z7TM=; b=Bq3cSVXHQIxVa59ZTiczk5j5N47C88h09fJY+eu8qq5tJo5bOZABHwVO2qVhWY/YB8 /o8/gjsIqnCYV6D+MSuHp2yX0Ma8VZYGp4L7p50APXYVJLM+A0LZ4rkPF8ntqT0JKBWJ V8bkykl/IW9KV3FJ8RP6tekblgJm6NVQ/UNEApTaT2jpJ8QQusUKFPmJ4ly5mSX/ZtcP Jz3p0or6m0sSwlnrfEL75Ig6b+n7g+TXAxBcts7IXXS+nQxVB04KvUHFQjdRJGPKHzuy o2HdUIuHjQaYzMiRLvzpUSwHmLg93eGbJYJojJmLrwrJgpeRp2nZ1YYLiLGdnkiKn+1d vQZA== X-Forwarded-Encrypted: i=1; AJvYcCVbt+OdvT/jstXb6wYohjSSm24LqwvKSRFdaenxwoqF1JwhR+sQjylKEOfIo/FtY+vCPLj0W92CnloG82wgAbnVidk= X-Gm-Message-State: AOJu0YwL2na3N/hJc9VOtR9M5Tu/Qqj3pIRkSeEP00MN2rqtnK7CA+F1 bMenhWv/7u/EM465RHV/gXWuz34MvT6bavPE0XVD50iYVTk/UQI6rH+QrJi6DwLSl0Z4J43OB96 B+h7d5lesoc75S7v7zipGKH8w0Ls= X-Google-Smtp-Source: AGHT+IHucBQ7dc7PnYTMhlvRTAb71c+Utt2cAvwC/TxIIrr8TZCHbS3SmsoI/ipJJDw0jdBr0COkROaqJdC6raI/78o= X-Received: by 2002:a50:a417:0:b0:570:5b70:d76d with SMTP id 4fb4d7f45d1cf-5734d67aacamr8193173a12.28.1715672815530; Tue, 14 May 2024 00:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20240513074712.7608-1-ioworker0@gmail.com> <20240513074712.7608-4-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Tue, 14 May 2024 15:46:44 +0800 Message-ID: Subject: Re: [PATCH RESEND v5 3/4] mm/mlock: check for THP missing the mlock in try_to_unmap_one() To: Baolin Wang Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 548B51A0016 X-Stat-Signature: u5sc8ytnu1jkkg956ffjft8wmq9w4557 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715672817-482690 X-HE-Meta: U2FsdGVkX18BLQGBHGR/gOR6VFsMux/gnW3NhPA1F0cg0jp1+UDa9sAb+dU6K9aAIgjhoNUO9kw3frLRsh5uUvfTbrczUjX/KJ9RNki03xX62IqE0teWypAjdx3eohdHmSaZ3qCmTt0i8DtTHJgfxLNnArRhRsg607xsDHKKWCut3wnl+oHAczomdBA6A2A0ZNG1i1k4eEl+YKTF1oP4oDmzBp1XanECTMs3CI5e1x5hLq6RTLvYcTsEGGGVqLprnOcDfGjqDZDgX2urg3w4FRqhUaRgx/Z51HucuLazQk8o1Wt1EL2VvhWYV4vl2spo4wXY5bzqM/cx3T3DVFGYxPet7dUgF71va4Gq/hXSLQ7qvq3f1GYzSWX6cpvfSsGIVdjHtC4ytvG9MFjMKfMu1Rjz6+kwjdtGYTi/lm8Jr4gVWKR3+Rn2fsxgIja6ycwpF+c70hJ1VyuV29dRHMzQ2kQBv9en+uPtGYt+QGEXKnHZNXSDpP/vQODpL/kCoYmiZTEpqZOuUrTb7Qd86psM5ELaEyEz9FwUuQ345NWfONLLe3RfilzykQMvtkcIxqrI8Mxm8d0HcHIyimzyPQZWVQ0O7AYi3zlpaAtYQtWiFl3xW4X/bbR2SVEUSPKXkzAf1LMNUPTuP3elnpHsyQqa3psn7kWkogA7a5DSNvl6LgKh4V86Wwi3xI5HEfq2Jt1K6WclHtAvVqNI1mQI9Z3/adyXsyI6ECAbYMtPVhhpsqxaVZa+XrhiVxYLkEfNjh4BXBoJNVav6rmtJn+ipsNllhZJHOm2A3mJMw6uQUs/758grt3at95lMIshJTWAkOiZMZDJ839zhz23gdOBv+cn8eaUMDWj8dONE8S1PJzpatOQSxZfFoNVW5ghMMvSt06my7Cl8cJv5rrShm6KqZZmlYdx+0XxQ8zeXMIz0j59seU0Xh4+35KTUo/ONVH65LUDSSuL9ct05zAq5nIdAUY cyKuaGFu wnNJqrAeVi1AGeuBgvNKIYRy1zzipztOon7OarroIOHZDNL7lpVLI1A31S0qSFXUl2eYNEIpAxJuR8bbWEcJDq17gVYYgA2FK3mVr/mmiACAQvpzpJZYp/wjKcUZs0pCW9PR81culG3hcWWutPdAsYEW2dYks9RJP9AMz1GY4/UCwsh6mZXolTCj/h8UDT2EuyKVvAamEu6WN7nsHpRqyfLCSG6m8aUR+ilUyMK4QTYInOGUWCMVKbDV/ORJstFoxO2s6V1x1n+7AKwLAcot3TQTwkg25YmL82KHyLpxEfrCWZbJdVMvDeIJpVSYsf8cPK/wGfzNx2eGEwXlVY/vbCWwtAEj/FgXb1I4rx2o67ZRsSf9qRw4hlliWzoOuevty7+3tXNe0ujvJd1v+IwhLRJh4IOM/LK7tPG81ENV2AWkzrvYcYYXQchRvLiPZv/CPSOHn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 2:41=E2=80=AFPM Baolin Wang wrote: > > > > On 2024/5/13 15:47, Lance Yang wrote: > > The TTU_SPLIT_HUGE_PMD will no longer perform immediately, so we might > > encounter a PMD-mapped THP missing the mlock in the VM_LOCKED range > > during the pagewalk. It's likely necessary to mlock this THP to prevent > > it from being picked up during page reclaim. > > > > Suggested-by: Baolin Wang > > Signed-off-by: Lance Yang > > IMO, this patch should be merged into patch 2, otherwise patch 2 is > buggy. Quote the description in the 'submission patches.rst' document: > > "When dividing your change into a series of patches, take special care > to ensure that the kernel builds and runs properly after each patch in > the series. Developers using ``git bisect`` to track down a problem can > end up splitting your patch series at any point; they will not thank you > if you introduce bugs in the middle." Thanks for bringing this up! I completely agree that this patch should be merged into patch2. Thanks, Lance > > > --- > > mm/rmap.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/rmap.c b/mm/rmap.c > > index 4c4d14325f2e..08a93347f283 100644 > > --- a/mm/rmap.c > > +++ b/mm/rmap.c > > @@ -1671,7 +1671,8 @@ static bool try_to_unmap_one(struct folio *folio,= struct vm_area_struct *vma, > > if (!(flags & TTU_IGNORE_MLOCK) && > > (vma->vm_flags & VM_LOCKED)) { > > /* Restore the mlock which got missed */ > > - if (!folio_test_large(folio)) > > + if (!folio_test_large(folio) || > > + (!pvmw.pte && (flags & TTU_SPLIT_HUGE_PMD))) > > mlock_vma_folio(folio, vma); > > goto walk_done_err; > > }