From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F30C25B75 for ; Mon, 3 Jun 2024 15:08:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DFE56B0089; Mon, 3 Jun 2024 11:08:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 497D76B008C; Mon, 3 Jun 2024 11:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32F5E6B0092; Mon, 3 Jun 2024 11:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 124BC6B0089 for ; Mon, 3 Jun 2024 11:08:59 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D29B01A1126 for ; Mon, 3 Jun 2024 15:08:58 +0000 (UTC) X-FDA: 82189909956.12.8800488 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf27.hostedemail.com (Postfix) with ESMTP id F2C0840014 for ; Mon, 3 Jun 2024 15:08:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ibpO/a/p"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717427337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R6n52ORb0XfDC9vZKE5fhnlo8sj5tcBG5wByYNQUJIY=; b=wRVikZnhyqrDNNGwOIKP/SLv74hvFumJiy4yDpvmzbJRhJhyTMHOQtz7emcDdELoH+FFHW GUhHXIRi/b1E/blzVLr+sS/B5z/32ta966qPyTQhJeogNrlndGlXlr17VEH7FKfNtcwXPP UMHLzd6wMzIir7QdOTx41AJWNRtiX70= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717427337; a=rsa-sha256; cv=none; b=j3SY8tsolPpnepGF9RCDTmg87w7YYvMs8aAUbpOCBnDK9+B5JuuKappQ0nJQ4hVkDi3Nk8 CJCleCSGYwOCt1tZiScNRJZ3phmG55udQsd04/4bf33jXdw2ptYzy3J8CeQYcNdfWe/i0Z yt4hyjJpXfGzmfwvqtmF5lkAdaj9tm8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ibpO/a/p"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57a3d21299aso3363518a12.2 for ; Mon, 03 Jun 2024 08:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717427335; x=1718032135; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R6n52ORb0XfDC9vZKE5fhnlo8sj5tcBG5wByYNQUJIY=; b=ibpO/a/pwKpBvHihitlTQyBF2BZG7fvKqHHOKucA5Fr/r4fHNBhhBgn8ZDf9WJNTgd l0Ab39ODBWXcsxKJHVKEUmg/J77AbDUcv2AagpKUX0s9cnUFJjlETpd/XS5Oj2CQDxjF irRywHO07eWN2EVbPBImGsI8XkpGv2tmctItcyonUzS4yOvD8KasUasrfz3mYOLUlsZy 5qgt4cKWfb2gp44dT7xA4a4jhanPdZNdAR6XY+mPUoir8JYoANw1kG7pY4zQ4F64DTO+ ncPScCeuHATnVzcaxmJHMRYC2zWSToDYWg3+J+7BawawVWLr9FMXtQEBNhY84v0NamxB heag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717427335; x=1718032135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R6n52ORb0XfDC9vZKE5fhnlo8sj5tcBG5wByYNQUJIY=; b=MIbPZtOcXeyn4O07JNnWcorn6o9UGpXfL1AgJ3H/Djvy9aX6yfQsD3D+Ir7p+/XgBY 1II4hLOFgMrSgvNdoVnhNyZJVRd0Y/ZTE/nwqxKDYZaO+6sxRNpPAc4zsPLe8OX0bC6T 10zQs4tMFOUKcteYrD2FCO0S5Rk77wGQZqg2tj+5PA/p+c0pPZ5Wlnj5MsA2U68cNpW1 yuOouhAjPf5tKGNNWakncq+ofJ8SpI4xTEw4+Uxym57kGfmR4zyfb6U71WaLTU3e8zGI lnWhOrgrN1HKRD1loWomIoIO/bw0AFxqW5aHe6N6mZ9gQYX6HLDRXCBPqhC4+aQHyCTa Va6g== X-Forwarded-Encrypted: i=1; AJvYcCWf/4wR+87KQyA6udaNF0wWB0VTU4jykLmgl+LEzrcBRBzMdEe8JLCZwgsZyeQpMO9+k68DL1AAUsrVzV55LYDAMjE= X-Gm-Message-State: AOJu0Ywr2PJtzWGCAiwzfdra/2jcHkWaQZsOwbST/VqvWinbOtcdY4xY Bh5Vp1bhYPOh/f8mdYjH+/vCNPjK0APTdWvFHlwkH6P7DSa5+lZuSPv1Ppxqjbzfh9rcbUwBG51 +w5QnwLY5tqNzFbfPquL3E5ScrUs= X-Google-Smtp-Source: AGHT+IEh6yYoOWL9lLBs0PfAJHZqgmYwjPFL0nu0vGzq1MMSQvlyHB81YbmMy0KP1lJB/ckdNFeoF3doIoTY6bBmlZk= X-Received: by 2002:a50:99db:0:b0:579:c015:5377 with SMTP id 4fb4d7f45d1cf-57a363823c2mr5623222a12.8.1717427335184; Mon, 03 Jun 2024 08:08:55 -0700 (PDT) MIME-Version: 1.0 References: <20240603140745.83880-1-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Mon, 3 Jun 2024 23:08:42 +0800 Message-ID: Subject: Re: [PATCH v2 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch() To: David Hildenbrand Cc: Matthew Wilcox , akpm@linux-foundation.org, ryan.roberts@arm.com, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, fengwei.yin@intel.com, ying.huang@intel.com, libang.li@antgroup.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: tc8wqpd4f8rsnz6twstqsw5p3i1du8mt X-Rspamd-Queue-Id: F2C0840014 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717427336-720862 X-HE-Meta: U2FsdGVkX186H4zxlng+lT7d1wjBwlW8WkrCp0+okwpXTsWDM4S7bmyZcrUF7DD22FzvDkW/1GnRdgzCrq53rdcwOS3iDcSB4KHnEt64QIKtfZZlzbEaTRkWr7vifPObLOM4i5kXMUIN831uX3I3gyxkHZpaHb4Z2rbwHDjFXiB4RPc3FA0t2TLx2SC/9cgHOX/WxMrFhtx9+V8imx3Abh0CJWXHjGY5qu7nSUK/nb7DOpsGKVC9aT+JP/jzh0+kTPEEslcVNViOde4LtLILlMqqyfIFF9UbUDAsc3CtSVAE1jrHA4OxlY5CXsiyFR9CpYIyh7L/5uPl9gmpZdBLMRgiEVCbF0L+zVGrUgpXu8XmR5hwEcn1cYU4YoAFFD3qQP6KshY60g7FySVzJqr5WHEa9Q1PNY63ZcSXqmN5aBwEpm/SI/fbU0TxikLPSAo9u/bWj2RQt5hv5T6B77us9hfK002VFet5Qx7EMULmIfmnrUZbazjko86RypTxX2cYBsJ+dIBQYh+mB0WlYPe6o8bKqd3sQS4GxmZXQX0raaDAPOsz53rz5XTsv3+OoYpeBc80DWD1COIoZNJkc45AO4fbsNwmUn0juqfGMdL+W7l0dNp7Ttq/Lt3kCVVJumtIW2x83BTb4QVgk1hAYb9QR8UoHLDEhm2U0+fHO7x5KCC6n9udL5OKmpoxGoXicam5maUWuWu99EKS1klIhaZ34KjUd1l3O4PcfR0rH8PHT0btT4WbrCLb58h0HaNcrrNpDz3yUFIOPY6nE0IZNpCY8mSyLmDgDYkhNegQ0anHf+cb9FI1h1o3jVCvdUuEPYEdVajVoJALkPK7LG85+ISbJic6X5SN4gQOdy3kZXubAuxxI/MRMUHRZ/V8idkm7cG9qO7s2GipBqoPPY3pCQA0BmeD+p9dDZiS114tjXsIeJDb2qS+Pk/R4IiCHV6AqTJHuLxW/B0xjnai3u2i+/3 6FYgTM8z c25AVYg0SLFY7ZaIhOI0JID98aQgTfuPjxpVLSZZ/7NDSJrvTHiW5K3XvpaJJPgY3k6B95OTS1L+Xj/tQDap2+e8dsyCzyJhe1mSNHzKngZKsp/X7iOefNTAojPHuavK07Uj71L72IaTUqwrnlmAsJlhtsjxwdaELmBa6/vHtm95malXSuWvaKddPvWNWKNVh0mljvHIm8+udp5qlQoRTNE4gS6j/QuMRhmPOmBkrnhGlsFI1aUShzf8NS3UrANnTnSPNwd+TWX1ABGym0uQLPh4oYV0Zc2YL05jl+B83+fFU8R+p+lBludu0pPDy1ody6RMfCLKsdSxkdUMO7qEi+sUj9oHujLizPIzpT3LTJExNAjkhdN+9ycLrj/QB/dLfQuFcVsAEi/vMopFopOVea98OS7GUsFJphkeDJszL9Wla/JU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 3, 2024 at 10:56=E2=80=AFPM David Hildenbrand wrote: > > On 03.06.24 16:43, Matthew Wilcox wrote: > > On Mon, Jun 03, 2024 at 10:07:45PM +0800, Lance Yang wrote: > >> +++ b/mm/mlock.c > >> @@ -307,26 +307,15 @@ void munlock_folio(struct folio *folio) > >> static inline unsigned int folio_mlock_step(struct folio *folio, > >> pte_t *pte, unsigned long addr, unsigned long end) > >> { > >> - unsigned int count, i, nr =3D folio_nr_pages(folio); > >> - unsigned long pfn =3D folio_pfn(folio); > >> + const fpb_t fpb_flags =3D FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRT= Y; > >> + unsigned int count =3D (end - addr) >> PAGE_SHIFT; > > > > This is a pre-existing bug, but ... what happens if you're on a 64-bit > > system and you mlock() a range that is exactly 2^44 bytes? Seems to me > > that count becomes 0. Why not use an unsigned long here and avoid the > > problem entirely? > > > > folio_pte_batch() also needs to take an unsigned long max_nr in that > > case, because you aren't restricting it to folio_nr_pages(). > > Yeah, likely we should also take a look at other folio_pte_batch() users > like copy_present_ptes() that pass the count as an int. Nothing should > really be broken, but we might not batch as much as we could, which is > unfortunate. Could I change folio_pte_batch() to take an unsigned long max_nr? Thanks, Lance > > -- > Cheers, > > David / dhildenb >