From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E869C02181 for ; Tue, 21 Jan 2025 02:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 197796B007B; Mon, 20 Jan 2025 21:29:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 147FF6B0082; Mon, 20 Jan 2025 21:29:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00ED66B0083; Mon, 20 Jan 2025 21:29:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D79096B007B for ; Mon, 20 Jan 2025 21:29:14 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7E3BAAF270 for ; Tue, 21 Jan 2025 02:29:14 +0000 (UTC) X-FDA: 83029877028.24.9F9FCE5 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 9834B1C000A for ; Tue, 21 Jan 2025 02:29:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=My95CPIY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737426552; a=rsa-sha256; cv=none; b=hu6GY/dmvH/2dW2xa12SLyfm0K55oaZiuYjVmnwgvs9mnFV9lV9N/iQEEt8thLHgUGY7iC RHyNTj23nFmp4U7V9KMp5yUp/FzP5uZD04nFPlS5uvmCBjWfW6do9ATV5nnqFA8f7J9mkd zpQhumfuZyWo/y0GwMBQKIzYedCytFs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=My95CPIY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737426552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/GcS3I6rjSacdJ6yhgg9vOSSQzP6C+FAe8I8LIf9h4U=; b=1Zx5PxnNgykC5d6KTCuY3lFcnaTzzZFobe1n8btSP2BRXlgc3dI7ERwnmKUvvW7jKpxA45 YWYS65j/5CqgtSYW3/sKrvIWWMUuIg5I5JkaUEvsL+PJCOXYBz77aeFRfExwuIqSFT2n+D CeSr2gHgH0RamtoymGaex8dk8PwwrGo= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aaec111762bso969521466b.2 for ; Mon, 20 Jan 2025 18:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737426551; x=1738031351; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/GcS3I6rjSacdJ6yhgg9vOSSQzP6C+FAe8I8LIf9h4U=; b=My95CPIY/XfYM7aB0K15JxA4Odbp/BJjLkOO7/wMaxl1b76k1MQ7RoX3DuH9v63P+a wKKcImjAjnCEUkjOhd2K6Wa4HOgpR1nXJ2Wouwh3caPZkdLUb1DsBaEDwaZss6N05uJm 6g5oU94Uyng+LbkI9ExHUp2feZetEzIZRdBnnsTk4YAxvLgAmuDTcEO7axb+YtWrWmcH xUUGKbRSO9XO3MDXyO0VsM6ut3vQ2Zhx/Ok2B0QQpwwbnMfi1VlQPZM0GvuqONjUPxm+ 6BerNZVZw5h0us07JZoJbPmoOUin0/1D7TSODbTkph5gLhbAfqLKoVSlD4Aws/AF4PGQ 4fCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737426551; x=1738031351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/GcS3I6rjSacdJ6yhgg9vOSSQzP6C+FAe8I8LIf9h4U=; b=Epx0nlw36bOLMZoK5ESkd0eKyogD6jLa3uS975t2X2Vf1hdhwaXtlf4BQoGKRPloR2 4Gmbuz86+MHpC2B9S+SItypCjhfGFOdOJtrf2wCbSJPh1rx+g8eLNzMlJ4yshJ8F3FzF AkQX0XagqJE5ewEyVWnhDIBpKvp4dVCF5GzcQS19F7s2YXlH7YZ8T1zBcf9MrR9HM8QP cbpuQK2i/JaBk5w3kAGb6fQM4lblWkPdHIp1hYud8u+HAjXoL+hM8WdQEgxLvz1cMzTU Byq3gX36d3+xbaDBUFEvkccBKz4mHFyk5Ja4V0eqao/D+7qNAtLBn64MHSNGBVH2M8Fn Zi5w== X-Forwarded-Encrypted: i=1; AJvYcCXsneQelu9UnfYceMdLZay8DQ6VdjdMQJdMNwC1Ob/+zCEf5QzunpbyV4zKfjbvsdx32bKcaocRyw==@kvack.org X-Gm-Message-State: AOJu0YwkWEf2rall+yCFrWs/+A25TnSbw8u/NilHsnVIYR0k+IB3IoIY F6rIt/mdbtJFVjp4qcje8ylOOqbt4oE69Kj4NGjduK1KR7d0QWx3Us5MA1Jqzs1WpF1Ms2dmMAM wZQdaOOg8nrDmSGzTvbKDfTe/was= X-Gm-Gg: ASbGnct983QVyyhsRlw+t2SgfiqGQu629/DwqsV+SINnrAjKvr/iRWHCQHVUGnA3Ae1 EaEuOCc6/dQC6hgC/BB/AsO0E7u4Q0+F/WuIDDMfyhgohC5T96Ag= X-Google-Smtp-Source: AGHT+IHEZ7M/R3ZFk1FB4y2z9G4Vk9u2cBa4LRd6K5EkG1AnEtLOuUBkp2uxye2clyngdz261mrSau3CFmV7pWQ9GFk= X-Received: by 2002:a17:907:6eac:b0:ab3:3282:25e3 with SMTP id a640c23a62f3a-ab38b0b9344mr1294059466b.7.1737426550752; Mon, 20 Jan 2025 18:29:10 -0800 (PST) MIME-Version: 1.0 References: <20250120013038.6657-1-ioworker0@gmail.com> <04d81e18-c206-40f3-b469-5ea588d4bf8e@lucifer.local> <1cbd3b3d-48b7-42b0-88e1-a9316e4acc53@redhat.com> In-Reply-To: <1cbd3b3d-48b7-42b0-88e1-a9316e4acc53@redhat.com> From: Lance Yang Date: Tue, 21 Jan 2025 10:28:34 +0800 X-Gm-Features: AbW1kvYktjKuZkkhaLu4x5UhLX9PD8y-P49dPIl7sl3BD-KKOXryd7oBvxLdw34 Message-ID: Subject: Re: [RFC 1/1] mm/madvise: fail MADV_PAGEOUT on VM_DROPPABLE VMA To: David Hildenbrand Cc: Lorenzo Stoakes , akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9834B1C000A X-Stat-Signature: yq33qqdyc3ct1d84p3uz1md49qp3hmo3 X-HE-Tag: 1737426552-272725 X-HE-Meta: U2FsdGVkX1/K9vh/Bmu5mOG42Z8USLdCrOB/i+ky9v48/P9LlK+pLLN82hGcvFBnvXxzaPI4n0DejOxnHg6WD1Lw2FRBQSZqHfQ9TaUD7WSi2phD6yTGSbB79/Qkhoj7Q0zeVbJZAwzrS8fxThv+dXtguy+xTwuY1zaMQxmHnso1ZRNE4lrfD/aOrTPUmkmfc96VTDAmmQXIT5vUNHf6t7NmbZuaUjQSq4kbX/AwV+C1ld6tz8/X34BYujMyJQ/3/yZN8bt/dfswkJCGNLCeC8DYunnMPT5Rbs4MsL/bSPLFIIPHoosFmqPIa7i2QIT1vGKYaaWwGl68DICZxn3isKOJviHoRNSsBiA+0+9k+LTpzP2ZIDszRjxk2rzGyN7zPcanhx+WHZISiLyEwf0njpJEV5lLugD5eV/ggiepQaQUwW5mio4+e25k2iNv2AXHR0meP9BnOnGZQ1l70pBCl2yLOferPiPYTlcdx6XDVEojek9HeYt8Om8RnF3Yz/PG+yuILGgOpj9dtHVS0r1HvSndv0c5QbiD6ErYazC1G00fqyRnXE9lpQsGLuWPYgDCOYDCwvxZkCex3lMtgTRUeJVm1sccRcEY+jpqJqyLeCQ85KyEdgu6rQNIkz6R6f1mDnaxJYuVKx5yULh6WGe7N6owcFjpQ3NrlXFSJb6hHaeLqbQAA2UTAakziCqw+F2huLlwx9beVh6NcoeduxJBBgF5zXDJ+AEto284kJX3JQWjM3UU8dkkL/2eI3TacTEVY4GnLXoZtT6xbJVtEe+rd2O0CUqo2VqzM2qlhnp8tHInHWZBdHtW816GaSoKVpdliwtABPUE+opTKu418/aBsj3Gqy1PXxfXCr3Pnm2VF7JA/Vqd/zsJPtaJIUZ9x8R/lWqtw+esC3IuiwRFe8TUH/WPLj1f+Ukr0m1kQkJn/mpJvA11uExwvb4q7MXsG0S8pQFGR3ixJcITEX3EMYG LXRnIdAJ TdkcljBv8jn6+W0WLn8ZBu06AWGY/LLKZdF8TzOBMzctQCOu9AquB8vYUgC3j80qKji4Xu/BmPWvs0AqN/G5XJfuS4EPO0mNiR7KcZwzT4zQ1mC8Op22ZnmX//iq0h56XtIMVzQE0p29hBmZi6bp1WCh0vMJSAhUmUKplpul2HbwZIs2ysv9p5cw2O274vlbewL+7bKZ9FMxnV2Zmw6erydstx/EoIpxKXkc24m4toARRzMRR9ubAaLthIQpkwhE+1NcxEIUymP5yWtdZhTJgter5ik0CxoKuYVPznntFPmlG56/X+jtN93gFjapSGo5O/M0o9w4aH8SRyqhxsX0M6KX+YtwjyVRZmLe8vHF/dagCq8q8j5Ut9rJuroQ21QkYXD/wCf4viLnf02Gc+XQtrq6JM0u5V9Te2l7P X-Bogosity: Ham, tests=bogofilter, spamicity=0.335442, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 20, 2025 at 9:57=E2=80=AFPM David Hildenbrand wrote: > > On 20.01.25 14:47, Lance Yang wrote: > > Hi Barry, David and Lorenzo, > > > > Thanks a lot for taking time to review! > > > > On Mon, Jan 20, 2025 at 6:45=E2=80=AFPM Lorenzo Stoakes > > wrote: > >> > >> Sorry but NACK again on this :( > >> > >> On Mon, Jan 20, 2025 at 09:30:38AM +0800, Lance Yang wrote: > >>> MADV_PAGEOUT should fail on VMAs with the VM_DROPPABLE flag. While > >>> MADV_PAGEOUT is intended to move anonymous pages to swap, VM_DROPPABL= E > >>> should not be swapped out. > >>> > >>> There is an issue where using MADV_PAGEOUT on a VMA with the VM_DROPP= ABLE > >>> flag behaves like MADV_DONTNEED, causing the pages to be dropped. Thi= s > >>> could break the semantics of MADV_PAGEOUT, IMO. > >>> > >>> So, let's add a check to detect the VM_DROPPABLE flag before doing > >>> MADV_PAGEOUT and returns -EINVAL. > >> > >> No, let's not. > > > > I think I completely got it wrong. Learning so much from your patient r= esponses! > > Maybe you can make the documentation (man pages?) clearer in that > regard? Thanks! Of course, I will give it a try ASAP ;) Thanks for your suggestion! Lance > > -- > Cheers, > > David / dhildenb >