From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F230C4345F for ; Thu, 25 Apr 2024 05:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4BF06B0085; Thu, 25 Apr 2024 01:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFC576B0087; Thu, 25 Apr 2024 01:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC4F56B0088; Thu, 25 Apr 2024 01:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D53D6B0085 for ; Thu, 25 Apr 2024 01:14:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1C72B8117E for ; Thu, 25 Apr 2024 05:14:02 +0000 (UTC) X-FDA: 82046887524.21.29C184C Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 4E6FAC000C for ; Thu, 25 Apr 2024 05:13:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cf+Gbdjl; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714022039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zMsvfQXS9e2cwUupmSavWVeAMqTjyBi4FVMWejO9Cz0=; b=usFb8dozSgqa/36iMXvp6RyZI7leWtEen5Qhb4TLFFD+E0kj6Rgw2L65mi/CRUwZYWK5Ra c5w5lIwdgVy8ITZ3gFqwH9gZVzZEMF8Qd865jU+f+uInkY0FT8NwmGkIMg4Smln4ZCGkZ6 rqyeOxOnnQ5xaZPpDwmfVI0GEi8PnPA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cf+Gbdjl; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714022039; a=rsa-sha256; cv=none; b=FdDgh3XNauUE43M26HMo05paXz9bQ+lzDYDZr8RdG+hnLxIRjWvJefjV4pz1BUqC6UZNpb vs+oURZCZQjroP7qxSakOLisBU9FOvZJ2LaCNn8ND59W9VyWHBt4vTdYnlJUFLS77NMXJf svcbbOHVNUTWUPKaNLs7U1xPV8YyDbk= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so587881a12.3 for ; Wed, 24 Apr 2024 22:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714022038; x=1714626838; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zMsvfQXS9e2cwUupmSavWVeAMqTjyBi4FVMWejO9Cz0=; b=Cf+Gbdjl+TT6+f6xdQoQcFJf0ofMNq9A64H/wrugsprTDUrNjfmHq/pogxS1tA/P6o nEmRJ8KAKU7NzWNcolDC05Ko8gcL3lN3NWFgW1HADw/VrQMiuq276JV0SYXi2W3ZYxhE aJq3TY+8Mp/prSazfHQyOAfHuCj23EYXh5kVhRDP5oaakDkbP9HvU760mqD/xkZdrC2h oWK4josHM+TeJkV1VWZ4MkIFkck3GgJ4xm/dNRpvrSvQCGgdpbd9A04jVqIRatU+tLtJ GQFkGP+v+aVE7Yta06Qyuu66RErog82K9eQPpRn/89JHJE885Z4yBEjuIWdf57sK41oE 159w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714022038; x=1714626838; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zMsvfQXS9e2cwUupmSavWVeAMqTjyBi4FVMWejO9Cz0=; b=f0zGmB6YLDRlFT+dMT5RtqLwBgEknaXuSWcAJLlj8Bh4r5TG9HGDMqAfOoQGYwfBHe 2QBsf/HBa7cKrfFnLsC11RkRWiEpade8qHoSlXUB2dkK90dm4F86xrACe4MTQ5/UzG+U 9UJL+gnyyFuFiWTWfRMKXyQa+hVcJeRLNSm+xMISM+X16TtyD6Vl6zDBbxCrkYr3/fRX +0p9lsCTgE9bvxN8CTCGDpTCHps0g9JzygNEeTMpe+9a+KZQlB1ALKVZC5/sPyKjfXjm N9gPzs+TKW5Fye7QmQzVuIsZpIyH2jcyvCgtCAyg66dgfwMdTZTiCMkEXhQ4vdkSbwwE Fd4Q== X-Forwarded-Encrypted: i=1; AJvYcCWoffYdJJufrLS0RHCZ3+lrhJz+8tLomIBD+uEIkO7/43Qk04VGQ99yr99L8rbGr9OWJbESFC0HIyPKo+f479VJsss= X-Gm-Message-State: AOJu0Yy7rlJ0nnGX3lIUHLd5/jkmTbWc4WMSZGm1mDYctJOhVGrYIQ8c CtYS2FswbAym+7FT7jlh7Lp5NRCGCgoQnEUSR9oK4AbS31S+M1mzxHKiGpOABlZtkSODi21ENVJ HdedQFyIGuK9xkhP4lltgpoWAsZs= X-Google-Smtp-Source: AGHT+IHp9Wwgtcn/BAPagOWZJypIB6On/thivfMjn03wEozTaGluYrlaW0ODr8J/d9SV1L5TtrwdJxDtaE7pDS1r7bo= X-Received: by 2002:a05:6402:35cb:b0:570:5b98:dfda with SMTP id z11-20020a05640235cb00b005705b98dfdamr3302150edc.23.1714022037500; Wed, 24 Apr 2024 22:13:57 -0700 (PDT) MIME-Version: 1.0 References: <20240424135148.30422-1-ioworker0@gmail.com> <20240424135148.30422-2-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 25 Apr 2024 13:13:46 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: add per-order mTHP split counters To: Yang Shi Cc: Zi Yan , akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, david@redhat.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: aa734bp5ty9c7tip35d8obr66r13rjgg X-Rspamd-Queue-Id: 4E6FAC000C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714022039-555853 X-HE-Meta: U2FsdGVkX19qvUDmBw4u4edVpJFzu7NZxmS+0fvjvcIPcX9oNy4g5pyW46cIGYUewxux+KjMiZ4V1n35U68pmYw6ReaVMbYPTjI0zfpjtzPJjwGbL0cmPWgHBwjrwOvksWrhR/03K4yIZUkXRxhnx/6NAmTuCbi5Fo5m1phCxfHUPUmuvl2S1aoB+vUQ57Ha1g08PPeTIpXFpXs4il4rN+laDyg2Mn/mQAoljdMuaOB0zfNpvr6ftyZfLNURshmWGFPPzWnbZtF3NXPyqDPUAYTdZrLYPelie2GlAJu773Wl7ei4Sg2QqLxR92iC2ku2vqrbhpXrCJox/iS2jFfZJIM8KuW0NryX5XoiV7tlriR1yUob2qsnF6jsQrLTKoPH1C3378aUeNSEfwZP1Ph+xMJ8MHWSJz3XM0fGQH7ZRDxnRJ4OdUJz5rsYgc+/F2dwoLiiG8LEMlKFSIklGisUy1oolR0IquHJ+ucj24fe6GSg1ooiXb4dVVYfLCWzFI8mXEO7L9XzlgPHg2xxAZnxm7hTpXJh28lhGQyAyb3RJHj5oD+zuY1OHOR+7+oICUKcJGhFs48JzuwspiDbMkglZm2rwxsQMogUX7PCKOIsvzyP/PY1xaug49pTQPk/Mu6vY6LNOsED/QbpqJQb86ZMNjKZtUP29HntOuNqnErbwmNEYAXXGLftW2OFPoidAMwZBF0EFduozH1/kedDi2r8T3YGGanmpFqE/KH3mRRO1ktW2JuKWWE+S1WzNJYtwpMTCWgAmUgqJcfKxBxbuSgFQKGVaNO8pC34KTEuUuiBjTf5H6Z1fZJMXWjy2nxWGT5/vMDrwYuLQzyKe7j1da/1mgkLqeGWoGd+zVKAL13O97u2OSVZ0aauFbmE1yuotVMQ2RTUOOjmmxgHQKYvF+vTtQEFjwdSQqyqAb/qO9k6zVBgm/ixaa7iNjJBwSJbUsFc7pKksh1fykI6BZPDsSW JwjV011g dPq3u3nE2lIEtWJWpcE9aMpPgD5aMgw+u73s2pCClIKHIOGmvjKfKrjDBHht9div7Bt1swUbYPfbcn7yUnG8wlM2XXFWVP0NRNtQp5gu6DgHxDix/r/cB979NKdJcDW+5UU1pdf6UAuNucxsdSg0pyzG5lTJmJ/SCEkqAeOQ1zeLL8osml5BpILypWLYYTz519p/C/fG1RnFloytTr171+etAI+ENfdvIATiceS3RrdLaG5UI9uJ+5OFlDUxj90ebq5pQMIvHbRWh+DE9L3Hc9fzPh4yuXJefI9kVncCny2a5NwH5Oh9Vy5fkRNsPOjvmxdIA5DC9lze/NSUrm+nl6XEcttByLrOa7JrpUkyjKAuPFAgpky2e1fdgizs+Tr9kynnhpK02Pr5LWos5GkIAP6Ln+eXE3oSmmFtdBn7tHRN+HZaUyZv9Wyb32XbmfRzh7lZvb7bndd6qAwSpse2BwoXlWP60DRUHraSqYKVYeL9vv8dU+CqIjxcsEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Yang, Thanks for taking time to review! On Thu, Apr 25, 2024 at 3:44=E2=80=AFAM Yang Shi wrot= e: > > On Wed, Apr 24, 2024 at 6:53=E2=80=AFAM Lance Yang = wrote: > > > > At present, the split counters in THP statistics no longer include > > PTE-mapped mTHP. Therefore, this commit introduces per-order mTHP split > > counters to monitor the frequency of mTHP splits. This will assist > > developers in better analyzing and optimizing system performance. > > > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > > split_page > > split_page_failed > > deferred_split_page > > The deferred_split_page counter may easily go insane with the fix from > https://lore.kernel.org/linux-mm/20240411153232.169560-1-zi.yan@sent.com/ > > Zi Yan, > > Will you submit v2 for this patch soon? Thanks for bringing this to my attention! I'll follow Zi Yan's patch, then submit the next version. Thanks, Lance > > > > > > Signed-off-by: Lance Yang > > --- > > include/linux/huge_mm.h | 3 +++ > > mm/huge_memory.c | 14 ++++++++++++-- > > 2 files changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index 56c7ea73090b..7b9c6590e1f7 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -272,6 +272,9 @@ enum mthp_stat_item { > > MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, > > MTHP_STAT_ANON_SWPOUT, > > MTHP_STAT_ANON_SWPOUT_FALLBACK, > > + MTHP_STAT_SPLIT_PAGE, > > + MTHP_STAT_SPLIT_PAGE_FAILED, > > + MTHP_STAT_DEFERRED_SPLIT_PAGE, > > __MTHP_STAT_COUNT > > }; > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 055df5aac7c3..52db888e47a6 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -557,6 +557,9 @@ DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_STA= T_ANON_FAULT_FALLBACK); > > DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAULT= _FALLBACK_CHARGE); > > DEFINE_MTHP_STAT_ATTR(anon_swpout, MTHP_STAT_ANON_SWPOUT); > > DEFINE_MTHP_STAT_ATTR(anon_swpout_fallback, MTHP_STAT_ANON_SWPOUT_FALL= BACK); > > +DEFINE_MTHP_STAT_ATTR(split_page, MTHP_STAT_SPLIT_PAGE); > > +DEFINE_MTHP_STAT_ATTR(split_page_failed, MTHP_STAT_SPLIT_PAGE_FAILED); > > +DEFINE_MTHP_STAT_ATTR(deferred_split_page, MTHP_STAT_DEFERRED_SPLIT_PA= GE); > > > > static struct attribute *stats_attrs[] =3D { > > &anon_fault_alloc_attr.attr, > > @@ -564,6 +567,9 @@ static struct attribute *stats_attrs[] =3D { > > &anon_fault_fallback_charge_attr.attr, > > &anon_swpout_attr.attr, > > &anon_swpout_fallback_attr.attr, > > + &split_page_attr.attr, > > + &split_page_failed_attr.attr, > > + &deferred_split_page_attr.attr, > > NULL, > > }; > > > > @@ -3083,7 +3089,7 @@ int split_huge_page_to_list_to_order(struct page = *page, struct list_head *list, > > XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new= _order); > > struct anon_vma *anon_vma =3D NULL; > > struct address_space *mapping =3D NULL; > > - bool is_thp =3D folio_test_pmd_mappable(folio); > > + int order =3D folio_order(folio); > > int extra_pins, ret; > > pgoff_t end; > > bool is_hzp; > > @@ -3262,8 +3268,10 @@ int split_huge_page_to_list_to_order(struct page= *page, struct list_head *list, > > i_mmap_unlock_read(mapping); > > out: > > xas_destroy(&xas); > > - if (is_thp) > > + if (order >=3D HPAGE_PMD_ORDER) > > count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_F= AILED); > > + count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT_PAGE : > > + MTHP_STAT_SPLIT_PAGE_FAILED); > > return ret; > > } > > > > @@ -3327,6 +3335,8 @@ void deferred_split_folio(struct folio *folio) > > if (list_empty(&folio->_deferred_list)) { > > if (folio_test_pmd_mappable(folio)) > > count_vm_event(THP_DEFERRED_SPLIT_PAGE); > > + count_mthp_stat(folio_order(folio), > > + MTHP_STAT_DEFERRED_SPLIT_PAGE); > > list_add_tail(&folio->_deferred_list, &ds_queue->split_= queue); > > ds_queue->split_queue_len++; > > #ifdef CONFIG_MEMCG > > -- > > 2.33.1 > > > >