From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5017C10F1A for ; Tue, 7 May 2024 14:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670B46B008C; Tue, 7 May 2024 10:53:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6223A6B0093; Tue, 7 May 2024 10:53:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E8A56B0095; Tue, 7 May 2024 10:53:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F9CF6B008C for ; Tue, 7 May 2024 10:53:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 96EB580B88 for ; Tue, 7 May 2024 14:53:58 +0000 (UTC) X-FDA: 82091894556.18.CC4105B Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf25.hostedemail.com (Postfix) with ESMTP id A8C75A000C for ; Tue, 7 May 2024 14:53:56 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dYcIV70G; spf=pass (imf25.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715093636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s8YKg7NkiQQzPDt2U04+751t+jIfci6F7qG1eD549Yk=; b=4eUDCBvX507lOzC4Z3ywSNf6vvtiCkAVM3i7XZW0VCOpBksM1XTbjL/iwPnIKAjCZegEzw /tFplMeGh2KbiCV4gdII82gfMzJ676dMf6e0iYpPDA3LjYKT4wBESIr9xkgLKzUOgeqSyl PNzCedqbDqIMPhvzWx7QFT4+fitSKyw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dYcIV70G; spf=pass (imf25.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715093636; a=rsa-sha256; cv=none; b=R2YcUSkyTZpG1jyv1d+cYPxwGQtGQht9hbiLbEc7EWR8oDyQ3gcDx1tafiRb8LxUMyr7q7 pZtaceS45K9rKFzT6ZhgFutCqjdxCWN7HxiqXs7dSftjzQlrkh68q9/S2qP3wRyPatNqyM /8yJb1HeFQYcfZWbffMgClUYYNTblbE= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a59a387fbc9so807654766b.1 for ; Tue, 07 May 2024 07:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715093635; x=1715698435; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s8YKg7NkiQQzPDt2U04+751t+jIfci6F7qG1eD549Yk=; b=dYcIV70GTjwrMzZAbq6DENROqzZFVWydksSvYnSICoiRurzfGJCWUP2Gn9bl4dod8z GYld6HQsYe3+gm3a001iw78elyk9jMlqxv2BoL8q5aFc51+454xwRkwD16GhIdZhXBJv UQq6tGA3jUFdROoanxQeoIO+PLYnl+aHECTnm5rDrzhZYsecK8RkxnjpNqM6ReXvioZW jdGN7I0peqjL67v0VdBIQYY5GnxEe7Nxmv0AUid8WD88ZP6LQmDogrWgupzrHYdpD/nE 5IuioNUm8FgEi/oJ7xaQ4o7UqABJXFyDWuPOmY9MDgDtw+LV8ZqN+k0IPkOPaA2AJTam mv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715093635; x=1715698435; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s8YKg7NkiQQzPDt2U04+751t+jIfci6F7qG1eD549Yk=; b=uJ5KKe5xWXl9as8SKafQ9jcQRPJphusa8vo7gss7s8l5OceUzFPf2bax0j43ECwAmL iPbSVJFWf1PaNZuAyJWZePNS7SbES4PpvJgVwkgs6skUHZE5X5AZqVhh/t0ph8kFNt9L V9FTLgI+j7ShJZSWUldg1i0DXDZ9N7MgvTPkxqHjHLdh4BP7fnsQ/2q7CjwzAw/igMLR RMA5HBK7TUX9If4gKZFDfHfe1fZVtauRtOKNqqbtJT7aInbGBOE0z6jAc31j7kcyMxtJ /E6x9jKen9PgDQkA/nRG4PTKLO07COY4Nyg48oLmhElqueJAm3IQVpsCxZF6PylLdC2a d0GA== X-Forwarded-Encrypted: i=1; AJvYcCU99TMPah2ZqDEjAGjNL+eN5/oSpfaWjgQAUChQEk6bkPWl5J//rJ/WlWf2KScK+fNqrKHAo2W8e/Y92CVUNqkkWaE= X-Gm-Message-State: AOJu0YxGff/CxDoCJBF9uh29R6HzPOMx7Uk0FH5AJh2N0rgazkb0r2Dg n6nNN6nYnRJBmf4sm7mIn71uWnNNn47UF2VrL5gjVwTk2vU1eLioEpEO28Hh6Vv1YFESdhWBlrX IK2tcEGL8ENPNf6HhSbRewcoCSw8= X-Google-Smtp-Source: AGHT+IFJ2ytPT0Nj7uGwYAQ3jKNVVBO7o8DONColK6Cp7RSU+lk399C6rgC/Fd7qavxTIn7Xi0esXHZBYS89ODEfi/c= X-Received: by 2002:a50:a44f:0:b0:56f:e75b:839a with SMTP id v15-20020a50a44f000000b0056fe75b839amr8760934edb.1.1715093634415; Tue, 07 May 2024 07:53:54 -0700 (PDT) MIME-Version: 1.0 References: <20240501042700.83974-1-ioworker0@gmail.com> <20240501042700.83974-2-ioworker0@gmail.com> <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com> In-Reply-To: <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com> From: Lance Yang Date: Tue, 7 May 2024 22:53:43 +0800 Message-ID: Subject: Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop To: Zi Yan Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, maskray@google.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: A8C75A000C X-Rspamd-Server: rspam06 X-Stat-Signature: 37ftpgugxxexw96aqrsydtso38npx1ua X-HE-Tag: 1715093636-42135 X-HE-Meta: U2FsdGVkX19LBUbj3iQUyLVUNbmTJ8gAURI5h4I4w3MCkgdCF1ZiSJOUH309y6Gq5wUZXdt+0ArP41bLfS6ZenF8BKDoboUpoF9DnkSHLvC6UXyie+B63cj77m1UfIDLa6KPkkuoCByGKKVDqhNvBFKQ9qVFZgXaAyQtU1MmKtaXFmg+d+n5b9VReznB7QlWrvxGV7G9LVdtUPsrBb/Y14q0A3t2FFhm0m8830hqg7qrdSDQXMuJfXoAjhS4GOTbMEh9CqDADwKxoavlJTjZPl6etMeIORFWG4PS6bzu+kPNl8bZjPKzGBJvqMZOFBWg+sZ3YkycHN4IL3Fj6gdHjlnHAjfhgdu8Qqs3TC0CbFbR4/5jQDK5qjTSkG4tcD5Pss4vQALmlGk5zVLfM394pTf79gQ05E1u2bUFZcImqs1wfJRinnnnS2GYdYwVcoLGtp/Xg6da86p9SNjjts1CTxyeUel1RIy7QeIKNjgewYlDB/RtaeJnoZkf6tjCzfEfj8QiymQRZ6n11QHp1dOb0/RrPzvcvMuz00BrDz31veQaU6H0Bj7vmyHh45tHuECFbt31afquPe5O7D4dJAnFTjhZSCSxrEXZu/uuq3PwiYuayOjHEpIQfZoBonPdhZYT/xiPWqcGOhlFlVKz1+kHuXtqyWkYGHJotoFCo3jmg831N7b4KgLgzS1LUneA6WieKwZLLhjNxjt53NQGZeCXslNm/x9tluFomXEA4Y8iugxd61cG9yosbP/10JQqcdKxwowLcuAvBlANTHSHK+dykgboQMFi4ZWQ4F9kxtCeACoBxx40xWoAOyf79WzmTwbiYnaSwuYPA/EiXrXvwDnypAdeYkW64sn0MXxFFJN7qhbKoF+Hm8KfuZNQsDxqh0oPZVTujSZ+nUJrPt8jqK8XHxshPD0PkPPgf+kS62JBpP9kCfs2tbihXq/qHxEH107KLrVgYWGjgTH+If/ho6u I8tQYYgu NzkojIqQ24iRMHeFC0wz2C9LVJ0/CRDShxkPHuB8+E6Z258NsqNc0rjYYnq6jsc7RsnmCF2VOSs05SzMoyFHypaJ0+svY9SvSFQYriOicpbpZCbu0Zrs0u8T8ZDeAQowiPxgLv90Xsd1bM68jlTXMNK+PJBHfezUgNjpX86cG+GKvYEnxdIbhP9yqmDo0hQAy7fcptDHHI1jLWwConyUH9nYmSswewBNWQ+8yjYkrkBHR+KFWOPdhBGUc2Wu1Mp+z25vyJDJjbJUU7BOVA6YB5jyo+AuVTF5pU8XErMIs72SXXHZcieu8JL2DXjK9N4dxPrObKhJhRS4siCfugq7dpGW8AroPF+d4RqJ2FA1gH1G/1Uchlq1GvvvMmFL7sTz/wUp9ncoJGiyK2dk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 7, 2024 at 10:51=E2=80=AFPM Zi Yan wrote: > > On 1 May 2024, at 0:26, Lance Yang wrote: > > > Introduce the labels walk_done and walk_done_err as exit points to > > eliminate duplicated exit code in the pagewalk loop. > > > > Signed-off-by: Lance Yang > > --- > > mm/rmap.c | 40 +++++++++++++++------------------------- > > 1 file changed, 15 insertions(+), 25 deletions(-) > Hey Zi, > LGTM. Reviewed-by: Zi Yan Thanks for taking time to review! Lance > -- > Best Regards, > Yan, Zi