From: Lance Yang <ioworker0@gmail.com>
To: Zi Yan <ziy@nvidia.com>
Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org,
maskray@google.com, ryan.roberts@arm.com, david@redhat.com,
21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com,
zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com,
libang.li@antgroup.com, wangkefeng.wang@huawei.com,
songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop
Date: Tue, 7 May 2024 22:53:43 +0800 [thread overview]
Message-ID: <CAK1f24mmhd1FT_YBZ=N27pzDCmaL-NJPP50pdmp=CnVG1kNPng@mail.gmail.com> (raw)
In-Reply-To: <0B21BF2F-26D1-44EA-B5C5-D0D490BB90CC@nvidia.com>
On Tue, May 7, 2024 at 10:51 PM Zi Yan <ziy@nvidia.com> wrote:
>
> On 1 May 2024, at 0:26, Lance Yang wrote:
>
> > Introduce the labels walk_done and walk_done_err as exit points to
> > eliminate duplicated exit code in the pagewalk loop.
> >
> > Signed-off-by: Lance Yang <ioworker0@gmail.com>
> > ---
> > mm/rmap.c | 40 +++++++++++++++-------------------------
> > 1 file changed, 15 insertions(+), 25 deletions(-)
>
Hey Zi,
> LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
Thanks for taking time to review!
Lance
> --
> Best Regards,
> Yan, Zi
next prev parent reply other threads:[~2024-05-07 14:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 4:26 [PATCH v4 0/3] Reclaim lazyfree THP without splitting Lance Yang
2024-05-01 4:26 ` [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop Lance Yang
2024-05-07 14:51 ` Zi Yan
2024-05-07 14:53 ` Lance Yang [this message]
2024-05-01 4:26 ` [PATCH v4 2/3] mm/rmap: integrate PMD-mapped folio splitting into " Lance Yang
2024-05-07 3:40 ` Baolin Wang
2024-05-07 4:37 ` Lance Yang
2024-05-07 8:17 ` David Hildenbrand
2024-05-07 8:38 ` Lance Yang
2024-05-07 17:22 ` Andrew Morton
2024-05-07 17:33 ` David Hildenbrand
2024-05-07 17:38 ` Andrew Morton
2024-05-07 18:30 ` David Hildenbrand
2024-05-07 15:26 ` Zi Yan
2024-05-08 5:43 ` Lance Yang
2024-05-08 14:07 ` Zi Yan
2024-05-08 14:35 ` Lance Yang
2024-05-08 14:48 ` Zi Yan
2024-05-08 14:56 ` Zi Yan
2024-05-08 15:52 ` Jason Gunthorpe
2024-05-08 16:22 ` Zi Yan
2024-05-08 16:35 ` Jason Gunthorpe
2024-05-09 8:21 ` Lance Yang
2024-05-09 14:53 ` Zi Yan
2024-05-09 8:56 ` Lance Yang
2024-05-01 4:27 ` [PATCH v4 3/3] mm/vmscan: avoid split lazyfree THP during shrink_folio_list() Lance Yang
2024-05-07 4:00 ` Baolin Wang
2024-05-07 6:32 ` Lance Yang
2024-05-07 8:26 ` Lance Yang
2024-05-07 9:33 ` Baolin Wang
2024-05-07 11:37 ` Lance Yang
2024-05-09 9:36 ` Baolin Wang
2024-05-09 12:17 ` Lance Yang
2024-05-07 16:20 ` Zi Yan
2024-05-08 5:14 ` Lance Yang
2024-05-01 16:08 ` [PATCH v4 0/3] Reclaim lazyfree THP without splitting SeongJae Park
2024-05-02 0:30 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK1f24mmhd1FT_YBZ=N27pzDCmaL-NJPP50pdmp=CnVG1kNPng@mail.gmail.com' \
--to=ioworker0@gmail.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maskray@google.com \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=sj@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=xiehuan09@gmail.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox