From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300EDC369B2 for ; Thu, 17 Apr 2025 13:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4CF6B00FF; Thu, 17 Apr 2025 09:25:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 583E16B0100; Thu, 17 Apr 2025 09:25:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4739E6B0101; Thu, 17 Apr 2025 09:25:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26FB16B00FF for ; Thu, 17 Apr 2025 09:25:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF66FB76A2 for ; Thu, 17 Apr 2025 13:25:13 +0000 (UTC) X-FDA: 83343606906.03.D517EE6 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 07A26C000F for ; Thu, 17 Apr 2025 13:25:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CLY+aHL9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744896312; a=rsa-sha256; cv=none; b=UgiRF9Kp8n0XhLX+VjIL73IVlZpW68duIqWdn2NvygL81fIe5oCil4r2LC2SyDfwoUGs9V HuqWlC8knltR5jDmhfMul9vcaxbW7rZQxMwf8WAriu+JAH29DoM5DQBJFuL0/plHuCTAp5 0oNLocVe1adpMAOvLmYVJtZTWJGzSP0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CLY+aHL9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744896312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kpNf6w6GnEUetZaJA+rqBWn6AFuG6sqOCwucLcmthoc=; b=zpL5Fxs+m5aK3wYljEjjejPNDkm3GSentmtYHA9CM0H6e5mvi4pGOmzVDx7pCF+5FjX9TA QEalsvqmMbHri964K42xbM4LiOa7J+Fq3gM1dzSma+froRkj3G4K5YJuZDuwu2KI8lXAkq e6yyCo/NIFzSbT8VOv0NwC4t7IJv200= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e614da8615so1638726a12.1 for ; Thu, 17 Apr 2025 06:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744896310; x=1745501110; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kpNf6w6GnEUetZaJA+rqBWn6AFuG6sqOCwucLcmthoc=; b=CLY+aHL9G8VJoqYo3ItII2f5VoO9drkE4fPKZQAt06cIYeBcbld5sE4lGJ8dbXZEtR cuh0WutncwBrd02igpKQqTnpiaAJyfG9ZXcHwsjBE9hkXrfJ0vnme0FFvLH/Z5/Qua9F Ct9PUNbcZXlmgfmnvt4awnxZhfQDbzfdgXZxtav5uVWhEwehmvja2AvlxpMCHcIDZedB aA8I72GJ/Vtio8jJrMNtoLRIqHTWm6J5sgKdZLGpdeiGfBP/3dDKRXlFkBai6LRzHpV+ vTz+/2KpTqJYd2ctK8FkPUCBynjwpZKXzjLKWVmVOEwqd3q48M8sT1cijSKZQzCKCZ82 HcMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744896310; x=1745501110; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kpNf6w6GnEUetZaJA+rqBWn6AFuG6sqOCwucLcmthoc=; b=upJ9Uyy982CqPgVjTUf/iICAk9WhJ71Ll0K9Ra07TdOE1lpu+0inu43dwytdVMIXXj ENnaJmN3QAYr21GqLOjTV8K/JcNr/Jy9xShlAWpxgCJZHbA4P/2fHZM+CaW4bYTHllsB DVI1uHZJchv3hjNgSZociSOeSEU6GqRUqHwaHp1s4GyMeU+Z/muCqzkVt84aFyGXnvWV BpFNJI/OUe0LEOI+y+E6QYdx1F0rxjhDIWoEtQvKyPDFIolakiQFa9hI6phyx3cC45U8 EJih/QY8BB1FGZphQ7JGSjKYsVAzJk0W0cQgKr5AApQDfWQIvaByl3mxyUn5D29Rmc4e 9cOg== X-Forwarded-Encrypted: i=1; AJvYcCV0PoKJGd9YU2qrKsQY6JgL6mFPu8JDnJFanfV+T6n6w+wkr2eIoJIjX5kYOXhkcVhN8jxWYaZEfg==@kvack.org X-Gm-Message-State: AOJu0Yw2KesY9Hnu2CN7HIae4kn+qQS23r+juS9EIH7LP5bZd9siXgWH LFT/bkn0Z86P7pUSTBe3F6tggLZIjbdSTrMSLiFyLYQYCF67ahzPf91l8OBVS70NFSWpH8FKRIy Ff39dcx5ERt+8X/4efp95A1U+4+w= X-Gm-Gg: ASbGncu7/ooyP1wjxeSIAA5lnmXLI5s5qD0hp1549BZoR1Z4m8WcBC4sF+6l0g3xz08 TS4zU/ZBuMV6YCBDvSbujqmNcEw8Tt40kdWsveg7jsTxGRbWO+wk/907GgVRC4jhbLeWmCi6IDl 2nIN+pnavN5nOz91iI/B0DTw== X-Google-Smtp-Source: AGHT+IE4wbCf7TezOopemIV0fOYus0Gx4w/ZoyD0bBV1TFMSzOb8alw5GhhnENcFKPzNOqWxc/bAQglhq8CL9qZtIs4= X-Received: by 2002:a05:6402:520f:b0:5e0:752a:1c7c with SMTP id 4fb4d7f45d1cf-5f4d1377d11mr2619228a12.1.1744896310073; Thu, 17 Apr 2025 06:25:10 -0700 (PDT) MIME-Version: 1.0 References: <20250417124908.58543-1-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 17 Apr 2025 21:24:33 +0800 X-Gm-Features: ATxdqUED3wkrDBOxfYANPvf-Dj0nW7Nq8Qoxfvbu9oI8rK9kDfgiQD8DT1tprds Message-ID: Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 07A26C000F X-Stat-Signature: eb9pocjqn5mr8entye3ybz5ncsi58emp X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744896311-834926 X-HE-Meta: U2FsdGVkX18YOGOjEXkP8TcB4NMSD/+cct1MYn4SM8cYSIo94Oim+ksTQqlURN0a0xszRVb1AmTG+5pl3A/aOohSXTIrrzk1FnPsCwaliiSLFQ6JBb/j8TGKMOIKN7+6Tjsk3PM6mxtR6XOhE3Oc0CVOaJVpAJ7oAu2cCkCWfhWgSgkFn+8fNNylZtQ9BkuhabAycQ7W1s0ic3bVDuo15lUE5VAPWkjt+07pqJqvjd+CH5Dye8CeCLlpNpS9DeqwDEo2tQS+S+pMpL3vguSCHt0p24qyVbIYTNMxUm9euvEDPs7lIYLBfDZupL29/htiieflS0qsXGQH+EmqImF6KHp4NvXfSErC8cXTwNg/LSwvTK/e+KGUeT8J135G5rUprogvEe7O1YhRiHPVVL15yIyvGDX5V9gv3NEuWXs4cVk+iDd9PAPmw4pICvT10Ok4Rvgjpt5hAM+0I7qNL6WbM2HQ3cyr9+mWnMWWaKGypUfYF7IvtPVIbEXzMbInrcM5oqBPYcIMM3dBUrZfxUHVxEO/YwqhkrFXaVIFZYOywHJrzLIBTOnP1yVfpMtQ7PwayJ/ItIXCLPqOc3GzFLrHI9/+I0xwV2zoWAtR2avJCCy3EX1jH0ix/l1GpP07Z/0uW8LgRNv2qbvDMAxCWR8j7jZZZuNhG2VBid7D2uk1Wv8vW/cO8w166NgrRFecehgsXNkq+4mueWwhvzfSHnlM2IuBcJYYYn+NQFGuA9LIvVYafeFBAkd9uPm7fZM0o7NV1HEG5cwdyfyiV4kvoQTWzJwW1qPOO3TRWzQy4qXNm9bEVbjpdkPwozjWMpOXNUE6g8VJFpxLd9bubxZsbfRoxaJAe1wa0p/WAucU5IY7IFbFzQRU4W/ppaGp+C68g32kjU3yDTs5IoMmHrzWKbswzEwmzQfE+e5W4AHzTikjQITxcuKiXEdHslPe8s4WNyC80J6l1tuFCf3dTVQkAz9 TmotiBP3 hwChOjEPPheayME1RuFYLnI0h71BfCr1IcbChbv4RUvWejSGMTkkqOsAL5FP1iC1m04wAZZQk9RZNtMKXSIQVP84o3N97gKeH5aa2U3qHTsqxLQ+WJer0JUH822ENLuZkxu+kRF29isaN1g4Zk8KUAfUCnJnH0FINbqu/txzUuLsHamh6t8nzGUl8/WExd7e1cXIfSjyNVRjzoKdPC4M+5urA7QRBgZJ7b9VDIBFIPMT/Cv096wUQxHg92y4QJVfN4jRepXvvkpVEgqPEBGL7ISMcCFtQaaKwCnolNq6yM7m0F/wH6hJVN1juGmcd+lz1Pl6uIVYxZv7WBQu2XgD8XgMWYDn29LipGY3QHq0nm6eudNr46gq24QkvAdNWmgCPTr/pYwdISLREAnmnfeGIwhbVJ4mufasCs82OQon2NROPwXRjcyLUuLXXbhaO2ft22zSDJb/n2unRqmIt/39RUlspIPDVjr0lN/mqnIgXs8TAvLs27IA/zB/QfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, Thanks for taking the time to review! On Thu, Apr 17, 2025 at 8:56=E2=80=AFPM David Hildenbrand wrote: > > On 17.04.25 14:49, Lance Yang wrote: > > Add a compile-time check to make sure folio_test_large_maybe_mapped_sha= red() > > is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm= _ids > > field that only works under CONFIG_MM_ID. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Mingzhe Yang > > ^ should that be here? Yep, that's my email too ;p > > > Signed-off-by: Lance Yang > > --- > > include/linux/page-flags.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index d3909cb1e576..6bd9b9043976 100644 > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct = folio *folio) > > > > static inline bool folio_test_large_maybe_mapped_shared(const struct = folio *folio) > > { > > + /* This function should never be called without CONFIG_MM_ID enab= led. */ > > + BUILD_BUG_ON(!IS_ENABLED(CONFIG_MM_ID)); > > return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); > > } > > #undef PF_ANY > > That should work. I can throw this into a cross-compile setup later if I > get to it. > Yeah, just built kernels with and without both CONFIG_MM_ID and CONFIG_TRANSPARENT_HUGEPAGE -- no issues either way ;p > Acked-by: David Hildenbrand Thanks again for your time, Lance > > -- > Cheers, > > David / dhildenb >