From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E14C25B75 for ; Mon, 3 Jun 2024 04:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0341E6B009A; Mon, 3 Jun 2024 00:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F26846B00A0; Mon, 3 Jun 2024 00:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEE076B00A1; Mon, 3 Jun 2024 00:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE73F6B009A for ; Mon, 3 Jun 2024 00:13:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E6481406BD for ; Mon, 3 Jun 2024 04:13:42 +0000 (UTC) X-FDA: 82188258684.01.177F1C6 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf05.hostedemail.com (Postfix) with ESMTP id 5F969100003 for ; Mon, 3 Jun 2024 04:13:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Sn16IeHQ; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717388020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gt8Odb6me4R55P6VeYtTBeVHg7iXP8uegA/SSq4GxdQ=; b=RRdHSrXeydykMA/CVh6+a3rBLpiR2EElY7nAuLKDYD7oQFX1K37jM/ZkAn/vvH46de1HWp JDQCQ4zL33JPFAzJ0b/CkTmojx5tlZOWpcWQQ/9za64lQZz4vnD3wIiDMngN7J4viL8l04 EckT/pM5EnTm39DYyu0qtCTvzKthD+Y= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Sn16IeHQ; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717388020; a=rsa-sha256; cv=none; b=VKoltV7DrCF0buG/lnj/syFXZiebTftL/SoRqW/cOI9fh84fM7+KF7xsEjGvjV0q+hAqsA CyFkfqD4amGiqeRhLrj8ngSwXrFseR6KJ9nla0z65hBMOrKJaozJDR1/2dflzthDn3royR eJsaK3cwMwmFoY526mjcCRdB8BfY2M8= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57a1fe6392eso4345005a12.0 for ; Sun, 02 Jun 2024 21:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717388019; x=1717992819; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gt8Odb6me4R55P6VeYtTBeVHg7iXP8uegA/SSq4GxdQ=; b=Sn16IeHQXACX6O8ibXrGydWS2xPzU8hQXG/c/TnsRRNV/af+bBkQdWSTyVtcN+Wrkl 5T1umjtBpAGoGErbh6ct4dhvV/gQA8vlxmTJaclzYY7CWz5F5Ctoxc0Z73Zlp0svOwe8 pJWfTUd+IT9fpBU4melRRuPrJon+CZOuZzR1Q6TWbUbpWya3Owihk7ySBr2Zy3cKV3hE Z52nOpKxQQemBeBBcWZf7SgPvxVtoZFGfVtgAeDHYGzoJzDS1qA6d6I5bdPYXQJ7H0Nc i20RGecY9WsoWcG0TgbaA1xz3p1H0H9lPqexwKRXoxI/5+ckA9jVBg27K5ZTpl+EfHFR u/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717388019; x=1717992819; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gt8Odb6me4R55P6VeYtTBeVHg7iXP8uegA/SSq4GxdQ=; b=Cr32tt+lUwCbosIcN3s1jPY3zEVZhfhIjcN6XrgpMFS1Ye5iVI38ET/YGcclMjLZ5/ LYHWGqIleom80nTyFho+fWL5gz9y3txu8N3W61/1pTNGlua2NbEgZKeJJicF0xL0+B3I p/AvTuKB2xnmZiDMKQdlZUFK+0XRntzGJWyr2Jn6sX4A3de5R6XalUkOQhYA+9Cn/8r7 2L+okS7SRpihvb6XezT5xPUZmgzHOt5SKuHB9uAo7RvwXu38cw+0CSLsvrOCpgzsJKB7 z+Ba+9lBMV+3lG4af8dgczajKcQU8R5dABhCeuiQi6JUiLp8sXHV10idI92qBAnDewQT Htrg== X-Forwarded-Encrypted: i=1; AJvYcCUtyuTtSOaMNnL4RWgneO0TFeSLyEds7pNPpzSKMTjr1ipSdSjm/Ge/nC7QGC1S/zaaohCNF3duebraMkvAB49AtQ4= X-Gm-Message-State: AOJu0Yw01IM2LBfr1SqKhzWdR3U5rVXbER4gr4AA1oYeCYGE7O9v2CZo D6zca7/sJWjfrTRs0I0IrSvsy6Ddez8l1WYREx3ULGWOe8LKq+OyX9dV9q+D+WAFC4JKQ4RihLm VuhfWnc1Tkr0j6pZWypqf046ZIcw= X-Google-Smtp-Source: AGHT+IFd6l2c9d+DpNztjTndInDEB1u7H8aOTZjOvmeCo+DlXf4m+/VOnurKSYnOlEhIQcKRBkiGOcc6WmpRZ5CRQHU= X-Received: by 2002:a50:9ee1:0:b0:578:36a2:7073 with SMTP id 4fb4d7f45d1cf-57a36450a36mr5597011a12.29.1717388018600; Sun, 02 Jun 2024 21:13:38 -0700 (PDT) MIME-Version: 1.0 References: <20240603033118.76457-1-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Mon, 3 Jun 2024 12:13:25 +0800 Message-ID: Subject: Re: [PATCH 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch() To: Matthew Wilcox Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, fengwei.yin@intel.com, ying.huang@intel.com, libang.li@antgroup.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5F969100003 X-Stat-Signature: n8e8xftpa4ctdta4gbp1edow6qrqq5an X-HE-Tag: 1717388020-125585 X-HE-Meta: U2FsdGVkX1+57sVciLPU18OcxIs6+tJVYf9XUQeJCerbt7Ubl829q3q6bryK2YM6dVWUMa7AZjGQnVUFnAqGIFyZd+I1n9Y8GRYGQZOcpG6bdAhR/CigIPM3jXZGMg2XqAzCBES3VkIYIIi3vvzum6OlutLjWg7vB4sW6XntfOz68S57LeoHxQwaCAKmH70nevGfQDcinXEZGqXE7spZj8YNQyjcKuzNjRZODita7jDmbykoYH0ofk/v3WRACKxcPUeERIOfZgEAiKItArDVX7BOSNhQ1mN5F6GokqKsgr43llZ83pjNX6dQsi25K9mgc1pWtwTc0OC6dbYWiRmGHdMeCtUW3MvZ2qyBJtd7Cuaj6VlGNlIN5sPdXLXhknu+ElU41rZuQRw7jlcq+f3jzfwEHj8cylzhJTbRbS9ohuamRyYr5QIN7ilTVzFL5FQw/TP+9Ua64P0p27JDCufm1/3pMuLegh1eFiSK/xQXVO5UfdimOwUUEcQSCz8C17EehVRg0vkib6rhz1ET/2ykZIVvY8pMExy+PtRQ3bUb09984I/ivGJApOHmgjxW6pVtX2yWjr786AR+9IORKs4UEsNjDnS9lvIGZ1znaJ4E7rvbxWJypXimyQQB8nZYSmVHoaXPSXSIZqdrYs4MGKr7yKzfWjUmge8IE+/UhfulElJIlXA/sZVFRDYdX34H5w6fCBhz/+Yq0UsfGPpsQz9jUPCFqYSwglrgHJGjM8awTbxGMb8DnOAYxqoYKBIGFKyawMHTNhAWiuwynTO+UlDsqMJRVT6FEHKIZ9gL4QDPdR33kfRcf+3ufoe0AqlKiLKXzdkk02U9dUB6CtoZMIizErddtqLVXKZXXUA9fPKws9sBImZFEKd3J/F56PHTaxZ1L+OPWm4dcQeNUrCCXL3DrxYRxL9PkH9zgC3Z+iBouTfdX7Cc9gX1tU4OTxNMbpDfaH8hzV05yaS1Tu4Fki5 oTu8RF5g KPHV6V8gHJgulWU9bPPq7K0T+f4R5QiA+gYlQQbVZJLFg3XZ8gQ8VrckiN67TtnItPZKapsoOgF+7kknl1WOckPaQuN/4x79leTEX4UGUtR2vcgicUh2KF6B0M0Bi7dpFX48HQ9CgB3acgwfSExh61UV7f3TXVhQq21gyWHQuVJXZLb9hoJmUG/8DtogPmuAQv+ushrNmWLPKwU33UsxIxbX3OQuktIJGiDzxIZpByzSrBiwqTnS0CsmfV+HYDVuF5AV9JoQgeTeypoLdG04fKXuhQevNtCmKWrbFDXDSj8ztbD3Emm0g9BLhr8rAzuLL7L4QNbppSb2Bhb2Lkm7wA04VWFw4IZ7VIu9EwdVElK2NOeQ8gsqJTGPRWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew, Thanks for taking time to review! On Mon, Jun 3, 2024 at 11:36=E2=80=AFAM Matthew Wilcox wrote: > > On Mon, Jun 03, 2024 at 11:31:17AM +0800, Lance Yang wrote: > > { > > - unsigned int count, i, nr =3D folio_nr_pages(folio); > > - unsigned long pfn =3D folio_pfn(folio); > > - pte_t ptent =3D ptep_get(pte); > > Please don't move type declarations later in the function. Just because > you can doesn't mean you should. Thanks for pointing this out, I'll adjust as you suggested. > > > - if (!folio_test_large(folio)) > > + if (likely(!folio_test_large(folio))) > > return 1; > > How likely is this now? How likely will it be in two years time? > Does this actually make any difference in either code generation or > performance? IMO, this hint could impact code generation and performance :) But it seems that 'likely' is not necessary here. I'll remove it. Thanks again for your time! Lance >