From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4E7C5478C for ; Mon, 26 Feb 2024 08:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842A36B0184; Mon, 26 Feb 2024 03:55:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F32B6B0186; Mon, 26 Feb 2024 03:55:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2AA6B0187; Mon, 26 Feb 2024 03:55:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5EC996B0184 for ; Mon, 26 Feb 2024 03:55:23 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 37E87A0A6E for ; Mon, 26 Feb 2024 08:55:23 +0000 (UTC) X-FDA: 81833346126.07.C265376 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf24.hostedemail.com (Postfix) with ESMTP id A42C418002B for ; Mon, 26 Feb 2024 08:55:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NwBLZpDA; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708937721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MkCFtlqoX39H9E2dfaJPOMPy21LrIumnHS1T319uwME=; b=j2SEpw1eMB/SFfpmx3ja+yccglaYtTAwKjxU823PHBQD2f2VuaLhj5jCv5AsfpoXRUx1zC tTo+kov0i5LKPVuZrLNNl1k0EJ3GE9IM5s19yFJ6uyIPrLoaMBqI0cGexzmDpCIqCLVOBT fJ83HxBaY0SOrW7JlIz3lTX2BU0n7AU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708937721; a=rsa-sha256; cv=none; b=XP4++GogsGi+A5jWBin+5RrbA9IgOkrcxywwq0W0i4SlIAekkIbJ1yTPN0VD+Q+yBI54HT FirELeshtOweekVrW75cZ/OlKT4k9UiMKxBMiV1bWkCsKej7Fyxd4nWMXdCoOgsJZBp4yc Y2KYcMDt+wHJyA4Jj8Imu3UdrAIEZXw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NwBLZpDA; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-608841dfcafso23610207b3.2 for ; Mon, 26 Feb 2024 00:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708937721; x=1709542521; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MkCFtlqoX39H9E2dfaJPOMPy21LrIumnHS1T319uwME=; b=NwBLZpDAUzAk5eNQMMEy1MBI7BDjnCKb2GNyVFrs6FaDoSSM7J4gbt56QaEvtAiUPI Plw4zg8prvMhWtGw5+w78UptobMlBy4fo36Jv/NDx1btLHdslqskJe27voGjFTPaD643 BAf9Vp1dMM2Mr05EIF5BaPh0ULgcuA3Egb8h/mo7CQMrCAotqC/Y5O8TqOMRKnBo1HKf WSOF4JWKGNgVcR2Tyo0racUbJDxo9D1rxaBdgQd07alTx+o1/f6oYOGYjaflb55gsfjC 2C45TGpLk3eXxF+O9cKHgRL/Tk4G9v5p+XvYsRyJvhLwD4LKl6dwUImejas+LZDe5upL 6onA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708937721; x=1709542521; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkCFtlqoX39H9E2dfaJPOMPy21LrIumnHS1T319uwME=; b=rm8btVKUcT2QHTf1whgrGNrytrm1mYl/bNHpNwzd6XnpEzzafsolldpMnNnNerGONZ SLSOdfrLVrY4diD/R3qQ+JwHbnL8GjbCuQUcPZS4wjOfeAJoU1/jChta3bMq4uhW61JS +XAZ/HqOUnEi6CvGGzcZRFKDPJr4PgHE2wlvi8toZAYtZ768eAp9Y69S3XtOmgQzFm+M ckVuxr7E8oJKB3gcIL7mHN3spXt8YH4hViWmFF5Uplof6H1mZrv1x9z5xI7ozbWfIPXi pZdPfhopvP4HXBN2n29sDW/DtypgmouTzrW8IzmmC5Y34y7AVFoa1lLeURzyAicSqpTY K/NQ== X-Forwarded-Encrypted: i=1; AJvYcCWRceArln0QEL8x8n4P04SRIwM6/FQ2lyG7auEB7Byi/NRqIgqLPJCRQvoA3kN0M1m9cznneriTIDOBm4YRTu9TkRs= X-Gm-Message-State: AOJu0YwXQEJvDRNPFxES8uwXva51232z5eEHjUe3mw4tV19lghpg4Wxs +59AwNER4/1J4YY0OGS0ZiUl3dAqWo3ClQ7kQCLRePB8c359yFlcFDyB9Tla3U5GXd1Z/Zozd1/ Z2/xtdhpFeXSf2T0iSYGUUwrFSKg= X-Google-Smtp-Source: AGHT+IFpshRlCDcswRxHKDpIYcNPkCMA9n8AA4i9TFIC7v6bKQyn7cCMPvsPzoO9pgN/fqS3O/m2xsrUVN2tnVuvAdg= X-Received: by 2002:a81:af5f:0:b0:608:e122:88 with SMTP id x31-20020a81af5f000000b00608e1220088mr3737137ywj.9.1708937720800; Mon, 26 Feb 2024 00:55:20 -0800 (PST) MIME-Version: 1.0 References: <20240226083714.26187-1-ioworker0@gmail.com> <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com> In-Reply-To: <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com> From: Lance Yang Date: Mon, 26 Feb 2024 16:55:09 +0800 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free To: David Hildenbrand Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A42C418002B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xkprpu9pkj8xf7c7ggd7n48hfew6ka9z X-HE-Tag: 1708937721-923685 X-HE-Meta: U2FsdGVkX1/WRHF4sENg82JIfQdA1BDnrJhX9f5bTN7pyBp+kZQNCbBPRaW48FraTfceDEyJo5BWwjm26JoX8NAU5dYTxJgL5uauU26MpfU0kxuT2zbX/NYrcQ3Wa4GGlwrzESP187PuPKPQQu2SzX6ZffStjiLk5Fyi22RvzuEOOkv5RslIRIAY606voUla26aaMGaGE8to8NLp2o333JMYWEv2SPH3wD1XFVLO1jSQMyNCYtI3Qak6fm88KdBoZICoilzv50Bh18aazOqH4XrFNuYo/eJc2/FBAKD7AOCTJmji2ILF6HHa9g0L+FQYXGbSHpxvlxR9EF8ucxSdPNj/eBsCk93aRkydJucGjyXVBDlcN0lz6/D8pqiGq4cWlk5GM2zv0ffYFNphjQu/9/FSjxKzt4ypWstbhdMHAk1UzXc3hxCJVoObqZcW3vssNvaeTuZWpRuhPyXXLemyMxwU0V05JGFxjkVl9GCvjJTp1RbHV0EMVx99oouxQWN23BeZRQPkdBK50uEfGdlU63C9hK22ohqbQgvM1qUToBm8tTe7IEMi8fUb4/AUmuQPiECjar7+fFcCotBPVNqaU4DlggUaiXWBxf1U2nawDFG8NUeu0lBUH7kFGmsT/BtsJtybXL0QINFKYcfmk3FLyJk1l6hWs1+1V20hJ0378cRcSd39TZd+ENQKoLt5rHm3lcPFV6jxDxKG4iS8ElFvjq+Bj5FWRr5YzIWMcz3mbBbAdWcr9FCR5zCxNF6kRjZtC0vIPbqYTWDlbAToBvPY0zggO2KhusMfKXikoKBfG33jz+OVAZAYnPOtaC9rNLemOprvrjmMzv29E8uwVKO87RJeiemFTmGAqeLjMBcza5b3tRd93yM0J13FkAhIk6LGm1w8/v1/LWf6WkbtwMMzQ+9KV5QXr8ebcX4eM2vp7VV0Indexhz07uLTnd/Mp77vl8s5eFN1pwbCk2zEoke 7bu2eQub u1NAJWs1wS2TFExpv0x9OHFwLzY1Bq2xq5G9jwTEEDjTXymSCcX5GYO44O2k25C3b29M6HTnr1A4zl61bs8wyZLi0kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey David, Thanks for your suggestion! On Mon, Feb 26, 2024 at 4:41=E2=80=AFPM David Hildenbrand wrote: > [...] > > On Mon, Feb 26, 2024 at 12:00=E2=80=AFPM Barry Song <21cnbao@gmail.com>= wrote: > > [...] > >> On Mon, Feb 26, 2024 at 1:33=E2=80=AFAM Lance Yang wrote: > > [...] [...] > > +static inline bool pte_range_cont_mapped(pte_t *pte, unsigned long nr) > > +{ > > + pte_t pte_val; > > + unsigned long pfn =3D pte_pfn(pte); > > + for (int i =3D 0; i < nr; i++) { > > + pte_val =3D ptep_get(pte + i); > > + if (pte_none(pte_val) || pte_pfn(pte_val) !=3D (pfn + i)) > > + return false; > > + } > > + return true; > > +} > > I dislike the "cont mapped" terminology. > > Maybe folio_pte_batch() does what you want? folio_pte_batch() is a good choice. Appreciate it! Best, Lance > > -- > Cheers, > > David / dhildenb >