From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8A4C369C9 for ; Thu, 17 Apr 2025 14:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D82F2800C8; Thu, 17 Apr 2025 10:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ECC42800C6; Thu, 17 Apr 2025 10:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28D732800C8; Thu, 17 Apr 2025 10:30:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 004802800C6 for ; Thu, 17 Apr 2025 10:30:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1567AB750C for ; Thu, 17 Apr 2025 14:30:34 +0000 (UTC) X-FDA: 83343771588.05.1536327 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 182E84001A for ; Thu, 17 Apr 2025 14:30:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="bB/6xSFr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744900232; a=rsa-sha256; cv=none; b=PEt/qSRgIpNWNWan0bE3jMzgGUbkccziZJMn0pZkkALIDvh9Bl9+8A+LVUqj2ASnrkDNwF NxYeqGXNmxnukiNmQUI0TOYOqo+M6ouQuBIdc/UM3iuk2c4Q+Xhm9ECkw2kSnqP1AboBzn qaJODC+L36Y7EuAbl4st1lzyd/NjB7g= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="bB/6xSFr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744900232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YfCtmVGoFSkKpjhL5I0rf5Nt3BlAznqyCmYY6G7xfjg=; b=HLJyY2fohKKCQe9pXXbTiaa+GYayCyZ3YowBgUxpcf1P+mWP+LsoqAzgFz3bTmwOpDRDmH pQwM3iT4pLlHfr6mvXiQ/A2JEHIgjIAbP1p2FVI2pCADNAkovVOE+dZCfVKa2zEL7RJDxv j/7kWOS++gGlNH9T1znzGTe8FZ0Kcnk= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5f6214f189bso406112a12.2 for ; Thu, 17 Apr 2025 07:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744900230; x=1745505030; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YfCtmVGoFSkKpjhL5I0rf5Nt3BlAznqyCmYY6G7xfjg=; b=bB/6xSFrCyEJ1BV73xM90eV267XS/8IZHRJ153r6wIaoWlNPSFijhCC2QYVEy0KYo6 Qyvu0MNBMwPv+LLk9FWxlJbebLOGS+2D/sihlHY0toKvjrHEZsvLYCcI3/gZPXTQrswc 3UE3OtyI764qMQ8sRgEid0bmPUTB6ikw3q7MK2DH15d7W8bStPmE7SzXk2BWNSJYy96m d5mhAlM/UaKzlwOU3HP4bHygrIJmGqBlKdnLYbINLFVhRnexcxHh8empRXtRr+EOO5qw stBLnd6nZmPU1cLQ6CEplljUKEpok/NRopAGb9RM9sWifZlTvOE28OQ7TiQ32xUl3JkZ FTww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744900230; x=1745505030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YfCtmVGoFSkKpjhL5I0rf5Nt3BlAznqyCmYY6G7xfjg=; b=sbeTD8LakH+0tfOnsqnlAmOVWz69lUXYtbhQytP+Ja/2cdy8IA82IIXfye3UHf58RP aZMTL6uEle079BTu/pdIBAtfv+FQobJRMn+p2WObL8Zhu08sKKGDxqJgsnkYtVyE0RV6 k0MFJM0HSb/KBICTnQ09Jrelm2ha8+84+wT3laYUi/lQv6nIKvQMpJRy5WBFkvwujgCP /y4d6Ph1NInVQJZNGiTepEWwyYW65q0b/5UBV8+pfUURvenlQcgyaY141v8mla8YUV/c OvjIyzy/EGuqUn22LFbo9ZmxUx9e+Tmj7qAzSPHISMYiBbFjR2VFhnlhxtIq8DYsOILz CrEQ== X-Forwarded-Encrypted: i=1; AJvYcCXnAvr0nXXw7vV9zp6fO1VoTFR3qRTa+/sbtPFUW4JkZgbu/GDMXAe7mTNQFRTPRHsU8tapfrJhAw==@kvack.org X-Gm-Message-State: AOJu0YxEiK4QXu+c6Em3ngeEHKiAYO+T8xTeyQ6BCerkSvrCj5lcl3dr MUjsueAaCcO9Rx34e6IG2QyLAw3OQwtQnydWBnIeSxlPa/xmKRlzII7yRCORu6BMYE260g46MCm LfrT2t73+P7KUaB7qRp2t9vh7Rmw= X-Gm-Gg: ASbGncs+YaGGrj6tCd+ODVAo4UMitlUqN49d8ce29UVEz1MWZGRh7UhwlXaXXUnjbhI 2n7SI6WUAWo48snCUKq4+HStlnT0y4Mm+jpTodWDecRrSH049xrZyRI16ZdPLyrnY/S+WuGwbVw 5n2Cf8SCeAa7A2cD/IsG+3dw== X-Google-Smtp-Source: AGHT+IFZxqd6dHZ0yHZmXrWMeY0rwSMIk+68ltLSOlPISm2OgLSk5QDRQZVgLHh6syHr4hIv6K8BM9jF09iabjeO2LQ= X-Received: by 2002:a05:6402:13c8:b0:5f3:f04b:5663 with SMTP id 4fb4d7f45d1cf-5f4b75c4f09mr5402272a12.24.1744900230191; Thu, 17 Apr 2025 07:30:30 -0700 (PDT) MIME-Version: 1.0 References: <20250417124908.58543-1-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 17 Apr 2025 22:29:53 +0800 X-Gm-Features: ATxdqUFYz3uVZQ_i9Zh-WSIN1oYikhls0KPlV16HT-oXK5AZCnELPn8l460NKd4 Message-ID: Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 182E84001A X-Stat-Signature: kyhmpiru9kd3ownornufprndcteooee1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744900231-862017 X-HE-Meta: U2FsdGVkX1+Jgb2DTJysiOcKz/kq/g2sKf9ZXjHUthG+bNxNpRr8S/vq+Z2D/H3H0ifZfMO5i4pICsSlyxmYn0zBmeZXcfGWltcY+9WirznR7EASy5ZFCeIhe1EEn1POyAoS0J5GRlD7MfRVwc2ZjQaSUQPA3NTdElvOQsvQsVMQhPm+Xs4a2FgnQ8wQwuxij0VdtcalzeDhWIaNMRYcVxKWeT2HAIlhkPJ0GDpEkYfzxojc/sxvaKRZJsYRrh0w+GKigMlPYNGjPlX2YFH5C1aMGHqdJ6nj6GJ8XDNnBVSIyYB14NHA5bavEe72JItGlriNdDoBLEWMGF8uxnkX7DxHxZYU2r1i/kuQweEhyeP0e42/9No+mYkjBU/qk5LL8DGeijc7OFwFZW49WaOdUnWsvyAgiUGdRm3vyJiYLfaIrCWN62qC5beM43DLxWTyeWMJobRblrniEtLwjH5zZ9sm8bCzm5VnzuEq907ivp9Sb+3jT7kMcDiYwIx2xkqzvMXTa0+5S/TsyI8iO03yvi5QIAsgq+Wzvj8CddeyVETBiy/cAOyjIUt9MyCCk0LSWIEBefREw5wuvtFEuEJUkLV+5oqoDYGJ1VQbcavaSNZnmtMmEVDnShpEF5XEYHeNetZi0k0z1RKTs6CfJh4gTDjKFVPeUfoiJSOdTN/Iuzt4UnuqAeNfMHFmBNbXAl/CDC5qT+RM2ssILdw7YvBspVFotTrWU/3ReuDiFSxgROxR5aVkfgrg+fnKMu5+zL6BYIDf1pK6UvIKPoCBQIFXrJHeD9ajeZZ/UMdJVIna+lOgEPer7yhjdgOJTMeqcYWAWXuGJ6Yz8zP/R6LkfPKuDGtwzc0JNvY9bkeFriYna1BLbz/tXDa4QgSnEgm/WRB8ptzvzXjMXgAR4Xz2kulbTa1a8w8E3Odhmm7X58wqmVVsmPLQIy+aQSSyQDfC9jqk+Fwt4Sfd/KHTViEPF01 7ytj+Dwv gFNdOY5cuW/6BRvQMgzINqIc4ddXP+0tcVeU2ryC83fUqa71a36wpfVe4flJj1GB2T8lRGX+iM2V1f+1001Du1ELlnQ+XYz8ZKHvTPQFEcedk9F4lhrHKoDnpDYUdK4rbbNwQu22GbCCD0rjaQ0X9Ia0k/B4ykn7VI2X+0ehz/10EnfvhIJhjK00c5nbjSXP0a1a3ne+W+6y+7upXsiNwrbJYTBm7RBsaLaCVPnnzSY3iF1xap2DtOZDljpLSLAb5yYPVnaN+s61zVxqqVKW6jixIAJHDD8lyHAxUwxbp6FwewXryC7cCwVpd4bUOmZXJyiaZ+boiL5eo0cXLA2KmaypFXIcZTufGL+Ag/KrrYJr7b23vp4gCETLdxTJwojR6jYWX8iUjlZBUEd9EKQyUX93LKRpjQ3ikkv5b/e7FFOAqw4uLDWF36aTZUE8Kx2zpSraE X-Bogosity: Ham, tests=bogofilter, spamicity=0.007052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 17, 2025 at 9:26=E2=80=AFPM David Hildenbrand wrote: > > On 17.04.25 15:24, Lance Yang wrote: > > Hi David, > > > > Thanks for taking the time to review! > > > > On Thu, Apr 17, 2025 at 8:56=E2=80=AFPM David Hildenbrand wrote: > >> > >> On 17.04.25 14:49, Lance Yang wrote: > >>> Add a compile-time check to make sure folio_test_large_maybe_mapped_s= hared() > >>> is only used with CONFIG_MM_ID enabled, as it directly accesses the _= mm_ids > >>> field that only works under CONFIG_MM_ID. > >>> > >>> Suggested-by: David Hildenbrand > >>> Signed-off-by: Mingzhe Yang > >> > >> ^ should that be here? > > > > Yep, that's my email too ;p > > Best to stick to only one here -- same individual :) Got it. I'll keep that in mind next time ;) Thanks, Lance > > -- > Cheers, > > David / dhildenb >