From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E116C54798 for ; Wed, 28 Feb 2024 01:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AF156B0152; Tue, 27 Feb 2024 20:46:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75EC66B026D; Tue, 27 Feb 2024 20:46:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FF6B6B026E; Tue, 27 Feb 2024 20:46:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4DDF16B0152 for ; Tue, 27 Feb 2024 20:46:36 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D35080E73 for ; Wed, 28 Feb 2024 01:46:35 +0000 (UTC) X-FDA: 81839523150.04.FA0F31E Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 175AF4000C for ; Wed, 28 Feb 2024 01:46:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R5cStQG1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709084794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=66cn6DXc79Sno5wggi7HSXHWH/kH93OR0PebifMA0xQ=; b=2t4p5xlILego5zbhhdKbZsdqZKk6FusI9aUcK1yYXWWClXaVfFJdOe8F/HpFJoWSbEA3N6 POHlnp2nfefft9Go8dguxLimdWo0k9NWtM/m1ANqMLIsT7YDC+42sQAsy95J+P1IQIBuqT x6eV4qi9f2BUdZuqQOmPO3hQHVUWNYM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R5cStQG1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709084794; a=rsa-sha256; cv=none; b=d60WY4qU8RUE1VDcz8uV5cM1pUc7kvoAswAw+mdW7TDkp9mbcYx8uDSGeyYjZPVb/i5sD6 NlURb1hSM7HlLSezaIUpQNRLgbY8ZdWIqKErwAYb/eeao/PldOtSgs5tdTWRxmfukTxPim OXcvAmpZmQ+03ngsAvvoyUAeaxSKoh4= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-6093f73b373so131887b3.3 for ; Tue, 27 Feb 2024 17:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709084793; x=1709689593; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=66cn6DXc79Sno5wggi7HSXHWH/kH93OR0PebifMA0xQ=; b=R5cStQG11ffEl9jFS5R4pFwxA1D4KHvzg/2oSmQQs5tK0u5iUra7yn5rn47Xm8Bf15 ZahYmXau1Me0eMdnNlPsVfgdvOyJZ48JHQdatVxms4otdRsq8EBq1PxNQjfDK4GH/n0w sKv13idEu9Gq8Yo0wAHQwIIG8Tq90LEHfF9f9DxEa9rRGQdVYaDjuc56OK54e9u/rS/p VUM7Jw6dN267Nk7Qtrp3EHOh3yhbJhaIG+Jhucx8T1p/bdG01AJN31x50F5OZPimSNOV fAOhUonrMDeEP0toANnSK3tKU705rlhgXBvQZr/dX/IhS9M/4HmTvLFtNzCLHRsvKmhO JHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709084793; x=1709689593; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=66cn6DXc79Sno5wggi7HSXHWH/kH93OR0PebifMA0xQ=; b=dm+F1pgiVLob88+cwue4uSHmFEy5Djo6DMLQ0r8wKHfcVJwgXFG28f5QBZfJ0OZo+e z+U/WRKx+YSNYxw+TXuZIpKqG99hGLpwrb+0RDCdrLt6wJhHE9KuNEpM93CrvJwfnpKt h3mEzImSixggPSTMJL74xqhtc5jdfdy3uG7zdk/UY1kpajYv6A8FWDKm9l+NZdX7frtq 1MU0nPMs6oCe+g86A9TJhq8XrShuUFDu1naBUBJp6qFARApEGeAlzlz2f2dXgsrQ6btX jriOIK2LA78/UiZVkbUuBQiHA+dHR2xYGeMMAzPrw0aDf/wYtvX4it6ywa1eMzufDwDF rYWA== X-Forwarded-Encrypted: i=1; AJvYcCU7gRdMyEhCVkqh6CEOTqSXOXQMAigR5dz0kptOKnervTOGlaYwZYC7E5QtAgNoDQB4qE7Fu7bA6EMwP/pxr0Z2/Yc= X-Gm-Message-State: AOJu0YwRwLVwaLldCdISHB6kSuzb5Qth9+wkLe4ry+Q1/ho0coq+QXJj MJMZw7PgMJ2pSJrgXF0K9Q0gjDB7kLvN/ClwFgqZNGTsRHnH7TlCNnkwAI7YofhbwRKKRfBPnqB udWsaaqlO76BuMn81umq9pE36shg= X-Google-Smtp-Source: AGHT+IG4HucEn1faUd+ZF0DGwKqb+Hfz/1zlzPU3M8kGwG33MXRElqaYYlU9JFNAPbhH+FSW7G3DHMiyGL9JvXwflKw= X-Received: by 2002:a05:690c:5:b0:608:d5b7:87b0 with SMTP id bc5-20020a05690c000500b00608d5b787b0mr4182816ywb.48.1709084793161; Tue, 27 Feb 2024 17:46:33 -0800 (PST) MIME-Version: 1.0 References: <20240227024050.244567-1-21cnbao@gmail.com> In-Reply-To: From: Lance Yang Date: Wed, 28 Feb 2024 09:46:21 +0800 Message-ID: Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Ryan Roberts , David Hildenbrand , Yin Fengwei Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 175AF4000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: k9xo68msmh8ysu3xct86winfo5pnw1yr X-HE-Tag: 1709084793-516536 X-HE-Meta: U2FsdGVkX1/WUq/tZO3OZnixcbIWO2cX0+gGbyuusCEiibQquqgXyy6hDxVWrJhmPwx544kaYXgQ7fY6mzFN26Xymhe8NtR9+w3XVrLMJ0foJPtpKjZudSSzBnIP+PtJWzDCcv/nfhcOjt7BHjgfHOXY1E5ySCTABeraAV59tVkuxNQckTe1LH3hGWaxZkcTiGdCOtVGQz4ZL4UFTVbpQcn1xYD9dH275523M/ASV6kRmrzydYM7mpcJeQiTyoHEFKz9OPt1DOr/LPlVGJ3VjlOEMO6tf8v3MhAWCLLVNHBMX4PReg93Hu/y/t+yITLAQkEmzf8vM/FCdrPJGiYFK2ljvxYBDQHbprEPgLBBxEfjl1r6KJaaLNYlomjbpIo7alespwt/NwNUb598ZV/jxipgWqzteNR12ihG6QjmsxFl7pprNPAC8oSncXkxBcuzBEHnJRsiUX5o616+PL3ozOygNifEMH6+8CyaqEFK0KL+HEJmbWJ6eM+t4gzOZ7lvQT43R2dgy5qGkwzgUhyFMTpomkLIc0CXaN7Mbpd8NvJfDJ18mKtWpVGffBjYTlVjpyPsVh90mte17iK6vYtIkX0IddgcTOPBWzAfH9zxLh8O/CQkZ4UiC+R34OF43tb10yHSbj34NVw0KEDppGulETkeh1gYZz30utVpUJUOj1xMjwaKSENfSKX8B53pipXUVCfYVqHGRqmTug0q15tTb47Ry0SeWIhziG9arnPnvt+DDl5jWOHjtXym65CCWpAFhcamsvmKVWLOE/SxyBv91yYGjM30Nq/or9y4Y3PP+eFeTDhR3CVvoZXlUJ7TfYs4xTw+1JcY+KgRjj+qmkM/BdN5kA53KPuOL47pyt/rytDV5QiIJbNGfiicGahaV0Z0vK9HwYMMg3aPfEQCG37gmBSS6ixJR5skBbJLhRRWU+G1Gu/Sr54VOSkbEewjhjr3cZxw2U69DrH+xICtQca BnNHP060 S6fTMwY9QRDLkTb8oMFTnZqckMsGXBVho/vnhGbxqsMxz1qhIeaCgBqWp+rI+9pkx8FQwDIezoSldPdE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 3:02=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > On Wed, Feb 28, 2024 at 5:00=E2=80=AFAM Christoph Hellwig wrote: > > > > On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote: > > > From: Barry Song > > > > > > madvise and some others might need folio_pte_batch to check if a rang= e > > > of PTEs are completely mapped to a large folio with contiguous physci= al > > > addresses. Let's export it for others to use. > > > > It doesn't look exported to me in the patch (and that's a good thing!). > > > > But even for making it non-static you probably want to include that in > > the series actually making use of it. > > at least two parallel jobs[1][2] (maybe more ) need it right now. +1 After kernel support for anonymous multi-size THP, PTE-mapped THP will no longer be the exception. IMO, folio_pte_batch() is widely useful for che= cking whether we're mapping all subpages of the large folio or not. Thanks, Lance > Getting this one pulled in early > will help build a common base for them and avoid duplicates&conflicts in = them. > > [1] https://lore.kernel.org/linux-mm/20240118111036.72641-7-21cnbao@gmail= .com/ > [2] https://lore.kernel.org/linux-mm/20240225123215.86503-1-ioworker0@gma= il.com/ > > > > > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > > > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > > > + bool *any_writable); > > > > no need for the extern here. > > Yes. this has been moved to internal.h as "static inline" in v2: > https://lore.kernel.org/linux-mm/20240227104201.337988-1-21cnbao@gmail.co= m/ > > Thanks > Barry