From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AE9C001CC for ; Wed, 17 Apr 2024 09:01:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253366B0085; Wed, 17 Apr 2024 05:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DC3D6B0088; Wed, 17 Apr 2024 05:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0562D6B0089; Wed, 17 Apr 2024 05:01:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D81826B0085 for ; Wed, 17 Apr 2024 05:01:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4CBD4161038 for ; Wed, 17 Apr 2024 09:01:35 +0000 (UTC) X-FDA: 82018430550.04.91AF1FF Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 571BD100027 for ; Wed, 17 Apr 2024 09:01:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LKmznNBY; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713344492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1IQPpzwWcfVU7n9t+qjpbVgRash+OxFdYmO+ZwvUXnE=; b=7mS6EoqIB4HIW21SSBKk+1gRfac/e9SzHbRXzZIQ4HhRaOPDlwQiM5/umIAT6UlbRa/yPf 3qRKd6jkj3G4CyK85PoX21O5mbDROtVEkhmrk3R7gwXgpQHv65TH6ggxBMDGw+eLiGSGbD uen9ppMZj5OPUaZSWHoQy9Xe9+MBnYM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LKmznNBY; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713344492; a=rsa-sha256; cv=none; b=K7yLcrKtuUlZrM+Ii7ezKZHx8GmI4l4szCLwZq8SYrxD1gOjX6Kc7xinP+dFxGeXW123LD jIy44nez2ZgnIS48r37oGeInVq52ojhZqsSKupJXNkPcRbxxVaaDe4pRzOYPV0FeYftRi/ LAyvFX8HmAstlPyHcHbZ/rv7v+wQQqI= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5708d8a773aso203318a12.3 for ; Wed, 17 Apr 2024 02:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713344490; x=1713949290; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1IQPpzwWcfVU7n9t+qjpbVgRash+OxFdYmO+ZwvUXnE=; b=LKmznNBY1+befw9gLFiYx+Tcw7hvH1NdoUzy+galmZNp/AzWRSe7EkNPOtneCfdRD9 dOadQsipzY5Akm1DD/SA/zrbxMaVobXY1rX+Oqx5/G/9eKw0ZkfAShmE5/b0xScD9wV8 WmUZiKxnnpXOOgae2969vuICZ3HpP+hBqX408QRhIiq53pdD5QjuQHqKgvT+qzobDnbY JuYLrkMHv2aImX54aI08qnv+Ig3uA3U7oywWAh5Gj1c46fFN52UG+lBj6yiTPjT/rnjm VZFMnDC0zfDEviK+1YOgCIrePR60mZSYBG53BLvKfUCb0N7J19HSwkik2wg1G2tMdjPg 2HvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713344490; x=1713949290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1IQPpzwWcfVU7n9t+qjpbVgRash+OxFdYmO+ZwvUXnE=; b=nK5yQ2e4X5zsP3d+Jo7vVwbElOuY2SnOTP5X4p9Lvu5HcFeJ85p+VJuTWPxNS3Psk4 ThShi5OgxLuvzMizziyHr2rIx3BI2dZF6twzneXOB1tHyrafbV3lYKwvbtYHqXEWi6js 0oX8SuPu8Vdi8I8MtfRJL/koiQBkmaSv5nvqBCeItZb9W6P4AbfTYUqZNehKajWx3Nxd VZyaTJwDihxp8cuqR3ZfVyZmjzptODrpZ2vJKsX3rS/59KW9fr1UMO1vY3aZRZCCy04w KrUBOWHxamcwwa7H4WxR+oXSnG5nj/cVc3KkitanaalSR4Iz+7Cr5FT4h7ByyvsG4N7N 3ZDA== X-Forwarded-Encrypted: i=1; AJvYcCU6q38rbTASucYl14/lIsd1J8ZrG89mVOFc1a16UD+yrScWFBXttpXQcwPCRaLq6xWMCfoUWss5EJkHAOZ5Z+PUM9E= X-Gm-Message-State: AOJu0YxRRofcjksRSIEatXQ/g8LKaelm79mS7twhKqMlVqaYiAKhxGys W9WvdDhKdjGzuWnQ1Ak1ezsfUgwUsi8MT8CvxiEZ0vtKkrkzZMVNWJ6sHmrpwW6k6hD5ERQo8NZ sQ8zvJjEsKXPg7OnXuy+GlKUkre0= X-Google-Smtp-Source: AGHT+IGXg0YVptrsLyFBykOpuIjh8UGp+Bh7094A1mQjXyrv8LDWn99rHXcHRn0HHvhLAW5O8SqjsJcGUb1GCKM+ENw= X-Received: by 2002:a50:aa9c:0:b0:56e:2ff3:bb89 with SMTP id q28-20020a50aa9c000000b0056e2ff3bb89mr9695343edc.28.1713344490228; Wed, 17 Apr 2024 02:01:30 -0700 (PDT) MIME-Version: 1.0 References: <20240417050426.66194-1-ioworker0@gmail.com> <76d22c08-82db-4ea8-a7cd-c77589e132e3@redhat.com> In-Reply-To: <76d22c08-82db-4ea8-a7cd-c77589e132e3@redhat.com> From: Lance Yang Date: Wed, 17 Apr 2024 17:01:18 +0800 Message-ID: Subject: Re: [PATCH v7 1/3] mm/madvise: introduce clear_young_dirty_ptes() batch helper To: David Hildenbrand Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, xiehuan09@gmail.com, zokeefe@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: c81ax9jdrbj8bh1eaeicjwo5xkcf1hnf X-Rspamd-Queue-Id: 571BD100027 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713344492-373925 X-HE-Meta: U2FsdGVkX18CfeoAB0WvJ0z2LvrftJGJbJWkYK+wqs0BljwPIkzF43ix+cXwxRgTsUc56nxrtaUafJXJDqtJjexwSJx6Th1rlJU3XgJT2BsEGR7+PxrQv050IHYtvIlHny+ye92O8WfuvyWxLPX8jq+POZEsyaLoWe92l1vnRTw0q0ZHUCgL5atrioQkKygD3JNWFYXTNPGuUDw92EhJfPHb44PxQxizDAlzajWZB4ViS1K1AcLciwvD9q2xXogIB79W95m1ZAVgbB0SiqdsJiW3WgqATKHHvsezJ0iuK4BdKkMlGjOgSiGBKgbTzmgrS3FLYX78ovhLdyNinqPuNJawsUKY+6rv2srLdzrWCi4sZPN++YqryxOaRwwkqd1VyKDMXBSzYgonMsrvmlNfWkWEBpTqxugod9sHL/d3PO/HVnO+xkOSin1ZmTcCIIp7RYYjvyHm52xAsKy4EhQinu+/XihA9OegGiQBy3TXhcN7bg1gKsrWep4hNXtE5o7wAV8VkBnS9/nOTCSOQAXYThZBUonnNmuu1ndGPNjTXnPB0+bIM7US/M0zQN1EzQnL3cTpH/Zq689Fxig66huUEWYn/NUqUfogyeOEt/98Bt98jnI6ITOtV0eYmgDr6Gm9XjjgQAOuDDwPrPogQuGALgjAWlEyHJbkkmTftw6ABLjg+DxI4bvNXCAi/CbehG2cpQVvgy7p8ny0O7ijvvn+cZAHLz+pV6COO82joLkSDi+BYChyCJ7fyKp3qT16gPQ+i1wbRlIVvNeonr0UYWBCmIhuNbyPtc2kulDx/j/7LH6e6jqnEr1bMlI2YI1L4rsqMzSyrwzg+y97fo8Ew/cPJQcoMYyT29Jxxa2ra9WZGqYPe1fCw5uSnVwAqxbcoZvt2yzWnDkMUoyRD8/6/MvnKqw/XEVmnimjQgpzEgGJ+58dH+Ua2wQpllNO0oCWeHCX1jL9s+Q2asoUMrTTDSe TwOzL4UZ wIf5RxHvgsM1LiCdDSm6UpOwYU3N9TVFpfG0nT3KV6XqVERwvT4YN++T1Uy0uNhNGeYo4oGqXlYjToDc3jKl79wdYTT7dkrodOMKOriKI99cG1hotMrNoMwSOc/FJVEwMiX7pNBCiMRsq2vNFkEEVVNtqtQmz+UWHLC7AFxDzbgMHb+ZXpQQY8RM5aygjIyxqyFUY5BA3cm9+Z+J3G2Mh7e1yEvIay4UwfIzybfvmfit6KalI949O27Y7hXaDcagDaxsr2On6C1p6Gt1PP3fQmQXQbiRVMPi6LMred7PBN2OLWa/WZXi6s//p9bcRDUsazKyKbe6WwHfwo3Z9VSr+6R1LMtyModRUxube0dOwDmijVNiNxaObWt1GzRa73R3WBbsHVW8EPc7zFwaLIzCTIrqSFbXH6JdC6Z6RmBgOV4CvqDA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 4:19=E2=80=AFPM David Hildenbrand wrote: > > On 17.04.24 07:04, Lance Yang wrote: > > Hey David, Ryan, > > > > How about this change? > > > > static inline void clear_young_dirty_ptes(struct vm_area_struct *vma, > > unsigned long addr, pte_t *ptep= , > > unsigned int nr, cydp_t flags) > > { > > if (flags =3D=3D CYDP_CLEAR_YOUNG) { > > for (;;) { > > ptep_test_and_clear_young(vma, addr, ptep); > > if (--nr =3D=3D 0) > > break; > > ptep++; > > addr +=3D PAGE_SIZE; > > } > > return; > > } > > > > pte_t pte; > > > > for (;;) { > > pte =3D ptep_get_and_clear(vma->vm_mm, addr, ptep); > > > > if (flags & CYDP_CLEAR_YOUNG) > > pte =3D pte_mkold(pte); > > if (flags & CYDP_CLEAR_DIRTY) > > pte =3D pte_mkclean(pte); > > > > if (--nr =3D=3D 0) > > break; > > ptep++; > > addr +=3D PAGE_SIZE; > > } > > } > > Likely it might be best to just KIS for now and leave it as is. The > compiler should optimize out based on flags already, that's what I ignore= d. Got it. Let's keep it as is for now :) Thanks, Lance > > -- > Cheers, > > David / dhildenb >