From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38E5C4345F for ; Thu, 25 Apr 2024 04:20:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A3F26B0089; Thu, 25 Apr 2024 00:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0550E6B008A; Thu, 25 Apr 2024 00:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5E8D6B008C; Thu, 25 Apr 2024 00:20:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C77916B0089 for ; Thu, 25 Apr 2024 00:20:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 729A1A1ED7 for ; Thu, 25 Apr 2024 04:20:00 +0000 (UTC) X-FDA: 82046751360.17.5E4CC82 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf23.hostedemail.com (Postfix) with ESMTP id 9AA9B140003 for ; Thu, 25 Apr 2024 04:19:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qz7YqrN7; spf=pass (imf23.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714018798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NMg+9hCwbXrc++Qvh4TJXQuS5Ly3hwbseR/9XIPaNGw=; b=sLjeY3sk10/elHxkj7cE5d31vmi8DFUK9gemKewCshDfwFnK2D5XThUp8kYpg6n72+pqfq X0priGium2aV1FutJD2TvKfaidXq+OJqR6Fv/4vZHPkCLVw5O53zhSg0Oh/9fafAD9XKKL nLHNo/bq1hLp4f3df5mXvjOrflW+KCg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qz7YqrN7; spf=pass (imf23.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714018798; a=rsa-sha256; cv=none; b=XC10/dOaK/rGcm7Rnmj92VGgvYV37YH9QMg47AJSeFMH6us9/ZtIQlE7Wffr+DbtZPqHNb NInYYPQ8JjfD+S4vZ/SE9dcDE7YMq+a/jNJz4R4czyRlgay2NqDPoIfTQGekmg1yBjWkMC 40YWxFHbejkSNO3OX8J4dLYVgC7QJZQ= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d895e2c6efso7312311fa.0 for ; Wed, 24 Apr 2024 21:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714018797; x=1714623597; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NMg+9hCwbXrc++Qvh4TJXQuS5Ly3hwbseR/9XIPaNGw=; b=Qz7YqrN7eKO6bvu587SkSDySYyckQu+s5/m4FkxAjFzDggcTlj18suf35g35FUsAKH RWlqNwFfB00CwvOZqpbUNVHRab1lxkivaS1rKldgn3gOWM4Y1YgtVY/Oy7bCK1n5rO9S w8poh1QAUvYtPBp/AqPTG1F4FfyFLRAmSJbP4LbaWDvZ18Em/fPrBy4yXYYXbzdNwggP zDstricXQOA+laNNrMcP+ppYtH9exammWJwQ59o2xB6gD+KdPQmhTTSPgqdUJ/kn6Zlo Z1f/qWJvlvn2ZVeeD7jW0ALg4hpcA+mbyBmQxUoONAEMUbyHqCpnfH4ci5N7LRMmj+/I GAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714018797; x=1714623597; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NMg+9hCwbXrc++Qvh4TJXQuS5Ly3hwbseR/9XIPaNGw=; b=mLd83YDtdtILnf1KvKYxhFsUsZ9SvpwS9BaOgaKV0pkIcVBipY/YnAes70o8sMYMjx WXy7O+bB2q7Tng3fp3RRu7llLZBGZhTPNSqj/HMV8KSbSohHCeT7Gt38mJ647tzZGMU/ j8M3xUuXJx4cfjOnTxFY38IlLBngC4ayAAd2URyZNW/6yIdPwB3ALPJgoXQCYCxq9HKU DAeCQyCzwnFu5bcezKE/BBfAurpnjpPXPToqe9F5NlC0qpSCuKu9pkvlQrM/0CCOXKAt Yjy9/7X2893oygfCyEWJHX7zBuT2IO5Q5b8zQ2JSiKzHikVmIDSwVutZlPvl8pthGRLT FClQ== X-Forwarded-Encrypted: i=1; AJvYcCWWMRZRHaaZInZnEjbTe4/bEK3kZpARkPTxf3zzHHBI9gY//nxcrxB+KLDZBOu8uDVvtvh0gLkG+oaeq2zXAKlmgDg= X-Gm-Message-State: AOJu0YzkxhVdL/CrEJB/7oE2GAODfUIWj81l0x9X1yZMwMLooFAJ2jtl VmJ6Gqo41ssaCiJ0KUV5aHNTQ2PuuIDIOJD958xXU62FrZFlC+YsAORmQG1R3L5rG/PvOtsVMS0 aaOyKrv+inTDL4TFns/3rbD4J9NI= X-Google-Smtp-Source: AGHT+IH4Dp2AKt8vVX0I/RfdKEAnIUxVFSKVd77V3vF6aJkMoz4IDJP/E4UiD0m1B/rW4k7ve5L8LDfqzwlVo/WCfj4= X-Received: by 2002:a2e:9d06:0:b0:2d8:6b0c:d91c with SMTP id t6-20020a2e9d06000000b002d86b0cd91cmr2438642lji.47.1714018796709; Wed, 24 Apr 2024 21:19:56 -0700 (PDT) MIME-Version: 1.0 References: <20240422055213.60231-1-ioworker0@gmail.com> <20240424142009.149eb988cca33822ce0fd0f1@linux-foundation.org> In-Reply-To: <20240424142009.149eb988cca33822ce0fd0f1@linux-foundation.org> From: Lance Yang Date: Thu, 25 Apr 2024 12:19:45 +0800 Message-ID: Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() To: Andrew Morton Cc: Matthew Wilcox , maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fbrmys6g8e9uacostchqowg96rrfaj9j X-Rspamd-Queue-Id: 9AA9B140003 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1714018798-353135 X-HE-Meta: U2FsdGVkX1+i6gOFbIwM4xustRwW0ahR3IE5CD9boEuD327xToCnyTo7+VYqS3QVyWImiPKZVrXDfSdECJ28do8x/Z7eEUv7CNKPnSCVbNiGNYzsxCQmGg6K5Hm13Kp2ozev2ygNx3eLGK9+Xh1gK7r7ypgBR5byMZZ75URYrXUCXorUPFlXqp4hkoaS5xMuoHRu3yIg4obKHuG7F3fyRZWKfw1hVwURHkuQqIZM+Ve3WfZqBI/BxIfEjwBPQ7fcstS6bs2mj8gNYMy5ldWumIFtp/ASOV66A5h7JTFbRi4c7wpeH3l3S5sbVbR4H6VAvYd335jwCtrulF3KCs3Fk6H2opYX4v4RcZiACokCZWlhJDRJqpmTmtyT1rTsKRe8xKFoUcC0MKN6hS8dwh3KBUqaMLwEhm75bbD2zk8xZxfkJRZ8xai9yMTYjwrAuOtWqhaRgg/ZoQKUa5wshsT0fBDXs8s6tcBtgp0v1V8X5bMrY3ZlBk5qD9/FVRapouTrI2dZscHUBq0oqEJAcvvJqUZ6c+MZdxucHKBFZzR6kl83UYoTl6uCb8sq+YAiWKxKmIoPHy6VeJl8ZMO4MpJ5H8fbHfUpfK75ndisGQY10bnBBZ6I7FIDiA6o8a2br2NwXXmy23WWW30njVeqg9ow7hMRRyBVmEynPIH08Tps/FPdun7BIQQsnDS18OTpI1ttJh1KtcYs12moUb5ENLD03rQow2XVsX0WC0vvEat0A4Qjq0+In9lBDpw1LCS0Sdll0M0BVcYAAenX0V6AW9AIduA1brrpO+twoZM2j83Tnf0E7+R7RbFcwVaXH5HSsMrdnUOppXJJbK2Ff4iWGqW+Nwe4HJnhSsRlr5YoesNsvXqC4L/1XsKD88TFO/7TUMjnmKRmM/SDl9ge2eqX8DzEbyD+VbPaCnxkuTpz0sWPzTCMTNuyg+nB7Jzu+Kfh/Q7pHJR5mMQmU49AiAPXgRg LxaDgNyb ELEF4i+OllfEP5T7zaxc8heYXNV5BmmAb0toCOEpgf3l82yiyRDrG5NY5wO61OCjtQxx2BTpKvf/BQlIzjjxvNdJQePYh27ScRL1gZKKuO50tgdJRd+G8dG2cjA9E/9NGXO5TbQhvnoGwI8PTiW20bHHWbl7OsdoVxmUMU53jxWaut0D+EGHbtk2A6tEAYOchpxyweAVKh5YtQnXl85vFhTVPM3j4zoovgIDUw87uZeEChyXm4yHQqUby0piX79x3f54NNgScY0JmKjS6x695SRzVNBn8tkwqO6pKnAECuq0TBStaIcj0UmLHdn+Zxk80leKKOSmQ/0cThESONeqbWuXegy2YFxm5jT5UPZlF8unI14ahJWL7hgKrNM7G10uVzYiHmR5yXKyPluE92sSJ8OmQq6QyC0tI0XaofNBhnu5GsPOEQmfZ7FKa4DvRqkjLmvXQ3fbM34jQ9VI+u/9WWS7dxjJbfkVygZT5DtFyNs7o/dc8gDIH4pftMiLZJeBRK/3oonJ9eVILfqcryxz8Glfnju6InEMmeYng X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 5:20=E2=80=AFAM Andrew Morton wrote: > > On Wed, 24 Apr 2024 23:46:59 +0800 Lance Yang wrote= : > > > On Wed, Apr 24, 2024 at 12:15=E2=80=AFPM Matthew Wilcox wrote: > > > > > > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote: > > > > When the user no longer requires the pages, they would use > > > > madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would = not > > > > typically rewrite to the given range. > > > > > > > > At present, PMD-mapped THPs that are marked as lazyfree during > > > > shrink_folio_list() are unconditionally split, which may be unneces= sary. > > > > If the THP is clean, its PMD is also clean, and there are no unexpe= cted > > > > "If the THP is clean, its PMD is also clean" can be confusing - sorry. = It should > > be modified to "If the THP and its PMD are both marked as clean". > > I made that changelog edit. Thanks for updating, Andrew! Lance