From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0410BC4345F for ; Thu, 25 Apr 2024 04:47:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B4E66B0083; Thu, 25 Apr 2024 00:47:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 263E16B0085; Thu, 25 Apr 2024 00:47:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105846B0087; Thu, 25 Apr 2024 00:47:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E6C9F6B0083 for ; Thu, 25 Apr 2024 00:47:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8849FC10E2 for ; Thu, 25 Apr 2024 04:47:56 +0000 (UTC) X-FDA: 82046821752.30.D2D0E1E Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf20.hostedemail.com (Postfix) with ESMTP id CBA251C0002 for ; Thu, 25 Apr 2024 04:47:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VU6zjhgR; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714020474; a=rsa-sha256; cv=none; b=y0as6vbsmc4IYs/+pt4z2+0tepHYmsrAhUd14ZRRAL043LVfvLzV5aQbZgzHHMspaMU9/t NQZu+8QU5WXubKj5vVyY6qEyUvPk507Ld8T6i0qYgmXgWuvwbgTTLEEeFRRsFQy5JwGXLb BwnZSmVWK5y1IPfgaHoParceCOJw+vI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VU6zjhgR; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714020474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jpo5EwUdOC96YukS8QWkRpGkkyVlX6pSgH/vTHIzZok=; b=nezOK7z1+cn/zKzh12EgcsMOoctoq6OlzJDofhWEGOhEaoVy9gGIllvQRnSneKpf52UNDL B6mRlVS8X8LAvvbmoju3T1BbP/iItQKBtwuGLblb/huwgTUBTybfnrxXckMGTbPc7Hmvth HpV6h+SS423g7E9epnJsdrxKcnrQqP0= Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2db7c6b5598so6708361fa.1 for ; Wed, 24 Apr 2024 21:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714020473; x=1714625273; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jpo5EwUdOC96YukS8QWkRpGkkyVlX6pSgH/vTHIzZok=; b=VU6zjhgRVt4uwM5cYgyRNnU/93ue/CCcHWWl1IyQmNYhgdXjjm+oM5Bedpe8ZSlDsI qaHvzUDXLKR+N6g8Su5DpfR4sqDfTbZHSg0Lj0RZ5hz8ZcU1eSv0JWkKkh5HXHlfgFNj VBITLr6nnkMkmYKiEIiRhZpVzysIkEuvKnwRJiogpyH6ZTNufH2caHjY+OjTv0yw9GCP qOOKUrIYdSkIbZ3r96zi25flygeB9opIUFhyLhi+Ug4ggEF/oHt5VGQ1XpRybZDcosOj NdtKJRZu1boCCKOoWCsxXjimUddwx9pU1yjx5GvbSUgbVffQLxY1gyEyarZKJZaTWMVr dDnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714020473; x=1714625273; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jpo5EwUdOC96YukS8QWkRpGkkyVlX6pSgH/vTHIzZok=; b=defGk3Dl/qIvnh2MFulWpYLx/IbKXbX9D+Ve/3ljJs2LDk/MLNNDnEk21nDKbsSFrc RPSuU9/zoareiy6wF7pOp22VELgrm3MwAe0+k76ZbRqz1tvn9HXYNDFU5OUWWt29x+p6 NKKBeGDBHoHW9gjwNyohExxJGqF8/ZxseNxhMPx3guHZviVWSHpV4wgz6bdxLWdobFxD DWyaIs44appLeEpaYzVjSL/TKJsTxvkZkO6sB97J5V9oVihXULKf8xUBgP18k672IaFU 2IO5eZWGjWkewtrvToWI2NZA6OCNLgbvb05u6XCprEmguRhs3WwJAtQkYDwfjc5jSEYG lfEA== X-Forwarded-Encrypted: i=1; AJvYcCUXyOKyQiVPKG1XPx1/zOSh6q4XLumWCLubCnURGNWKWiQ82hkKufqI5lLj6z5VxK63rCvfYg57EqNX3I4JojZxnwY= X-Gm-Message-State: AOJu0YzJbF+pV6GWvzUYOr/ehvWRTxwSk4gYxEntQVOGJMfNzn1tD2M3 yHlS5bV3M0B36WFK2UVXy23ZzUGoMXpHr78w+MHutvQ4621+gUOtMdkWg8st8ZNrD6dEielbLf5 d1YGKNDxcFHlLlg6qlaAr9USfWfM= X-Google-Smtp-Source: AGHT+IEcY1PB98rnhwReQi4sQiaQRD3HiP5OZtKx50yyJPlKlr64VRSTvtpWF+5AibA/pSQcllF/WKGP5xjT3aSQxY8= X-Received: by 2002:a2e:2c0c:0:b0:2dd:372c:e7bc with SMTP id s12-20020a2e2c0c000000b002dd372ce7bcmr3030160ljs.31.1714020472863; Wed, 24 Apr 2024 21:47:52 -0700 (PDT) MIME-Version: 1.0 References: <20240424135148.30422-1-ioworker0@gmail.com> <20240424135148.30422-2-ioworker0@gmail.com> <1192295a-5b94-4c1a-b11c-7cd8ef0e62b7@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 25 Apr 2024 12:47:41 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: add per-order mTHP split counters To: Bang Li Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, david@redhat.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CBA251C0002 X-Stat-Signature: epmgd5ypyukocg3abwazt5b1gfk4hy8b X-Rspam-User: X-HE-Tag: 1714020474-66823 X-HE-Meta: U2FsdGVkX1+AWezdDAHjugi3vPtNmcHAqUiJihg4ZnnLk0lFnpuivBNz98ijYxM+XT29RfqVx7u5gertHFLPhBL17CnQcTlJuYus+6HXHnPDo4+2yu9ygVU5AC8fZU0070fyrMfY/whhYBK2Ci0hqRQJTR3CSb21evgTzsahCZ1TxqOSNiVUbBNB0gtqYyZooFZitMjMWAaX0iyV3Vlt3tYe+PsxyqRJuiEZIj0G+sxVbqvaPIun3A+RZoXniWZNzQ4oY5UBdd7EuvXU0MDnejZd1d6bsighiFmLHX3+c2wELrlviq4OT8e3irLVx6OmFXN6ZyOV4D2vh+h3vRzbLMNJDKlJmvgoo0BpTwEcliVjSDpk228S/xtt0zpyM0B8wgJVcEE/TtnvwtEhpAEEzQicT23Q57K2DLGfFg/TA5YzR5EhLqnmqrFK4iAu4rH8Y0EtZYnHjl0yjuR+KJJoPRbGjd2yLm1oLvuRwwGtbpH9WCGpSn8/Fnxm25QREWShEwu/aulgTqnvSgmcZPIS/Z3AX7Go9udIyGX0kdnIBFKfpeJkjkE4ls/vrtK57n2izjA3Y85iCygmaAmua5MpuEFSOFF/bmGQ4hiVaN723mRLc00HuARX/n/q3VdV8zS2/ELFJuoKLrx829KMrDkxBgbjF5QDgZrdONjqUfWMXCqeEJ8F/9ECi50j2SbJShx+jlgqYqDSOJTcEgTz/EEtCPUQsWaSgDqyJEecUZmf6wsPyJVJDLSYbKLP0E6vsnYRhjOV6o0ckGmSIO8WEZAvDHem6Ep/4zfd64ofVJONslVKRzQVJYoKakACCEW3t8bu9knaK8+KKnM1k4q0bf4Cn4dtN8B18nJf6wgmA4zKdDYk8vL0GvPu6UXjLsPVlvx821Hr6dZ1M1uCarNgL/Zo67ApMh4sQteDTkgQrjHv6ObB63qFyalKd2bollH2EPJ0V8hFjtnkreNPbPUOOjL lRocQeK1 /3WPCrbMoTNNwcfJazJdiSbc/1f2ZEZgiVzi7ihlVYnsiaKDlsOwNroRIR7M85wVSeMbLcHu3n3Y789k2Ytnals7xPW7ptj78LoA1Ld4A1gDfHHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Bang, Thanks for taking time to review! On Thu, Apr 25, 2024 at 1:59=E2=80=AFAM Bang Li wr= ote: > > Hey, sorry for making noise, there was something wrong with the format of > the last email. > > On 2024/4/25 1:12, Bang Li wrote: > > Hey Lance, > > > > On 2024/4/24 21:51, Lance Yang wrote: > > > >> At present, the split counters in THP statistics no longer include > >> PTE-mapped mTHP. Therefore, this commit introduces per-order mTHP spli= t > >> counters to monitor the frequency of mTHP splits. This will assist > >> developers in better analyzing and optimizing system performance. > >> > >> /sys/kernel/mm/transparent_hugepage/hugepages-/stats > >> split_page > >> split_page_failed > >> deferred_split_page > >> > >> Signed-off-by: Lance Yang > >> --- > >> include/linux/huge_mm.h | 3 +++ > >> mm/huge_memory.c | 14 ++++++++++++-- > >> 2 files changed, 15 insertions(+), 2 deletions(-) > >> > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> index 56c7ea73090b..7b9c6590e1f7 100644 > >> --- a/include/linux/huge_mm.h > >> +++ b/include/linux/huge_mm.h > >> @@ -272,6 +272,9 @@ enum mthp_stat_item { > >> MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, > >> MTHP_STAT_ANON_SWPOUT, > >> MTHP_STAT_ANON_SWPOUT_FALLBACK, > >> + MTHP_STAT_SPLIT_PAGE, > >> + MTHP_STAT_SPLIT_PAGE_FAILED, > >> + MTHP_STAT_DEFERRED_SPLIT_PAGE, > >> __MTHP_STAT_COUNT > >> }; > >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c > >> index 055df5aac7c3..52db888e47a6 100644 > >> --- a/mm/huge_memory.c > >> +++ b/mm/huge_memory.c > >> @@ -557,6 +557,9 @@ DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, > >> MTHP_STAT_ANON_FAULT_FALLBACK); > >> DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, > >> MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); > >> DEFINE_MTHP_STAT_ATTR(anon_swpout, MTHP_STAT_ANON_SWPOUT); > >> DEFINE_MTHP_STAT_ATTR(anon_swpout_fallback, > >> MTHP_STAT_ANON_SWPOUT_FALLBACK); > >> +DEFINE_MTHP_STAT_ATTR(split_page, MTHP_STAT_SPLIT_PAGE); > >> +DEFINE_MTHP_STAT_ATTR(split_page_failed, MTHP_STAT_SPLIT_PAGE_FAILED)= ; > >> +DEFINE_MTHP_STAT_ATTR(deferred_split_page, > >> MTHP_STAT_DEFERRED_SPLIT_PAGE); > >> static struct attribute *stats_attrs[] =3D { > >> &anon_fault_alloc_attr.attr, > >> @@ -564,6 +567,9 @@ static struct attribute *stats_attrs[] =3D { > >> &anon_fault_fallback_charge_attr.attr, > >> &anon_swpout_attr.attr, > >> &anon_swpout_fallback_attr.attr, > >> + &split_page_attr.attr, > >> + &split_page_failed_attr.attr, > >> + &deferred_split_page_attr.attr, > >> NULL, > >> }; > >> @@ -3083,7 +3089,7 @@ int split_huge_page_to_list_to_order(struct > >> page *page, struct list_head *list, > >> XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, > >> new_order); > >> struct anon_vma *anon_vma =3D NULL; > >> struct address_space *mapping =3D NULL; > >> - bool is_thp =3D folio_test_pmd_mappable(folio); > >> + int order =3D folio_order(folio); > >> int extra_pins, ret; > >> pgoff_t end; > >> bool is_hzp; > >> @@ -3262,8 +3268,10 @@ int split_huge_page_to_list_to_order(struct > >> page *page, struct list_head *list, > >> i_mmap_unlock_read(mapping); > >> out: > >> xas_destroy(&xas); > >> - if (is_thp) > >> + if (order >=3D HPAGE_PMD_ORDER) > >> count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED= ); > >> + count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT_PAGE : > >> + MTHP_STAT_SPLIT_PAGE_FAILED); > >> return ret; > >> } > >> @@ -3327,6 +3335,8 @@ void deferred_split_folio(struct folio *folio) > >> if (list_empty(&folio->_deferred_list)) { > >> if (folio_test_pmd_mappable(folio)) > >> count_vm_event(THP_DEFERRED_SPLIT_PAGE); > >> + count_mthp_stat(folio_order(folio), > >> + MTHP_STAT_DEFERRED_SPLIT_PAGE); > >> list_add_tail(&folio->_deferred_list, &ds_queue->split_queue= ); > >> ds_queue->split_queue_len++; > >> #ifdef CONFIG_MEMCG > > > > My opinion can be ignored :). Would it be better to modify the > > deferred_split_folio > > function as follows? I'm not sure. > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c index > > 055df5aac7c3..e8562e8630b1 100644 --- a/mm/huge_memory.c +++ > > b/mm/huge_memory.c @@ -3299,12 +3299,13 @@ void > > deferred_split_folio(struct folio *folio) struct mem_cgroup *memcg =3D > > folio_memcg(folio); #endif unsigned long flags; + int order =3D > > folio_order(folio); /* * Order 1 folios have no space for a deferred > > list, but we also * won't waste much memory by not adding them to the > > deferred list. */ - if (folio_order(folio) <=3D 1) + if (order <=3D 1) > > return; /* @@ -3325,8 +3326,9 @@ void deferred_split_folio(struct > > folio *folio) spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > > if (list_empty(&folio->_deferred_list)) { - if > > (folio_test_pmd_mappable(folio)) + if (order >=3D HPAGE_PMD_ORDER) > > count_vm_event(THP_DEFERRED_SPLIT_PAGE); + count_mthp_stat(order, > > MTHP_STAT_DEFERRED_SPLIT_PAGE); list_add_tail(&folio->_deferred_list, > > &ds_queue->split_queue); ds_queue->split_queue_len++; #ifdef > > CONFIG_MEMCG thanks, > > bang > > > > My opinion can be ignored :). Would it be better to modify the > deferred_split_folio > function as follows? I'm not sure. > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 055df5aac7c3..e8562e8630b1 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3299,12 +3299,13 @@ void deferred_split_folio(struct folio *folio) > struct mem_cgroup *memcg =3D folio_memcg(folio); > #endif > unsigned long flags; > + int order =3D folio_order(folio); I'll consider storing it in a variable earlier for later reuse. Thanks, Lance > > /* > * Order 1 folios have no space for a deferred list, but we also > * won't waste much memory by not adding them to the deferred li= st. > */ > - if (folio_order(folio) <=3D 1) > + if (order <=3D 1) > return; > > /* > @@ -3325,8 +3326,9 @@ void deferred_split_folio(struct folio *folio) > > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > if (list_empty(&folio->_deferred_list)) { > - if (folio_test_pmd_mappable(folio)) > + if (order >=3D HPAGE_PMD_ORDER) > count_vm_event(THP_DEFERRED_SPLIT_PAGE); > + count_mthp_stat(order, MTHP_STAT_DEFERRED_SPLIT_PAGE); > list_add_tail(&folio->_deferred_list, > &ds_queue->split_queue); > ds_queue->split_queue_len++; > #ifdef CONFIG_MEMCG > > thanks, > bang