From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04101C48BF6 for ; Tue, 27 Feb 2024 01:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883D66B00B6; Mon, 26 Feb 2024 20:48:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 834396B00BA; Mon, 26 Feb 2024 20:48:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D4106B00BE; Mon, 26 Feb 2024 20:48:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 564876B00B6 for ; Mon, 26 Feb 2024 20:48:48 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30BF21C0B5D for ; Tue, 27 Feb 2024 01:48:48 +0000 (UTC) X-FDA: 81835899936.30.AE098F6 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 94098140013 for ; Tue, 27 Feb 2024 01:48:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H+sEAW4Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708998526; a=rsa-sha256; cv=none; b=0rZHYUANeWv/UTX9LjQPwmuhd9C8HKNbH2x3OOMva+WU0ptbYmp7zUz142FioYrfvVY7hD IUi3EdI8MT9XXMyy8rpi/p4E04kta45sI91xC2+77uhkHZOc0scqOITHj1rrlFoQcZDHHz p8G3IFHkVNlAv1b1e08eDdCooftZqc8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H+sEAW4Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708998526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Q3okeBK/888jP630KPQ8RoIb8Z1wYCvm95ViNJwrqE=; b=jPU77iVHPil+6UI9xFO2EA9rnoT61ILisP7GzclR7cbRqQVD5Ls016VGHGL0UYkyCVJ+F7 sD/ZPTDpJ/NHZD97Db7t1KoTyoIoBgyS3/+BDh/3OFOQzBlePew9YUy+2rrhKsPZ748ut5 DwOiLAZKIPDJJ4JwlRsHnODzVy+GrWU= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-608cf2e08f9so31422907b3.0 for ; Mon, 26 Feb 2024 17:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708998525; x=1709603325; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3Q3okeBK/888jP630KPQ8RoIb8Z1wYCvm95ViNJwrqE=; b=H+sEAW4YKBwKnEwEBoSkK3txLCBpMcFHNiazM9yFsR5/a9I4X30cz3ngbeHB5jNjU3 nate4+MhPc9IHYI7x2mIjHqzYW5WYIiNZ8+rDWzHwUuBnXdML4a5nwXerl4AoGXhMHbR 1K8vOx4C/8iSA6ndMGeirbNeasD7PXs+sxkrlLpNiXePtUwL7/GSlI00KIgA/x/drT3h 4UXsLxX/eePivi51ZpTaOR0boN6ZpUNnOFPSuAWxd5zgfdRyPJMHhKNwAeOq/0o4ECXT YnXb2kCg+D6KWuV8Yw5WyT52Ljp+cVLoMKl0TH1aUwyTPjW0rFmuKg4FXgBeW63dUqPV u3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708998525; x=1709603325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Q3okeBK/888jP630KPQ8RoIb8Z1wYCvm95ViNJwrqE=; b=Uv1sIaHIhDjL16MwQSBXGie2AqJUVpOQeus2xMq84Ab+ueOp8dOLi+fProDVmnp0C1 StaB5ks27w82bwqoCXKtuEe8cmshqEOW9IuMloouwwWVOqOSK1Sq+xhWpmRiQxk1l82B MCe4KWq5Kv1SwM+EjP579SR3MGRMP0GGBWV025PQ+LOaEN3VbTgEx3WwhULzNYPi/2R9 tpINPZw36RwEW1kvDEIVMeF7ZhjnBAbAA7OihwPEPUE65wrakssC78G1IZt6YEUYX6jw iWotzOiJOVapPa+amvJ9VcoN32pf1oYEzSjSUFn2/X3ZgQTqBM/mKYUF2DJ16m1FLuqw TdBw== X-Forwarded-Encrypted: i=1; AJvYcCUah7k6sa2KjNzFKizpdOIzmN0hTBaKkzG8YJOxSipXVoU3PVAWOD8ZqeLfQ8mrfeOBdTjgj/LO/w8xgLeR2SqkTZc= X-Gm-Message-State: AOJu0YwuGaUaSaXT0bju7SvoGKIQJnHmNiy+2CzYUjO7OFcjB1phcOgJ 5DQ/vP0iK+e5pXKMpj6sot8XFN0H0VSLXIC/JQOxsXitm09eKUKmH1vXJyraxagryWvOnZXJWUB yKRQxD/nfhoEPXkMbWXxh1iJzFu8= X-Google-Smtp-Source: AGHT+IGEtkH5U0Ho/pR/EiR+6jzzUK8Pzq+Um5FnixRZ1QQY5N9BT0sDFGamb+RN2Ibx1R8bnBmjXjvwMSRvXoRJi6k= X-Received: by 2002:a81:a9c6:0:b0:608:15e8:9283 with SMTP id g189-20020a81a9c6000000b0060815e89283mr824256ywh.3.1708998525650; Mon, 26 Feb 2024 17:48:45 -0800 (PST) MIME-Version: 1.0 References: <20240227012127.174048-1-21cnbao@gmail.com> In-Reply-To: <20240227012127.174048-1-21cnbao@gmail.com> From: Lance Yang Date: Tue, 27 Feb 2024 09:48:34 +0800 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, david@redhat.com, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 94098140013 X-Stat-Signature: nb7eiide96ewsipg3t5aqrh8b18wkesu X-HE-Tag: 1708998526-490269 X-HE-Meta: U2FsdGVkX1/2SK4ntKkI59xF98IXm/BX3NoQOi/zyickyo9EqWDIzMlbM6VO65PUGvDBF/5hGSHzZA5WtTVDiDuRco+DuGSYuIlzNG/ADznyXKPI7xmvpSuXy3ERlT1cxpPI1x1VOYissHG4BDT497kbmBXZKLIZuzuXFbV2LLa6Jb50Ej28JIcKwtVUAi/XeL4mpIq8IKG/JULuwq8w1PWvQc2OFXIoC18Hq78Jl/58na3RCCRH6n2hK3slQg+0cLV/Qyx4pH76tD07xIvNaaBtBvKaWkFsCLaYgqhPeA8GaPAs74BTKXoT/pumQbH5LjM8+CEUqCBh+s7RDcJqkbTa+Vc3X0uqQbAJGwii0a2wsWs1BtXNHFxyA95KHAUJl99k8Ro5IcD1A/+vSu7A6cSeUThH5ZJXkDbA2utgMiElEHL77d3W0YPl6/6RUHlRS/rHIJHMMi+35BKLHOizYGQVGVhA+JJZrt4NjusqeoJ3pqXCO32b+G/UDo59QfjxhHH8N4WOvoqjLl1N51viQSqWMK3qxumM17M2RfQcgi56lUb3cxLyj13yqeISiQbgQJHA2Y1Jnn+uFbIt7dW/b/C+jFekVLvHW/G/RJi4xNa0MgnZXS9k+UrCYCh32+A+KX5fbKa+Aekp0sfP3NkST978dneBbwgqhDpI9UJKc5HR/s07fggy+gXIP2eB6QvHwbEqz/1VGPapkULMPsTseqvaC8kBW9Hs7Wk27Z0Gwg9uLm7vAt1EFL0mrSnmWH6NLyYm877fAnOLowtp8NybDQhlqdwtBekWxdwMaBAvwyfjyReuTc4EphTmn+qRX9yy1e1AXeTWa1KIsoEtP+lpkPBi/8hBVpQycRxcM3yL8FPMVy8Fg0sL81cMLTiHFk86zPFcAfpsk13KAeAdPlOnYAZXLY9/bHEPG/3hyAxE3YjiTNTHNp4nDz0htLXOSWwNL1CLRfclLZwgrAu2bt9 Zed1pURm sfosK90q6atgRSR2rRY2oesGtMON5Wo3g4dzLi/EhVJpQCbFQSzlpyNE2eW9Y6Xu/09ceWT/XAAgJ+yajzw05lFjTAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 27, 2024 at 9:21=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > > Thanks for your suggestion. I'll use folio_pte_batch() in v2. > > Hi Lance, > Obviously, we both need this. While making large folio swap-in > v2, I am exporting folio_pte_batch() as below, Thanks, Barry. Could you separate the export of folio_pte_batch() from the large folio swap-in v2? Prioritizing the push for this specific change would aid in the development of the v2 based on it. Best, Lance > > From: Barry Song > Date: Tue, 27 Feb 2024 14:05:43 +1300 > Subject: [PATCH] mm: export folio_pte_batch as a couple of modules need i= t > > MADV_FREE, MADV_PAGEOUT and some other modules might need folio_pte_batch > to check if a range of PTEs are completely mapped to a large folio with > contiguous physcial offset. > > Cc: Lance Yang > Cc: Ryan Roberts > Cc: David Hildenbrand > Signed-off-by: Barry Song > --- > mm/internal.h | 13 +++++++++++++ > mm/memory.c | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 36c11ea41f47..7e11aea3eda9 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio *fo= lio) > return (void *)(mapping & ~PAGE_MAPPING_FLAGS); > } > > +/* Flags for folio_pte_batch(). */ > +typedef int __bitwise fpb_t; > + > +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ > +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) > + > +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bi= t. */ > +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) > + > +extern int folio_pte_batch(struct folio *folio, unsigned long addr, > + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > + bool *any_writable); > + > void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, > int nr_throttled); > static inline void acct_reclaim_writeback(struct folio *folio) > diff --git a/mm/memory.c b/mm/memory.c > index 6378f6bc22c5..dd9bd67f037a 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -989,7 +989,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t p= te, fpb_t flags) > * If "any_writable" is set, it will indicate if any other PTE besides t= he > * first (given) PTE is writable. > */ > -static inline int folio_pte_batch(struct folio *folio, unsigned long add= r, > +int folio_pte_batch(struct folio *folio, unsigned long addr, > pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > bool *any_writable) > { > -- > 2.34.1 > > > Best, > > Lance > > Thanks > Barry >