From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1E3C27C6E for ; Fri, 14 Jun 2024 07:49:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8C846B00B1; Fri, 14 Jun 2024 03:46:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3ACE6B00B3; Fri, 14 Jun 2024 03:46:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDC256B00B6; Fri, 14 Jun 2024 03:46:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE75B6B00B1 for ; Fri, 14 Jun 2024 03:46:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4F6AB14014C for ; Fri, 14 Jun 2024 07:46:49 +0000 (UTC) X-FDA: 82228712538.23.56C7DC5 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf26.hostedemail.com (Postfix) with ESMTP id 7C941140007 for ; Fri, 14 Jun 2024 07:46:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TtGToTPh; spf=pass (imf26.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718351205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sINVLGrn2l3nObO3lTzserdUkLo1bsT+2+A9FNq5GHs=; b=P28vz6t4sY4Uld1qDBNZdvEZa0TWi7DHtq7dziw3yxl41fqBhMPSiIUevjujfNFzGNMtH6 Bd6WIuAErfKIWXBD8+q/Y0oYva2rGISRDHQH+6zI0q2jbt/W4wBO3FxVb1P31cE9Qhhd5g 9LphsvHmi6PcdxWX9rGppF6VaDQAuiw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TtGToTPh; spf=pass (imf26.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718351205; a=rsa-sha256; cv=none; b=KQ0pjo+FI51nUeTYBZTXuOkPD1MjAK1St7gCbhUhZ0Q76yT+YqLTMqtTAnjDuJmuEryJ/V onY1TlJnuA0SsOYqAt08NCBWOY+/ncqmcny6t/uuoZHjMk1SjYsx2Cug4K0MDI+1IvMaU9 Ofb5MK6b5GJoUQXTt7gfI04R4JkJAf8= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57c83100c5fso1917440a12.3 for ; Fri, 14 Jun 2024 00:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718351206; x=1718956006; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sINVLGrn2l3nObO3lTzserdUkLo1bsT+2+A9FNq5GHs=; b=TtGToTPh2vPm4jEV9HJhsA8lUZwH0wQdo9Sro0caiI2KV1Zh59CRgQGErSaSVEwSQM qbXz570x9494ib/Qw2JDQKWIFtJzT1eKMkjK0Z/h82BxxorC0FEZc2D/PK4ujr0yFAsl 5xCZSjZZZdfsPjFOvX/0XEshws42VQ3nIaCspdDaBv3+deWkq4sSzEWpUcnh7rmXoSdP l5WoVzQ/BZuZkNhe5oHTCq/u3DLNqWC5/ckNvMJ1x9EHZxEPRZXKH0M3jGGU/RdJrEUV SNXqPQmPMqXygU3EPz+6OvlyUThUsRO9zF2nUSP+LkTCTwNCwUZ/oFi6XdF7FIA2RsCM V9ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718351206; x=1718956006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sINVLGrn2l3nObO3lTzserdUkLo1bsT+2+A9FNq5GHs=; b=TZEhd551tL5+BezOoDMjhSkpboDttQ3wTZWsbj8Z2BDArPYZcdsOFlcadlujjAIXJ7 8E7DZTyyyVpCYJSiAtV0XodmPrfF9NHeygk3CWh/iLj3TiGda4GG8FS7HitpxXEJwbee y2/lLvE/gdtRNwmkRDqCgNzTg72HZFM4Pr4bJvMg7Ec+2lCPtRgWbBNAX1Y8HUigCWhU TJ9UIJDlwo17FGXWc75XJr5X99soV15v4Ru+1KIZiu0Xw4tZs4M2YIgh7aB9D4JEy2GT ywqUQeD+UbfV8+1Q6bFxM78VqpGBtGRxkv1s+02l0cgK7WJzX7iIWVpm2wVlkcOj7CI9 8+cQ== X-Forwarded-Encrypted: i=1; AJvYcCVG0soZTn2fiuxY6s1ANjMwUCAn2tKbqgmhiZMb03VFJvq6WvxV4X5BiBaE1wKkhU0J0cyV88SRonr8OLVrAVTInDc= X-Gm-Message-State: AOJu0YzKxgp8EgLbuKFqVX9Pj40VXZLVMyjcFY/0PYDDLGmXab4ubJjZ XziBWJhMy3fm+GLl8CyeUEyZJXxBEWGVfrhJahcsT9/Ywa7OV+Qrjzxmkn5LpvhASAARRnmfPhn 3dRguO4vCnI1r2TIURzrrUFBvmAk= X-Google-Smtp-Source: AGHT+IHkgCG4131CHp0LXyXkxosqyByTHmrFjfdkkkIR+ZaUjnuDFp+AdcwdUwSsgBABzH4njOXb6DjQ1jZUjBggOFU= X-Received: by 2002:a50:8746:0:b0:573:5c4f:27a8 with SMTP id 4fb4d7f45d1cf-57cbd8e7144mr1297235a12.35.1718351205549; Fri, 14 Jun 2024 00:46:45 -0700 (PDT) MIME-Version: 1.0 References: <20240614015138.31461-1-ioworker0@gmail.com> <20240614015138.31461-3-ioworker0@gmail.com> <24765af3-2f2d-4451-9d9c-c35784ae95c6@redhat.com> In-Reply-To: <24765af3-2f2d-4451-9d9c-c35784ae95c6@redhat.com> From: Lance Yang Date: Fri, 14 Jun 2024 15:46:34 +0800 Message-ID: Subject: Re: [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop To: David Hildenbrand Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7C941140007 X-Stat-Signature: a8tpbm6sti6sbr7if7ny1nmbc8hbp1wt X-Rspam-User: X-HE-Tag: 1718351207-114021 X-HE-Meta: U2FsdGVkX19fLGnTSvna8nfhib5LFbSZhwDF8smG4q/MlzMT6YniCcX9UHed7WyqR3an69fp2keej5x6HHVD1z2vk0kFz3vgQiLYoF3wJWOdyMBYcX8uKIa3EnUXPFnslXE/ydzcUimWA82iNFWdU9hKR2879vGDRKbs/qemeoxyMrYWIuHWnKWXgOJMato81mvSnm/30qx84+RkAYUCHjscGY2hGokEvX4IMhadw8fafx7+SfVkS8nml8CO1Ukycig94hK+rjYfCvWWjD15jkKKmWjXJvWFVz2VGiwJ5fMRCVdM+Z8r2PvOAgyY3aJbxnbYQwMGKsTFWVPCECWBTIzhyfXVJj9ItRCmG8g2XJ5KzRuCPHOwPcBNrCXXyfUcLZciMAYcS05DwMmxwbyZortxgY1sO4PNol+2SFkxEYYdPQEkpjsfKk8s3nFap8aBfzAkql/ibzn/SmQrF6HgoDW0DQRHnS2f69cdLCPAejfX3ifnJXlGBJKaD7eg2utD/6Xd42UM1WZdeCDg2GfFL5Fdgn9d3k8LxxnzqHt9cP1SMkimM7Wf6x8uicRzD/zO8vH0y7UGHp+KJgYrSLJyt/aLgCbp4PzSNzcaJT5YLLBxnQzwe2/5MaapjJtNlh0vlqFttjzNSEo+dXAavYFDkByNaFgfE4mApdz8vbaMHOoHGXbJheu+q3xBBsT2N07s/T/YGPRR5XC21fbxa7tIOAXtPUIdY+YpX9I+pbk3mTC4zp1BmkzpG1S9Nh5ZLLqoZEHkSwdUF3DHTXs9wJgwWN4efjDXlb8bduOrKB3JeWQoUNp46qbPxr+lCARDwbIT6x68w9u3htsll9XJyPvpi07iYFVGl1AMAGegUJ56B9fuUETH2L5coUjssXbLdPY8KEbuL7XmJtvhAPi7zEIdbVAokBoUJEeYBWLyeW71a/GvGowNdSiqQdvd4bqQSqJKYlDPpQUE+hgjqJov7jp odup/Sx1 AHDW6B5mu2pofgOIagoKNgafw7U1sVc00O9G98bG+9FW5hM2K+fUlZpq8oARTlgxymqjt9GJbMAUDwwlQA5IgkzjdZ4zInRg/gKBwuYKCPgzjkfJQd226aHly29cU0e/jyqkLqKRwKuWKHPKrgoKGbk62x6t2HtioGlXS9N2yHq4QqJBVYDzmxCQLx8u3Who3svsZxgjd7IASGoWfVwvl9nthP3+khQEOxuRLzC9Zf8NQ2IxuLRrA1i7Au1+uFb/A9hsYF6oqA6XKb9UCRAxOMQmF7zsX/dStqb62+V1wN9HAYxvgMDH1lCfDLDIE8caaPyiyyUyQIEojoikr6CF5uiIIwPOmtF7QQOryXQRzNhQiZO/j4NdFzTlQgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000703, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 3:34=E2=80=AFPM David Hildenbrand wrote: > > On 14.06.24 03:51, Lance Yang wrote: > > In preparation for supporting try_to_unmap_one() to unmap PMD-mapped > > folios, start the pagewalk first, then call split_huge_pmd_address() to > > split the folio. > > > > Suggested-by: David Hildenbrand > > Suggested-by: Baolin Wang > > Signed-off-by: Lance Yang > > --- > > Would have converted that VM_BUG_ON to a VM_WARN_ON_ONCE, but it's just > moving code, so no big deal. OK, let=E2=80=99s leave it as is for now ;) > > Thanks! > > Acked-by: David Hildenbrand Thanks for taking time to review! Lance > > -- > Cheers, > > David / dhildenb >