From: Lance Yang <ioworker0@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org,
baolin.wang@linux.alibaba.com, maskray@google.com,
ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com,
mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com,
shy828301@gmail.com, xiehuan09@gmail.com,
libang.li@antgroup.com, wangkefeng.wang@huawei.com,
songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop
Date: Fri, 14 Jun 2024 15:46:34 +0800 [thread overview]
Message-ID: <CAK1f24keXQbx8jh=Jd27mRk4Km-viyMLcQh=VqReG7LLzYCCXQ@mail.gmail.com> (raw)
In-Reply-To: <24765af3-2f2d-4451-9d9c-c35784ae95c6@redhat.com>
On Fri, Jun 14, 2024 at 3:34 PM David Hildenbrand <david@redhat.com> wrote:
>
> On 14.06.24 03:51, Lance Yang wrote:
> > In preparation for supporting try_to_unmap_one() to unmap PMD-mapped
> > folios, start the pagewalk first, then call split_huge_pmd_address() to
> > split the folio.
> >
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Suggested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> > Signed-off-by: Lance Yang <ioworker0@gmail.com>
> > ---
>
> Would have converted that VM_BUG_ON to a VM_WARN_ON_ONCE, but it's just
> moving code, so no big deal.
OK, let’s leave it as is for now ;)
>
> Thanks!
>
> Acked-by: David Hildenbrand <david@redhat.com>
Thanks for taking time to review!
Lance
>
> --
> Cheers,
>
> David / dhildenb
>
next prev parent reply other threads:[~2024-06-14 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 1:51 [PATCH v8 0/3] Reclaim lazyfree THP without splitting Lance Yang
2024-06-14 1:51 ` [PATCH v8 1/3] mm/rmap: remove duplicated exit code in pagewalk loop Lance Yang
2024-06-14 1:51 ` [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into " Lance Yang
2024-06-14 7:34 ` David Hildenbrand
2024-06-14 7:46 ` Lance Yang [this message]
2024-06-14 14:26 ` Zi Yan
2024-06-14 14:41 ` Lance Yang
2024-06-14 1:51 ` [PATCH v8 3/3] mm/vmscan: avoid split lazyfree THP during shrink_folio_list() Lance Yang
2024-06-17 18:04 ` David Hildenbrand
2024-06-18 1:56 ` Lance Yang
2024-06-22 10:00 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK1f24keXQbx8jh=Jd27mRk4Km-viyMLcQh=VqReG7LLzYCCXQ@mail.gmail.com' \
--to=ioworker0@gmail.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maskray@google.com \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=sj@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=xiehuan09@gmail.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox