From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4FEC27C4F for ; Thu, 13 Jun 2024 08:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DBF16B007B; Thu, 13 Jun 2024 04:49:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38A4E6B00B6; Thu, 13 Jun 2024 04:49:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 204326B00AB; Thu, 13 Jun 2024 04:49:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F38706B00B6 for ; Thu, 13 Jun 2024 04:49:54 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AEFCEA0847 for ; Thu, 13 Jun 2024 08:49:54 +0000 (UTC) X-FDA: 82225242708.03.1D56C29 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf27.hostedemail.com (Postfix) with ESMTP id DB81D4000D for ; Thu, 13 Jun 2024 08:49:52 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AglhS68E; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268591; a=rsa-sha256; cv=none; b=LIYuaOFI5khySqDpuW3lJAYhjJ/Hflyw1gnJ/L69fcNKucsoZ37IDscXWb1Jrp8+KZErxR LMCzajNKiTct7EOZ/i0aExDqLct4RTZWMl/trAzuClKEtdPWX0ao8pjDKQ/y+yxAW5D6QF +/F7tfjfPA2LVGFDarkPNcsSjmV219w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AglhS68E; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f9zjtO9AtabnLNuJxqiPcWb5sV8xQYdL18OmBwU1Kd4=; b=myJHih39xkhQRACROcn867+pvjw66wOSx61DxdxM22KYbkjS1yGD+yFtRWeNBtNquGS/1R TVo6m2eUm/L96v3z+9zvn2irUoyzE7CXDJ1iZkSxmSCRiAk0NcPExuKYy0bqMetE9Obt6Y kC5ZNajRMpcDKKZjqjt96ZOxCdE7TLQ= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-57c7681ccf3so622093a12.2 for ; Thu, 13 Jun 2024 01:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718268591; x=1718873391; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f9zjtO9AtabnLNuJxqiPcWb5sV8xQYdL18OmBwU1Kd4=; b=AglhS68EDkZ1koYxH2LY404lcyqptonUKGt3VnV3y0VOHAtxnyRI/4iitgHdubU1pN bZEui9JNNEL9vmwPsArBj3/AYcX8X+gfyJXVxzuKO5Hz91RhLkPabGJrUnM8VBm+e2DR jOnY8V2nflI5aNvr0aH+rRsKx1OIm0YA3XTBL/hHOsTwrEjXqPYzPhtALiDSF6YWxN3j aOnaTHroojlceujyhhDPXOh428aF12ZoGMwnHVHXr6x/VtA8SEUEZb+RL2l1guX3dc59 WXBX0XqWuphsvkAf35BvQGKx4ZYmODh8cP6yv+6Xk/n0sWZcO0jVd3pGxiReU3MmYS2f 1VWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718268591; x=1718873391; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f9zjtO9AtabnLNuJxqiPcWb5sV8xQYdL18OmBwU1Kd4=; b=khD8QzRKAWbdawQIFNBWj8l9UqFhxUpEpOubLLGwBPD+9hx+ESYbXHyPZlAyMEfype 8I/tkyyeMK9uFMan79uKxV0uNYzK8sgGbTDSGKw72t4XHYqerwxn/9nnGZ04h1Kot1dD 3Hqj2gtzj2mNBsXrT/SKb55sdBnRos1HYAe45s6q0yQJI0IRGrYJaD4lyRg+/ZXTp0QA jgeTWdhmI/lPGcWyHzqnV2DwnVBz+5sP8XjnZ72r0kMPqNlKZJXAYbUuYwglOpPYIS94 u6S3rvyffLKOEO6Bih5x6fqFHx2Ru3ftLxWOB31HLK8h4Mi9POFyiXyGjishQYKd3rI9 EtBA== X-Forwarded-Encrypted: i=1; AJvYcCUpLPXsniCBrCbyI32VH5/jYIyUXibyowZL+Ib8FfVbCtodSEmJZBZlKePDVaCZU3NAJMzSQAYzas3TOY/rCOLxvkI= X-Gm-Message-State: AOJu0Yw65tNoMmFrD3wz17hkpVkv/5CipyYSslXuaNrcXrSxnr5g26rH OsxWLi7q0bX3IkkssKyEUOpiKYflKQYYcqp277BGb1aBip0YhEzqmkzUO90UJtfINE3A7rrF+q5 REDUx4hqw6K/ozg8nyfR8b07hFiE= X-Google-Smtp-Source: AGHT+IHwOYreymC1B9TPFN1wj6YCfUaTdYq1QGaY2/vdQUfMOFyZMPCj764A6qrN+sEltGa36FWWwsci3aEnDocO0C4= X-Received: by 2002:a50:8e48:0:b0:57c:610a:6e7f with SMTP id 4fb4d7f45d1cf-57ca9750ac8mr2586590a12.11.1718268591200; Thu, 13 Jun 2024 01:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20240610120209.66311-1-ioworker0@gmail.com> <20240610120209.66311-2-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 13 Jun 2024 16:49:39 +0800 Message-ID: Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DB81D4000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1df45owm5yoe7kx8bt89e1uhzw833q6j X-HE-Tag: 1718268592-358322 X-HE-Meta: U2FsdGVkX19Zn31GS/oHS588OQruAvlRLDEybJFBvVGfCcuiwphsBoCOhuW36inR1LBE6aVHNQhyD1BuFiF/3ZVfY6TCfMa67yRnlwpUi/31teY+2tFNX9Q90/PAkVh21Zh7VwwkEHNtMLNXxkdcdv7pdxywgw7eIRWKDBrADorHoJASVjJOIiuuW4L1v8md3lOM33Wab3FZwzA0k+xdqzKloVlHRCBM8XAKmj/lpfwyuJRZhhCF+IcMssvs03e3SUTUFTT+S3hw8Gs47F3Nff0D+qs4Fn88QNg8FmkVj/JfqEQLLIH0lek+3lO0UnzVE6mBwLtUbfeUw+wDoUuekJdOCgKr6IMLQk2zFNJGywBh2OdpxSEfypNpkyO6NcwLeZEEg8KL7HGO72dDmuVl9vesFvGIAljy5IJrwpzgd3KgVw+fsbIPlYo6V+kSnRLGMTQEnLqpmBNcFratAqBDGDIG2KM8lvmolJlNjG1lamX+SPgieyqy3PxqxUkt/jBfrP5ivg6ZPfOUFXFdh8PklFWCVW9lSxLj51N+Z1hHtZXXHjkVbmZtgBszzJ9bfZJ/9TiWXo9K/c0ReayIIRcyByDCbzsfNt4pfcJ6BUivgtdanPUmabfm0Vw4zfHGNedRhq2Pt0LXAztA+KoyKas3uIM8plFWTKPefGqao7uU8CwCx71wQE5CcO3+5sCsIfGqlWZrCNRP5+vJiUorsMBKDXtpkQlz75xWkhvWujjED7Hg1WaTXziT0UUwE0q4lXN2CbAUjs9jn8kHANAhKxi+ad557fpdEAtkZRJuRqYH3i5eWS23bJiaJJkauSyi3JC7it+nYIga4bUb7MddOoo18sCTHthMD3LnF217KaNs7tCC0o+lV/v/ZqfkV0o8TH7RdDPPZE8l6HVaFaEBRpbVd6Rf0B5vvD7SvTRJTEOs0DFvJPRoEnp08bMni3dNAC1ZRpsMSx8hcew4tLlWqvN 7aVnoo9t 7uN8sCJ0LJkj5EoUMroi/66pAMboTpuOhUCvgp2aG6/SFORazhsbP1otRjWHXRVasE+/nDNxDYX1910e5VyngFRPkANN/1cQn4v5joymKv5yaVGxDaFYvmbzwNKotSju0R5qdCP0azMyUoNiu7NGYcIjXm+G9Dk6ZlN/WMqy9MsgbxmbPbYzZolCeLoAph8nSGTYwwgtkwMQYCxTXRxjx5gfDOVn9/CIvzrExAt2q7f70aNhdZ4u9T4K9x31THF/JbCkMzExaTPY39p+WdUImcICYWMqzlKDMVJRz4p2z6OmpPCT4BHF10hZ9igfX1/pYkH4XpU5Hb4d7JVwa/uIyh2WOaGNAhrjhbDtYzToV9YXTgVyOtTJY2ZxqiuUrFXH3+UGYvU7+Sf1840s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 4:27=E2=80=AFPM David Hildenbrand wrote: > > On 13.06.24 09:52, Barry Song wrote: > > On Tue, Jun 11, 2024 at 12:02=E2=80=AFAM Lance Yang wrote: > >> > >> Introduce the labels walk_done and walk_done_err as exit points to > >> eliminate duplicated exit code in the pagewalk loop. > >> > >> Reviewed-by: Zi Yan > >> Reviewed-by: Baolin Wang > >> Reviewed-by: David Hildenbrand > >> Signed-off-by: Lance Yang > > Hi Barry and David, Thanks for taking time to review! > > I don't think "return false" necessarily indicates an error, so > > "walk_done_err" doesn't seem like an appropriate name. > > However, this is a minor issue. > > Agreed. As we only have a single walk_done user, should we instead > remove "walk_done", keep the "page_vma_mapped_walk_done" for that single > user, and rename "walk_done_err" to "abort_walk" ? Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and let's keep 'page_vma_mapped_walk_done' for that single user ;) Thanks again for the suggestions! Lance > > > -- > Cheers, > > David / dhildenb >