From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05532C27C75 for ; Thu, 13 Jun 2024 12:43:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C21C6B0089; Thu, 13 Jun 2024 08:43:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 271A16B008A; Thu, 13 Jun 2024 08:43:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 112E66B008C; Thu, 13 Jun 2024 08:43:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7F3D6B0089 for ; Thu, 13 Jun 2024 08:43:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42668A36BB for ; Thu, 13 Jun 2024 12:43:55 +0000 (UTC) X-FDA: 82225832430.03.30B9BF9 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 6ECCA12000F for ; Thu, 13 Jun 2024 12:43:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cuYuyNDk; spf=pass (imf29.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718282632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+xpkY7WSFIBvT9Gb60qWH87G4yPyQPGboaiQzUeWMM=; b=pUHmlJyqphjC7z7Dq0egD2TRvw2guUfMxn1Eev1SB+EUwycfgiMh6HZePWtCISBkzJhasT GpAkwFN2AlFn+5zPyNg3aloaZQMHY2qcZL2w4j2tHVPCoQKvd6/sZD6YCzWgoBhWeLRSMR EmM9vczLnORN3dCwY/T0+QfLzjgn288= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718282632; a=rsa-sha256; cv=none; b=bNzXpPQpMRkFDmbsIZICquWB2p/y7Q9pFD1dwYMR7ykxBdVDTy7NUNzvVCfC28qoCNYW/i Ct+oUV99kSvvVjmSuSWpyODsG+CxNp2QvAIQTK5OBaEBg+73SWNBV0ednYV6NF6YfqPob6 5Ih7DBJQ4S4Hd6NB8sAAZV7sGUxsKhI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cuYuyNDk; spf=pass (imf29.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-572c65cea55so1792228a12.0 for ; Thu, 13 Jun 2024 05:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718282632; x=1718887432; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h+xpkY7WSFIBvT9Gb60qWH87G4yPyQPGboaiQzUeWMM=; b=cuYuyNDkaWFWgXQgOyPXmbcw4uQljyAb/DOYZyynNIo5ZQEFl2c/DrAWNgMaYvvCqN fXztC9jWgt9p7qiVaCzhk1tdrKlVyaE1e0V3G0CuP+DapKi++me4dH9cnnfK7S05/TAg gq2D6gOjPBRoZjramLnqoGmSux1WOOzzAB0SMbR2LsgPa3CU3DJYuTnnfOh6mE8bM3+J 3Pn5NDX1UvSa1aJITm8WrLKdnzKA5KTRQl5NfHzoOyC5bV3jtrtSFzgV1xWDbeSvjGaz rnZSYEeiRoSRl6QKtJ3qEy3R2upfCEYRin2lHpaFWbeOAfvAwVFyAmc/t0vrmKOkrml/ JJIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718282632; x=1718887432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h+xpkY7WSFIBvT9Gb60qWH87G4yPyQPGboaiQzUeWMM=; b=KglnmYC/U3eyy78MltXXOJ7+ASx1DuzapiIDWhsgT+IS4DcmVOkBgjxyLeXaToYT1c +B/KNNSJHXlYQs0f+56yb49yL+R1Nw/n4+l2fDnMlcGH2XW7YfQsBD7JuwaqugRwOiHH BOV3aBAk1dGfSBVnyse3txCEj1BmcLx8nOoTYikWrsu2mqFj6RJJe+FIocGzB8zLN4Qz 88pX82Wvu268abcHYJAyiJi/y3Q4OpLwbEXYQPbQ/EPVTYt9Ln8seqEvYDa1o3iSl73E RP+7Eh2O4T1pDFFsya/s7KIPfQevZvDy0lqYMa5Te5Tlm4UqQ/FaVIH1QdKYCTOkhJ97 G9lA== X-Forwarded-Encrypted: i=1; AJvYcCXjf7AktsWzI0HDBPPlkrV/BUjPq48rJv4iyPwr0AiXvVgv3mpi3fboN/XYLaU4L6Gie3JrebApZwt70QDN9FpUyKY= X-Gm-Message-State: AOJu0YwYcvmpYdlxKx6Ml8gqoORN5gmzkAhiNLLQxfbp6xGSpjM8npGn 1nWcmlCU5qb+NJt0Iy532BGfZRQb+R6sb1PA+wJZi4+D8IqPDzCdspGdIZeznr0MRoe6Tx3G14X slFaNXRR2V/Ig7ozoj92iT+ObRyI= X-Google-Smtp-Source: AGHT+IHWEnhEAG7BIKzNUmdChKpRz4XU/chxrEqTqjIokiG3GESbbaPfbcO1r4pT+VE2ZOBA9+VCkv5DKbE6sUU47XU= X-Received: by 2002:a50:fa83:0:b0:579:fa8e:31a0 with SMTP id 4fb4d7f45d1cf-57cb4bc275bmr2089842a12.10.1718282631462; Thu, 13 Jun 2024 05:43:51 -0700 (PDT) MIME-Version: 1.0 References: <20240610120209.66311-1-ioworker0@gmail.com> <20240610120209.66311-2-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 13 Jun 2024 20:43:39 +0800 Message-ID: Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6ECCA12000F X-Stat-Signature: zz3nethidbz5h4pqfezoi3jdehrsc9do X-HE-Tag: 1718282633-64017 X-HE-Meta: U2FsdGVkX19k1PoP9JpHMXbUUKqQP4MRPZJbKOzSvTfqoIdKQaqGV+MSbAtKWyrqgkYnmhqA5Cy943c2UaS/vpd8oAPYj3jDwYZ7dABUeArU+IiQTg0WIF/XjHs0h0PXvzzUb06oORV9o+zek2Zc8tv9le5LSUHqyPMo6YxERu+FzvJ5RnfJfFWXkoMSJ84QpedJZEosiKcNtJDlmz+SKOVaRZbqB8uHSLCo5yPHMwig/W+miHwCdFJlUPQEaBElSoUkkQboyoxin+hLa/oeNAEqR6O8TXfvJZFLkud/MocNDWPX9XZbkyOEsUGb0q2OPhuqmg5EtiX/XQlKYIOFp4G3HoF2brGaJ1HgasFLOONRYvglrwCZ9jWhxSDZOxNu03ED57OMW3Eg0onpqP620dztl5wedwC/dXoi8nQ0g8lMWZ3J6vq9AG0rV/Xvv2uNvDPRDTSWuUi2sz/oKHQXNvv1mDlMo4FFwXuljngDHqfUDqsSM1jZWlIsbVfLWuJ0DXVkk0C5vCwIbEzkJ3rTtGDJJZKGmpL5+NZDcU71U8waOljNwdRwaDP6hoDTtKgHClzw5Ox6yuGUe6LWfmY2CBiUNs0OCrH5kVnyLDVdTg6IrQeR3nbc99VkN+8Yn7v6wF04hVCiG/IsWPBBIzIo608cvrJ/27bfw53xzp3sMF+MKceRiWeKyjAB4/ilbqNDL262I946n+BaveoS2SStq18BGzHLQfrAC089tZfHhTbFPWJ6Ya0CzFksgHqqHJ0nMKxDWvNC0G9ES84OrthIFwy14Pg3dKyrCEwKnilckeb3qxyd8xO3y9KPbz7Oym80BZvmYY4RdEJBlsVaAemxs+8W1JOk+Lu6J892G8XmPqylyeZp2296eXfuW8gUawDN4HP+BuhNGYOs6u2hOW6lMiZHlJ5hZl7jvTUav6aiFp1bpx70jTLjrpy+BQxR4ZQqoF28N9eiryharNQZVvy ggDyFBEk tnWzGPR6f5FYx6+2OfY5B9NJrdFdyvhuQp/q5w4mJozU5cQAcGPGvYBDM0s+9lOLXYLoKcOti9CDex0Z1I582+NlUrbkgxNezXqBlZDtawpjElS15bOTjiOSW+wajMkIIN3rKUVxEWPFIEcepxgb/zRGip5qn8FrTkG33rZNOvgSUGV2oeBhKjbj6QKzuGpAQjyvT5VZLgnCRCHwsV5yhE6A4NOA2WUaJUvIVK0UBYxrCcHeHKAdxxoJFTBwGi2X+Qn0OOWtcmQaLPiTrRCzaBpfdnpOj52sSeyBKAVGrLKPO1ZJzoYh/IGtS2xWVUQXt6pUQw+jcERRyNkSUfgrO3zU0Ao1SRjglkWsGrt7lEm/dkYllT0w7McqovYL4zl3gNmOjDeIDGtGSgVU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 4:49=E2=80=AFPM Lance Yang wr= ote: > > On Thu, Jun 13, 2024 at 4:27=E2=80=AFPM David Hildenbrand wrote: > > > > On 13.06.24 09:52, Barry Song wrote: > > > On Tue, Jun 11, 2024 at 12:02=E2=80=AFAM Lance Yang wrote: > > >> > > >> Introduce the labels walk_done and walk_done_err as exit points to > > >> eliminate duplicated exit code in the pagewalk loop. > > >> > > >> Reviewed-by: Zi Yan > > >> Reviewed-by: Baolin Wang > > >> Reviewed-by: David Hildenbrand > > >> Signed-off-by: Lance Yang > > > > > Hi Barry and David, > > Thanks for taking time to review! > > > > I don't think "return false" necessarily indicates an error, so > > > "walk_done_err" doesn't seem like an appropriate name. > > > However, this is a minor issue. > > > > Agreed. As we only have a single walk_done user, should we instead > > remove "walk_done", keep the "page_vma_mapped_walk_done" for that singl= e > > user, and rename "walk_done_err" to "abort_walk" ? > > Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and let's > keep 'page_vma_mapped_walk_done' for that single user ;) I just realized that there is another walk_done user, which is unmap_huge_pmd_locked(). Could I keep "walk_done" but rename it to "done_walk"? Thanks, Lance > > Thanks again for the suggestions! > Lance > > > > > > > -- > > Cheers, > > > > David / dhildenb > >