From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682A4C4345F for ; Thu, 2 May 2024 00:30:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C18206B0087; Wed, 1 May 2024 20:30:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA2316B0089; Wed, 1 May 2024 20:30:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1ACA6B008A; Wed, 1 May 2024 20:30:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8100B6B0087 for ; Wed, 1 May 2024 20:30:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F03B41A09F2 for ; Thu, 2 May 2024 00:30:54 +0000 (UTC) X-FDA: 82071575628.14.2975562 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 411E018000C for ; Thu, 2 May 2024 00:30:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MMrGw0GH; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714609853; a=rsa-sha256; cv=none; b=fVfxY0ndrbCGF8XmdDMMOcpZiEn/M0PTrrFB1OTgBYEKzdM/xdmDT2vbddGi8PGt7z69+S 6zYNOBmPgWvMBUzB0QmKGDLu0BaS3IuhpHRNNgd5/dW/uqAyS0GpUWnCCTEEGEyIPmi98h M20P124eNbOf2bc1ufBLHuvNTMJhLbg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MMrGw0GH; spf=pass (imf24.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714609853; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kp562e4y9SulzbDyJ0IEKx2QOZQ2mnPE6n/S2UPXGwA=; b=RdHQZUo9LY665UGIr6ZEuDkBdkA9CZi5KEMVktPJexLsWbP2FBm/XOE56ak5GQYP1FRmkn oDId+gl6EQMBueg+zOfNEg5BlRoLVhqPzmS1OY934P7M8RaStVasWSrEHyir0NhRNx1Mt4 7N3R5o0p9+sx25Wndl6evUbAmPKWjdg= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2dd7e56009cso95302771fa.3 for ; Wed, 01 May 2024 17:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714609851; x=1715214651; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kp562e4y9SulzbDyJ0IEKx2QOZQ2mnPE6n/S2UPXGwA=; b=MMrGw0GHoCLd0Vim5jCDaa4gb+8KqBlvd+UxDz2CIlLLuY68xZJjGmK5zk5o6/7B6V JjTe1VjP0up22t5Ry5lUxbtPRPIuvpPBFjcsuLHeVKQ2Ferj3r8+m5GaVRhrN2s7KCSE XHVuNgqtrom0NguRdK/8IK8ShiA0WxLFNRdIze9W+2bZC4MNW10eA8FCZ4G8nUmuV1er KeY4a06pB/jn8uikLHmqry5WKlUZKqWi1tViaOPrnpeDqrLTlZecJ4CgzMF+h90X0bzZ I/kPZsIj8mtrjQ5NVz97O5oA+MxZ5wlJGFo5UPNMp8BgA12bdQVC09/EkjM+/xnaRtYp fjOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714609851; x=1715214651; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kp562e4y9SulzbDyJ0IEKx2QOZQ2mnPE6n/S2UPXGwA=; b=AjbfB0akN3RRKdCXY/XCMkOywtDUcnHf0Cp5Rn9qoGoU+lnNj24mA3VCAMjWliH787 Ql12t+YWamTprHcxurw9WEu9Lss/YhzoZ9KXmOrUBRjMiYITBYw5a/Bw43OySh5oowtt kf1+dlEGapx5LPIZNodJ1JLSfO6eSjhOtaa4hYx87eYu51QkjDx6WToriFJ1+9AwsH1o J77JAfD8EDgZenrXLu9dXlvhTblZDHsbQC+EInR1FXWowUl4oanustBUPaP4HkZGPt7G oQv6TtgINdMEPp6eNUWWgXu8fXyCFH1LYrz6z4atcv/H1VAOMLD8SpKYQTwZmPkIcm7e 9H9Q== X-Forwarded-Encrypted: i=1; AJvYcCWkivvjXDvdsaaEIRx8xnMfQYoaCXLYBwBHcYbEaCbbx8BG8l5S+iplu3e07ZY0p5deak0+B7Bm1LhBwiae+2/RToQ= X-Gm-Message-State: AOJu0YxAsjIyPqAMNuPGEJFR1LPHHuwUGHA1B2orHD+wxQ0Camr2PiYk 3YFJszLZOk80XUP3kGF3ZiCviBnz1okAg3dtKAd0TcthFtV/sQmVabW9+WcXAnjMXF10Wi4hWQU 5m5KPA+k0TpOzReBlkEFIzB/5izk= X-Google-Smtp-Source: AGHT+IGGzcny3DlV2Jm68J5B2kaFqlbDfTOvJloIoTmsdrcqI3Z7BEoNjeV/hDuJrOs9REavq38NZ/ZnvoNuUHWyg5Y= X-Received: by 2002:a05:651c:2049:b0:2df:49b:27f1 with SMTP id t9-20020a05651c204900b002df049b27f1mr269940ljo.4.1714609850999; Wed, 01 May 2024 17:30:50 -0700 (PDT) MIME-Version: 1.0 References: <20240501042700.83974-1-ioworker0@gmail.com> <20240501160803.60988-1-sj@kernel.org> In-Reply-To: <20240501160803.60988-1-sj@kernel.org> From: Lance Yang Date: Thu, 2 May 2024 08:30:39 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] Reclaim lazyfree THP without splitting To: SeongJae Park Cc: akpm@linux-foundation.org, willy@infradead.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: uqdeca9ibcfrdnmh4ntp4ddeecmpq4xe X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 411E018000C X-HE-Tag: 1714609852-913585 X-HE-Meta: U2FsdGVkX199O7U0p4gLVaRvuXeZyus2qO4JppLJir8L9+LffXQmyPqOHuz5XtqJ2OzjZFOiW9C/BpQ/ZKhVUfWY8z3PRqrAWUhFIxaD4MVXe/y2Dn9TK6OVYKn+nbcguDCtt33t97PDmARdYXq7mZOWJl0ccXeG+n0lK1Iu2XH/Kvqa5FSahAUVgccVcsKfdGav3eG9BBncbo9XqCyrjwhYe83peS0/WYQYslYXFWFZuOo4OTygfF1cVrWYL7+Sxhn3aIPH/g7DSCLIr0+l0YfwFsol0i0nrb8Xzw048/q6++Ftd3wKnr1YOGdhRGMgk+Z9/zP9mAwYXhaaHQ+BUu72SFL2k5kkeyHCXiGkRhbA5aLfjz3UGbmnr+g8a0KaJWx59uQ32O2iwHpCn8imkg2FJUg3t+KdBfGkgG0bxELToNsiPC4uWiQPac5cFqyp6GKE71q2I4nwumjxLQ7eXe2qm5GXd15Nty3A9t9Prd2Co1v+04jBEespk4yLKINE6JQ20uWDMhdKhx2jOxtBQpNffaZCjWK2EhRb7mWISanLmpbcjCwTlLMy/VDBvtD2kU/Ma9Pm+Yj3rIbOc5BlWZp3SyEqMjM7mZWHHKXd/w+PWXFKX8IssySk5urKrtKga77+ySFR0VCJdwMpNcWHxzukHT85aYKfZaU7IOz4yqrYE6rrBWYE1bV7E9rmraNDhznDrSxTvKDcN7VdKq5oIpml+jo9mfS/8L44M1GWNV91PhderHimvpKx/918hITbDs6VNKTE/kg9gNAx0qLnYICXlo+zXKmYusS6TWzUBLawIAzcq6mqKHSiS+eyDYWXbjaOsR68jUtsV68SkWCRfAtJh2N9yGqIPGZJ9ndPznD+WDgcAoDPbOL+SshHZV6PdgTpROnaeMVUQltMrWtg+qerWMK8JddPQ23CIj4e//D2UyO45GhVf1vDeXCTqn53UtC1QWG8MBE39Mlw30f DHXqLy/x HGjqWT6Vu/1CgZRMN/7yKdjkJpAyuWwX2zJLr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 12:08=E2=80=AFAM SeongJae Park wrote= : > > Hi Lance, > > On Wed, 1 May 2024 12:26:57 +0800 Lance Yang wrote= : > > > Hi all, > > > > This series adds support for reclaiming PMD-mapped THP marked as lazyfr= ee > > without needing to first split the large folio via split_huge_pmd_addre= ss(). > > > > When the user no longer requires the pages, they would use madvise(MADV= _FREE) > > to mark the pages as lazy free. Subsequently, they typically would not = re-write > > to that memory again. > > > > During memory reclaim, if we detect that the large folio and its PMD ar= e both > > still marked as clean and there are no unexpected references(such as GU= P), so we > > can just discard the memory lazily, improving the efficiency of memory > > reclamation in this case. > > > > Performance Testing > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > On an Intel i5 CPU, reclaiming 1GiB of lazyfree THPs using > > mem_cgroup_force_empty() results in the following runtimes in seconds > > (shorter is better): > > > > -------------------------------------------- > > | Old | New | Change | > > -------------------------------------------- > > | 0.683426 | 0.049197 | -92.80% | > > -------------------------------------------- > > > > --- > > > > Changes since v3 [3] > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > - mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop > > - Resolve compilation errors by handling the case where > > CONFIG_PGTABLE_HAS_HUGE_LEAVES is undefined (thanks to SeongJae P= ark) > > I confirmed that the issue I reported before is disappeared with this ver= sion > of the patchset. For the fix, > > Tested-by: SeongJae Park Hey SJ, Thanks for taking time to confirm! I appreciate your feedback! Thanks, Lance > > > Thanks, > SJ > > [...]