From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F82CC48BF6 for ; Mon, 26 Feb 2024 13:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A58A440168; Mon, 26 Feb 2024 08:50:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12F85440147; Mon, 26 Feb 2024 08:50:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC221440168; Mon, 26 Feb 2024 08:50:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D4C8A440147 for ; Mon, 26 Feb 2024 08:50:25 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A48181208D5 for ; Mon, 26 Feb 2024 13:50:25 +0000 (UTC) X-FDA: 81834089610.23.09DDB8D Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf05.hostedemail.com (Postfix) with ESMTP id D5468100017 for ; Mon, 26 Feb 2024 13:50:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PtWlj3f7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708955423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJhncUTfkuo0jdDz1sV5i9HS2I+N7q1J5xNow39o664=; b=o4qis0Hahi9hiBENJL4yGRbEWRYx/0kxQWH4qwUHChCLuNRmoLjcX230xyiAPjXpq3Cfm+ erOIKxptkwaz0ZIaTCdopdZDJaCufDrRcXi/6XsFtBX7a6H0NHPUOx2YIuZSuWQASsXZKR HDQ1HsvCFDPS6YDmrYk76tO+3o0jaJU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PtWlj3f7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708955423; a=rsa-sha256; cv=none; b=z45BPuRfN9EC/3UIlygqxTOgyMoF7rhLL3ebyf2BWsoQGCuoJtVGIxLBFquk/5hVsD9BC+ 5S0dp2k7BjFdoIdnbBV5wU+GRgnnW4faklYxkcZ2PYatMywrGtiHbQtCY9p7qOcgAmjE9+ tH4ZCjo4KkjgtIKeiGpGkTEVKi4GdMg= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-dcc4de7d901so2325080276.0 for ; Mon, 26 Feb 2024 05:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708955423; x=1709560223; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EJhncUTfkuo0jdDz1sV5i9HS2I+N7q1J5xNow39o664=; b=PtWlj3f7ZXx8NrGdbPXwBs9ZafUNWa71GwNIYUxebvk/HI5GZe9TKMLD8AGAUK03bI TJKOKPO9ors0Mr7kkLDphSLekGOIs/ONUX/YBjfDhmSlDOnF8No7UMR+NdEZ9n8tWFT+ iFo6/EsiTlprDbcmbMRU3dqgxzRPLIFv23otJgCKAnuO9XX442GM23X42lY1yaqnOnR/ DzlcjoKF6Xy+WpOXIzp+QiINMJ8Af1uJBwN1j8t8YSoRCf2pfjHDhgzbTEBR7N75NhFK pK9M1y4SQ2vYU6SeZZFL9x3SdZ/SYiPvkH2djbef7BxO27ycXbmhRnt86BHhQnAA6xSr 1R5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708955423; x=1709560223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EJhncUTfkuo0jdDz1sV5i9HS2I+N7q1J5xNow39o664=; b=Ub9+PvLLYztw41qnav/dGkkdK/FEuJfWhL9Gh+yB8yW6VzCKa26wM29bLRtw1UbnpL VM5BRmYj+gRJP6uepyQwLJ0V9YRrBLxD1lgS9oK+8KT7DnYiH197BWlWAOoNTZpRaq4u WlvJXdZYbwRsl0xgr/DB9WMO/MEMNSybi6P2jKAcfXkDyN7jIHJZ2AfVzm55l6uWv6Ks MBtWmH6xhJgAqV4eqHNOHQKNc/MzKjNTbv4jJPbvyiOXsYY2v52l1mV/Y1IJNwzLMB/G ckjdwrYVw3VXZHs8QA7rmEzAWvw/Fz4Wk/jURhQPE7WB4qvXuueS6ApHtbVu8wSXkrdt hlgQ== X-Forwarded-Encrypted: i=1; AJvYcCUZi2hsq42/pBfekhMmSct/yHKm5JmWGwvA9XAWGIcl1N1F/fIb2VTUjEajsxPbB85OHq9aL4LCVhZpGTsOoffLxs4= X-Gm-Message-State: AOJu0YzC50gvPrqXjviQZt8DwS3UR7Bbnv33Cc3CEUYNP4kTblEsl2gA SCkMoeeK/biq1nr86LebjXPQjPKLrR6ly5zQSHlSZnvL9VhemQo3rW0rDHJNLa/uCZzGXw2PAX4 aSs6rtl1rHkxBDkkAfj5uldQuWaY= X-Google-Smtp-Source: AGHT+IGpdSB28Oq3AP2DsRHs45c7+4tgbkWMmVmRJnM+CPWhqkg1f1F2q+2W+SFD8dmP611lRHRK2LZq19U52UrvE2I= X-Received: by 2002:a25:abb1:0:b0:dcc:cadf:3376 with SMTP id v46-20020a25abb1000000b00dcccadf3376mr4643365ybi.18.1708955422889; Mon, 26 Feb 2024 05:50:22 -0800 (PST) MIME-Version: 1.0 References: <20240226083714.26187-1-ioworker0@gmail.com> <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com> <318be511-06de-423e-8216-af869f27f849@arm.com> In-Reply-To: <318be511-06de-423e-8216-af869f27f849@arm.com> From: Lance Yang Date: Mon, 26 Feb 2024 21:50:11 +0800 Message-ID: Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free To: Ryan Roberts Cc: David Hildenbrand , 21cnbao@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D5468100017 X-Stat-Signature: 9c68qmn7jr3wxmsrapo7pceu5hxk6ot8 X-Rspam-User: X-HE-Tag: 1708955423-253848 X-HE-Meta: U2FsdGVkX1+cPNwb/iTxYNOJynEYZRm0WMhBCH+SSmcYdZtCLDbTJmffUQNoJKv+xZFm1Be5nt0oefz6RlzogJp19SkmYCegUseXtdKDMY/B0V5OD60znKcQCqY6icJ5miOyJ0cQU48Y7nL3+z+EhTcrTI/ZnXVQjhVxnOcHpOIKZhX/Nt/5iobouN++LoTHH9NAk++31sq0iKDedzvpBqFJEqyryoVAArdyuqcmXirifdG7yIUQPB/1yVKbirImQwPsF2fKlXlhxrxMaNgCUdYT5yQVlD2yL2TKocaEcdXU297M5TBBG4K4WKmBq3JtOAlGPA9Qrm7s0qGMqKbcqhW1fpWmP3p0vxZ1+RPST/cHYhHAyIdkwjZ08G1ga75hArqEiV6mM4aoPENw7tub71MxTV8vR4a6cve8S0KC+jzdGOkSNKLa0c0+H2uGpB7m8xzeS9oFBKD2VjNN1RGr5uch7N0/feEyZa9gg4g0LCniG1V29yTw5D45VaqOF2D1sq9ujxOgD1SUGl71t4PE4/EyQ81nMaThiq5i0WFG88pwfMA7+oOh2rih5XhPMvDYijAymY6hvBIWFZwvIsoWJsWVjVhcA1URY6h8QnzsYLXX5r4MvuNQaTStAS8RlepFX1sUyHvu0UukWsTGYRl/CG+XdSY1H8UcbHu9tSNzQkO2hs2HTC+J7wSeyorgEZf8QNjN1VWY15rYmWNTJuH6GzfX19QyD86s+5yQSaNIwH45pLYIHPmmoUyMD02QDCMaHLRJLrSfFPjGRxW5M+Vr7kiKCUIGmQB1gIOqng/6fl2oUlcPSdShCF0uxlqXW8hvYXW2Fh1shx85oK+H+U9wGvQWnbYT5y4F6xe55RkSKvkljeLnJYGJJc+6AfQ7cZO6LARptYTw8B3pwsj1c4gKfH/cmgM6UmgK+UXA+IRe3FQnJdd+QS3+KcbstV/9lvHPmNAWOBJjF8hgVuEVmay 6ZJTgWS7 nO8D4sNgLXUGsBu6d98D2kkp6YrUFzmAMRECnj9bc/IiWIwkf+UmD9p+U8uXmWcOmbvNsvG02bE7eIyQObRXmy7/fpAVzdmrAbnPSDgv0t9kIQLPf+uGHTXsEsXN37cRWbz5ksUxVJS3N2fRHebMG5y8hBTvZvdR8wQTuMAIq5rcAz6hyZ25tLjQ48mVZ101dTGiYsHHP27uTWJZQLg+PO4v5+cKq8wB793tku/usb6+hky+SZl6yY6yYQFu2WrDmdSEcV6YkGBWjwEQ+zvzuIsLIFHZKi36RRzPjQ0wSUmZ9JeumBIvRTJ6jia/c5RyVc/PhPZcyOVyI5A3dV2riDPlT5ST8/Fz8fjfNrt4obVGTp40mAIvmR7IqZWwsq+BpIIG8Fs2tSpwqjzNsPz4SbpYexG8kLQh8kfaOlHlnvCY+5nqHVvkF8WG+HKp7/sw3C6DisjbRfnXrYhTs7FVvWRlY1riL5PSkLx7NW844tnrPie2fuMKsO22TrYFHmk+J4zV5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 9:04=E2=80=AFPM Ryan Roberts = wrote: > > On 26/02/2024 08:55, Lance Yang wrote: > > Hey David, > > > > Thanks for your suggestion! > > > > On Mon, Feb 26, 2024 at 4:41=E2=80=AFPM David Hildenbrand wrote: > >> > > [...] > >>> On Mon, Feb 26, 2024 at 12:00=E2=80=AFPM Barry Song <21cnbao@gmail.co= m> wrote: > >>> [...] > >>>> On Mon, Feb 26, 2024 at 1:33=E2=80=AFAM Lance Yang wrote: > >>> [...] > > [...] > >>> +static inline bool pte_range_cont_mapped(pte_t *pte, unsigned long n= r) > >>> +{ > >>> + pte_t pte_val; > >>> + unsigned long pfn =3D pte_pfn(pte); > >>> + for (int i =3D 0; i < nr; i++) { > >>> + pte_val =3D ptep_get(pte + i); > >>> + if (pte_none(pte_val) || pte_pfn(pte_val) !=3D (pfn + i= )) > >>> + return false; > >>> + } > >>> + return true; > >>> +} > >> > >> I dislike the "cont mapped" terminology. > >> > >> Maybe folio_pte_batch() does what you want? > > > > folio_pte_batch() is a good choice. Appreciate it! > > Agreed, folio_pte_batch() is likely to be widely useful for this change a= nd > others, so suggest exporting it from memory.c and reusing as is if possib= le. Thanks for your suggestion. I'll use folio_pte_batch() in v2. Best, Lance > > > > > Best, > > Lance > > > >> > >> -- > >> Cheers, > >> > >> David / dhildenb > >> >