From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59572C30658 for ; Fri, 5 Jul 2024 11:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8A616B0096; Fri, 5 Jul 2024 07:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3A966B0098; Fri, 5 Jul 2024 07:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADC066B0099; Fri, 5 Jul 2024 07:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 919D36B0096 for ; Fri, 5 Jul 2024 07:19:30 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCD794186A for ; Fri, 5 Jul 2024 11:19:29 +0000 (UTC) X-FDA: 82305453258.16.D89FC3A Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf06.hostedemail.com (Postfix) with ESMTP id EA3B0180016 for ; Fri, 5 Jul 2024 11:19:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KoWuhbFf; spf=pass (imf06.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720178354; a=rsa-sha256; cv=none; b=xEaIUqDIAhqnV3ZS3RSL90mGteqOs0NNqpqorp6iYCRE64pK75etXFmODOD/DKDIsD+4MM Ck+avJ/5tzvCrHCvWOn1+ZUn+4HSef6m19RqdjK7MoSr7dTKI2jOKlWHwKO8oSu2YRv+6O 0zHTzFjGwXhRxhbhl2BQjcCAKKmXcH0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KoWuhbFf; spf=pass (imf06.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720178354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5CZbNI7VdWEztIyeBdO2rOowUpdrgoXYkMXWl+mjWHU=; b=a92w7j0GUEcI39JkZrztetu0Mbxq+Wv/oytnUA+r3a/6nJO8Ikkeq9AV70ikQNpndZQO8r CPpMIEap5smmTGzdS0qPPLpi8hVoT+7QgwRu4mwGEEgi+H/uiQgveY6q2QKgE8P/bwBMMY F+qyuJz9ajwT/6T4XZVXny8imO8L238= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57ccd1111b0so1110473a12.3 for ; Fri, 05 Jul 2024 04:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720178366; x=1720783166; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CZbNI7VdWEztIyeBdO2rOowUpdrgoXYkMXWl+mjWHU=; b=KoWuhbFfYgOm2ALeFkQmQ8ec0DTKtxD314qFQdKpd/vq2g88v45eHM+1h/q125zMpB 3LVAQWRK6jhB1A8qOxJ3jXvHtilmDJXVkICB1E7eLHr5ZF5Kw0I70RHQfEoGMMjH87ec 6WHLEIl3gSbmKDp5mRcLkG2eQptcFHAbuc3mb2TVUDC71GdanyDHaojYrd+Mvd1nm4yv m5+4fmib95vwohqTZc9mqHjnBJR4EHNJhTUO2Ex3bIyF8Za0bWW4+dBjqHESG5gFmX6S n4lonQswVrrqao5Z0GJVXhR2hcsCM5FIKUOpqGYfgkjRWHcCBSdOJ/uemC1lm57MgRyb NlAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720178366; x=1720783166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CZbNI7VdWEztIyeBdO2rOowUpdrgoXYkMXWl+mjWHU=; b=jWIxK2moNc6ZJDXTJrF4F+K7lHW9W1vCpu+r/+5dR3wgLzjlY+XAq0ZerlN5b/KMxj WJIhbUj009zWtYY/8qC6sJEVHVOMeD1/hrVjxC6fU4+r77sMop8x/9QIfrX1sn93PDWE aQ1H+/iFcIdhr/MCS9UEXhxMiYw7bP1LsNkc1mRBrEcMlL4MIMbJlg0SYtnwnz78mjc0 LInWv3rLGayl0AOc8F95RkfcTRcKNyCNr1VR/B1ajwPJsWHt2BjVT6qIFf1fl6GsX9Bw Bn1GHfabMQH/L8N86SVZcbkdRA8rVqZkCT5Qj/2x5RlNFOKZwxGWAEcJMO4v08IiR0aq 65YQ== X-Forwarded-Encrypted: i=1; AJvYcCXIxShYFIfvzIockCkvqrXmOvBh481+kxFpyGpPTxS+4JxBvMlFvL0JZe8UJLAEGfVPT8axVpVDxCqueG2mkaU8e6o= X-Gm-Message-State: AOJu0YyO9LRGWXIdkULvQWQ5dNsNbrP/sP4mQHg3jv8U1XLn7Xz4lNcc T3cZbLuoKqT/N9QcTAmaNsdzqUtyEoiWdogOaXje4C9K2NFNBW+IWZ5WH5O4efd4MM/9ZUXXx/B 4+r5E4ZQdt0VvvWh8SYUCcIF8aLg= X-Google-Smtp-Source: AGHT+IFuQBhaGGxL/7iPZB5mR3yB+SEInlItazwA2fUnSsOJoCQYdPSoBCpVWEN8lB9iEBUd6vWHIY/YD6fRusQ2vbE= X-Received: by 2002:a05:6402:4408:b0:57c:671d:8455 with SMTP id 4fb4d7f45d1cf-58e59f27147mr3947638a12.14.1720178366341; Fri, 05 Jul 2024 04:19:26 -0700 (PDT) MIME-Version: 1.0 References: <20240704012905.42971-1-ioworker0@gmail.com> <20240704012905.42971-2-ioworker0@gmail.com> <677fc803-0bb9-48dc-a1ff-3ca1fb0dea15@redhat.com> <3aef2bc6-c889-4a9a-b35d-f10ca8a5796a@redhat.com> In-Reply-To: From: Lance Yang Date: Fri, 5 Jul 2024 19:19:15 +0800 Message-ID: Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, dj456119@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 16fa6451454ewsqq4dmdpbxdj3gc1aj3 X-Rspamd-Queue-Id: EA3B0180016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720178367-240410 X-HE-Meta: U2FsdGVkX18FaFsd9UtLNfisy/7VQBe1/QS/+LpGmY1MU5CIG/gHqw1DcQbE5JraSyc2LzZrBwPGe7hdFG7Pavqtol+lS5ScJZK7JMIyZrBkhkb4WPnbr0TSng85l86cOXCxwyjHXjgMignaLAwGzuIDoJg6uRrlxfgrhWhI0eejKgtFcpjK5HkQdeanLGweK4mDMYayefAYERSdE5+yCizR25OFPkamIP12L64VLEthHIXbXGD86ZalOxatj9ydBJEr6AunEBARNaXRWmOroB8G9ptBtHoRQF+iT3DFulNdT+QErXwvtMwRDNnkzNNtduceXk5D5Pbn0TyNz+mYfo4pbbVBldyBHvzitZXgYN860/3jioFOCiG0KECWfdUeS/rvp4lWsN1YH9UD8WZg4O5rN6xXTbHOmh1HtR3wfjfxGZebU2UpsSZX22+rqyroUjtVcUqnoaDzCE1XAoq1diqBAYZqT5ni5JfLFx1Ln87j5ZnOoytPe/paV5mvM8Ii5592E0JlkUOn0cbfyTyzSxeoyGfkGAxAwFgeLMLZMZHMyT3pQH0b8cpcO+7+V1GJ/fLSkw9vZ5/HMvQEJrFU+sIf0uU/znI+6t3JsflB0Vahk73e/j6Ax8lsELp9fop2xMM1nnTq75U5ln5qWCllJNrjk5xoLtB9fHdhJQH4RZV4P8wBHKg4CII8prbzM69Pw2hqWDL+iy9XlNIkoYqCMCGMxuMsmjbOPpac7dNccc8kXBFgiNaj8GpKKzqAV1R2wl4iP+nDYTbMBEyPi0kx/C1Pi4vg1+nPLRhOqqzDcJqVHmTZAExq4JCtS/elssq0J8AC6fEh8sMX+XJQmFRVo6U8+Jfr55CGseYCUczfyE9/RhEvKgjymde+HK0dqsUVw0JeIXT6riThxDgSfu2pmZaKGMK4mD//7nhD/4DwtXx79CXoF3Y8utRN8qdNluhidS1HidIhNUZHUPsYznh A+2j0c9y ImmOJKoOsy48cCcO5/mMuW/Imff7mA8/drpL0iviW5Rfp5nUVvAyoiMKf1UJ92jnnQLqljFAUf29jD0QBGS2628e77OBOXrKwbgGAuAyHCOTWgWr5eea7PLl1VNMaz/00S3Sr8ZdJ6DGnSnQtkRzfJ4ICFxrlRn8iEqcGkWirbfJ62JCiJh26llkx37F9ERoLceEsASNUxNJ3VPidGuC5AsWGmlCd7MEb7RqsoX63QFhfPgNi6YD2tRNk/zunOsIJx3AIPdrOLvstkwCqrW8AQeyyqAqVfzCyoNVQKFkrRvZtFa3qOGbEfvHijs9VFB9kYrO4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.056351, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 5, 2024 at 6:56=E2=80=AFPM David Hildenbrand = wrote: > > On 05.07.24 12:48, Lance Yang wrote: > > Hi David and Barry, > > > > Thanks a lot for paying attention! > > > > On Fri, Jul 5, 2024 at 6:14=E2=80=AFPM David Hildenbrand wrote: > >> > >> On 05.07.24 12:12, Barry Song wrote: > >>> On Fri, Jul 5, 2024 at 9:08=E2=80=AFPM David Hildenbrand wrote: > >>>> > >>>>> @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct p= age *page, struct list_head *list, > >>>>> i_mmap_unlock_read(mapping); > >>>>> out: > >>>>> xas_destroy(&xas); > >>>>> - if (is_thp) > >>>>> + if (order >=3D HPAGE_PMD_ORDER) > >>>> > >>>> We likely should be using "=3D=3D HPAGE_PMD_ORDER" here, to be safe = for the > >>>> future. > >>> > >>> I feel this might need to be separate since all other places are usin= g > >>> folio_test_pmd_mappable() ? > >> > >> Likely, but as you are moving away from this ... this counter here doe= s > >> and will always only care about HPAGE_PMD_ORDER. > > > > I appreciate the different opinions on whether we should use > > ">=3D HPAGE_PMD_ORDER" or "=3D=3D" for this check. > > > > In this context, let's leave it as is and stay consistent with > > folio_test_pmd_mappable() by using ">=3D HPAGE_PMD_ORDER", > > what do you think? > > I don't think it's a good idea to add more wrong code that is even > harder to grep (folio_test_pmd_mappable would give you candidates that > might need attention). But I don't care too much. Maybe someone here can > volunteer to clean up these instances to make sure we check PMD-size and > not PMD-mappable for these counters that are for PMD-sized folios only, > even in the future with larger folios? Thanks for clarifying! Yes, agreed. We should ensure we check PMD-size, not PMD-mappable here, especially as we consider large folios in the future= . So, let's use "=3D=3D HPAGE_PMD_ORDER" here ;) Thanks, Lance > > -- > Cheers, > > David / dhildenb >