From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F05EC25B4F for ; Tue, 7 May 2024 08:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C346C6B009B; Tue, 7 May 2024 04:38:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE5556B009D; Tue, 7 May 2024 04:38:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAD086B009F; Tue, 7 May 2024 04:38:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E4D06B009B for ; Tue, 7 May 2024 04:38:23 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6722B80D37 for ; Tue, 7 May 2024 08:38:22 +0000 (UTC) X-FDA: 82090948044.21.7B864B9 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 8C61C40010 for ; Tue, 7 May 2024 08:38:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F2D6VWUe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715071100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W8d/lEWlCZJQYX2qha3kS5f99rv+hpjz1wOoh2/05Gk=; b=UNMKHnycDOo2MObp7Di5ss86JtV9FVIEza0mVjrtcBPanqOMXiiWR6ocvDkvkJNoZrjljk 8Q2Jwki2uL0Harggdd5mqlZVJuk3cXghL6P9VPDTbFJTv2Ajn7BasTZTBkOY9xnp3hwx5r TG8Fp0mVde2/WXyfmFRAqWV5Fmonyc0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F2D6VWUe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715071100; a=rsa-sha256; cv=none; b=GFBLsePEYERy4qyBvmory8zuc/xOEKm6d56tATgPOqUtZ8elhdNvZqgKSTp+A+tG+pLBmI 1tgLSg+QtpJZMsAD/wguATpt2NNyy6idsiTrWk37yvdgPCx7hprvBcHJRyqkEcCa+dds/I wSbVSiAIqNjl2uUqCV5TfgukQYLN07M= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a59ece5e18bso104703066b.2 for ; Tue, 07 May 2024 01:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715071099; x=1715675899; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W8d/lEWlCZJQYX2qha3kS5f99rv+hpjz1wOoh2/05Gk=; b=F2D6VWUe99Qac1g3JKMpLvod+s3xRfR/d17ek8Wv4gwA1UF+RT7JHNJ3NECeQY1vmn 5TGqG182doVhv0n7GaSQaOhChJ1G8ngPer2bROkdP/eHFRRW2scU0/sPvOO4nis7mjR8 srLpWTUeeueas1WxUFxlwyzhHkhm8lmBowybUFfFm81CiO7EhIVi5LYOEQ+FvtGatf7Y DKcnO2caFiVjBrFAh2akyW02Kya1WaGOicMHcDepFHK31bp8p0CV4D3QByiArEa7vY64 swJcIH3kHnxu0jYr1IkmliHkXIiBzNGayY0+vB2BGgdZpLWimHH4JZ8jl+6uw5FsfeMG UPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715071099; x=1715675899; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W8d/lEWlCZJQYX2qha3kS5f99rv+hpjz1wOoh2/05Gk=; b=XAyyfgK2mKtyxFwzjFwfNlD2c/k4dURrQFankpdm/GXGg8YjW7IlP4PxSrl/7y1j2c WOj5wpZPPQo0I9ZycNPxJLO7Tm0gsNgh8Emez63vob8Mcp/PcZRlV9/veRkU7xswoG6U yDFSXCi41i2wOTGpHgff42Smr8Z25wiZYP5CQKjrPwRiMvR57ZEdK4JpA0HvBG0v4IBk TFZIVTeJd3unxLFpG0Gw5FFo3V0d+oZI1kZ8EGpfyf3yC8Cv2wOhPpPH38Ma9CPBiNQj eK5k0bCbt28AWhYYQwwX50MJUOn91MVd1lw/DEuYvy/T8MancwkfRE4OISxK6WdI+bom P5Zg== X-Forwarded-Encrypted: i=1; AJvYcCXH3w7r28PqLOJfGGxChXPb2R97Arot4Wbi1trqu4jx5i8PSmgdIaJhtc+MR45qTQaKDKnFkSra9dQeUhKZPWPWCx0= X-Gm-Message-State: AOJu0YxJghzoUNM/Ivv0I6AH1qzi/F0cSAmBgXaiwToNVYjIYTK3Gbeu IpkFaLXgZgO2zBF2vX40eM06ZkNwxpZyRGx3KowldTZGy5aP6b5duPsz5ZtoHjLExUvdRD6Ac+g VoVSaHZ4+jww4nG5i8QPeJzvfLg4= X-Google-Smtp-Source: AGHT+IFnaj3FxuvdLHi80OAEbz1pTKKCCrJXhtWCA3W0lzkbNcQqyw1zs3q4GVr1QUEyYKfAE9GIk8ukRJNyFtk8Osw= X-Received: by 2002:a50:c319:0:b0:56f:e7b9:e67d with SMTP id a25-20020a50c319000000b0056fe7b9e67dmr12607642edb.12.1715071098814; Tue, 07 May 2024 01:38:18 -0700 (PDT) MIME-Version: 1.0 References: <20240501042700.83974-1-ioworker0@gmail.com> <20240501042700.83974-3-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Tue, 7 May 2024 16:38:07 +0800 Message-ID: Subject: Re: [PATCH v4 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop To: David Hildenbrand Cc: Baolin Wang , akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ghth9t8tphc634htze33anr747wjcwtq X-Rspamd-Queue-Id: 8C61C40010 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715071100-213700 X-HE-Meta: U2FsdGVkX1/S7y+5AFAfZrV8evqw5JGvlem7NBjiHx1t4HnY9BV2/L2lH53B9YMeAssU30uckMXBjZAaQkbhF9b27JSs84Yo0/+wZu/vfTj/AFOI0tDbbO0KzuL9l2kOrafADJFfVpNbbs2C055vg3sgn6NiWp0oh+Gb0Vl24X/8ptx5sppADs8ZY5KV6+VS0/zVNf0tiO1eTc/3lGGGTnl07w5HN+3x9y0gka0sIUyiOFWwkP8+83hUjo4Mc2eIH1zmS3pQYcoz0+PVGZK8DIasSLQhchua46dTq8xD3/DyZYJHa+NRa2QppFfINztoEUGx6iR1lYAfYY5GXR7+WBGyC9xb6g+Pjp4QmOOSju7DgbNo039MWtzfZ68tGbnlf4ZAbCTlRNmaDK6PqvZ1d4eFnrH1gIinsN0WqMdTVv/1O5GBY4WshDie/56NagMy3xXYiTCquW/RINDdAtnXVAeHIbhkdfAnXFGrV9NpZRyBhxdxPGZFOZo5ulhKNU0VAiWwLvQoCCsdNunDcqZnu2gYpjg6YOaqFgZs1VaHSqef302FMpUqljNDTUsnvvU+JZX42d2kXF5zoJFlzqdnQpzqZfo84N3GMqxr0Bd93+wnqQEBstzR5nw71JOqauIkWlN1ZnaYq94ABZU/UJMHSWtA2jPSARhcOWyJjiiPQKj2KNlSvwmbDVbHk5+UB61QGJgwr/tCij6TGWD5UGtFL0XltOiQZO6Ml6tIN2lfSI6HHHUv1XzeJg6J4tlvn1g+epwfZDBRFnid0TmYG4ixL9EqFSl2QRg4NzX2UVermv+88+C3rJxvRV6/U+7h9SowOmRfn0nDj3PPypkMnA2KWoh2Lawrfo8N8d85CNVsiDpKAzn5RLcHS6OLDppnBEoCGz9CJh2YQy08liqAidvz0tpCy5ml68ACmInL0KoMTcUiyD+Wq2wgrS5fH9/Zl0k3K9F8Ilwf61qFOloFIUw FQ6bNxYt 6XkbC9EYqzTbvmusgEiQjwh2rh/lZVGfK9eFgcUt6+ilK+Yq5Tos3CJUJ6/3hxE83zhAQc2OtcwWGR89tWRS/NQCgvbtRNlgD2FSpmT78KfaYhjk6DSVHEB4SWCAD8MJGErq/gb1wkG5w++uFzdTmMwJI+NYk9g0JVT6vP1Rq6j9CIZUN86BsNYi/jf6+dmsT2Qr5iioQnOLaAo4ad/Dd61ZFwiwJAyNAXcWKHFrMfOf++1mLnRnlHvTmpByh8r7PY5nVv9KZ4W+lyCDDdlsUUGwKzakoT/I11PSMmqOL6FDYJsFItlIoVFsHzTs326wZjfa9ygr422YtNJIboKIzoQ18buqN5MKiCuMyWAC8/oo4i7WuhSyVrJodvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey David, Thanks for reaching out! On Tue, May 7, 2024 at 4:17=E2=80=AFPM David Hildenbrand = wrote: > > >>> > >>> + if (!pvmw.pte && (flags & TTU_SPLIT_HUGE_PMD)) { > >>> + /* > >>> + * We temporarily have to drop the PTL and star= t once > >>> + * again from that now-PTE-mapped page table. > >>> + */ > >>> + split_huge_pmd_locked(vma, range.start, pvmw.pm= d, false, > >>> + folio); > >>> + pvmw.pmd =3D NULL; > >>> + spin_unlock(pvmw.ptl); > >> > >> IMO, you should also make the 'pvmw.ptl =3D NULL;' after unlocking as > >> page_vma_mapped_walk() did, in case some corner case met. > > > > Yep, I'll also set pvmw.ptl to NULL here if any corner cases arise. > > > > This series already resides in mm-stable. I asked Andrew to remove it > for now. If that doesn't work, we'll need fixup patches to address any > review feedback. I'll patiently wait Andrew's response, and then submit the next version or fixup patches accordingly. Thanks, Lance > > -- > Cheers, > > David / dhildenb >