From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779E7C04FFE for ; Fri, 26 Apr 2024 09:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3C46B007B; Fri, 26 Apr 2024 05:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3CF46B0096; Fri, 26 Apr 2024 05:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDF1D6B0098; Fri, 26 Apr 2024 05:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C1096B007B for ; Fri, 26 Apr 2024 05:33:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 580511C197D for ; Fri, 26 Apr 2024 09:33:56 +0000 (UTC) X-FDA: 82051171272.23.1B6CF59 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf20.hostedemail.com (Postfix) with ESMTP id 8891E1C000C for ; Fri, 26 Apr 2024 09:33:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c6XFGdQD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714124034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPuH+vBjv5eyQAgbcQ7abdv/zl57lH4J1QFyOBw4iiY=; b=Ic0KmNMinWKXToXOQLBYKDb8g3hbRGwTTguGcfyQTu/XIEWAkxvdBvuVUcqJEbRIRcAG+O w9HtZcJUad476u90sAXibhi5VgerYWil8DH2q3IaRJkUZJ169EwOe8hMmIFDhZiDT6XuZC fl2ptPCmQxXctcq9yLFGTCqOt80MWb8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c6XFGdQD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714124034; a=rsa-sha256; cv=none; b=Fo94fawjs+H9IesPKJ7hiEReWMz8Cq/wSSVrzg3tZJqpFgCXObghu5c0jt/DmxvA4X5NTR vJrV3mj1ucXTtPEPyT081pGJFO7+33OhjH/8jmVIqiY0aRHo+aJoztewijhztJJoXnKREx ISNu4lLfyKB/eGlIoydykOh09Lapl0Y= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-572347c2ba8so2142636a12.3 for ; Fri, 26 Apr 2024 02:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714124033; x=1714728833; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cPuH+vBjv5eyQAgbcQ7abdv/zl57lH4J1QFyOBw4iiY=; b=c6XFGdQDE4WIdGLxoNMwrRQKhf0p4MCP5w6opgcl29cXDCvk9Mqt2LpTMOq58BUvHB /IETiyg3JpQsUrWN7fXl0lH2zdNItoTx9LcCMRCYupet25inO8AmI4A48YsBity+WxHc moC+M+qJ6vxIT/3E6reOiPicVJKs3iy2nQ1AtnA3QgiM26xlWr8hxutPeaCfzKWbWhO1 VvEDEcykBEFnC7ekWkUr+/nq1DgaU8Iuf/vPXj3Rhw2anett3nNUAUPc/LvNi/3STFaQ FuI4paHaBPkIaG7BDfhOS/9Q71BZJ+8h4egXqs6/BD5ndoZydgHBzh4tszlY3UWvOdAG IY1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714124033; x=1714728833; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cPuH+vBjv5eyQAgbcQ7abdv/zl57lH4J1QFyOBw4iiY=; b=CmEY1VfcspbPwvCMqN70AUdOr00UT7jI0Ob8y/6ZlCbafykwmAT9ZUyuukFr6gU1vM xD8r6CD4B15DapnnXexVAydAM6fJkU4Yq+XkgMedDWcHBHxqzA84L7mPXuyMltJzDhCC q/tbkOvU6+cKiUU79PN54Wp90CwCltOL2XvTTA6+mOByQKDGl5FHFGbFmiUlzvB3V/9S ++HMm0OIOFCMLODFs8hVR7Gxw0Lln1NksT+JGj+tB1Bpn1YRhIoFumy8tqe60bqKrYv/ k8CXvMVNDTbTp7b/ZhGzKnSggH5a1ddx0z0Wjai4Bi8syk+cdQjZKjwepAXOyX314N+M ZHbw== X-Forwarded-Encrypted: i=1; AJvYcCVP5Op/qsArs3ppWTW5EeQoM3Lzgwn0I3JNbHQhijnbsj5ZXhiR8zVhg5mzVRVVBa4rEapjruV0n3kfJ/JnwHKDLC0= X-Gm-Message-State: AOJu0YxGyKhLXCWl7l5ymfb20Z2SyoX1xYvvn0XwS16Xz/TN6G2QrrJz xfwloMsiSCvg9bZsafkZe3IPpVWOIHWH1infOeGjtqyw9/EpEb9K39FC1dcpudOdlm4TKKZ8j/s hQIFxma3x0ocsD9McxDtJPtrbk1w= X-Google-Smtp-Source: AGHT+IHPezjE+CJztDyYGDoPWkYAoc0JFZBredYxiGUqz91b4Ostfrb6qpSw9Sq9J+ppKcnAjnV98p/aXleUwfeXIEM= X-Received: by 2002:a50:950c:0:b0:56d:f47c:5308 with SMTP id u12-20020a50950c000000b0056df47c5308mr1351685eda.34.1714124032931; Fri, 26 Apr 2024 02:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20240425211136.486184-1-zi.yan@sent.com> <7c233278-1006-4449-81b2-d473b18a66ca@redhat.com> In-Reply-To: <7c233278-1006-4449-81b2-d473b18a66ca@redhat.com> From: Lance Yang Date: Fri, 26 Apr 2024 17:33:41 +0800 Message-ID: Subject: Re: [PATCH v4] mm/rmap: do not add fully unmapped large folio to deferred split list To: David Hildenbrand Cc: Zi Yan , Andrew Morton , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Yang Shi , Ryan Roberts , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8891E1C000C X-Rspam-User: X-Stat-Signature: f5645dre5dkaxiq4ogcry3xwq719un7a X-HE-Tag: 1714124034-587615 X-HE-Meta: U2FsdGVkX1+z6HuODMDjRnrwW68KMwX1zYute5OPrMamJrm6HIChdrXfvvu1RJd/a5ggPkkXdAebfQypZFTt7jeX/+Q64soRtGnqpbOB0tLSbpaJiBW3mq/hBMHTPu8Xjrv3lBfg/N1RGpSDtFAOns6PESU3MTiM8wsLzQmrspdEYKFy8y59nZyn/nHtW+ZaViGo4sdHcZdB3mhMbSmUcrhgEp2sKk8qQr3m3KSqmj3HvP/E8QHz/modSe2H4GVyhe7wlewly/2PPzR+ekH9kWugHplaZ+xtO7L62v9/e/AlcEE3kiXVnNMb9nPJT+Ps9AC97hMWnAwkHRb7aXnHYJ3MqtqRiVpQSULrxe3r0tlmF+FEKMemOGRe/1ri9e7/7pHyQw0F9JhnGWN5TDCKnsZLRmod3id6kovtWS+gjcjavXVrbucWuvFkQkSkzjEhab8sJtFn20Xs8jcBJqz1PmKZEkyiCdOhnd2R2cTLYeHdJ7tjLucsvoZUE4R1SSqI6Vlke8t/4Y9JgRAq0QSx7ZE8EsH25q4FN5ywZ2REeYXBSMrbgFVDTRc0Vpe1vpraSWgk8OGz88n2bkS17pDsskkw7Y3Tif7oWJ3DWQ8cuEpe1yHRU6sGdJGGJ3LOPQqRMzEQhUkHNmYnxwRKO98nRgfFlbhKy6TXnfo4zFZ/aw0hPNa6RYG1cWc3FiQ5/rP5ujOiA+YOmOIPeoPA2rFqnEZGawsJcNgJ5GZt7H5MUZFFFMJlU3mN2p3qU9HhVzmXKoQIMOh0XhHme3y6LRtTFVsxWozOH2zvWksI84nyHx6eBIwbmJxxxFhtO+pBZsTuUzZmG8VA9ExwcoEX0IF1UpjHvl5mBB6H/0llleR5QkrV58K9i5vIxHmar4eNxhB3TAP3PVPYP/iM1SpAXNS+5zKjVZOcloBD5SO0S8Tk8LMclQ08gxxkGIgJEK82u43VLp0So4I9+Ef/45slxtC cS8uTzSM T4U1jtvOCpbH2d5zgRkq8EXKZIcjDN2Ld8mPSSAsIfDudsGFCvsqdNUHXOsS3JUbT8HlzNV6a+YTndtF6Jd/Rcz4xJw8okB8QsO4PZN/1D0+D8UXKNMiHiJnzX/QCKDQpGdpxhpkj/W+keS73/xx9FyXb4KuZAmiOK/N30h7Rid/zulc47oHd94EZU8t3hN+TarupoCdvo1vRwhDIZF5qYmiP592vkEzmS78LM3l4/do+vP2fLCnk4eB1SDUQ3U6uqYYvtBEn7yPzp5ScB8Vj1YuDg5+0WeGqDHkotdM/7/oblIjyUGeWiO5Qq4l7PK1chqITV59eW6Qt83BEBNNqkibxNHMX9VzOS0AXaCsDlwQK1sfGdiEwQsAaqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 4:26=E2=80=AFPM David Hildenbrand wrote: > > > > @@ -1553,9 +1557,9 @@ static __always_inline void __folio_remove_rmap(s= truct folio *folio, > > * page of the folio is unmapped and at least one pag= e > > * is still mapped. > > */ > > - if (folio_test_large(folio) && folio_test_anon(folio)) > > - if (level =3D=3D RMAP_LEVEL_PTE || nr < nr_pmdm= apped) > > - deferred_split_folio(folio); > > + if (folio_test_large(folio) && folio_test_anon(folio) &= & > > + list_empty(&folio->_deferred_list) && partially_map= ped) > > + deferred_split_folio(folio); > > And now I realize that we can then even drop the folio_test_large(folio) > check here! +1 Thanks, Lance > > -- > Cheers, > > David / dhildenb >