From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D163C4345F for ; Thu, 18 Apr 2024 12:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10A976B0085; Thu, 18 Apr 2024 08:09:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0955C6B0098; Thu, 18 Apr 2024 08:09:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4EBB6B0099; Thu, 18 Apr 2024 08:09:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C54236B0085 for ; Thu, 18 Apr 2024 08:09:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8FC414078E for ; Thu, 18 Apr 2024 12:09:32 +0000 (UTC) X-FDA: 82022532984.15.1DDAEE3 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf18.hostedemail.com (Postfix) with ESMTP id B538C1C001B for ; Thu, 18 Apr 2024 12:09:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q26scWAr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713442170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s5K3W4xG55U9XN1pFNNqQImuxOw6l00UI+Hr/SOLhkU=; b=S7BZO/b/nxlGXMJuIZvhgU99lKtr7aFge9uoOC8oT1kOK77An5vhyay/JjyMxPse/jh+y5 eRYRondNu/nx0pxP+W5MM8uPZr/sU08GLWak+ciK16EFO+VXdlKZ4lFWCO89+mjd+qYO6L nuxJJE6Z64KJ0r6BvZTFyPXRUMOTv/M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q26scWAr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713442170; a=rsa-sha256; cv=none; b=KMy8Odfhmj7fzRndntk6zY/YZOsH0PMjkxrtiOGHUtjnuG4IiBhB3grDmicTAdXuwoo8In wC1dQsr1sJsFNGg0Xdph6bNdBV6HSu82NrXZb+FgZROwGxZrQRTb8Ew86eeH7Xv7wP+OQ/ c9lU73GA5uO3vuG5qeHyc7QFveh8iP4= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so1047380a12.3 for ; Thu, 18 Apr 2024 05:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713442169; x=1714046969; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s5K3W4xG55U9XN1pFNNqQImuxOw6l00UI+Hr/SOLhkU=; b=Q26scWArV0wbck389phDdGLgWXgsg1HyMME7u1oDpmnn5VrcQbyrRREhyw5bC90QOj dpVPI5UwzI04H1s0ffKgUwzGyp1w6giiSnv+bNDdXEbpcpX5JEg/xy+fahwAvUOD3iWr VUenKH4mLJVAbZspqCe7nfyl4jxQjprVX5/+L3Fo9uhk+HH08bO+hp8QJEJt84eAhnyW dThZJklwBnZBmlbknWVtsvlgxP5kOG5nlMAIcQ0LdWyD/roSV5pAd6J1Gk2EUBDWxvZ9 2Yx93N/puP8W6A3H0FIMrh/5nUyMiGBj0b9o+GHU1lFSp1aWRvOxRSEPDWzkXaH/sdq3 C+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713442169; x=1714046969; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s5K3W4xG55U9XN1pFNNqQImuxOw6l00UI+Hr/SOLhkU=; b=NFaO44sc/BRwGIdcg4Ng5IckA6ZFay5MU7V0jE2s9NapNoghYl6pQQ9QsgS5SZtbCU dxpUUWHo0sfwN0hyTaPJY3udiYSgu9dolfl32VmJcTzUhOTXIL0sCWX6yx/b9HicSdpI /OqbCEr7kJwm9pgQhc+s2PIXSRt6/7xicLHpyxASWy0XMuUZTVYWHx+20Y6/r5Mu9ZoZ onIwGXJGfneJuflWmAeTiLG905BfU1eMzpHGhdvJK6Wgn64v9KS43IK8GXG88MAIAB+T z9YWMwjByi0+1OY0FSEaQh6lR0zhfJFqHfy9sUhJG9oMJAPLsxK9jCw88I0ugxWwPi5n XTSw== X-Forwarded-Encrypted: i=1; AJvYcCWtPCaY3TNHPlQIv7PIEgbA+dXDFIqyQbcfbba13du/C2PYVihGt2ikrl6F9ZSWX5P+3VHH0Vk2DpJLidIFVGAJvhY= X-Gm-Message-State: AOJu0YyqKKvFeqaBb1+re2l0/6VlmObRIBvF71040OBw5a3ICBWOAl3O 50jUJnQnLWZa+rsa8q8ZncWpd5s3yG+3Of7lYWITd7glNgh7AG/FdYCXY89swiXfrXaJ2yY1tWq i4K9Gya4uONw1yFfLmXYrbx2BSus= X-Google-Smtp-Source: AGHT+IGViHTeCrergrz3VPH5VQOSjbayGlXq1x3tymtBxOJ652N7TE6Z9MtYTg+mOkfMnAW4LfAcpyShPf4x+ggcTN8= X-Received: by 2002:a50:d7cb:0:b0:56d:f00c:2b13 with SMTP id m11-20020a50d7cb000000b0056df00c2b13mr1503904edj.32.1713442168920; Thu, 18 Apr 2024 05:09:28 -0700 (PDT) MIME-Version: 1.0 References: <20240418105750.98866-1-ioworker0@gmail.com> <20240418105750.98866-4-ioworker0@gmail.com> In-Reply-To: From: Lance Yang Date: Thu, 18 Apr 2024 20:09:17 +0800 Message-ID: Subject: Re: [PATCH v9 3/4] mm/memory: add any_dirty optional pointer to folio_pte_batch() To: David Hildenbrand Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B538C1C001B X-Rspam-User: X-Stat-Signature: irxpxh1qishkb5iup4etpgimwbj5tqrb X-HE-Tag: 1713442170-904104 X-HE-Meta: U2FsdGVkX1/V8KKZpWmlj32075jph+CcdUZyV72cRS+WcoSR17/9d5BUXWitVXVHTi369yb6H58r62bQcbXYPL7pg4b4LOM3Ra0u60TpacrCexZTb3j3sczu2wy6CD9hv3y096wXiez6AhNAyDn8OjusK5zRVeAoQA+mReG7UB/2jXEYQkbYLtJ9ph6CBDFAhzCYe4OtLykgPRDR9heYGmfkt6QUbJgpEgNpYHGtmDOII+CUBWBxtpkzSoEY2bagHFcQCsscGr7tay6r+y2caUSzvZdcvnjY7yEm8XN1BFzQFspLhO3bZDipD62xjtxPoOSuO8jNBaxTBPeDAgI40j53AKeMO6Ed0Rs+3rdmVhINJUPOhvv1D3LOAOPrSh8Hcnz9S7j7Rjo/flCB9Z7aIcQnlBTwrSfEITEC5MrYBlNHtR98K2iywuBeYU+DulR1IuKVgrUonN5gKmz4W+iJvDnKuu0UwUtFQFHyH4RhDszXbYLF6tClDo02IZJbE6d9gMnXN067gUTVrxSLSfAWVxvPMqipdZpV2XjLpscHPxxpN6qJW5wWM7vj43wOJg/+dmdkLcVGZW71nksrnUmQcN2ct7QqWBBxTBGKA9X9tFQbtEBIUC6Ag50IzHpGyZrDIrndk0Jrc9YFDGg4BOLhUfB83H4AN24dVVD3Ra958rHc6yo2HrERRRag6ODwvne2+3IARcbxDZEIrbGaYYMNQHiBvukGqPubObofEzU3JcUXYH86tgbBNh9lzxLyGIM481mr3oVRV0yZAuiQ8+56xmKMz5Ks8foYTF9JbL5VBTiqX5XzbuUkBYLN3J5makusaPWW+EtCotpbeSptMAQu0nlFkumwT1o3W3+5TfgZ7MJYdtTp9rhloPQwJ/Dn4aY+mSu6Cx7yPGaTK5dGWzQrwGv94uqUc2ItLr/WtEfAjDTw8XJNarf8dvgiTfBQ3jFFVMxKyLqFELZbt/owYuh LCv+GKtU BHFqdMpKm3FCN6xIx58Nplhe7e4h2MgFSph0PH5kNGtesaw9pDvGRwAB82ZiBK7dPx40svkGQPGsIeIkCDEVEr/FpsyKIaGBP4P2fJxzPk8U6SIIcYf3B56JH1ywxkF1cypL1pILzuJ6pfQQBmGSH3qdmvqNhWSn4HLyVJZh8gE4tMDBNHoSirWI5cOzP1cdBzSv4X9wIWxy9UPqmzCFHcY4PLlWua2o4JG3RnWNoLn7r4tSaCc/ys1heqhUUmpCBsjjCW2JyMsUv6n9xpdXfmV2zwOdu2SDRbsjK3w1KTAy2ch0QYtumvUbd/ZkZyNPYX1oXxJALeQewU2XAQJumk4bHhG1f6uYJYo/D7lqNnfTL5F11+sWTw1+lhJvK+4R/kVxIoXhAc2hg0oB1nTy6P+MxNUlCVNjS9mOMAGF5KX4LpaA7+avx5ElIkGwdoFprGm88 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 8:00=E2=80=AFPM David Hildenbrand wrote: > > On 18.04.24 12:57, Lance Yang wrote: > > This commit adds the any_dirty pointer as an optional parameter to > > folio_pte_batch() function. By using both the any_young and any_dirty p= ointers, > > madvise_free can make smarter decisions about whether to clear the PTEs= when > > marking large folios as lazyfree. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Lance Yang > > --- > > mm/internal.h | 12 ++++++++++-- > > mm/madvise.c | 19 ++++++++++++++----- > > mm/memory.c | 4 ++-- > > 3 files changed, 26 insertions(+), 9 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index c6483f73ec13..daa59cef85d7 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -134,6 +134,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t= pte, fpb_t flags) > > * first one is writable. > > * @any_young: Optional pointer to indicate whether any entry except = the > > * first one is young. > > + * @any_dirty: Optional pointer to indicate whether any entry except t= he > > + * first one is dirty. > > * > Hey David, Thanks for taking time to review! > I was also wondering if we should make that function return a > pte+nr_pages, instead of only nr_pages, and then simply have the > function, based on new flags, merge data into the original PTE. > Nice, good idea! > But let's do that separately. Yep, let's do that separately :p > > Acked-by: David Hildenbrand Thanks again for the review! Lance > > -- > Cheers, > > David / dhildenb >