From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4BFC27C6E for ; Thu, 13 Jun 2024 13:46:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B5526B0095; Thu, 13 Jun 2024 09:46:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13ECE6B0096; Thu, 13 Jun 2024 09:46:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED31F6B0098; Thu, 13 Jun 2024 09:46:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC61E6B0095 for ; Thu, 13 Jun 2024 09:46:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C141941ACE for ; Thu, 13 Jun 2024 13:46:05 +0000 (UTC) X-FDA: 82225989090.19.B90E3F4 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf28.hostedemail.com (Postfix) with ESMTP id D2430C0025 for ; Thu, 13 Jun 2024 13:46:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lY154Bwp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718286362; a=rsa-sha256; cv=none; b=i+7evrIelmHqq3KSLvqzW4Ea6H+9+ODkfxofGeDELpofHN64EGOaQQP7WovLpcDcy8AYgQ 1zQqtd7jqT8NPujsPrsVasLXH+FgymWDjkL1U0ew12/ouIOaKZtdSieLnd4dD4NEdbvUrl dGZAvjt2P4TJ7mRJwqvA8MEPH9VO2y4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lY154Bwp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718286362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y1LCLqTQpgjlSACujMB9iRZQRD/4Q4qxBaYK7DnQBy4=; b=WAIrCEa69thW1vtqgGpATN5CgscKrCrdcE9eA4j0JKy38dy7ZBEiqmNI9EvuwEQGEKxCZW hkim/hsEtSDdKIMueXs11t0vjxUPbTViB9hxEsjbjTP9Nxr9qoSvEL1CKBM6e2iGfIa828 aU/oZuFXuXAxfUBL8EOHq4tSDa10JXQ= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52c9034860dso1365585e87.2 for ; Thu, 13 Jun 2024 06:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718286362; x=1718891162; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y1LCLqTQpgjlSACujMB9iRZQRD/4Q4qxBaYK7DnQBy4=; b=lY154BwpAvPoVjvj+zcrmw+CeCJ0b6EdBdp8MJmn4YkA0GQDXg1oPowJBWOgAar2iH 79yTBOapR4r63dO7r721PF8VPK8P83ADsPHwU16ovr/WHrdZPH6KCDJNicV5gGraqwRk Ii3lJO3k6dckLjuHVcQSqjTFebTEnwRpB5wWdXrtSj/WUcOpSkmD8nAPDS7HNDzZlL7I KsRDeLGa2J9OG9Pgkv2tmliuT/2VwVfRNde/Ac4U0wTE7JWxGwVtWVSowWuHP/hcSipr OEhvhJRv3JogURn0DecHE3WyZVoVCGwlvZIuuxZNbX68iIxNgAmDKNxyy8Mp0FNnM/D7 Rwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718286362; x=1718891162; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y1LCLqTQpgjlSACujMB9iRZQRD/4Q4qxBaYK7DnQBy4=; b=fNtS+6vVmSPwc6/gScIm8aaacW2GyURsKEra0JdaaZ1v/lGnKjzTu8/yLdejPONTpr 8ep7zy7izlT2XGBhdGFdnJUIGLivCCrb/ctNb33eGsXeT7lAdyMRKZ8cJKUM2JJIPj7M 7NYPjcfz/OtafmJUEkGmZyg+htG/SsSkb4dRCobZfuVaKCJG8jnvjtB1yAFK9F/QQmVa ZDgaIdwdP1e5FnP7Pqo6H9N2qIySWmSEXYAWpJIx+oQnko4wr4+bPE9k6oKC2nUQUJhv ABfkPxNkdTWm31YYqsgLZkaPCcWOCBiwbojZgWjMOSzp3cxkUbSnah0T6nwbE/vw+TxT 4QkA== X-Forwarded-Encrypted: i=1; AJvYcCW3EYfSVWPTo72jdciJBki5T8CGXVd7bh2cZx5LtBAevjVNaUsaZ+xCuQ50g1jYM/ASO00ru7Onf8kov/cxiFe7DsQ= X-Gm-Message-State: AOJu0Yx2e/QFdlWW9V0HhL74crJRVfm8nUhAiwz86Ngql82wM6A84OhA HCV9gk1jX+/M03MYrjksR7M76f4RrgRh1vd8kwa0pS3jiLyFZ4sVWabIL0a3B0nkG/ObYVzIlzf +U9sgrX7wuIp/DUVQyf/xxAxivjA= X-Google-Smtp-Source: AGHT+IHzJ/Adcm+S3iQK/vRtS0Wlj08YM9YFWFMFMkj93AANbkW3iZj5+3KJbwCR2LidvL4eCAP+Jg9MfDoGNQQRoBY= X-Received: by 2002:ac2:46d3:0:b0:52c:9877:71b7 with SMTP id 2adb3069b0e04-52c9a40b1e1mr3656409e87.59.1718286361823; Thu, 13 Jun 2024 06:46:01 -0700 (PDT) MIME-Version: 1.0 References: <20240610120209.66311-1-ioworker0@gmail.com> <20240610120209.66311-2-ioworker0@gmail.com> <59d82010-c24b-4e83-a9a8-0add8ba1bc82@redhat.com> In-Reply-To: <59d82010-c24b-4e83-a9a8-0add8ba1bc82@redhat.com> From: Lance Yang Date: Thu, 13 Jun 2024 21:45:49 +0800 Message-ID: Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D2430C0025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bckxz3re95i5or58digcezjd1ehwqzhw X-HE-Tag: 1718286363-257042 X-HE-Meta: U2FsdGVkX1/8gp64tQsGwEJSe89PRTEbKaieHVi8vtrQ15vFjXmrbEy1Z7pcW/Lhc19kijDPr+BUZ2foq87HDZWGW6JwP44+yDScK9IdKwB0rnZ1OV91FURUIMHfnv1sqobfcIwnYp0YiZT5wkdIiDEbwjUK0br1QBTrzJ4UHFdCAubyw51bMqcLeL+K+Bcl8391hJkNaeUSx8hiChcfPRAGa79QFEYG//73DhGeO7eHSOFNB97Qj0P4MQ3z54IcziIOyuDXXFWQDdUnVvmRR94HDc5el6BwUaD1w2AjDjEyQ55HLxfFUK/pxdJKBm6qLT07I5SCXwxQKYV7T+Sq5HNp9FYE7y1C90qwAhvVy6X5jK2S5kfS8ppFpab9ISJh1fPVcZMTAdoE3ka4M8CC8ePQwXSrtS3YC7JoIflfhdVcmjko/vQiVu4HulS53q4r9VZu3bG4Q3hRkpfx+SStmIcczD2Ip1wHxGdfeVDEVmIVPt1KScpPWz6cRE7AVYVc+aGv0HSaIGMYVCxTpPUpn2i2p24z7iXf+xA327pXO+9LTUz0UMzgiJa9PGNxzxesW0BQY2AeSxf7aJGQa5n0bebT1w9lB1fDOUU/3tExCPOoEAnT+paYeI/GQ6trMI2FG2jvMcd4A6yh+nSUzOECSmwr5jRaop5B+F0OZCt/CoKPIPMrfPWPeBGw6+DZ2ELcpCWPKZlK3HM7YuMIJf9CdLdeQDe/5Zz0qYqeIa02V7WJow20CclOT+13BW+I0WhQU5D+tB80BXm/JUm0rD5ZPTu0clTgdzFRa+NjCilbW3pJVTBEJfhD7isoMa8jCGRfZMIH7U1evPJiJoDZAG21+j0jY3qjs/OI+b/tzx4cSRORfwlH958di+36S5lkFRgv4QhQ6/aidy4aBpg9tEdh3p1+gB25qqr1J9A5pTvOHFk7eRpCXryzcreb0QtEJfyNPwO6dfpQeGKVy92A2am x0rmFMGF iZQ8iSXAfW8nnSQSktFDwBrKrFb1q8tLvX2f9S2UdwuF7n3ZqLkdMhbEl23Q6CPLC+MpySZFM7aTPF4GA1wXP/t4xVyMijyOEgznzHBtsakG4N5GRBs392Cak4BllZdKResqsPF/A6QY/DWGxAVzuGAOe6W3ZP0D8WBKcs9aalDjKWieWn3D02leZjGmXl2UzdQrswjc7nFTficfdwDZJUADUKEj5DV5xvc7pfsOJh6JpVcvmRlfhBKWlOvLLAZTmAytRh6sgidT1PeHm35zhn7EFWuiK/DMYVH0kFf58rrgCE8E08e5nZkXjJPtYtX6wGx5f1aDMU4gooefV6dScuuhDaJH+5w/Tj0zanQSM6ztJrhExOrWThNCGs+kzHggT1Tx/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 9:29=E2=80=AFPM David Hildenbrand wrote: > > On 13.06.24 14:43, Lance Yang wrote: > > On Thu, Jun 13, 2024 at 4:49=E2=80=AFPM Lance Yang wrote: > >> > >> On Thu, Jun 13, 2024 at 4:27=E2=80=AFPM David Hildenbrand wrote: > >>> > >>> On 13.06.24 09:52, Barry Song wrote: > >>>> On Tue, Jun 11, 2024 at 12:02=E2=80=AFAM Lance Yang wrote: > >>>>> > >>>>> Introduce the labels walk_done and walk_done_err as exit points to > >>>>> eliminate duplicated exit code in the pagewalk loop. > >>>>> > >>>>> Reviewed-by: Zi Yan > >>>>> Reviewed-by: Baolin Wang > >>>>> Reviewed-by: David Hildenbrand > >>>>> Signed-off-by: Lance Yang > >>>> > >> > >> Hi Barry and David, > >> > >> Thanks for taking time to review! > >> > >>>> I don't think "return false" necessarily indicates an error, so > >>>> "walk_done_err" doesn't seem like an appropriate name. > >>>> However, this is a minor issue. > >>> > >>> Agreed. As we only have a single walk_done user, should we instead > >>> remove "walk_done", keep the "page_vma_mapped_walk_done" for that sin= gle > >>> user, and rename "walk_done_err" to "abort_walk" ? > >> > >> Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and le= t's > >> keep 'page_vma_mapped_walk_done' for that single user ;) > > > > I just realized that there is another walk_done user, which is > > unmap_huge_pmd_locked(). > > > > Could I keep "walk_done" but rename it to "done_walk"? > > Sure. "walk_done"/"walk_abort" might sound better. Nice. Thanks for the suggestion! Lance > > -- > Cheers, > > David / dhildenb >