From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C203EC30658 for ; Fri, 5 Jul 2024 10:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 126606B009A; Fri, 5 Jul 2024 06:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D6626B009B; Fri, 5 Jul 2024 06:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF196B009C; Fri, 5 Jul 2024 06:48:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D03326B009A for ; Fri, 5 Jul 2024 06:48:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 62667C1637 for ; Fri, 5 Jul 2024 10:48:18 +0000 (UTC) X-FDA: 82305374676.14.23896B9 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 9AF25100003 for ; Fri, 5 Jul 2024 10:48:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AXUuOD9L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720176476; a=rsa-sha256; cv=none; b=WpImiOHQT7InJn74LHSbcFkNfYKUf9dK+c+VeRV7VxddvM+LNPuu98MAggozLifVcUVZvq 8cz2A/3JvqTaQuYC/STWEdVwvcqivOOE4fylhjDGhoEYwKgmOw2SwijESxr8gk+Xj2sRLA /Zm1h44J+/DtwxZ26/YL3dMZuBbaEnU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AXUuOD9L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720176476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGZf3oMRjehNO2BE/DWNFgwDKRxGAZLkBTWw8ufFXHM=; b=c6oLC5b+9gtXREDmMNiu/JmMBtmvoYaCkl/nFJPQr09Yzvf23/62Kt/prtz7FlauQk4aGQ aKW02UgqcWQmqPmyCLaUnKM3K/pdhnmRMgPP9nrkl4l3C7QrcLpwEarY/QDnNMTiTMTxAf uIdBuTyScc8xw3IHIFV6YHBX2QqIFEI= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-58bac81f419so2152077a12.0 for ; Fri, 05 Jul 2024 03:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720176494; x=1720781294; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AGZf3oMRjehNO2BE/DWNFgwDKRxGAZLkBTWw8ufFXHM=; b=AXUuOD9LQ25czJV7nfWa6YSFh+5BJhD36Q4a4UW0qKej1egzfIQQrjz/AGhyfXwwsU xbaCvpHGVRjuRWzcx9EdbK59MkdAH984MaI48pv6OPeFa4Z2RgJqOi/aZQZ4EKXnClc8 ZKXuWEVeoPE7KmE86gY80kDhBFbYlsth88AekEumh+vMyUct32fqiVaO/oTOEW7bZqFa VsEJ2U0JapnIlmCCdK+vidzPy7MN6iTsFoMCqp/p0q05EPokyYCrnyI7cE1QDoHaN6Lc HH0ndMDCwA9EhCNodh+oX+ECIGBThHx8qyMxGtPFZlo1N7+bK3obaNTt2WgUebU7Rqaa XNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720176494; x=1720781294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AGZf3oMRjehNO2BE/DWNFgwDKRxGAZLkBTWw8ufFXHM=; b=rfAN2O0jkngD86QkSPZBN7mfcIj4eSr3BM2htg3qKojDHX/J7qg+tIDpd/qjOm0iTv w3USKbE+Bg3mzpfKrfojGBqdXgR58B773xpkDS2L5aNNEqJLaDXdog3k/N9wAHU4EEPG ba/vSDW9XY9UFOCc0Y5BRGH+op0blA/CBZy0R8PUJs/GnG1FegCLONFF1WSqKdoWCr9P SO0xSt7w9g0p8InoaosL5mXcS1psIGw0bSwdgSYlA1wV0NB3iv4Al5tPi9nhnlZNpYcG 1Eq0GiPoRahtc9T+EBwtjqvr+fkSW75kogIBwx22frG0GGKwQus6lPmiZXtY1gnw1GS7 VQ0Q== X-Forwarded-Encrypted: i=1; AJvYcCVV8lycO9P0ZG7rZbx0Kwztdkmmd50mWKgoQ/8BpLwGtsPy1ZeZvv7crY6clAEoLfMnG8+ZxEJ9/mte9T3F/Htk9HE= X-Gm-Message-State: AOJu0Yyd7m5CmZ9d2K9TBJzdoufB6jdLRIAGC9LOKHDt6s+15BDBPdHz q2goP/fO4rIoEQpI1kM0rsMIFLWc5MBqZGvtIntWLULg8LhspAnQf+N9zrcApBRNWrQCOk6bsQ5 dcw8Nb3izN12QpWtJBY3ZLCVQuAI= X-Google-Smtp-Source: AGHT+IFUt05pEViwXK0y5svdhOT5z8s/1i61eTFLRCLW5ypmyknB/oB+aCe+XWTcWfYhWkjCVg7imBjlascAdNbz0pA= X-Received: by 2002:a05:6402:524e:b0:586:12f6:c0fe with SMTP id 4fb4d7f45d1cf-58e5916fafbmr2908734a12.5.1720176493840; Fri, 05 Jul 2024 03:48:13 -0700 (PDT) MIME-Version: 1.0 References: <20240704012905.42971-1-ioworker0@gmail.com> <20240704012905.42971-2-ioworker0@gmail.com> <677fc803-0bb9-48dc-a1ff-3ca1fb0dea15@redhat.com> <3aef2bc6-c889-4a9a-b35d-f10ca8a5796a@redhat.com> In-Reply-To: <3aef2bc6-c889-4a9a-b35d-f10ca8a5796a@redhat.com> From: Lance Yang Date: Fri, 5 Jul 2024 18:48:02 +0800 Message-ID: Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters To: David Hildenbrand Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, dj456119@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mingzhe Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9AF25100003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8ydu9tq19scqeeks4oyg8rysdbtr5bps X-HE-Tag: 1720176495-442957 X-HE-Meta: U2FsdGVkX1/yL2lh1//MYjU5fkwm+7anMiK8Hxtb0V7b+WLCejBHiQDNR/lDjwj5x1jAx7jGi4IChJlkjVG6pjS3QpIuB3KLrYMbngSj18aW1PEQFTjpmijcgIs5tST0FVgsYz95MaBDOXnBsR/As4McK2hW7fex+dONYWiIYC6vOSanpRmk8humbYUyjSXTxkuC9O8WlJz0M2O++IjJoHKopomfwUixp37J1rQborIW9S+N9uAKhQ1RMUUthfo7b2BF/R4zWP9WYu7KWbYtelqMwM1aAZ49OeaPnCSs96aysuUUB4CqKZg9/zVPWyXw/MF8WxJ/KsaBQVCw0GtYyrRcnzh3NVVoTKL24fScIulmM1TXAK4mxgI+y1auDnxAzcW5bhTaN11OWTK80oGBxJE6P9DWyf7zcNEZB34Xe9hV1/aph8I3nCa1P4jcnjCLjhO/lMBmV6MNY65ss5YHNFjtc4dP5ZYtx7vufW9Ssd+xGJ9x5kZ0BwhQgqycKPKaFOStCZBPoKP6JdybuWj+eMVKUspJ3zDux1gLzNDd9SLWRuWanccCLFA3wCtgHkcmMteyrAYGLaMH1n7lbYzRdTx/I3srDt08OX1gX035bD3BYYl48O3a22JyfDosJ7yCVDylNY1NgtPsEHa+ImcJVpNaoUxzfPaof+WnZ+ylYOcGGQeUorEAYm2HNddjTFuq6bICvpBFUcTwtTyWX0+YNryUatn31JWiZokDbjAady8HgV1/+Q0m/uqUiwbjvWNlhHWfc6DJ3Mx7cdu2D3zQ+O819UhxdphF2P3/uIHtY9vlyLoCXOF24fwaoqFw5ACQXebF28CGRRCbTJckrbujnZqmxHbk9Tz5m0yVMmNktxNgb4dnATV3FsQNworGNe+IH1dkpHsrt3UlZ3nHR/Ex31w9hdoFHTQCqPFai3bSZOXtOiQV72IUk4IqWTsUZW6voqdkcCqgLST95M1XjnH VqM6ZtjD A3T1G+u0pdhRk+ACrYQOPbLGo0qmFYmyIX60qZoTg5OZQ+4P6JS37lH0jx2snvARPEvbBukSmWkVLEYyS7w/hjm3GwMGET+hciYJ6M5L87BPxoi/pnTiR7+oOFX8Y7SLtCUOJl/7H0Y6NThGugHKrFVbwQnYmd4p6zcnfSuzvGv2VhGyslpThxCQ5IzUXNJW0D/MVVR+94qY4n/OS+DUhpOmFkIuq03af26c2P2nAMXNRfistmkLsOcHxOdLTO7eVhf2rqW6XPgl2LrZpHO4yndRafsh7jZlw4dB7Bc3e5lj28b/G1KMAvqK4UYequbr8/7bI X-Bogosity: Ham, tests=bogofilter, spamicity=0.003046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David and Barry, Thanks a lot for paying attention! On Fri, Jul 5, 2024 at 6:14=E2=80=AFPM David Hildenbrand = wrote: > > On 05.07.24 12:12, Barry Song wrote: > > On Fri, Jul 5, 2024 at 9:08=E2=80=AFPM David Hildenbrand wrote: > >> > >>> @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct pag= e *page, struct list_head *list, > >>> i_mmap_unlock_read(mapping); > >>> out: > >>> xas_destroy(&xas); > >>> - if (is_thp) > >>> + if (order >=3D HPAGE_PMD_ORDER) > >> > >> We likely should be using "=3D=3D HPAGE_PMD_ORDER" here, to be safe fo= r the > >> future. > > > > I feel this might need to be separate since all other places are using > > folio_test_pmd_mappable() ? > > Likely, but as you are moving away from this ... this counter here does > and will always only care about HPAGE_PMD_ORDER. I appreciate the different opinions on whether we should use ">=3D HPAGE_PMD_ORDER" or "=3D=3D" for this check. In this context, let's leave it as is and stay consistent with folio_test_pmd_mappable() by using ">=3D HPAGE_PMD_ORDER", what do you think? Thanks, Lance > > -- > Cheers, > > David / dhildenb >