From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67433E68945 for ; Thu, 31 Oct 2024 01:40:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5DBA6B009E; Wed, 30 Oct 2024 21:40:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0CD66B00A0; Wed, 30 Oct 2024 21:40:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFB2E6B00A1; Wed, 30 Oct 2024 21:40:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A19A56B009E for ; Wed, 30 Oct 2024 21:40:22 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D70041264 for ; Thu, 31 Oct 2024 01:40:22 +0000 (UTC) X-FDA: 82732191444.10.0125E54 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 2483A4001B for ; Thu, 31 Oct 2024 01:40:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KJjZfaNB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730338764; a=rsa-sha256; cv=none; b=TDqgvF7uAG431k7Hs/ny1Crqc/0nvo0DaJlkDCvxWuTtDFABuNfG05GV52w7O/2u96pz3s P+25T4vUXOJ+oFF0Wg+9nLsRUQ4UdFPqJhofRrEoQKjNqYZlomLJRrfwTpU5GGBrvbPhio SEmWX8rB0w1mcyvWnoo+Pg6npjX8074= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KJjZfaNB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730338764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KFR+bKCwvRVUX/BxiY5sWjZTz3GjZpROxqvWLTi/ADs=; b=QLOR6lRNkI2Jhu21GkOS8PlJ//hUE12uWA0ognBRPHijsR+8GF5q+05vFFkiYlPcGgnsZz mWDfdzlaAMF7JqtmGnLCNmwWXQPo435lhpuQfrTi9ijsXAojNn84wJlm5w2tXwwwmo6i4L DnII8balRdiuB41TWXQMKCimJ53dXB0= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c9634c9160so473052a12.2 for ; Wed, 30 Oct 2024 18:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730338818; x=1730943618; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KFR+bKCwvRVUX/BxiY5sWjZTz3GjZpROxqvWLTi/ADs=; b=KJjZfaNBhV1WV7hVZ3sjiQamPx7PANKHeKHjcDIkTDN/dF8E3q7KorF/ql/3xDN206 W9IL2jOL6pFW1tq7yKZmuhLSxJ9KlHYeC8lDkB4Wk7caF79+TwdEcPMvsbMhc4lv1u17 gOoJnW9vAqhLeFu4ZTeX/RgwreKWeFZkGQVz0xdWJiHE7fD9EHqhW/G9dANeb+uhfHKK 8CVS+FszcOjr1FzEtrBdlJ2dfQUT35Veos1qdmv5kGdLiLl3c+545Ul9awjh1xU3vBB+ ZFlA7dY32f1Fs8Ry3UXNgDZgLzfywabHTR8SmarLtuQ+cApZDwhQ8IDNC2GhFiOzgs4x /IXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730338818; x=1730943618; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KFR+bKCwvRVUX/BxiY5sWjZTz3GjZpROxqvWLTi/ADs=; b=X1OzQR2TPndMtwAKyFAJrhyrKPyLsZMDlDF9VXbX1aKlXxmtOt0NztBowsrZdHxuKQ 5WZijn+RtbvwC/6F/nYIkrHqpUzMmRrkYVSyVMb+Ff4cuftn89lX73so2I21nkyW4zzj QgAsnDxOOV7BW/erMyme82kSB83YlgmwSN0jfNPkkC0OA0nFmhn35IV+CXpbfM7ZPtXN Vrxi6kg1J+9m3tuQYxBaYKFZT2fiPa3SyJEjLTkLMs3t6gKhfpEycq1AzHgCf3yk5vdF u0d1luD6DU2Rzt2RYrnSeKnhfCxK/HcC+c6qKuv4crCFX3A5GT8ME5SKWOb9ncIlBMqQ +ymg== X-Forwarded-Encrypted: i=1; AJvYcCVu1cnbbQTaeRn2hq5Hv1FS+PkXmfo4hPp7LDuYfXr6a7Vie2B3v9TRjG/b1i0RJcBR8Gmya+VReg==@kvack.org X-Gm-Message-State: AOJu0YwwSDPuLyFds7VPWYVT9QFkMUpFCKZWrAM4Eixv136S6P4q9h57 M/ynhEKiotSp5AeF7fYyrSKlI9RiIzrxVrwuimdRc7sIR81JnkvNa7d4N7wuUCIU95bMR1c0ez3 1WeErulZ/zA/QvAz3GgpHac0xiD4= X-Google-Smtp-Source: AGHT+IHJgLaqlTk3oM2roWzZFSZzpTQuATiSid0TpEirjsjoVUFKzoTKPH5jyfrAx515v80ao8diru9MxcSS6gEH6o4= X-Received: by 2002:a05:6402:2550:b0:5c8:a01c:e511 with SMTP id 4fb4d7f45d1cf-5cbbf892059mr13375133a12.10.1730338818227; Wed, 30 Oct 2024 18:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-5-mcanal@igalia.com> In-Reply-To: <20241030130308.1066299-5-mcanal@igalia.com> From: Lance Yang Date: Thu, 31 Oct 2024 09:39:42 +0800 Message-ID: Subject: Re: [PATCH v3 4/4] mm: huge_memory: Use strscpy() instead of strcpy() To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , David Hildenbrand , Ryan Roberts , Baolin Wang , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2483A4001B X-Rspamd-Server: rspam11 X-Stat-Signature: 5qjxqyazq6qqdzhhus46y8yqbgf4takg X-HE-Tag: 1730338807-243778 X-HE-Meta: U2FsdGVkX1+R/sTACEpVv3aRas9odG2thoqXU8408JOkq/73A5m9WKtqttw/rDcgKa7+HGmPL6HlYMFUSzpNvF+0t0LVYIDyxWcxRkhYHThcyspxkxeCa7HLmVCX8XJx3cbw8dVGwhfmEvdN3V2R2qJLjYdry+kYsM+Ibz6lIxDeIlypCN5QYi5haFA7dCNe/yMOIxvRka3qfSyzK2J1rtQjahaFtT4GSPh4Kf/26qUseTXV3BEABEb+LQP1iHlrRyG9C49pEpQZ0BvbAeDBHAhPKbltOaGTBWbwgRcWLrP8dr/Vaukmxk4Ng62pP7NWxhHXFNx0OevTZxJHwP01d2VbuWPU7WA2wp3wXzc9Cw16fiwVkaZ3pWYFjBDl5ZzwTZHF3lnTb+XpPGuJ9f58vWItSGvOxIKkfp8U9W6MFXxRuNPOHflljP9uFpwN5AmfAz4vHTq3a8fyYM4dWIeFAWpHPT8l7APhkBsaldZu/noCrBKKy4IeKxOvutornnQeyWHTTkcQ17JikC8ZF1weMOyBQ/xRPCSUvezeSz4JcP1p4YuO9zAkQYDXoffgb71eL//C5LEhftXeHjdMlBuzslv2YO8RDFd1jOhv3YD0ygLqMajjHSO78Wf3TEHQZhWwyrVAcWOPNa5vp6h3T11SauJPsEucRz7FFc0BjEVe7LanklKDv6TYlrxxtzq7UvXVvRkoI7bonDGZppDypITx6hM7YvlzruFwEHJFGr6qGvGGgt5DfYNS2fHL+baG2VWkE8XvLIbhnClyAtc9S6A1SHyaXBsKCczauk/26pvw2XKTBBky/QnCXYKbi+8jD3NvCvPAQhdnN7BSlTjqK/cusIRUFuOxRmT7Y0FxgJ+Ixx100SxWVDRPJ71/0EbV6aqyALz/P1w57TZ3XSSfEeuEe0acNqcmnS/ov8XGiJab04QNm4gvDLIDWfQv3Q8eFUNX9p8T+lPrlGYG1cJ6AaJ 9sWzdyXM wJIREF0i337F5mtEK1IGHOzZwJw0DRdfEEvFuYaCWesXO27byvjFFdITGFuN4c8ZmMmf1CC8BZmy0d9vmZqDtA6EJZMCcTFRezo3PJASzwHLhLbQnxyPbEYCK4lK/Jw22HkBs4lhyAON6jWQDjI0WO0uNklwzMuVEO7J2xaaYI4dhuP7suUxTP+ZL//+kZ5kc1Cg1g5bAbYnVhrrrOIKgtpb0Dz8SbMRJzTJxHgP7+oWzbwzj0YnA8WUun+OT7Je+CwXGHl1/oURda+EsctqZK9BHtVgL/dFCho1BfPaqMkr0sWpb9hiuUCtqE0BIe6gc4ajjlXS4cyzmOJp815xPEZLCxM+QXoAcBeoC9KkWi4xuxZWt/LndN9N6g3HhOGBPSQfvcZ3DplliMjesbF3ejwmEIyZbPsLlzbxK3D1ruLlOqPD6UGaLrrToRSAlGke6g4HjpWYMAbe0BFU6L34nCktend6EMwCOhgud X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ma=C3=ADra, Looks like a lot of kernel code is still using strcpy() ;p On Wed, Oct 30, 2024 at 9:03=E2=80=AFPM Ma=C3=ADra Canal wrote: > > Replace strcpy() with strscpy() in mm/huge_memory.c > > strcpy() has been deprecated because it is generally unsafe, so help to > eliminate it from the kernel source. > > Link: https://github.com/KSPP/linux/issues/88 > Signed-off-by: Ma=C3=ADra Canal Feel free to add: Reviewed-by: Lance Yang Thanks, Lance > --- > mm/huge_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f92068864469..8f41a694433c 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -989,7 +989,7 @@ static int __init setup_thp_anon(char *str) > > if (!str || strlen(str) + 1 > PAGE_SIZE) > goto err; > - strcpy(str_dup, str); > + strscpy(str_dup, str); > > always =3D huge_anon_orders_always; > madvise =3D huge_anon_orders_madvise; > @@ -4175,7 +4175,7 @@ static ssize_t split_huge_pages_write(struct file *= file, const char __user *buf, > > tok =3D strsep(&buf, ","); > if (tok) { > - strcpy(file_path, tok); > + strscpy(file_path, tok); > } else { > ret =3D -EINVAL; > goto out; > -- > 2.46.2 >