From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E37FE77188 for ; Tue, 14 Jan 2025 06:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0879280002; Tue, 14 Jan 2025 01:06:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A91A7280001; Tue, 14 Jan 2025 01:06:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9321F280002; Tue, 14 Jan 2025 01:06:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73AE9280001 for ; Tue, 14 Jan 2025 01:06:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1DF8B12073D for ; Tue, 14 Jan 2025 06:06:28 +0000 (UTC) X-FDA: 83005022856.16.5803809 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf21.hostedemail.com (Postfix) with ESMTP id 3A2F31C0008 for ; Tue, 14 Jan 2025 06:06:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M7dHs7OS; spf=pass (imf21.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736834786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=813evcyTv8dumTUalEYwn1B2vgVA+BpviWK4C0TXDy4=; b=VKvRA/A5cgTvDBjP/fy/NIhaRNqascj9hhPwdR1NQ/vHF6wyqnCrOEAwYb0mCRgpMAH6tw b5dg1XpFaQV+Bl8hRuZtfNKohfztIR/MqeMkMsxR+XWjHPTgNcYbByYg8xJhY3U0+6D/fF VhQPJ0135EqRYH5wFcjNOKwhI7x9tP8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M7dHs7OS; spf=pass (imf21.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736834786; a=rsa-sha256; cv=none; b=Tcz+g+ac9PD1rYDA2KnOIcK3ODBC1SNSYdckOGk2N6RgkzcY3UfsbPOcSu8hme8rYW1cY6 1iSwab5/Oq3FdUcP7isDvtC+agu0eGXqBZm8/dymi1PtLJygoUM8zgZ+LTIqtjLNtveVAc 3qvpDuhIcvtDWfruNhMZvbysxdILrO0= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso2436438a12.1 for ; Mon, 13 Jan 2025 22:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736834784; x=1737439584; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=813evcyTv8dumTUalEYwn1B2vgVA+BpviWK4C0TXDy4=; b=M7dHs7OSXyBR9I9tT3TmWzCgfwrQoSWDGfoHXXIXqk3yg+7/ar4y6ABjYARB3LMmRk b/n+UOa6+yG91MU2wHa6kPzfbLBbxQKCRj6x1ztC2WZ3i9ybZbKM17UmcNKLIrdTYvu4 VKHBaLKTFvy2tF3FklNLIAxvS9oUt3N5EJzCZx/nOjTxQEhI2A8X/jblFg9GhCL8nAMl qjxdSp/urMlqP6woPi4DI1mCnHbiAZddWfd48hxM9duo/OI9/BcRGBlSG1Rl63c3EdF0 6/hHm2Zbf/jMIwTPUga7P4d7l/4lPyBnRmtCZH+pgRHPhi+CJ+7lF4x5v40TCeUoKtHn 08hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736834784; x=1737439584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=813evcyTv8dumTUalEYwn1B2vgVA+BpviWK4C0TXDy4=; b=jwW/+Io7lIreaL561I79JOZHdj7wFdCAX7v02vPoEgVRfBzhdSRyM262pkgbOE2jLb ca+WZuoH7J9OQMuhmeZDhjYMlT+iEU5s+qXegTWY9dPrFtAZCpx/GqclH9q4EdNSpIc1 JuvQen6jG+mZQ+7BWHQZTckG/6Q6Vf1jD/62wYETRN1Kdrv2APM8wibYg8flIwxGbr5k XmupSLmsZy/3vpQo/uhHBnQ9xv++3WITiaD8qejHDfzdQ/GqO2J1LVgOuhO+WY2yKXHs AUdGg9mSjrJfhaIy4ndYTDaYDgrphUdA1d2fQPjEHmdnWJEi9H0kfBBlCveNtCj5Bgd0 9jVA== X-Forwarded-Encrypted: i=1; AJvYcCUbQnZTG3TX8PAHrLkGUSeLCMDQda6ZAYKnE5R4dW11SPv83cutpicMK80UIBcPAYdquMXEPLbK/Q==@kvack.org X-Gm-Message-State: AOJu0YzaZ6Zh9QmtH6+BLCO74ElWcfaQijB2OjWTQ0cOk3W9npnkF/dF VNP3dcXfzWHyrhqMDCIK0Ywt9VChaXT7nB59ExGZjHUorP/xTUm6v79P73r/RR6aOtuXVrRD5T+ +0iTl87uHyXeONIHBEIEvKDsNsGk= X-Gm-Gg: ASbGncvAsfQtayrk5dZ3rv4eYUb/GScwWVzoFZxlPQcFSmzkuj8XbomTU7nAC6jiFq7 LEXZ7EmaUnLI1ZuBO0mskVdGrtc7P2ygqtm7neGz5 X-Google-Smtp-Source: AGHT+IGkZGoUQKrZFs+YqDR5CNO8Djvct/1D+JUD7ex6JEhA7MIRrWBGaDCX2KJEAguOUrZdlbMw/i8LQv8/JctIJLk= X-Received: by 2002:a05:6402:3903:b0:5d0:e7a0:154a with SMTP id 4fb4d7f45d1cf-5d9861d6778mr17916783a12.8.1736834784411; Mon, 13 Jan 2025 22:06:24 -0800 (PST) MIME-Version: 1.0 References: <20250113033901.68951-1-21cnbao@gmail.com> <20250113033901.68951-2-21cnbao@gmail.com> <21fa516b-8828-40c5-b5cb-d97cdf01f0f2@linux.alibaba.com> In-Reply-To: <21fa516b-8828-40c5-b5cb-d97cdf01f0f2@linux.alibaba.com> From: Lance Yang Date: Tue, 14 Jan 2025 14:05:47 +0800 X-Gm-Features: AbW1kvaObrzFbF6tRqgXeGqHXmlNgXzvexniwwc3YO2ckaHIxS1F0kSUyHHydB8 Message-ID: Subject: Re: [PATCH v2 1/4] mm: Set folio swapbacked iff folios are dirty in try_to_unmap_one To: Baolin Wang Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, chrisl@kernel.org, david@redhat.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, linux-riscv@lists.infradead.org, ying.huang@intel.com, zhengtangquan@oppo.com, lorenzo.stoakes@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3A2F31C0008 X-Rspam-User: X-Stat-Signature: 5duoxfzuhm717fohwgb514qizc3yz6dn X-HE-Tag: 1736834786-674162 X-HE-Meta: U2FsdGVkX1+rcoZ4Lvblbc2qX2tvBht3rmixLXsrweDOTLdSZmJFsDVkFnVPk5bvSCDVPxy4H0DBBWF1Dp/322AGE8hs2uZyf3/tutXfVK+TGmG9DQSUqZmyTwI7mjsF0ORSqjskPGbYXpy415sCmJU/1kkbScfpLPc09qLGuuFiohCeR4CyIRCkNk8e6886poCPtTExF9yTvJhRDI4BknXBneiGURRUvWMgzdO3K0W20EgzG/aGVrSo6tUS3KbcoPH+haOOsnEIvz7GfYH7n/FrbUZh7MQ5dmp6yzARTYtmKiFz/8ZGXMpBRo4Gi1fw8hMvncVQFg/nSHHSPj6IasvdKlyxy1wAGubJgetPpSon5NH89yPPXMfkAMYXGuXnT99vn3PsASmkIq4hNwWECjNUCVa3ot5Vzd5zq21kPQrGnfqTSj96Hw7+BbrCh61X7jADMgyc+THIJMes5JM/kDf9YxiJNhWjwDHDIx/l8ubPIsOfZVyk0ghhWVh45+hTCJGrQFerY3pF+v28tuc9qwHfvbIvnWEsOYby9yjfIMUVgtE8yloYLqxl88SrsKVmTcuPtxkhK47P1W0pEzNz7bR9ZPSovndpvAPaLZi2GThFjAXxeDYcBKiJm3oL7VkABpzDFl2Ra/rnGgmSvF6cNhdR/oavU/Jy8lsj6QoS33QKWF/A3hGkRvuwkku3x5GEcZ9MRQsR79oQ0x4UrEGEnuFODZsjHpqEmBtqEqNY+aJFqfTN8403y54gfgxC6L1C5K6YCPLvoZEdxkSpopV75cYTKZCk4aEWorRUOyp68T0ITTpe+xsxgdXcmKbriPbV4NEvEI/4rVqRP5qK0aj7xD5IZQc4zUVjQsjHRZ4maQv89oGTOKUOnh9m8/6pZNay4zfy0don84PGoBNcWcAjNp5t55bSP+9DfxhnZD9AP1RXuGsb2QQPAlGhEZcJBnel1ndsB72z7cw0vlNiMUc P0iVhN2e gWsMWgqdBqWe3kd+boKO0OMD9GnYpFK0hFZBeQhAfe+ej62DLXHFg2K13QpHCwR4NsKCVz/Lvk2wotaZv+Cf/SeJ4kvHyuYuCzFT7+kE+I2JekxiT5MCHZarMWOhsi86+HMsHGgeDHLy3YSA3EA1ReHe1EnjZun+EVwQy4PyomjZm21NG0WrhxYfXA+0Ir1f2ATZ9jTcopr2Eq2n9EaWKv5a3yVB5/Uyt+78UOQ8oFEKdaSJxuKu7mB3drqtHjof98X1gBfnkMyqZElaPPE1p3s3W6291D/5PBzjxUP5CT0944g1DcNcISS1zWAlZ6z5Ww2jgy2wuTN+mEYpLnf5rngCXZAYIRh7xtZ2L7kTQx9YX7hbVIR3xjobcFn7jgWBSQy8PxJLuOuPD5+SYWOFzocCyQmdHJlAAEFoqq5338SkD9EqOamkL+Gq5F0BpCO2oH1+eBiXxR4dDjoo= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.477396, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 10:56=E2=80=AFAM Baolin Wang wrote: > > > > On 2025/1/13 11:38, Barry Song wrote: > > From: Barry Song > > > > The refcount may be temporarily or long-term increased, but this does > > not change the fundamental nature of the folio already being lazy- > > freed. Therefore, we only reset 'swapbacked' when we are certain the > > folio is dirty and not droppable. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Barry Song > > LGTM. Feel free to add: > Reviewed-by: Baolin Wang LGTM! Reviewed-by: Lance Yang Thanks, Lance