From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07991C27C77 for ; Wed, 12 Jun 2024 14:16:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454EE6B0083; Wed, 12 Jun 2024 10:16:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 403836B008A; Wed, 12 Jun 2024 10:16:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A44E6B0098; Wed, 12 Jun 2024 10:16:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D0D86B0083 for ; Wed, 12 Jun 2024 10:16:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 289631C2C1E for ; Wed, 12 Jun 2024 14:16:36 +0000 (UTC) X-FDA: 82222437192.23.D760EB1 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf17.hostedemail.com (Postfix) with ESMTP id 2DB5E40002 for ; Wed, 12 Jun 2024 14:16:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JEEQugOg; spf=pass (imf17.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718201794; a=rsa-sha256; cv=none; b=PI3/pP8hnQ5EhUKQ39OgCYqOVxtTrP1JrzW81jAPMje1MycgwTumh841HGXRyUsa0jjKR6 zF0BTP51VpdsHNn8YknuRjyvur5IQD1i53oVdU5zuvHlDmebLB7axnFkCg25jaqXvStelN qG6pKfx5ibzft75DJkKaWpF2S8ANbNw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JEEQugOg; spf=pass (imf17.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718201794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXFeQu/InAtcwu283qRDGnx+2udBV3ofp/Fn0b8L8Uw=; b=xmRbkEz0qlJQfdVhP015SSL4qpOV5YSQ1is4HJ4NOp6RyVramJ90kOSA10ItPNhXWpKiHI x/cAyv2Bwjj0xIt+HLB72gmmS8ogx7VHth/talA1I0fUf/Gllf+IGKS3BJBPnQSx1ixW86 0TcCGFGTzBVRvCJrhEIyt5mEQtTcEFU= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-57c83100c5fso2902977a12.3 for ; Wed, 12 Jun 2024 07:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718201792; x=1718806592; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SXFeQu/InAtcwu283qRDGnx+2udBV3ofp/Fn0b8L8Uw=; b=JEEQugOg+2wBGkTfP0HVswx8MyysbinRUKoPO1OwLf05EUypgT0eKdP01VqEDGSANS 5HBLFza/K0qbb1+AloZPztlr31lrQMMzvknLntifF6kH12FJSj+LNZTFz2n/+jI/w70g m03ucvNuYc60EuJHvBzGvuwki47OEYOyPORYaKil9UQTPnJZW2vUFmrPdxR+UeXrGphF FAMDY9KqpsChhtcENUJ4ZebPwPLKBHKtxSev/67XNx9N76g62FCUtT+m92PyQtdz483E jfZC47Bc6gupD6hvqsNcfIeprLcE2MYCFPa9RZ4qGvNUrZYm2P8bTEAtBAmdySE8tanE 6eZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718201792; x=1718806592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SXFeQu/InAtcwu283qRDGnx+2udBV3ofp/Fn0b8L8Uw=; b=LVePakmbZ1pBQp3zfj7D1I8VY/DYu+NCuQZEv9pz+jNrB87xe9F0kzD7CS3XPvyWV/ GTiYmkwYfFMui8gaKfCG7BiGon/MmUn/V2qlAfH+ja3BRknQCocca39zLMxx1A0DSePf mCyeQdEolsM4yVZncQEY8GAm10An6LWYCmRApxqGg3CrT2fzjG/Ma+jnCtwl8KGxW12A SYbPHKklDpMhlFARiS5SLRZIo3BqvytDbj0Zlgko3guANtOX/bInx5Rp/AJoRXNHvefz AmZhFPwRDbPh8Nhtf1gF4pRAGT0CA6YwJsYaAg8QxzsARbfa5Rpl7uIO1wbIYQDgj73a uPRg== X-Forwarded-Encrypted: i=1; AJvYcCXcVkpprpl4Yd9jzgYzXLKisL3bgXHhgJyUA65gUTfltJEZdY5rC+tC/687AlGFEfjWIQ7JKDoYBeL1vRkasiRigOY= X-Gm-Message-State: AOJu0YywXF8y/iMZqAtuhJwFv0s/rNgE4GojBF2m9ldrXWJm46TTsysq vab92AscMG5kOTAuK0tIrpgbWowlvnU8K3xFafFPPoMXp0Q9lDRBHCI+ZrsGhjwPxEg1O8Q3Y39 9yUWoauTLIryqNWg9fpWNEpUkqI0= X-Google-Smtp-Source: AGHT+IHW/hXJG+TBumCiBmHqhgd87pgriARFMrlfHwt20rM+xtCGUrKlVfeGKfk0StJxgwQF6b7D2BSQv+6WeSAyOU8= X-Received: by 2002:a50:9308:0:b0:57c:947c:f9cf with SMTP id 4fb4d7f45d1cf-57ca975348cmr1205743a12.11.1718201792124; Wed, 12 Jun 2024 07:16:32 -0700 (PDT) MIME-Version: 1.0 References: <4fd9e467d49ae4a747e428bcd821c7d13125ae67.1718090413.git.baolin.wang@linux.alibaba.com> In-Reply-To: From: Lance Yang Date: Wed, 12 Jun 2024 22:16:20 +0800 Message-ID: Subject: Re: [PATCH v5 6/6] mm: shmem: add mTHP counters for anonymous shmem To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: uxubx734ek3rghe948a8fg5npqd655ir X-Rspamd-Queue-Id: 2DB5E40002 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718201793-596816 X-HE-Meta: U2FsdGVkX1+tA5dG+KfrbIHIzcZ9zxztw8Px+JSmj3N3m93w33fa2VF0wrw1ZB3YnP3Q9iEsFPbKkl+9zSMKp0QqEOD4vHl+ZJYHBUqzmOv164FPgjwOTmiUmfnefi9IMK+bIRv6MqNBL7BigdJmw/8Te0dohuXZt8jckGy3Tboo5yb2QrnI4ld63LYQOGnke+bXCTAGXMqXcXJvTX2u03VOyKhpi9WS4N6Acs7m/s4aEYYCnxFgYOyyymj5sjhm95iDrY87VfUhBM/AvP1sg0qJiTfApbEKAzScIjME5lbBN7yO3U8GemXlFwY7bnzAHR2iUxu+wHQFGdx/sznuJ/n2ypJUpmmvLL6lm8ZiCrMnsSPIkrypZN5coMIetkCGPUnfebsGb8GhCnhNSoQRlSO+M1Jvxf98oB2jbuIakOSJxKr2BJ6n4pteenjjQ9yCodlEdLhVl9P3Y7UAmWwvzosWFtQoKclx59T9pvlPgGiVW9eDvOzmUMoqROrY4q2mmu26x87qM1hr5kpM82VOrBuAIOHcsnxPwykP63tirdoyNMeNWOllKk221+3uiRExGThTtbqGFuForJp2xawSO9QYuXMOp84my/fYm6m6URJe8ZIzDQo67GixNKtQWn3Ybhp0Vmt+52UQBcSHjOVRy4iuMJ3ZME84l3wtQLP+MAkFtujTRw5aq4plZRtAqHGKp0oEaBUuqxPUXd2GgF5zZNIR6ELpHxClcmeVcUADpGRcBDnvgo08gS5KzQDr9Mvhawp+7ejVHSNv87o+EAssUho0YYjuOpKiS8teKRoJ6inhT7gcZIJgpwT+tlescxrt0s5vA0/xDI62zhJ47UeqcFuz0JspuGs0LdnqDZS0RxZaiOzEjkQX3Kzz8cR+Kjuc6USaDhMVECCmETB4qyEMXIfO69GjYgzWuKDCyfYFVPjMqcrX1tzC/ovy/HbKOrJwUFIb3zChTd9HqrFUny6 RqEMqNhn u7VTVKeYpavAzS/3QgrghOKXCxW1Hp/OqV3zr83383dTN12Umbot0gSGBpOlGKS69Otas/5dKnrWYnGbiFh58xxCf7doi9Hmi0oJ9kLfiuBUbUeBtmQjIvJk/urlmzDPfmTulg/yeqo/OeQASrVNipPqwBflDWGBy5ic0CNzrfl5TfnJIXeMoxQ270bIUi44MgYcf/28z+zfbkCF/fJHglupf31hSdwOr9//ziOLrzS6dOT71rQSVrm+uBS+7vfZAlLokU3WKYEZ2XPFV4mgj6p+VTtCgKBtCpaL6DKUv+CxldZ7iRtw4nWtHDuyE3BpbD0zq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 5:28=E2=80=AFPM Baolin Wang wrote: > > > > On 2024/6/12 16:04, Lance Yang wrote: > > Hi Baolin, > > > > On Tue, Jun 11, 2024 at 6:11=E2=80=AFPM Baolin Wang > > wrote: > >> > >> Add mTHP counters for anonymous shmem. > >> > >> Signed-off-by: Baolin Wang > >> --- > >> include/linux/huge_mm.h | 3 +++ > >> mm/huge_memory.c | 6 ++++++ > >> mm/shmem.c | 18 +++++++++++++++--- > >> 3 files changed, 24 insertions(+), 3 deletions(-) > >> > >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> index 909cfc67521d..212cca384d7e 100644 > >> --- a/include/linux/huge_mm.h > >> +++ b/include/linux/huge_mm.h > >> @@ -281,6 +281,9 @@ enum mthp_stat_item { > >> MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, > >> MTHP_STAT_SWPOUT, > >> MTHP_STAT_SWPOUT_FALLBACK, > >> + MTHP_STAT_FILE_ALLOC, > >> + MTHP_STAT_FILE_FALLBACK, > >> + MTHP_STAT_FILE_FALLBACK_CHARGE, > >> __MTHP_STAT_COUNT > >> }; > >> > >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c > >> index 1360a1903b66..3fbcd77f5957 100644 > >> --- a/mm/huge_memory.c > >> +++ b/mm/huge_memory.c > >> @@ -555,6 +555,9 @@ DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_ST= AT_ANON_FAULT_FALLBACK); > >> DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAU= LT_FALLBACK_CHARGE); > >> DEFINE_MTHP_STAT_ATTR(swpout, MTHP_STAT_SWPOUT); > >> DEFINE_MTHP_STAT_ATTR(swpout_fallback, MTHP_STAT_SWPOUT_FALLBACK); > >> +DEFINE_MTHP_STAT_ATTR(file_alloc, MTHP_STAT_FILE_ALLOC); > >> +DEFINE_MTHP_STAT_ATTR(file_fallback, MTHP_STAT_FILE_FALLBACK); > >> +DEFINE_MTHP_STAT_ATTR(file_fallback_charge, MTHP_STAT_FILE_FALLBACK_C= HARGE); > >> > >> static struct attribute *stats_attrs[] =3D { > >> &anon_fault_alloc_attr.attr, > >> @@ -562,6 +565,9 @@ static struct attribute *stats_attrs[] =3D { > >> &anon_fault_fallback_charge_attr.attr, > >> &swpout_attr.attr, > >> &swpout_fallback_attr.attr, > >> + &file_alloc_attr.attr, > >> + &file_fallback_attr.attr, > >> + &file_fallback_charge_attr.attr, > >> NULL, > >> }; > >> > >> diff --git a/mm/shmem.c b/mm/shmem.c > >> index f5469c357be6..99bd3c34f0fb 100644 > >> --- a/mm/shmem.c > >> +++ b/mm/shmem.c > >> @@ -1773,6 +1773,9 @@ static struct folio *shmem_alloc_and_add_folio(s= truct vm_fault *vmf, > >> > >> if (pages =3D=3D HPAGE_PMD_NR) > >> count_vm_event(THP_FILE_FALLBACK); > >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > >> + count_mthp_stat(order, MTHP_STAT_FILE_FALLBACK= ); > >> +#endif > > > > Using the conditional compilation directives here is a bit weird :) > > Would there be any issues if we were to drop them? > > Will cause building errors if CONFIG_TRANSPARENT_HUGEPAGE is not enabled. Sorry, I got it wrong :p > > > > > Since THP_FILE_FALLBACK is working as expected, MTHP_STAT_FILE_FALLBACK > > should work as well without the conditional compilation directives, IIU= C. > > No, you should take a look at how count_mthp_stat() is defined :) You're correct. count_mthp_stat() does cause a compilation error without th= em when CONFIG_TRANSPARENT_HUGEPAGE is not defined. Thanks, Lance