From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2681CC07E8E for ; Mon, 22 Apr 2024 13:50:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 869D96B0082; Mon, 22 Apr 2024 09:50:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81A406B0087; Mon, 22 Apr 2024 09:50:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E1BA6B0089; Mon, 22 Apr 2024 09:50:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C4B96B0082 for ; Mon, 22 Apr 2024 09:50:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 75D971A09EB for ; Mon, 22 Apr 2024 13:50:29 +0000 (UTC) X-FDA: 82037302578.27.2B7C7CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 6EABDC001A for ; Mon, 22 Apr 2024 13:50:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ml/s4HU0"; spf=pass (imf10.hostedemail.com: domain of aahringo@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=aahringo@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713793826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ePT7cc/aNJu9XoRcC0vjX12uSyiKribwraAl/sl33xA=; b=xKo3ZU/brobVNFrdjZGP+yg7X8Ds44H3igu1wr1iIl+b1rNDMtbnJNAc27xJN6r3FKpEYU A0guWF7U5HYm4DveKygcKWEqqHDlUR/YEMNWRPrAyp9DyfwpvFPEJl4YI7gRg/D026gR5L Tumkc2yLCbbbChZlZqJR7pdj6z5u4b4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713793826; a=rsa-sha256; cv=none; b=zvRB8uVwW1tE3jiop9uHEFt4fFPIJxScrIuJgI1JeB89X1U5rCACCiPyTC60SGCHq6NQha 6aRCQcR4jZzV6GgypwZVh+G9pEIBIm4UzHzy8teV1DyqRzvHLGsF9KuRGVXfX14buyFnfe 6YMk1FW8oruW7zD6/hY6SpDBSb03QNo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ml/s4HU0"; spf=pass (imf10.hostedemail.com: domain of aahringo@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=aahringo@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713793825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePT7cc/aNJu9XoRcC0vjX12uSyiKribwraAl/sl33xA=; b=Ml/s4HU0ZtTK9/xjiT86kF8HsoIRp5WF2QMlYTvAMtu+R1D3q75gLPy0q2kJbMqAChZ2Hz lt9ajiqgNAyVU37GxlVSqR3Q+kr9g/x6Na1cDgr16lwe+Us3Imnx3/UUmKiYCPEcwFWPyV +Squ9/CfzF7y4SK6CgvzH4G2p6QgeJw= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-apRLdr-JMGy2iUj1kwidng-1; Mon, 22 Apr 2024 09:50:24 -0400 X-MC-Unique: apRLdr-JMGy2iUj1kwidng-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d865b3b04cso27036621fa.0 for ; Mon, 22 Apr 2024 06:50:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713793822; x=1714398622; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ePT7cc/aNJu9XoRcC0vjX12uSyiKribwraAl/sl33xA=; b=bcngEQIxgEJPelXE6g2W0eTmQhIY0sWREGHFSmuIztkIyoBXe7FZdBUeYyENnp6TVa 7xJpq8nIwIXkkvC74rV0fKHg+CRMZwKVLOtFh8usH5he3wqnbjRxJZu7TBFnhPV9MYHJ G4mO2cFTFkdYL/hNB2Yx4hjYi1a8BqsHzdaRnBgiuY/DI+cPmijvQawcJ3ZK/1LuVm62 fEvSB9BPULqHwlXUXCbz6mWHK2v1mxlTla8xSEZWg/8uo5aUO0ER2D4buqZ8GMK6FjcM ZZqocVSf9q4/KAwTQZGXbSQD5JDVrWssbEj1USnTV297Pe3e5XhC0NOsXRvqJ+jt75rY qwPw== X-Forwarded-Encrypted: i=1; AJvYcCWXafms/oAPNgA/fcklKCUsUnE/x+eir9NvyZx0sVzVB9TBK8+XlyeU7yBa7YRoDvfjCRs46bepk/73ldc/+IVZHFU= X-Gm-Message-State: AOJu0YzJIdkh3YunOUl+eRBybJ0Si1QPTtrPr69mWMDAdRJheql1bjX3 GzDBC6sLQCBy11jjLYmamc1Vu174kfJpRHxNouNwKBBSIjjM/xHxrR8RIQnnfPJUEd65jVxKBzU bS+Q8WIF6vrhFJ7ay+KkqM/9sm8pxPz07NYzH+cdg8uqse1MGqdo4mH1qoBUKLWbdsY8eOvJe2s zRyWtmyXhthojp94rQ24UWN6o= X-Received: by 2002:a2e:98ce:0:b0:2db:2385:d02a with SMTP id s14-20020a2e98ce000000b002db2385d02amr2808490ljj.22.1713793822478; Mon, 22 Apr 2024 06:50:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZYR8Zh/oxxhfcKpxYxLO0px3lM2ejr/cz+74VqOsz3y3mlUkQPIxIIcQ1hd/q6nUrMdg+RsBCDN4mTPvA4N0= X-Received: by 2002:a2e:98ce:0:b0:2db:2385:d02a with SMTP id s14-20020a2e98ce000000b002db2385d02amr2808480ljj.22.1713793822036; Mon, 22 Apr 2024 06:50:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Aring Date: Mon, 22 Apr 2024 09:50:10 -0400 Message-ID: Subject: Re: [linux-next:master 5836/7122] fs/dlm/lockspace.c:566 new_lockspace() warn: missing error code 'error' To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , David Teigland X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6EABDC001A X-Rspam-User: X-Stat-Signature: xnginjhwzwkh1qkbkyqkbkk7m9cioykg X-HE-Tag: 1713793826-651413 X-HE-Meta: U2FsdGVkX18J8vX6ei+I0BFuSYkHVax6T05/YLsU9mMQ+tINdjoBTioFiyaQFAGn2SBd5fThSI7DtMgp/MLeGroHMyGxBdTWWFhxQOmUxjXFSj1X3II9Xbxzw2rykVj12twi7MHdm6fv5m7TlgmFBw9wX7jAc8OO8qkY6DZInBqeU1sxBcxqJBJI4X0aLBPB/ALG5Sg+ycPx0ohJ9MFOUgXQk5plGN1/2e7vtW3/LPNfbuaucLzEGOXc+wHZSyEYUtkGXXNBB5EWawjr6W28Bv7yFc3UIUY/oJ0bXF/JBEovxPNIj3WY/A9nuxvRfiQtVnp7wBLDt8Jmp+U01nBa/qbmtAw/ePoUL99Engzo4KudHLEqz1zTNFDdaRWn4LnOLUDcumQRu+4xntHZyaE/ZniiVu/cDJa+xeTWuwKTnQM7P7INQNSo4kpvM3uRbsXeM3XWWJ1Hoi2Adhbze2fFWGxiXzYNlex+ewkguu+h/ROtsB3HlcM7dzKw9YnHhdJK9gVVHKpnn+bOa6Zc06pDoWdNYjN9Z/u9KOFPQemzMJLqFOiF3bL9o+x9F6BB1glLLW9JAa/XwyMQBLRz1CfUGDwQ8VAiqmBd7UIb66nExQa+L6bpXtzjx+XH3Hu/EjvNIDg6fuN+pSSArLBa3JZV5xyS6CKFMxnd3V1yFDCZrzL2oKmlGXYDdsW9cX0A6lH9YA2ZP7hcv3NSEAmdpoGNtZFpKzBLhZJpVdXCVYuH9hvMYd5jFy9ZpsckQkgX+wJsc7xc58hT+Sd4I+XTMECJOW1HVjt+LstXaTloDGBv8kqN1WH/Ehj7nv4QFZGpsd6SJzUhYllssnL0j0kUNZAkKigxikTAqAVqXq5B283aILKuCheY1F5t8GU3qcr8Zoo4Fw2C6V7YW1eVfO84GGKwPeROySn0C+tfHAf64N5oPPUyYCi2uwrpGXbSnLKu+p70N6E7/YoFcrq1n315W6j SL317MAf dIxXkfSv1MrubMUL4QP8z2ZVtgXfGWJirMwK0xf6VOpo/UKfdwc5J6k2xRqkutO56ussovyh7jIlY1dakh4e6DDdl13TUEGJeaHhtCnWEaTOKSot+xoCuxGs1zLJVTa0y2YevU2WKbNJXikdxuS+2Bfb5cV0auOxU8hCbl08Ulk7KpKsdhy0pDirXf40J5Glkdo09+2AA8Um9UVnWS+jqc+OpdcHL1oHTcFyaLZh/u3lPKFWOoMXAd47i0CKmk8ZtmohICTj0MQazNr8KZjCjzXI/dCvefvPMLg1cCbCICdDsYe2bDkyo7JgmhudxDm0XQIjq4WwROJ2hMNYMIpoaJAbplnV9s+O72AmpY5CZWBlkNowkkxuXInuX2DTDo4ME+4Ql6iOyZCoO438ZPSFzWs/D09nYLZqj3Ye5oHRhQAAqHgX/cSI5kiqvZVtczFuK0/1Y6GhIe8oZOBZcRHR33xemTujBU2YY0WLrbJoiMKvHUI0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Apr 22, 2024 at 9:31=E2=80=AFAM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: a35e92ef04c07bd473404b9b73d489aea19a60a8 > commit: 6c648035cbe75d78836f6d7d2fdd9d996048a66b [5836/7122] dlm: switch = to use rhashtable for rsbs > config: i386-randconfig-141-20240420 (https://download.01.org/0day-ci/arc= hive/20240420/202404200536.jGi6052v-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202404200536.jGi6052v-lkp@intel.com/ > > New smatch warnings: > fs/dlm/lockspace.c:566 new_lockspace() warn: missing error code 'error' > > vim +/error +566 fs/dlm/lockspace.c > > 60f98d1839376d David Teigland 2011-11-02 407 static int new_locks= pace(const char *name, const char *cluster, > 60f98d1839376d David Teigland 2011-11-02 408 = uint32_t flags, int lvblen, > 60f98d1839376d David Teigland 2011-11-02 409 = const struct dlm_lockspace_ops *ops, void *ops_arg, > 60f98d1839376d David Teigland 2011-11-02 410 = int *ops_result, dlm_lockspace_t **lockspace) > e7fd41792fc0ee David Teigland 2006-01-18 411 { > e7fd41792fc0ee David Teigland 2006-01-18 412 struct dlm_ls *ls= ; > 79d72b54483bf8 David Teigland 2007-05-18 413 int do_unreg =3D = 0; > 60f98d1839376d David Teigland 2011-11-02 414 int namelen =3D s= trlen(name); > 6c648035cbe75d Alexander Aring 2024-04-15 415 int i, error; > e7fd41792fc0ee David Teigland 2006-01-18 416 > 3f0806d2596de0 Tycho Andersen 2018-11-02 417 if (namelen > DLM= _LOCKSPACE_LEN || namelen =3D=3D 0) > e7fd41792fc0ee David Teigland 2006-01-18 418 return -E= INVAL; > e7fd41792fc0ee David Teigland 2006-01-18 419 > b5c9d37c7f6051 Alexander Aring 2022-08-15 420 if (lvblen % 8) > e7fd41792fc0ee David Teigland 2006-01-18 421 return -E= INVAL; > e7fd41792fc0ee David Teigland 2006-01-18 422 > e7fd41792fc0ee David Teigland 2006-01-18 423 if (!try_module_g= et(THIS_MODULE)) > e7fd41792fc0ee David Teigland 2006-01-18 424 return -E= INVAL; > e7fd41792fc0ee David Teigland 2006-01-18 425 > dc68c7ed362a00 David Teigland 2008-08-18 426 if (!dlm_user_dae= mon_available()) { > 60f98d1839376d David Teigland 2011-11-02 427 log_print= ("dlm user daemon not available"); > 60f98d1839376d David Teigland 2011-11-02 428 error =3D= -EUNATCH; > 60f98d1839376d David Teigland 2011-11-02 429 goto out; > 60f98d1839376d David Teigland 2011-11-02 430 } > 60f98d1839376d David Teigland 2011-11-02 431 > 60f98d1839376d David Teigland 2011-11-02 432 if (ops && ops_re= sult) { > 60f98d1839376d David Teigland 2011-11-02 433 if (!dlm_= config.ci_recover_callbacks) > 60f98d1839376d David Teigland 2011-11-02 434 *= ops_result =3D -EOPNOTSUPP; > 60f98d1839376d David Teigland 2011-11-02 435 else > 60f98d1839376d David Teigland 2011-11-02 436 *= ops_result =3D 0; > 60f98d1839376d David Teigland 2011-11-02 437 } > 60f98d1839376d David Teigland 2011-11-02 438 > 3b0e761ba83cb0 Zhu Lingshan 2017-07-11 439 if (!cluster) > 3b0e761ba83cb0 Zhu Lingshan 2017-07-11 440 log_print= ("dlm cluster name '%s' is being used without an application provided clust= er name", > 3b0e761ba83cb0 Zhu Lingshan 2017-07-11 441 = dlm_config.ci_cluster_name); > 3b0e761ba83cb0 Zhu Lingshan 2017-07-11 442 > 60f98d1839376d David Teigland 2011-11-02 443 if (dlm_config.ci= _recover_callbacks && cluster && > 60f98d1839376d David Teigland 2011-11-02 444 strncmp(clust= er, dlm_config.ci_cluster_name, DLM_LOCKSPACE_LEN)) { > 8e1743748b7e96 Gang He 2017-05-18 445 log_print= ("dlm cluster name '%s' does not match " > 8e1743748b7e96 Gang He 2017-05-18 446 = "the application cluster name '%s'", > 60f98d1839376d David Teigland 2011-11-02 447 = dlm_config.ci_cluster_name, cluster); > 60f98d1839376d David Teigland 2011-11-02 448 error =3D= -EBADR; > 60f98d1839376d David Teigland 2011-11-02 449 goto out; > dc68c7ed362a00 David Teigland 2008-08-18 450 } > dc68c7ed362a00 David Teigland 2008-08-18 451 > 0f8e0d9a317406 David Teigland 2008-08-06 452 error =3D 0; > 0f8e0d9a317406 David Teigland 2008-08-06 453 > 578acf9a87a875 Alexander Aring 2024-04-02 454 spin_lock_bh(&lsl= ist_lock); > 0f8e0d9a317406 David Teigland 2008-08-06 455 list_for_each_ent= ry(ls, &lslist, ls_list) { > 0f8e0d9a317406 David Teigland 2008-08-06 456 WARN_ON(l= s->ls_create_count <=3D 0); > 0f8e0d9a317406 David Teigland 2008-08-06 457 if (ls->l= s_namelen !=3D namelen) > 0f8e0d9a317406 David Teigland 2008-08-06 458 c= ontinue; > 0f8e0d9a317406 David Teigland 2008-08-06 459 if (memcm= p(ls->ls_name, name, namelen)) > 0f8e0d9a317406 David Teigland 2008-08-06 460 c= ontinue; > 0f8e0d9a317406 David Teigland 2008-08-06 461 if (flags= & DLM_LSFL_NEWEXCL) { > 0f8e0d9a317406 David Teigland 2008-08-06 462 e= rror =3D -EEXIST; > 0f8e0d9a317406 David Teigland 2008-08-06 463 b= reak; > 0f8e0d9a317406 David Teigland 2008-08-06 464 } > 0f8e0d9a317406 David Teigland 2008-08-06 465 ls->ls_cr= eate_count++; > 8511a2728ab82c David Teigland 2009-04-08 466 *lockspac= e =3D ls; > 8511a2728ab82c David Teigland 2009-04-08 467 error =3D= 1; > 0f8e0d9a317406 David Teigland 2008-08-06 468 break; > e7fd41792fc0ee David Teigland 2006-01-18 469 } > 578acf9a87a875 Alexander Aring 2024-04-02 470 spin_unlock_bh(&l= slist_lock); > 0f8e0d9a317406 David Teigland 2008-08-06 471 > 0f8e0d9a317406 David Teigland 2008-08-06 472 if (error) > 8511a2728ab82c David Teigland 2009-04-08 473 goto out; > 0f8e0d9a317406 David Teigland 2008-08-06 474 > 0f8e0d9a317406 David Teigland 2008-08-06 475 error =3D -ENOMEM= ; > e7fd41792fc0ee David Teigland 2006-01-18 476 > d96d0f9617793b Paulo Miguel Almeida 2022-10-12 477 ls =3D kzalloc(si= zeof(*ls), GFP_NOFS); > e7fd41792fc0ee David Teigland 2006-01-18 478 if (!ls) > e7fd41792fc0ee David Teigland 2006-01-18 479 goto out; > e7fd41792fc0ee David Teigland 2006-01-18 480 memcpy(ls->ls_nam= e, name, namelen); > e7fd41792fc0ee David Teigland 2006-01-18 481 ls->ls_namelen = =3D namelen; > e7fd41792fc0ee David Teigland 2006-01-18 482 ls->ls_lvblen =3D= lvblen; > 3cb5977c5214c2 Alexander Aring 2021-11-02 483 atomic_set(&ls->l= s_count, 0); > 3cb5977c5214c2 Alexander Aring 2021-11-02 484 init_waitqueue_he= ad(&ls->ls_count_wait); > e7fd41792fc0ee David Teigland 2006-01-18 485 ls->ls_flags =3D = 0; > c1dcf65ffc5796 David Teigland 2008-08-18 486 ls->ls_scan_time = =3D jiffies; > e7fd41792fc0ee David Teigland 2006-01-18 487 > 60f98d1839376d David Teigland 2011-11-02 488 if (ops && dlm_co= nfig.ci_recover_callbacks) { > 60f98d1839376d David Teigland 2011-11-02 489 ls->ls_op= s =3D ops; > 60f98d1839376d David Teigland 2011-11-02 490 ls->ls_op= s_arg =3D ops_arg; > 60f98d1839376d David Teigland 2011-11-02 491 } > 60f98d1839376d David Teigland 2011-11-02 492 > 6b0afc0cc3e9a9 Alexander Aring 2022-06-22 493 /* ls_exflags are= forced to match among nodes, and we don't > 6b0afc0cc3e9a9 Alexander Aring 2022-06-22 494 * need to requir= e all nodes to have some flags set > 6b0afc0cc3e9a9 Alexander Aring 2022-06-22 495 */ > 6b0afc0cc3e9a9 Alexander Aring 2022-06-22 496 ls->ls_exflags = =3D (flags & ~(DLM_LSFL_FS | DLM_LSFL_NEWEXCL)); > fad59c1390045b David Teigland 2007-06-11 497 > 93a693d19d2a4a Alexander Aring 2024-04-15 498 INIT_LIST_HEAD(&l= s->ls_toss); > 93a693d19d2a4a Alexander Aring 2024-04-15 499 INIT_LIST_HEAD(&l= s->ls_keep); > dcdaad05ca1515 Alexander Aring 2024-04-15 500 spin_lock_init(&l= s->ls_rsbtbl_lock); > e7fd41792fc0ee David Teigland 2006-01-18 501 > 6c648035cbe75d Alexander Aring 2024-04-15 502 error =3D rhashta= ble_init(&ls->ls_rsbtbl, &dlm_rhash_rsb_params); > 6c648035cbe75d Alexander Aring 2024-04-15 503 if (error) > e7fd41792fc0ee David Teigland 2006-01-18 504 goto out_= lsfree; > e7fd41792fc0ee David Teigland 2006-01-18 505 > 05c32f47bfae74 David Teigland 2012-06-14 506 for (i =3D 0; i <= DLM_REMOVE_NAMES_MAX; i++) { > 05c32f47bfae74 David Teigland 2012-06-14 507 ls->ls_re= move_names[i] =3D kzalloc(DLM_RESNAME_MAXLEN+1, > 05c32f47bfae74 David Teigland 2012-06-14 508 = GFP_KERNEL); > 05c32f47bfae74 David Teigland 2012-06-14 509 if (!ls->= ls_remove_names[i]) > 05c32f47bfae74 David Teigland 2012-06-14 510 g= oto out_rsbtbl; > ^= ^^^^^^^^^^^^^^ > No error code. yes, later patch removes that allocation. > 05c32f47bfae74 David Teigland 2012-06-14 511 } > 05c32f47bfae74 David Teigland 2012-06-14 512 > 3d6aa675fff9ee David Teigland 2011-07-06 513 idr_init(&ls->ls_= lkbidr); > 3d6aa675fff9ee David Teigland 2011-07-06 514 spin_lock_init(&l= s->ls_lkbidr_spin); > e7fd41792fc0ee David Teigland 2006-01-18 515 > e7fd41792fc0ee David Teigland 2006-01-18 516 INIT_LIST_HEAD(&l= s->ls_waiters); > 097691dbadcdca Alexander Aring 2024-04-02 517 spin_lock_init(&l= s->ls_waiters_lock); > ef0c2bb05f40f9 David Teigland 2007-03-28 518 INIT_LIST_HEAD(&l= s->ls_orphans); > ef0c2bb05f40f9 David Teigland 2007-03-28 519 mutex_init(&ls->l= s_orphans_mutex); > e7fd41792fc0ee David Teigland 2006-01-18 520 > 3881ac04ebf942 David Teigland 2011-07-07 521 INIT_LIST_HEAD(&l= s->ls_new_rsb); > 3881ac04ebf942 David Teigland 2011-07-07 522 spin_lock_init(&l= s->ls_new_rsb_spin); > 3881ac04ebf942 David Teigland 2011-07-07 523 > e7fd41792fc0ee David Teigland 2006-01-18 524 INIT_LIST_HEAD(&l= s->ls_nodes); > e7fd41792fc0ee David Teigland 2006-01-18 525 INIT_LIST_HEAD(&l= s->ls_nodes_gone); > e7fd41792fc0ee David Teigland 2006-01-18 526 ls->ls_num_nodes = =3D 0; > e7fd41792fc0ee David Teigland 2006-01-18 527 ls->ls_low_nodeid= =3D 0; > e7fd41792fc0ee David Teigland 2006-01-18 528 ls->ls_total_weig= ht =3D 0; > e7fd41792fc0ee David Teigland 2006-01-18 529 ls->ls_node_array= =3D NULL; > e7fd41792fc0ee David Teigland 2006-01-18 530 > a7e7ffacad7b9b Alexander Aring 2023-03-06 531 memset(&ls->ls_lo= cal_rsb, 0, sizeof(struct dlm_rsb)); > a7e7ffacad7b9b Alexander Aring 2023-03-06 532 ls->ls_local_rsb.= res_ls =3D ls; > e7fd41792fc0ee David Teigland 2006-01-18 533 > 5de6319b183930 David Teigland 2006-07-25 534 ls->ls_debug_rsb_= dentry =3D NULL; > 5de6319b183930 David Teigland 2006-07-25 535 ls->ls_debug_wait= ers_dentry =3D NULL; > e7fd41792fc0ee David Teigland 2006-01-18 536 > e7fd41792fc0ee David Teigland 2006-01-18 537 init_waitqueue_he= ad(&ls->ls_uevent_wait); > e7fd41792fc0ee David Teigland 2006-01-18 538 ls->ls_uevent_res= ult =3D 0; > 682bb91b6ba829 Alexander Aring 2022-06-22 539 init_completion(&= ls->ls_recovery_done); > 682bb91b6ba829 Alexander Aring 2022-06-22 540 ls->ls_recovery_r= esult =3D -1; > e7fd41792fc0ee David Teigland 2006-01-18 541 > a4c0352bb1094c Alexander Aring 2022-10-27 542 spin_lock_init(&l= s->ls_cb_lock); > 23e8e1aaacb10d David Teigland 2011-04-05 543 INIT_LIST_HEAD(&l= s->ls_cb_delay); > 23e8e1aaacb10d David Teigland 2011-04-05 544 > e7fd41792fc0ee David Teigland 2006-01-18 545 ls->ls_recoverd_t= ask =3D NULL; > 901359256b2666 David Teigland 2006-01-20 546 mutex_init(&ls->l= s_recoverd_active); > e7fd41792fc0ee David Teigland 2006-01-18 547 spin_lock_init(&l= s->ls_recover_lock); > 98f176fb32f337 David Teigland 2006-11-27 548 spin_lock_init(&l= s->ls_rcom_spin); > 98f176fb32f337 David Teigland 2006-11-27 549 get_random_bytes(= &ls->ls_rcom_seq, sizeof(uint64_t)); > e7fd41792fc0ee David Teigland 2006-01-18 550 ls->ls_recover_st= atus =3D 0; > 317dd6ba6ccaa5 Alexander Aring 2023-01-12 551 ls->ls_recover_se= q =3D get_random_u64(); > e7fd41792fc0ee David Teigland 2006-01-18 552 ls->ls_recover_ar= gs =3D NULL; > e7fd41792fc0ee David Teigland 2006-01-18 553 init_rwsem(&ls->l= s_in_recovery); > d52c9b8fefa3ed Alexander Aring 2024-04-02 554 rwlock_init(&ls->= ls_recv_active); > e7fd41792fc0ee David Teigland 2006-01-18 555 INIT_LIST_HEAD(&l= s->ls_requestqueue); > c288745f1d4a2e Alexander Aring 2024-04-02 556 rwlock_init(&ls->= ls_requestqueue_lock); > 296d9d1e989083 Alexander Aring 2022-08-15 557 spin_lock_init(&l= s->ls_clear_proc_locks); > e7fd41792fc0ee David Teigland 2006-01-18 558 > 489d8e559c6596 Alexander Aring 2021-05-21 559 /* Due backwards = compatibility with 3.1 we need to use maximum > 489d8e559c6596 Alexander Aring 2021-05-21 560 * possible dlm m= essage size to be sure the message will fit and > 489d8e559c6596 Alexander Aring 2021-05-21 561 * not having out= of bounds issues. However on sending side 3.2 > 489d8e559c6596 Alexander Aring 2021-05-21 562 * might send les= s. > 489d8e559c6596 Alexander Aring 2021-05-21 563 */ > d10a0b88751a09 Alexander Aring 2021-06-02 564 ls->ls_recover_bu= f =3D kmalloc(DLM_MAX_SOCKET_BUFSIZE, GFP_NOFS); > e7fd41792fc0ee David Teigland 2006-01-18 565 if (!ls->ls_recov= er_buf) > 05c32f47bfae74 David Teigland 2012-06-14 @566 goto out_= lkbidr; > > Here too. > This is still in dlm/next and needs an error code, yes. Thanks. - Alex