From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E64EC433F5 for ; Fri, 21 Jan 2022 07:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5031D6B007D; Fri, 21 Jan 2022 02:02:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C536B007E; Fri, 21 Jan 2022 02:02:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3534F6B0080; Fri, 21 Jan 2022 02:02:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 22A616B007D for ; Fri, 21 Jan 2022 02:02:50 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C3A0496767 for ; Fri, 21 Jan 2022 07:02:49 +0000 (UTC) X-FDA: 79053401658.18.D38F154 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 700ACC0002 for ; Fri, 21 Jan 2022 07:02:49 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id r204so6033245iod.10 for ; Thu, 20 Jan 2022 23:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FVobGviDm1nm1GMLQvd/EYPCyCZ2DMF5uRlmstDHO0I=; b=GbJjOyNWKDBuoGbJ17LfQNorZPhqO49Ii9Zpx3oNZq1KscKpnGF8tzMS69aAfuzb7W xo5a94992eGe5N2oPV6ud7kSSXez3IX/LS98iilSw7E0EwuJ2x53MFklMFJDSQ4vsMHu 2I2OFA1z1C5IADPDXj5XiN+H8J8AXykh6li60T/fDhw8IYZaP5mvFQVFGDC9+/+XClFx OcWKvKvI8ywljW9vIrl5bEDnA6zN2HuYY5joqPPr50ZhkOkca/AAMmin9+8m5Y0SHmBl 9AdPidzH5w/c7kSibWbfFDqFWZF3DsKE14ZhMN7sTh6yti7fdBCbcjV9Z2RKedcc7lIf Z1Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FVobGviDm1nm1GMLQvd/EYPCyCZ2DMF5uRlmstDHO0I=; b=dHdEsMoe0VVDNZGGnwsupPvBX8HHpCZl6KrtOEErTQiNeA2HZieU2cYZ2oA/90boym Jyz9YCizRghSMD/j2ehfHBe8r9AsrVtJyiJinK/BeQgSKaYk1ZZXJbdLn+NSGQMogm0G 6cAmEUCrL6SM3LfnA/yKr2BDkqO3vUCAG5zw8dtYKGy3VZVLIeP/lLAZODE4ovc7dbOv uH4TjEdZnNbpEo3WwJsxULduC06tvUXdybJAfhWceLu28uduCpjW/zrjETEbUtq1i2gn 4u3hzIu4YC4eRhUgxf7+sWxRLXzIH+EMR6yr42AMJlvcs0lRdNcP+TK5k+sJd9DhuKYb pdcQ== X-Gm-Message-State: AOAM530gaVL8h1KNLXzNYQqQMIkZ0NSMNp14Uh+LRIHX+WuNHT7yI7KB dBq4QwtFsUmuNJBKRVYUjQGoDitmix+QJC9w8UY= X-Google-Smtp-Source: ABdhPJx5tjDJw2o9AqfxiHpuePMfQ4+XrlHN7ioUNoql/VyVGUezZc/YkO6IQdRIa894Nj7slhFkATnFLYByfLQ7vnM= X-Received: by 2002:a02:ca4c:: with SMTP id i12mr1206692jal.40.1642748568390; Thu, 20 Jan 2022 23:02:48 -0800 (PST) MIME-Version: 1.0 References: <20220120131024.502877-1-alexs@kernel.org> <20220120131024.502877-2-alexs@kernel.org> In-Reply-To: From: Alex Shi Date: Fri, 21 Jan 2022 15:02:12 +0800 Message-ID: Subject: Re: [PATCH 1/5] mm: remove page_is_file_lru function To: Matthew Wilcox Cc: Alex Shi , Andrew Morton , Steven Rostedt , Ingo Molnar , Naoya Horiguchi , Yu Zhao , Arnd Bergmann , Vlastimil Babka , Mel Gorman , Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 700ACC0002 X-Stat-Signature: d69anjfxastzt4e45f4fu44w8rpbqf64 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GbJjOyNW; spf=pass (imf10.hostedemail.com: domain of seakeel@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1642748569-309108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 20, 2022 at 9:28 PM Matthew Wilcox wrote: > > On Thu, Jan 20, 2022 at 09:10:20PM +0800, alexs@kernel.org wrote: > > From: Alex Shi > > > > This function could be full replaced by folio_is_file_lru, so no reason > > to keep a duplicate function. > > This is not a helpful way to do this kind of replacement. > > Instead of choosing a function to remove and doing a blind replacement, > choose a call site and convert the whole calling function to use folios. > Once you've removed all callers, you can remove the wrapper function. > > Also, a number of changes here will conflict with patches I've already > posted. Try doing change_pte_range() in mprotect.c to get a feel for > how to convert a function entirely to folios. Hi Willy, Thanks for your comments! The patchset did the thing as you required "convert the whole calling function to use folios. then remove the wrapper function" on yesterday's Linus and next tree, that included your patchset "Page cache/iomap for 5.17". Is the conflicting patch "Enabling large folios for 5.17" or others? Sorry for can't check everyone, your patches are many. If just the former, I see you mentioned: "I'd be uncomfortable seeing it merged before 5.18". Would you point out which of your patches was interfered or blocked? And yes, replacing page functions in change_pte_range is a bit harder, but it seems it has no much relation with this trival patchset. Thanks Alex