From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6377C3ABCB for ; Mon, 12 May 2025 16:48:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773A46B018B; Mon, 12 May 2025 12:48:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 686456B018C; Mon, 12 May 2025 12:48:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 290176B018D; Mon, 12 May 2025 12:48:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E08D96B018B for ; Mon, 12 May 2025 12:48:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CE54D1CBA41 for ; Mon, 12 May 2025 16:48:40 +0000 (UTC) X-FDA: 83434839600.25.2CD2132 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 03AA740002 for ; Mon, 12 May 2025 16:48:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yNfxub4d; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747068519; a=rsa-sha256; cv=none; b=zWEuJfCwHd8Ns5u855/23gpkPbryUAXheUCHQXVUAL5Vp+f8pourVV+VkqLZ/2zSuu3nLJ vi+UqvlxCIRp3BLGUyhpXEfhyFfks95NZqNnAPX8vnQvgH157J5sE9JpNEUHoVGbk+XNh2 jgpODBe7tWhKQ10WHhsjLaU823UhVCY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yNfxub4d; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747068519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JdDHeL7/u5YV9ilTzq9FklUNNEV0HEKhyvn98R26adU=; b=IOBVBSyD0iuEGNvftB4/QeI7Rs0A3xHhHuJhZy4dblPHwAtaF1jgN0u/fgoKqGPklZxQ6l VeKMQpL6hUNwPF3cCKc1nctljVqeYAeOu6qJekjD+hLnvSXNwLtyzkDqPoYs239Pj5Tjxd BdwEFFkIhFguEjH2frZwJfuLt8ze8sw= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-47e9fea29easo5481cf.1 for ; Mon, 12 May 2025 09:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747068518; x=1747673318; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JdDHeL7/u5YV9ilTzq9FklUNNEV0HEKhyvn98R26adU=; b=yNfxub4dOfrRxsZC9W43OPvFcvR+AxRJYYKK3PV896ipbD4CbO0hUO24rSdUt/YUfF fs9z37P5cMvIpz93q9FLXr5cO4fTH7IZV+IrXQETXpjzPDmTf3lB2EAzbXqHjcTAzHeG bV+EncNduh/bj/HhShIBXaizY3l92EF06Ha13b0nWsH5asWxmxkfpq2/BdbVM+ldrhN1 Gl4vqYNrTnJe24DT/JDTTBEpswIZI4DaRsXWnsLjMxcApg9/EHkyxuu5yesBNFM0/0qy /Gg7sKBsRjfs1KDwr47nBW81uAAkFAbrAaPneO2uWS8foCU09eVGBsx6EA/RRNNZDJLL gWIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747068518; x=1747673318; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JdDHeL7/u5YV9ilTzq9FklUNNEV0HEKhyvn98R26adU=; b=ggutV+tn0tWbdxYAPdzqisrAS9kS7eRNvMwbsyu6ZlWOe1vfRwRk9p5NcHw/cdHj70 hTRJAnsclxvpRZ5f2Rufygv372IA84FxRwvDo0MDp2SF+oO/CjFt26f8mpsBEjLs51tn +pq0owqS8/a85SVxmRbcOFh+U7LCCXSuwPyBnHVWajv3DJBfp+K3y5lLQUNncY8upikn gHzfjT+9IX0ci+Sf8R1U7KOKStRveOgKfu6X2VQPy54j+UqOCMOh6E18B8S/8KzSOVQT 6UFHHJEDpZEC4g9DG0T5K3dqrIr/dlYqr/+ITTVzwwAIESL/Qh+mhrzPKZD1arOtd7W0 kj4g== X-Gm-Message-State: AOJu0YxDNdjqadAd8vp6vdk0OAO7sFN+kEr08JOJlW9VbM7oOupv13Nt eHxLpOQOV7LH2fCfYePIERQAg+dPE2YZYMCjf9oOf35Dj9dh+LeZuOD/+1kDffXJQSbZ9eL7QTq iMiBFlYZHSvQylnRLpoOvLpa81UDQob68ccd2PH30Wcrd8sWYe6mGP+s= X-Gm-Gg: ASbGnctpsyZQgv+vvEpXGaGop111JHj+ioWimsSEn/4MY8820fjOgW+Oh/HzXDxK/Q2 HuJchIPcdnsWC0vAQKTJGdGk483tmxudNV/E2+4UIR84J1QaWemYL8HFGd3o8TXfTUPDxzDMD5r 4GvK0zylcF0g2degzXUouHbiSGQX3go0P9TafK6lEJ3vYnNeN8FOceNmWY0CIuSLeM5tMC/Dw= X-Google-Smtp-Source: AGHT+IHt1ws7wDNqOzluD3M0F9kC6LW4ww5+ZI74Z8s0RH6ZKEo4yUVJ5nfxHaZMa3/19RIgad0mffqkqVoAziww6Ak= X-Received: by 2002:a05:622a:296:b0:476:861d:10ec with SMTP id d75a77b69052e-49462e81df3mr10579701cf.15.1747068516859; Mon, 12 May 2025 09:48:36 -0700 (PDT) MIME-Version: 1.0 References: <20250508234742.93114-1-cachen@purestorage.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 12 May 2025 16:48:26 +0000 X-Gm-Features: AX0GCFsRi2hK87lNbiCl2nmzs5KoeKiyzrPyXHKFMEKLESB_jHN1B5WMfcJ6kFg Message-ID: Subject: Re: [PATCH v2] alloc_tag: check mem_profiling_support in alloc_tag_init To: Casey Chen Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 03AA740002 X-Stat-Signature: d6zz3b4msnnsuuizrkwutyymnntfmgp7 X-HE-Tag: 1747068518-919420 X-HE-Meta: U2FsdGVkX18qiK7qXQh9kVAJmAzc/DdQBxwHZpqz+gtumqPosVn2KcwL/2zCmL3nW6jzs1EMkKKMIWL557fbANH4hM3jnnacB6XUhKTYmfaQxl1ayGB56AfEuNEguJb8r8lOC87oOTVzggMmWMgBnvHns3TnOEXToQyirHSHFGdmVcH3Pz6wZk5ld5Y/91cRDsvK3bEWw2pXMHKPuIz/dke7VuuaUhqFF9ovPekaROMGZ0/UDa66rf/hn3nJeccQpQ7OfLaj3IaZUOPjLKAeoZFFb+a6XftWaB6EtZMqwSXCYAcuQ4yVcv1+PAk6b8rmtqnAcQAic5m1y39y6fMQ/J1xJfgMNL9I3YpPAZ9zoSvmWxv8q4y6LiYiVgxsZDFp/nH3nx/Go8ZFEC8EG1g2/TQ6sQ+j2trng17mq6mR3ObsA8LmOtNPGZYxx+U6sotKHkynVtRnQwg/gD9Ge8ibBxTt1nKNI5hJzSYXIiMh7xIthHpaiieXy1yNIEheZQMRbYtCtLPPRQGKs1tAkFJGA3peib9doVy0sGVFeKgY5Gy6ayvItsqK3p4tCMSRQ8htAj+guJG2BqvnA6idZ1MYoy4NRZ+PS1o8+VaVmCpYAh2SkICU3aAjCzMHaWoNPqUpz3IsvgtTm8PaQEtEciVQAcj2oEEk/p1rfkQBqPimlo99T/QURvBs3epEHGIi8m5d53e4uw1mDtrkc1NrXEHUawK/rTNkwJ5yB992jawgTvVLXWKpElqixsuMWiCf0DQCdr+1iqS3dur4chPIFtLUfBAjSBRneZGgKQ5hwGodZdd9lSrAST/PDwJzJssEDaQan9a13J0bp34cI5ORk+47Hi0tgNcjjaJIg5w5vsAs4nGk7Myi+jvWbxEyibMspBHKgnqYdl6pN20Qw4P1dqkuNodAA7wWiDI8Im04qzz+40DrSvDM3R9dJVgLbNAoVWsI/9scOy1RwRRtUNlQ6lY u7NZZk1c bnu9fPLiJ3LYn7B5lkrJMRP6ZjdRlQJrC1uFrKNPziHhReMkDFlfSQmDuGPQQFJ6ZjIM6cOPoE3fAj7cdHZREQqkJjd/r8hqVTgdiRKYxqHUgd3ZIQlTIYb1h6l7Dy/xak1toNQbMX9epY+cBLcokuLAtYoeeo6u9Q2ce0hkfDr/DsB21tplzCvLpQcRGM4oiEYOMI24cFBhxCjtg0HvgYrYhBuetojrMDFyRWGr7Jnj0twDR91E8yLBvcq+5C8HSW0s8LuvG8FWqW8X+H5BiuaO3+5JrqJwFGey1p42ZHValcUQG35Bnm1dhO0htVCEJAdIe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 9, 2025 at 4:11=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, May 8, 2025 at 4:47=E2=80=AFPM Casey Chen wrote: > > > > Allocate module tags and register codetag type only when > > mem_profiling_support is true. If it is set as false, > > for example by sysctl.vm.mem_profiling=3Dnever, skip them. > > > > Signed-off-by: Casey Chen > > Reviewed-by: Yuanyuan Zhong > > Thanks! Looks good to me but let me take a closer look over the > weekend to make sure we do not break anything by skipping this > allocation. I tested the patch and it works as expected. One thing I noticed is the extra mem_profiling_support check inside procfs_init(). Please move procfs_init() call into the "if (mem_profiling_support)" block you added and remove the extra mem_profiling_support check from procfs_init(). Actually, since procfs_init() becomes just one call after the extra check removal, I would suggest just moving the proc_create_seq() into alloc_tag_init() directly and eliminating the procfs_init() function completely. > > > --- > > lib/alloc_tag.c | 18 ++++++++++-------- > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > > index 25ecc1334b67..fbf128072c7e 100644 > > --- a/lib/alloc_tag.c > > +++ b/lib/alloc_tag.c > > @@ -762,14 +762,16 @@ static int __init alloc_tag_init(void) > > }; > > int res; > > > > - res =3D alloc_mod_tags_mem(); > > - if (res) > > - return res; > > - > > - alloc_tag_cttype =3D codetag_register_type(&desc); > > - if (IS_ERR(alloc_tag_cttype)) { > > - free_mod_tags_mem(); > > - return PTR_ERR(alloc_tag_cttype); > > + if (mem_profiling_support) { > > + res =3D alloc_mod_tags_mem(); > > + if (res) > > + return res; > > + > > + alloc_tag_cttype =3D codetag_register_type(&desc); > > + if (IS_ERR(alloc_tag_cttype)) { > > + free_mod_tags_mem(); > > + return PTR_ERR(alloc_tag_cttype); > > + } > > } > > > > sysctl_init(); > > -- > > 2.49.0 > >