From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CFBC4332F for ; Mon, 30 Oct 2023 21:22:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4ADB6B028D; Mon, 30 Oct 2023 17:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D40D6B028E; Mon, 30 Oct 2023 17:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8751D6B0290; Mon, 30 Oct 2023 17:22:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 737126B028D for ; Mon, 30 Oct 2023 17:22:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4458380648 for ; Mon, 30 Oct 2023 21:22:32 +0000 (UTC) X-FDA: 81403401744.04.C2384C0 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf17.hostedemail.com (Postfix) with ESMTP id 7962140010 for ; Mon, 30 Oct 2023 21:22:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JKodQ1/v"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698700950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwJPbkzTcW2a0Aake5KdIVl2hETAF8IjmbwWVJSuVUw=; b=ywu8bxN0F721GsJ3kRnf8EH1KPpiqVvvCaAQY0U73niX4cw8SIVRMlm9hsC+Ui1eC+4pvb iSTetpXqxQR5OV+OVlc1GhtZtiY4aIf9ntkukI9DJ6fU3zWBJflLTjBxkYQ8WsirMJ9w7R GUlRKSgsGBu3t+lXysyXoT6CSmhX9gM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JKodQ1/v"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698700950; a=rsa-sha256; cv=none; b=Vny7BYyeU2OkNSSdgeJHyjG6/lhL5U8Yis3yCrMyKqxEodVEYfiLb1WczQQPxXQ+hcFsw6 VcEOzda/uhqi8XGku6xtRgot5u4W2ffUjCUYsDjqLl+TF97oFyF2Ue5Vfeka+0y5F1Ekg+ 2sK/LzP4XRrKLPZt7UBPvpm+eFYcPvs= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d9ca471cf3aso4487409276.2 for ; Mon, 30 Oct 2023 14:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698700949; x=1699305749; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uwJPbkzTcW2a0Aake5KdIVl2hETAF8IjmbwWVJSuVUw=; b=JKodQ1/vzJ+axYZ03zQvU/weQqjmcKxQ/Mo1J/8QVT1Fhc6m7aG2Zxdf1kHC2HenUi TyRuQZKWhFERtbFsKGf7BXGreP4ufZ5l0lrGj5W2X1mAQr/42gEt8c+SA1d4KuZjPpkS eWhG9YhmfGXI+ypc5VrP8EnKUkiSyzyUgBF8+hnMVEgeMXmEx4cc1Dn/vq4+bQ1fM4Q+ AhPw+l0XhroTrGm/KqiXUg+pSt7eTvC42TSzYNLLm/TcV0UPzLQ44QuIm4fH2dwfJbuv Qh1hvcrhbdvHdojv679yT8GqYIsad1XrgfPzpBCF28tAelkGCe7VSChr2mJ6BKPbJKlJ trQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698700949; x=1699305749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uwJPbkzTcW2a0Aake5KdIVl2hETAF8IjmbwWVJSuVUw=; b=MT1l928+ArBSP8n29XGVwaKkSvo9u+0ITxIfoXshazPKzZF8NLfETQULqHYpi8izzI R9/7/dxWXD1ZTiuosYmPqdcmWbjv2D8h7LcPiUIv6waTgHwqZzpIr9ir5YrXd4jiKRax w6a6blmjICgjAnC4BCWWnOz7tbTStQhNKRfNh5hipaM6TMWr+FGeD0koZUVn0svmxiau 4VCn97SaoUv2CxmpR1tyyqijCI4/TK344pAL1HwxjA9pW0vLowPKpyt8/aD8JyHVXvZs fEBaP5+sej3XLRBjbpAG84lxp0h9Tw8B4K8TYr+rTPIEH07Klp48UdGV7FLzG5B+ZAGW 9Leg== X-Gm-Message-State: AOJu0YyTtE41hSVZDmTKeVb4/p7S7IvadVmJPsy/BatBVQmzY0IL6Tnh D/1IkyFs5byfjklgc2mwIkMB5d0MYCzZSpa1siykfQ== X-Google-Smtp-Source: AGHT+IHUKCGn+zcI97gOSVY+FNlKbbSCWP6tGfywZjOb4ubvvKE7w61Yhe1EdRLZDEeh63lNRWL2VU/yYTIkofZbYco= X-Received: by 2002:a25:30d:0:b0:d15:7402:f7cd with SMTP id 13-20020a25030d000000b00d157402f7cdmr11851887ybd.27.1698700949306; Mon, 30 Oct 2023 14:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20231028003819.652322-1-surenb@google.com> <20231028003819.652322-6-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 30 Oct 2023 14:22:15 -0700 Message-ID: Subject: Re: [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test To: Peter Xu Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, david@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7962140010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qtgqtid9czmkaptcydq4k7cpmczsmiih X-HE-Tag: 1698700950-268962 X-HE-Meta: U2FsdGVkX1/eoy2yy7Toc1zuDCrNp0l7ycf09xeErX35Jh04bWL5x1iuLDFoGgFYUujwIf/4+owLTqh4R9BroSsfA6ifnkCgiaKtBY9PomZ0XXUqWkWUJqW5SgUyVWuwK0HgheDOJaZyBboSKjKl/LPs3Iaf7rWPuA7jq4jszc2+i1CW/CjYrA0Aa/Jnsh35sDL58WY7z8Yf9wBNDHG521eZ9ATYuY2p/SQpvvcMs6lLYQN+aupC2HbRTH8KYzg1AUekbj7jrCzwftLoIOkbD28Mvs5MfkQqQfOgIG3Ix11H0uJh9LaL1jT9gFSHOLa+8HyFqBigml0QH6BMJvTyvYnUd3wBJTCib9dcT6djTfdpXFwV3mbwjOWK7pJx/pkjhJUVXioUd6yQb6ZEeUxJRLN4Kq2hJircoHBVrtxLktRvGNIqzws0hXkg90h+hYdN86XlGgsvPkb70MFHM+WvUo9guDxpQ+lveu/xGB0S3mEpwDRnKxvNEn6VDniD7ptIgI/+VtnndDPDh+/E3lauQeZrt7a9itO48MHcInUkIammOxT15vd2lLhOCs18j3QM6DPX5TClOaH05izxTSkMlsmuoVcDqxvQ37H61YEy+tNxqDXNpCcLyMZ9sPk4PrqBZcae22RUaAt5x+jJuQc737/ADh+dl4PUKn+1+W4cOo8wqmRZ/FGxb3Y2ErLEz6fKQxtwOnF0lvdaw/tMC4ILX7+0xnU6ej4LKczd172ojlianpYwfFj6Lr2xxVIS+9MIOGQLDqr85dkdgS40Tx+P7gLuyFhQVMTNJo+uxO2/9hFseJELtmIszpONE4SneqswVDLzA2UeQrU5EV3sgDrg6FOJPfoBylsuFMznIJrB+JwhkagtWxXtwJlBB6fPxvLBqK7VynJGizYYS/fzvh5jq/gjdn9Dc4QcUbvBkMFK49inlERkd1UZy1omBZ0YihfRTGcprFub0O8U3TQfUR2 u9wqrkyG 0YOPqJgEFbqhCBtm56YHFDglUjy+//zjb5ZepSUNePfjly1Jv/Rm7mbe5I6JLcWesI1n4vFS50xQ9MXThiWFVjGk6RUg5hIyyzlAlmx1u/2dZ9BlASS212RwYeUWBFpc6blWt75aFaYgRv2u05wNxnIDioSwl9F6NVuEiloIRk5C5vrzedGE8oSyELYQYV7D0okg0J5qXzMFTD2jHl0h3LgEuG6WFHVZm6RszYLy62jsoTwl5L5OxGmzrkamgwauPYemlg1RNECyP8WrKl+znSYwQo0o9GudBE0Shoi8Wn6InnNg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.036739, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 1:35=E2=80=AFPM Peter Xu wrote: > > On Mon, Oct 30, 2023 at 01:22:02PM -0700, Suren Baghdasaryan wrote: > > > > +static int adjust_page_size(void) > > > > +{ > > > > + page_size =3D default_huge_page_size(); > > > > > > This is hacky too, currently page_size is the real page_size backing = the > > > memory. > > > > > > To make thp test simple, maybe just add one more test to MOVE a large= chunk > > > to replace the thp test, which may contain a few thps? It also doesn= 't > > > need to be fault based. > > > > Sorry, I didn't get your suggestion. Could you please clarify? Which > > thp test are you referring to? > > The new "move-pmd" test. > > I meant maybe it makes sense to have one separate MOVE test for when one > ioctl(MOVE) covers a large range which can cover some thps. Then that wi= ll > trigger thp paths. Assuming the fault paths are already covered in the > generic "move" test. Oh, you mean I should not share uffd_move_test() between move and move-pmd test and have separate logic instead that does not rely on the page_size overrides? If so then I think that's doable. Some more code but probably cleaner. > > Thanks, > > -- > Peter Xu >