From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDD2C47DDB for ; Wed, 31 Jan 2024 02:37:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9086A6B0081; Tue, 30 Jan 2024 21:37:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B8496B0082; Tue, 30 Jan 2024 21:37:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 780036B0083; Tue, 30 Jan 2024 21:37:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A3D86B0081 for ; Tue, 30 Jan 2024 21:37:30 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E60C4A2211 for ; Wed, 31 Jan 2024 02:37:29 +0000 (UTC) X-FDA: 81738045018.11.AAD11E9 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf05.hostedemail.com (Postfix) with ESMTP id 3197410001E for ; Wed, 31 Jan 2024 02:37:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n6loA8SM; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706668648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TFtM9M9RNSsCscdub7UbZbmrBPSDwKReEdWaEJLTDYQ=; b=31ZyVrab67sPqUxYFkrCG7QbAJRNp30uGsGv8UjFvd5YWTjBsY2tOavx8YLJmDv/0o/l5K NLgnyfsVZjOAjhVuNW/ixbwAcBPrqOwMkqbskgE9nSBvIXJLgFtRKhGV9qZPEGxKuJtujd JWyLFX1ZXirYmHhczTZPAdpVH5hDkxw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n6loA8SM; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706668648; a=rsa-sha256; cv=none; b=3HmzpSWEjQNhJCIkDAFMs3mhp5n6/UnYUg4/rDigw6tX50oVciSoRNGDyn3lg2rLw39NvP sDVjXB54hiedZey1N7v3LkSUDb4ElOkki7wGqdGhS6Iml82yl/XhyQ5dKEubsQhnajMpLL 6Cr6hRSKM8LU+ltUtJk7JKMJXM1j67Q= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-dc2501ed348so378864276.0 for ; Tue, 30 Jan 2024 18:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706668647; x=1707273447; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TFtM9M9RNSsCscdub7UbZbmrBPSDwKReEdWaEJLTDYQ=; b=n6loA8SMfVfc7mIUY8B7NzqSiRR8hdlvcyoGr0BzAV2Ap1DOHH5tCcXzZFhpoWRCed Yg5ST2Qo3GNtH6BmMl7NOzS+eJXek+CBSKp6C6A8SiPcWTt/ZA8rQ8c0hUBNRIouKhX7 hw/CsWeeYbGQDA2OC3hPX9O28w/Xi1QRnDLqy5yHW+4VO8t5MXwEAbZXXLA1JqipWhpk ufA/O6W+eTB06xvNPIIlVWkyZ1Wt408XBKeqk5tp4zmYDjhLI/huTOcqvqJHLyF3JUyt Fwq3EnIBUByE5ZyU5FyqqI4D46274WX3I2a+NoNnq66pcNaNucEMKo1+iMA8GlX2UKUY 6W4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706668647; x=1707273447; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFtM9M9RNSsCscdub7UbZbmrBPSDwKReEdWaEJLTDYQ=; b=jGbti5ENzL1AONVGa86GClieSQR8/D2y3p+bQtE+0kzRCYCBplUIqjWzc9qno11AFh 8ntREqOTfu7pF9psEvHDab06mYF2WABnQrE3eYk79pGpnYZrrK6LZ01cdp9WW+9YAwqv jmVLzHOdFowVU9ekwXxP59uktNZdcx0Qao5y7/6UNWGnAWJnzKfBruc3xD9QPXEqQuvY EN3cGNd7sE75MWPLwwFTiTiKRubjJtwJ/+0w5cvvBrfnLqRdiSlNFJwwqmgfNNJ80SFB EdwP2HVcW7Fu2p879dqiGD+qGUUlSBT7c7jgph6z+BxaneemTAMbsfcJ3vLoiMGMYQnQ +lzw== X-Gm-Message-State: AOJu0Yz3WFu/fDk3OFT+B1h6hAQ9u+6rT1x1kr62EErbDMvK1AY11GXt JjwyWFNJGEFZpcMEQOEA4t7XHXBrYmu+SlxKJJUlPAQEh/UEOGUftuEy5p4aoY0THRq4j2+8UYh cQZdQE76P1pRFK5nTQ0kSuyC/coptYkbzitfr X-Google-Smtp-Source: AGHT+IE77UGX6zv+fYOMSYQRTJt+PvgbckZGS4IXQT+4e4FP2JpLR8KrluHFwd7mJg3X2O21apLZ9k4ePAaltmt0Pps= X-Received: by 2002:a25:c3c7:0:b0:dc2:5044:70e with SMTP id t190-20020a25c3c7000000b00dc25044070emr1649328ybf.46.1706668646968; Tue, 30 Jan 2024 18:37:26 -0800 (PST) MIME-Version: 1.0 References: <1a42e4fc-54a0-49f1-94ba-f075e0ef29a8@moroto.mountain> In-Reply-To: <1a42e4fc-54a0-49f1-94ba-f075e0ef29a8@moroto.mountain> From: Suren Baghdasaryan Date: Tue, 30 Jan 2024 18:37:14 -0800 Message-ID: Subject: Re: [linux-next:master 2565/2825] mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'dst_ptl'. To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3197410001E X-Rspam-User: X-Stat-Signature: suxdr8maim1e1s6ht6w9f3cpft1p1fxs X-Rspamd-Server: rspam01 X-HE-Tag: 1706668648-179343 X-HE-Meta: U2FsdGVkX1+DuFhA9Oi/KwvWiCwWyaxHlgrp279/e8vXCxN0NJ/Wg+f1ANfParjHmZcX5ZcFGicy+cYpQLBbyMlqxVoRYJThB7C5fCE3beef8ffWZdzQ71a3iyHyfymK3Y/YqS/o0E8/u7OVHxU6Qd02az0K9ZhnQXTms0Z1mfoa1Srfb3W33zGJ0Rhz56VlhuaY64pLyip6uwLAhxqgwj6puFfHTyTy0omd2JhmED0bb29xcD7p2oJGUUMkh0zdNZpa9ybJn38q4mVyB8Ke46kcd7JiQgSoSrX7V7T3sb1uuni7acLCCaWr8J8c1ZvixISAXsY/wARr0doC3GxSXv2rGxgKBu6x4BbJt6ELhR5bJtUQLG4DmoSN0+jTrsV4//zo49rASgo4moYhCVJnH25PidJqj+74NMn8gLduB1p2ap1wfDBWy9DTs6kuza+1UwOldPuY/gxIE9thipDkAVSXZUlXD0Vus6HQrwhRJHe3z/mk5lzUc928xZuR/0QNgXVmcd0noNLqMZmglFWO/uQjMgOG0Jxl0FyWIstKT7M/YsGkqgy6AgaV2kln22DiWwfK4Zn2OvH0tLA7mfvJm7w1fAX2A5+S9AD/+3riY8DWTV8cLJRm860YyKfbZQ51Crfz3CCot7ZO6aGMGjfoT9a7Jb4YUqN/ZXCnVkWFlLuinyoFPn6Z8JZwDhcV3GNF6PQ29Jyik6yt/wVGCl25s3zQ3lj/FJdJWNkPoeUQWr9nYQOwQrBuBnu+tiPCHWkMyYG9ggQjyh8Wk8Zw0zh6/pjDvxRyGDKQVWEn3nQsCt5cxFXsLZAeHI+hqWN7raft26VWDPW1L8vRMLxbCk52BS1AQM8WLCj6WFWnnFCvnmhuyDS9eRGtFyDuurPuRz6Elwo572Je7O9l0pRtsm5ZLU1bf4LwznSlDups9ynbCC87J7jZdzawJOjVzfNkedGNi8ON0n8FV2SXzusPI7h KE4mqs6T yUqAlRDJ0evXwCU0VPccD4XnpVhte1++YF6P6zLFvcX9rCDCfsTyUProq3UZl/VUMA2n4Q8RKIO1lw7g7VMSrevsw5/yxNmVOrDkwkb1B8f0Kn9WWFcGHuJsuH/t4YCCcOW52lNEE+PIMHan3R1XCy71+cBlTMPqPhjp/3xfBkZuA2x5dGnfrvzakfjxCyRIuAwdRSHwi7/fvKmcO4SnT6+m0rIfzzwgte9l3FFLrUDl6H4St0HXdXSo8dpkQq48vNsAyG3oXrF1xbvWEG9RxnQr1uCooGEvTSnbpdL/x1XQYfGe8fP/tItgHcEcbH42CNSe3PiIAgWbr6Gp/tIBDCEG89O59ENggLVey8l2lyCWUMgxhzgP4lDApCd5vbyc3/EKNYHyACrKNBxyY9Aur/5KmMYwWxLbMcKgMcvmJuoFb7b1ARgdCYmYlfZuqRVVzfg1ghW4404wjrIHMRTRDlC113IoCbejuKPaTkq/9uIzjjZBubLtFVefmHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 9:13=E2=80=AFPM Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 596764183be8ebb13352b281a442a1f1151c9b06 > commit: ea4df6a5ea81105879ca5549555e231c4596fbc4 [2565/2825] userfaultfd:= handle zeropage moves by UFFDIO_MOVE > config: x86_64-randconfig-161-20240129 (https://download.01.org/0day-ci/a= rchive/20240130/202401300107.U8iMAkTl-lkp@intel.com/config) > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202401300107.U8iMAkTl-lkp@intel.com/ > > smatch warnings: > mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'dst_= ptl'. > > vim +/dst_ptl +983 mm/userfaultfd.c > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 962 static int move_zeropa= ge_pte(struct mm_struct *mm, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 963 = struct vm_area_struct *dst_vma, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 964 = struct vm_area_struct *src_vma, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 965 = unsigned long dst_addr, unsigned long src_addr, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 966 = pte_t *dst_pte, pte_t *src_pte, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 967 = pte_t orig_dst_pte, pte_t orig_src_pte, > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 968 = spinlock_t *dst_ptl, spinlock_t *src_ptl) > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 969 { > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 970 pte_t zero_pte; > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 971 > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 972 double_pt_lock(ds= t_ptl, src_ptl); > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 973 if (!pte_same(pte= p_get(src_pte), orig_src_pte) || > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 974 !pte_same(pte= p_get(dst_pte), orig_dst_pte)) > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 975 return -E= AGAIN; > > double_pt_unlock(dst_ptl, src_ptl) before returning? Thanks for reporting and sorry for the delay! Yes, this is definitely a bug. I'll post a fix tomorrow morning. Thanks, Suren. > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 976 > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 977 zero_pte =3D pte_= mkspecial(pfn_pte(my_zero_pfn(dst_addr), > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 978 = dst_vma->vm_page_prot)); > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 979 ptep_clear_flush(= src_vma, src_addr, src_pte); > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 980 set_pte_at(mm, ds= t_addr, dst_pte, zero_pte); > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 981 double_pt_unlock(= dst_ptl, src_ptl); > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 982 > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 @983 return 0; > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 984 } > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >